From nobody Tue Apr 7 14:40:57 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07A4C388E78 for ; Fri, 13 Mar 2026 09:02:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773392578; cv=none; b=ZT9rBOwu79m3lSSkzP7hfPuQRvcFsG0J7/W4nzIf/mxSu9TOJJXGEHwGkpANsIXvB9YFJwIKr+qCS30sOCUCflVIW6PBcSZ2Id6V5ZASVwFi7FU7e3xI32W4RTuHq8lZ4UjLrQe+9YLBBko6kTm+jEaIdZ2qYFEpDx+daWHdvQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773392578; c=relaxed/simple; bh=nC4Owf4MXjBHiFj34VEuBfBkJjEC2Xd5I2Sevk5UnH8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DWd1zFXAlre5JPh/xB1p2t6bDPe8xaY2ze5X5eNdp4QiC4ZQdW6eemjDiEWvTnb2vys5n58SR4pQQvequmFjswq8jEWvcBgfaF0FPPsVDiXoPoD/5F2wGJY8uozSNci0dDWwQtuoUPO1FJRBWVUjzt1ms17zsHQ9Rdf5BczL9MY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=p0TDtLkT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iDmYBfrX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="p0TDtLkT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iDmYBfrX" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tdf71014931 for ; Fri, 13 Mar 2026 09:02:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= L48WYHJuhhkO9dFp26TAm1fpnJhYIgGr7XXmW7vKLpc=; b=p0TDtLkTPv3bP2+K 76YjEI1hQq1paFdfLoK5BaWrKQUr5vNoltpAW2sJyXJXn1hc430mPyRk2He1zifa Lw/VAXOITvm27EB8SzltmyC9fZdEGyPzFFMRHWBbU70ULyH5ES9T3OwmmCQf4edg tc5d8yE6A7LL+4ASrl53OXsQ1eF+k7+7dpkxRFxurrIQ6y5rRG4e2wdT3e23ltkG g+OOKGIvSjklQRAFen4QL1jGjKc3rLtRhEgmpImS7noZaUsPjYqaFM6oNH4xHusT ZfUOqlwBaid3JFMHZqPacT6n5Rav+FpEvtESIW5utWA1bkZabqvMdRVul+YOwErF vOQFEg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cumvdmqdn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 09:02:53 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35a0b5cf34dso2249737a91.1 for ; Fri, 13 Mar 2026 02:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773392573; x=1773997373; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=L48WYHJuhhkO9dFp26TAm1fpnJhYIgGr7XXmW7vKLpc=; b=iDmYBfrXTmXBrAmygut2wfp7o6IfS4dYPVOsTjOva21GRikdPpoeESf/rRD70MLkCu 2MPyHXO8l/yern6Q9l+keCHsCDBUqKnCoTKxHr6CIwapacpqacMlybHUEDlRkDzJE9y4 9VYXFzooz+AvswRGW9QR5wRNZMngzf3RxHYhcTcW6kewqt1CVYd8gujBMQq6O+mxxfpY Vm0hWJoGgrce89zwfx/l79h3gEQq4dEjC63V1woBhMYD3dNrZXaBEmfbOvQRAE6z1mXC BXLV5/+i2r7wBi5oZ8HsqfY9Fl2Cr5djmZjOszln2etIyFQyrN0JZ7OYNxm+AtSqtfW1 ctcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773392573; x=1773997373; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=L48WYHJuhhkO9dFp26TAm1fpnJhYIgGr7XXmW7vKLpc=; b=b3u3VFApBTDS1nc82tI+njhK8tiVpDx3/AqpBAcBGPWxtfxKGieSHm7moy8mmb2YlI xWwi3HPxsz4DJwxV6UKpegbBiFQmpjrzgeo84WMXOxS1eOUfQN5naNKDmCUYKxk4TCAP dTHPZScTmzZS+aqGfhxg9G6EqL9I3k4oTtuP7DmNeGtsPd6kv0jygJMpD8bu0I+Yhdx9 6ZdGvRzxl+VEUuAFLA4NLq46RhcE5oglrQWq2n1mxLETPDP8jd1HyC3wWYTcGwmuLUG2 AIWsyr5qYCWEeWTFEMd6PQJjQP7J+2h6SsCw7WunW4sl0Aj5dCf9Nf3CkdBxxlC4DkkX hquQ== X-Forwarded-Encrypted: i=1; AJvYcCWpPi/B66lVnT8F9fD4nA3VmMuqHdnJfcv3icxnr8Zq/Aw9ugUkl3yefqlUohj46frVIE7GBgDbExCjvMg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzkuhl3owV+xoqTxxrlCWX36os+EVj2AKXc6SK692s2q+uuit0J XXHSPyZPuh6Uusr6hQ1+LaoKpRm8FjSHv/ttDwISJg1uKXlYRIUFUs6HYRgejmYilMVChdhtdPL BPrqAoM/3lpCtCuRYsQip7GUItNTNsmOf5YKbmTrdsYhAkkw3Dwj/aBA7hY9op/psSdHB2O8hZZ YxQg== X-Gm-Gg: ATEYQzxy1OySJcaPAqojDdkN6/hO8GqfiUfgsRyPDQ0AoV1kNOahhDEwSrxe/MkVJZl vcCL8DHmVNZ+pajiJ7hMrlVzq0FqSZ6+MLVEyIH9MyGuq2n3hw1Cnkvxk/dMt/TLWRLfRRBX4TD LNdMCzEAnC0pdkZUPf4/DnfL5xtgyga8lIng53tTnoe2mDGfW4xiWPwHy0rZqdB5LzlT7Dxc+Js wapKnN9Aqkr72shYbHx/jlaivI0eSxeGW6VmCU/0eY5w1GQc5STLcHUvsoqXuP20FWVGv2z7ElL wLxgwuMu4DwEkCM1IC4O8z84ONPlxWaGUU5M0OejQ/clhDNFRTlTR8UkscP5RKVJUsvewTHZgL7 obXKCnpK+KTDvllNCKMlSULazI87LrBZpzHPm0zSzkRKBFp3lDls3+XUJ05v1gRMPHo9szsiDjX 9uIW4l9Jrb X-Received: by 2002:a17:90b:384b:b0:352:d59a:b28 with SMTP id 98e67ed59e1d1-35a21fbe2c3mr2369896a91.19.1773392572623; Fri, 13 Mar 2026 02:02:52 -0700 (PDT) X-Received: by 2002:a17:90b:384b:b0:352:d59a:b28 with SMTP id 98e67ed59e1d1-35a21fbe2c3mr2369870a91.19.1773392572168; Fri, 13 Mar 2026 02:02:52 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73ebb9ed44sm1269275a12.34.2026.03.13.02.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 02:02:51 -0700 (PDT) From: Jie Gan Date: Fri, 13 Mar 2026 17:02:06 +0800 Subject: [PATCH v15 3/7] coresight: tmc: introduce tmc_sysfs_ops to wrap sysfs read operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260313-enable-byte-cntr-for-ctcu-v15-3-1777f14ed319@oss.qualcomm.com> References: <20260313-enable-byte-cntr-for-ctcu-v15-0-1777f14ed319@oss.qualcomm.com> In-Reply-To: <20260313-enable-byte-cntr-for-ctcu-v15-0-1777f14ed319@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan , Mike Leach X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773392552; l=5200; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=nC4Owf4MXjBHiFj34VEuBfBkJjEC2Xd5I2Sevk5UnH8=; b=680OzAf8qsYE3RuttmLZm/HyPOQNsaUyipptyvNuG8EgqR378XZux5Ew4oPnbHNclrPBXigg9 G4oKQ3bhfgcAefhUXOs3izzV5FOz5ZSQYI/UJMsU5Kh+DhGyugys6lP X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA2OSBTYWx0ZWRfX2IiAC5DLUfRY SmKL5CNq+c5eqZL28LsDgoeigW+Qw2zwOYugRMIbmt6g9gPceTMFrBX/gXLSTAuEvOP6IUUhSfF y0e9GUopS7KcBwDGrE9ZZmA4Gp0LD4VJMSQlKo06Pj25opZFsNUj+JLDc6Qef4zB9rX2yAkHR0o 1oL2oUFMtyFo6qcMA4U286Oteap0Q1CDDEG+y7DNm5Use7BFnExsld5c90u326exRJ9aOrxBw8e F35JLWrds0ulkxx5zngmgxJp2VyZ8xSxe78oUwgn+7+0UcyoYTDm8MKt4WoVZLNmKlC7XgMt23f 1e9c7kiNDz7SaXBhKkYeT4V6yXZ4UEnp3C8KjpIWSIb0Ka6LJ8//d+3GLdi4PFZqNZXcvNXWe/P evHymHumPNAjZxMfF6fr14Js4o37ithr7wfnowdb9/sX8Te4FMRsRS1ScjNtBQKamZBIipunCkt dRCCJgqsygZh28k2y4Q== X-Proofpoint-GUID: YOT_yCShnxlpPQSR30MYFCyC0OyTOGzW X-Proofpoint-ORIG-GUID: YOT_yCShnxlpPQSR30MYFCyC0OyTOGzW X-Authority-Analysis: v=2.4 cv=XsT3+FF9 c=1 sm=1 tr=0 ts=69b3d2bd cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ia3uihG--C1vaqsH_ucA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130069 Introduce tmc_sysfs_ops as a wrapper, wrap sysfs read operations, for reading trace data from the TMC buffer. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 51 ++++++++++----------= ---- drivers/hwtracing/coresight/coresight-tmc.h | 15 +++++++ 2 files changed, 37 insertions(+), 29 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index bac3278ef4dd..110eedde077f 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -228,17 +228,10 @@ static int tmc_read_prepare(struct tmc_drvdata *drvda= ta) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_prepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_prepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_prepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read start\n"); @@ -250,17 +243,10 @@ static int tmc_read_unprepare(struct tmc_drvdata *drv= data) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_unprepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_unprepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_unprepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read end\n"); @@ -287,15 +273,7 @@ static int tmc_open(struct inode *inode, struct file *= file) static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos= , size_t len, char **bufpp) { - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); - case TMC_CONFIG_TYPE_ETR: - return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); - } - - return -EINVAL; + return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp); } =20 static ssize_t tmc_read(struct file *file, char __user *data, size_t len, @@ -764,6 +742,18 @@ static void register_crash_dev_interface(struct tmc_dr= vdata *drvdata, "Valid crash tracedata found\n"); } =20 +static const struct tmc_sysfs_ops etb_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etb, + .read_unprepare =3D tmc_read_unprepare_etb, + .get_trace_data =3D tmc_etb_get_sysfs_trace, +}; + +static const struct tmc_sysfs_ops etr_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etr, + .read_unprepare =3D tmc_read_unprepare_etr, + .get_trace_data =3D tmc_etr_get_sysfs_trace, +}; + static int __tmc_probe(struct device *dev, struct resource *res) { int ret =3D 0; @@ -823,6 +813,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.sink_subtype =3D CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; desc.ops =3D &tmc_etb_cs_ops; dev_list =3D "tmc_etb"; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; case TMC_CONFIG_TYPE_ETR: desc.groups =3D coresight_etr_groups; @@ -835,6 +826,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) idr_init(&drvdata->idr); mutex_init(&drvdata->idr_mutex); dev_list =3D "tmc_etr"; + drvdata->sysfs_ops =3D &etr_sysfs_ops; INIT_LIST_HEAD(&drvdata->etr_buf_list); break; case TMC_CONFIG_TYPE_ETF: @@ -844,6 +836,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.link_subtype =3D CORESIGHT_DEV_SUBTYPE_LINK_FIFO; desc.ops =3D &tmc_etf_cs_ops; dev_list =3D "tmc_etf"; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; default: pr_err("%s: Unsupported TMC config\n", desc.name); diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 81237944b986..4d80105d3fcf 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -259,6 +259,7 @@ struct etr_buf_node { * @crash_mdata: Reserved memory for storing tmc crash metadata. * Used by ETR/ETF. * @etr_buf_list: List that is used to manage allocated etr_buf. + * @sysfs_ops: Read operations for the sysfs mode. */ struct tmc_drvdata { struct clk *atclk; @@ -290,6 +291,20 @@ struct tmc_drvdata { struct tmc_resrv_buf resrv_buf; struct tmc_resrv_buf crash_mdata; struct list_head etr_buf_list; + const struct tmc_sysfs_ops *sysfs_ops; +}; + +/** + * struct tmc_sysfs_ops - read operations for TMC and its helper devices + * @read_prepare: prepare operation. + * @read_unprepare: unprepare operation. + * @get_trace_data: read operation. + */ +struct tmc_sysfs_ops { + int (*read_prepare)(struct tmc_drvdata *drvdata); + int (*read_unprepare)(struct tmc_drvdata *drvdata); + ssize_t (*get_trace_data)(struct tmc_drvdata *drvdata, loff_t pos, + size_t len, char **bufpp); }; =20 struct etr_buf_operations { --=20 2.34.1