From nobody Tue Apr 7 14:36:34 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F6D32BCF5D for ; Thu, 12 Mar 2026 22:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773353673; cv=none; b=jSGBfQrk/SXqVd/lCkgbKNJR3+psGrjGxPqfFOet9uZPEFAjXZQFsZzKy5WSd89bBRnox9gSQUGiJ3tGgUa458bmi1YmKQ7NOBhw0RBKMIvYCmKcC+7INu1lNuH/ib/WELk9FsZuPAw8AMPKZ1qVh2QnBNec+PJzPUVhDWuIxZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773353673; c=relaxed/simple; bh=HDWfHxH2zI4fJwu2rlnGGnYTKmy2HwupsW1My5kpJUg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sggYu0+e/phQjSo7RuX3V0hrwjJlZQtCkgWcBFBEdcgxp5xJXTX0QjO0n9bRI2tt0DoqXfphgpvBnsRPh1lQ4HUQPgXvDdSbYomNsK/Xgux2Egak5BbN6LovAoW2uUMce4TfXaDOecm1qWG1YlTigwBZ+gZwtRp5+AXeYhAnS7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AtbR8MsT; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AtbR8MsT" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a12c19affeso630574e87.1 for ; Thu, 12 Mar 2026 15:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773353668; x=1773958468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=utH2CJruXBa0wmELa4vzEbNYAlzzH97hfuKsfsnnNdc=; b=AtbR8MsT6nmHKV03Je/DLK5kzj5djHPNMNmvyAMxHdDbszkJTcomDaRhX0Q7K7nqgq OcflWP9SGCnkFlryeYwdVw2js15VZZa7aH/Qu38kJ0v72ZF0h8cR+npwQIH7GeT5vtOH wqfXIKT87VWRmhI4a0APKrJwZHpF+dQeQQZflsecSmw/VzZpUP86YU9mBv+PvV4I8WC5 0AsZPAhWCKOETj+JgbkjwAygYQS2etuT5xqfTJRmuJIFDGqpnkTdrmTzS4sVfbsLNzLr qOG5T258m3BQCVHyjuGLhi/mqJ/KHdlBIKG2VnTLZnMzBqvhsmTVq7yRuoRfAK7o50Ey iixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773353668; x=1773958468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=utH2CJruXBa0wmELa4vzEbNYAlzzH97hfuKsfsnnNdc=; b=o4w0JkvzzZ8W5DoRQqqxsip6Razt0ikvWe9bACwVj3v/c9GnCBQ6sp9tRtMU2rxbCs Zq9AVEH4AM187lCH3FtLt+jUsniT1T2LethpTTFgFr6EfInHdx2o6w2ROZzpeR2XCQpY pUocX/Ic2kquFrhRb5tm5xeOFdfC5L4/DNdMwno0jLmYeU02U/AHU7xvBOhWPSG6gIUG iV3wogJjVnEtb1EvhLsPKZgf/Xbp602affp05Fney7iyfDQcjzo5MAUUny4k6pMN2HS6 6574bqI1j1+9RPelHdCNu0CPkds1JeRo/+eegjSk2NR4FFMaOO1xwt3t/HBhml3APXq4 S+cA== X-Gm-Message-State: AOJu0YxpdCKAQIP3UXJaD3ZZvfyjbDULH/oW8oDJ68jCU0HcPRcPMSql sBt/D6zKzxAdVXnGpqknJtusB5Rw4hcz3f28LwB+Fx19dgfQPqeLyZ0w X-Gm-Gg: ATEYQzxJAE7Xf4b2Z7AyyxF6zRmFMoLo2hlGTKTZ5UNxWIP7WPlJ47PckyRa84PYV5q DO6ZRJdLG1BMupK/DVS15uHpvIM9APvhthoZ7xSR1N4U9fAbuuP8h8hObOjkxq/VTOQ1SBwD1gR VO1L5CXuTQeTyBd1pLtaD3hWZyzoY6cokhdbqopESa4qTyZOyNPgyLxa/cuQzPUCR3lIPgYrh8Y +6UOQpFoAJNzfXUTrQuvCtz3DVbZd1Xjw89FelH1MBtZFQkzl3LjkNydC1wUNiqRQ+cmT5kAbkW LfpXyMr3FjSB5VSjApidYlmjuTTSf0ITMFEzBMB+YeSJi04GMCpWWxB/mupkW0eiHjpYF+qxDc4 zuVKYApZJyLiLs0xMXzRCLCkw1KxcFh3IVwfsZM+opBJ+uIgnxxtaO+v2kxZ2U2Il5wJBEVsWD4 ELFsnEsMLaha6zxAjzdN76QG90emRnTW4qpJQrqCfl5zJFTzqUtdCcjVC2D23N+8s0j+oVIlo= X-Received: by 2002:ac2:484b:0:b0:5a1:1de2:cdca with SMTP id 2adb3069b0e04-5a162668d52mr284920e87.13.1773353668141; Thu, 12 Mar 2026 15:14:28 -0700 (PDT) Received: from ubuntu.. (static.159.107.27.37.clients.your-server.de. [37.27.107.159]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a15636ef2bsm1160099e87.84.2026.03.12.15.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 15:14:27 -0700 (PDT) From: Josh Law X-Google-Original-From: Josh Law To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v1 1/2] lib/lwq: fix potential kthread_stop() hang in test Date: Thu, 12 Mar 2026 22:14:26 +0000 Message-Id: <20260312221427.75011-2-objecting@objecting.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260312221427.75011-1-objecting@objecting.org> References: <20260312221427.75011-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Josh Law Check kthread_should_stop() in lwq_exercise()'s wait_var_event() so the thread can exit cleanly when kthread_stop() is called while the queue is empty. Signed-off-by: Josh Law --- lib/lwq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/lwq.c b/lib/lwq.c index c1e11ba6f254..1fd2ed612c75 100644 --- a/lib/lwq.c +++ b/lib/lwq.c @@ -86,7 +86,10 @@ static int lwq_exercise(void *qv) struct tnode *t; =20 for (cnt =3D 0; cnt < 10000; cnt++) { - wait_var_event(q, (t =3D lwq_dequeue(q, struct tnode, n)) !=3D NULL); + wait_var_event(q, (t =3D lwq_dequeue(q, struct tnode, n)) !=3D NULL || + kthread_should_stop()); + if (!t) + break; t->c++; if (lwq_enqueue(&t->n, q)) wake_up_var(q); --=20 2.34.1 From nobody Tue Apr 7 14:36:34 2026 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B776A3B19C3 for ; Thu, 12 Mar 2026 22:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773353673; cv=none; b=EHKLReI5FhPgJV5fBvUQkK+WH37S5+h/fOZAA3zWFnsxMn/oRcmir5nmBLeH1R4SG07127EcAf0sQHiK7ipZV5WMTmgHFJTxOYSdOycc3BnbWKlYQTYiSB+74jjyVWQXN4+bVUend8ifugC3OsvSeSpHuGBykA4oXXQaZ8cusIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773353673; c=relaxed/simple; bh=V8l5ThSZkZupn29m2Qj3aKRxe+sAvRi8k6z8V/0UDgw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uBRgKBeu6meawdp9Vew1tH6NnDeHuYnMPizzQd/ofiRTxydT5oTf57Z8vJuVZ6ZduqxsKbyIhJ6qWEq0klEfNuBZUr3FZoSE5We93juoC/Ou5y4p7qljJrAc5iUrROImUSoBnukJkCIjjd88TrQinh9M9NJaYctVPVIRVIUyzmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q8miTHUT; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q8miTHUT" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5a1322af04fso1866538e87.2 for ; Thu, 12 Mar 2026 15:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773353669; x=1773958469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HejGri6FdvgNBJAukqHKlTno36GpiEINbeGb+IZqJXk=; b=Q8miTHUTNhLssevm3crIZQab84gbEpvTllwGq9KRwG+SJM0l/aFPgOkg1y6KM0FI0A BaWKapNK2lgd9jkK2lqx+WGh/sj00o+H3X2kGP1i7VnqZLrBYkteWE4xggWvPfh03q5Q zxXwC1/GVcEiTlXd80qLuTv4LxreuzkJu8ks6odI+C44AelTjH4VEU3uZ58OgdXUmBNz 2ZRM7AOEPk3N8DopEjRTvjv9NG2+QgGfsyXzojMRbhxllkwn2MFDCJGRD90YLrbsCDz7 S5eOSTgu2JTf+uf5Iw+Mcay3gB67pnpBOHA64gAzpXGtQpzI16x5X2i5Ztg4yqvMrq7G YMYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773353669; x=1773958469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HejGri6FdvgNBJAukqHKlTno36GpiEINbeGb+IZqJXk=; b=VofhNzvBqorYaUKy/pCFJsT3SDayUV4ArXXps5PncIRH3hplYx5G5CpTwK9m4BmESq zSrIdYsOiSkleaA8Rd3mF7kP0swV3gfQmdJBVPYWep4koqdKpLD1R+8iy2yS3aLITudr iW4cMIg1UdCHIBRenxKh6KZA/vGwM4UZ9Ijup5Eew+2DGThXwtQDUs9jwVuDtVh+QaMD 9BjpXClKlNw7X5awVfsXCzZKljQUmtOsioEVJl5o3+WG1mdCn1fOXFjO24NMh+JBpABZ 7QyLc96wqcA2ODqub1y8jvu8RoxU3NM5Mwgl1+AltAewGshKXkIwqTBGWeloDP8EPioX Xz1A== X-Gm-Message-State: AOJu0YyvkhodJ9o9pwR75XoqZQ+A5C4w1ZtBtPbCnaF5tCTPsUJYznZQ o/I8sIDWBrivr1t7Np0KlpTT4coQTx9DxO85mMm0PvJ+x44thbbhPwkohEUxDrHF X-Gm-Gg: ATEYQzyzXmZzIYM5ji0fQ7k/4g62KrtGc5CZBLQr+LMJJu6rh/Uk6EzDWjY8Ge1NGNR sr3KYzHetLex6PDIpevSE01QwZ04K24s4Umavk81eVRzx/nygs7sDUyHszZDZuq8ExuM7K2mVaz f/y03IleVJhITBudyF4wIVcI0e1S4rpKBnOqJ+0eHNcq7y24KaWnXnHMIE0QiK8AfdkUTc7oZkM KHC5Tj3f8wl+8mub8dZrUoOHHdttV0o+HcLiEcgZQDiGOiQSw0G0glzuV76xvKzIJURqA4FASIq lY8JO8xead+v09ZXRgTUg/C2dyW5rAftB6svfMW9Ghk0N0hByui4pQrYKXSlmnPg6EozyYUmJsb k42B07xwHETnHtcPjEm0EgIcS6Wpe3MZi+Eb99OjZ9woEznd3rR1r+Had3t3OPPp2HF5kXmoPZ+ 99nYUHM7ETGZqhXe2Cd3curoEE1UUluMkkqbaEuvJVaNOP+1GR7yTOmd02BGKh5b4YX1pFWbfyD nFe1+mVMQ== X-Received: by 2002:a05:6512:281:b0:5a1:499d:8f99 with SMTP id 2adb3069b0e04-5a162b0de8dmr271800e87.33.1773353668464; Thu, 12 Mar 2026 15:14:28 -0700 (PDT) Received: from ubuntu.. (static.159.107.27.37.clients.your-server.de. [37.27.107.159]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a15636ef2bsm1160099e87.84.2026.03.12.15.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 15:14:28 -0700 (PDT) From: Josh Law X-Google-Original-From: Josh Law To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v1 2/2] lib/lwq: add missing module_exit for test module Date: Thu, 12 Mar 2026 22:14:27 +0000 Message-Id: <20260312221427.75011-3-objecting@objecting.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260312221427.75011-1-objecting@objecting.org> References: <20260312221427.75011-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Josh Law module_init(lwq_test) is declared without a corresponding module_exit, preventing the module from being unloaded when built as a module. Add an empty module_exit handler. Signed-off-by: Josh Law --- lib/lwq.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/lwq.c b/lib/lwq.c index 1fd2ed612c75..cf4d174d6898 100644 --- a/lib/lwq.c +++ b/lib/lwq.c @@ -157,5 +157,10 @@ static int lwq_test(void) return 0; } =20 +static void lwq_test_exit(void) +{ +} + module_init(lwq_test); +module_exit(lwq_test_exit); #endif /* CONFIG_LWQ_TEST*/ --=20 2.34.1