From nobody Tue Apr 7 16:16:41 2026 Received: from flow-b5-smtp.messagingengine.com (flow-b5-smtp.messagingengine.com [202.12.124.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FA551E5B64; Fri, 13 Mar 2026 00:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773362749; cv=none; b=LjfHCXb1eZkGvFoEMe6fCGrMRKwiiUEy2/oB+F8XIi1JkRI/XxABlaIkJPQK2LCoZyeR+aXhkYUQH6/YNkVhXL3hH6PHBe173zVTYluwah+2i+YMMm/eKxidMQZgi1HqUhcRms5/pre8Oi6VkpF5+iRsKaXLijsq2xP0SYcsvhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773362749; c=relaxed/simple; bh=g9vnkC7ctlL2n6jegN5oKCEOB5+TJXS9/I+ZsrZjP7M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mAquLAn63iPFCqyvgJ8Cy4PD6Jrk1uYtTBx3z4K42XrCBB3NoYiP6u5JuYxefs4jpJCpNCBMDuNo5BdLzHqVB/xdoB8aaiW3l9jPSIxopwqo1dB0ZCgLdYkmseYsVf7t9I646IVZ/s3vDO8+8q0NtXi4mD+0sI0pWra4lrSMxXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ownmail.net; spf=pass smtp.mailfrom=ownmail.net; dkim=pass (2048-bit key) header.d=ownmail.net header.i=@ownmail.net header.b=cE1Lg/xF; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=jM9+cNGi; arc=none smtp.client-ip=202.12.124.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ownmail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ownmail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ownmail.net header.i=@ownmail.net header.b="cE1Lg/xF"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jM9+cNGi" Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailflow.stl.internal (Postfix) with ESMTP id B728A1301B4D; Thu, 12 Mar 2026 20:45:46 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Thu, 12 Mar 2026 20:45:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ownmail.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to; s=fm1; t=1773362746; x=1773369946; bh=yta/ONG6ZSj6rRZhdNMJVWJN5o8jH9bKyVShEpbtcv8=; b= cE1Lg/xFP0Sm6V6om+xiR/woiTWX3KvncecIx4H7TAb7iajTj5fptF2VjhZpgpd0 ysGa6UL0ZOe44vo9fTWe2s1758oiXSmJXRDbStoiiOYNb+G9/etnJNkRra4M5omW o64ruAeKGRLUYzLPoIZ9aCSyQPaC5Ukxh1B1OhK7z2H5FJQQw9ASMVBMD25RzYzi q2TOTwjNXuXCv/Bq5muEBZJ+JHbO9mmaH/rWBsYqQZb5lD4v4JbjoJpiPNi3odoa yTtnxM4U1DcBgoK/KMObBZDwPj5ll6Js8Ek3NeZ8y4iE/SaV+MfJX23XtPecVIsU NOB8quAvQHVIeMvGkWnN0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1773362746; x=1773369946; bh=y ta/ONG6ZSj6rRZhdNMJVWJN5o8jH9bKyVShEpbtcv8=; b=jM9+cNGiMa0yJ821j XIe2hxjc7cs5JRvyn7N6B5ZpVJXWj9HHAS2ZvHu3CkvqpXMjLDtwMJjFOi9cFMEu Rk3aQr6q4AX5TkjM0iTuRxCSwHdBERW3BTGo/GzfF9O7hqF5xllNf3j+JQ9BIm07 BbbnxSIgg3jKpkp1rl9gnujcjR/h+SycfQQ2Aw1zeb/bZoETR8Ln24k6bNqXqhDn VXaDWsXcHn0IhZaz4RAdBSwoKuRcFM2Mxtmju40VQ0Dgbsb2r7ZjKEACZ8XG5vki bQ08kv/ZDmo/me5yB8dh9Bl0ipZV5O9Pr21Ssej5wEjMd91ZsFHSDNQioqUwGP1e xMYwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvkeekvdehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkofgjfhhrggfgsedtkeertdertddtnecuhfhrohhmpefpvghilheu rhhofihnuceonhgvihhlsgesohifnhhmrghilhdrnhgvtheqnecuggftrfgrthhtvghrnh epveevkeffudeuvefhieeghffgudektdelkeejiedtjedugfeukedvkeffvdefvddunecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepnhgvihhlsg esohifnhhmrghilhdrnhgvthdpnhgspghrtghpthhtohephedupdhmohguvgepshhmthhp ohhuthdprhgtphhtthhopehvihhrohesiigvnhhivhdrlhhinhhugidrohhrghdruhhkpd hrtghpthhtoheplhhinhhugidqgihfshesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgt phhtthhopehlihhnuhigqdhunhhiohhnfhhssehvghgvrhdrkhgvrhhnvghlrdhorhhgpd hrtghpthhtoheplhhinhhugidqthhrrggtvgdqkhgvrhhnvghlsehvghgvrhdrkhgvrhhn vghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqnhhfshesvhhgvghrrdhkvghrnhgvlh drohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgv lhdrohhrghdprhgtphhtthhopehlihhnuhigqdhfshguvghvvghlsehvghgvrhdrkhgvrh hnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqvgigthegsehvghgvrhdrkhgvrhhn vghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqvghfihesvhhgvghrrdhkvghrnhgvlh drohhrgh X-ME-Proxy: Feedback-ID: i9d664b8f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Mar 2026 20:45:32 -0400 (EDT) From: NeilBrown To: Linus Torvalds , Alexander Viro , Christian Brauner , Jan Kara , Jeff Layton , Trond Myklebust , Anna Schumaker , Carlos Maiolino , Miklos Szeredi , Amir Goldstein , Jan Harkes , Hugh Dickins , Baolin Wang , David Howells , Marc Dionne , Steve French , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Andreas Hindborg , Breno Leitao , "Theodore Ts'o" , Andreas Dilger , Steven Rostedt , Masami Hiramatsu , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Tyler Hicks , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Jeremy Kerr , Ard Biesheuvel Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org, coda@cs.cmu.edu, linux-mm@kvack.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, ecryptfs@vger.kernel.org, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-efi@vger.kernel.org Subject: [PATCH 28/53] smb/client: Use d_alloc_noblock() in cifs_prime_dcache() Date: Fri, 13 Mar 2026 08:12:15 +1100 Message-ID: <20260312214330.3885211-29-neilb@ownmail.net> X-Mailer: git-send-email 2.50.0.107.gf914562f5916.dirty In-Reply-To: <20260312214330.3885211-1-neilb@ownmail.net> References: <20260312214330.3885211-1-neilb@ownmail.net> Reply-To: NeilBrown Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: NeilBrown cifs uses the results of readdir to prime the dcache. Using d_alloc_parallel() can block if there is a concurrent lookup. Blocking in that case is pointless as the lookup will add info to the dcache and there is no value in the readdir waiting to see if it should add the info too. Also this call to d_alloc_parallel() is made while the parent directory is locked. A proposed change to locking will lock the parent later, after d_alloc_parallel(). This means it won't be safe to wait in d_alloc_parallel() while holding the directory lock. So change to use d_alloc_noblock(). Signed-off-by: NeilBrown --- fs/smb/client/readdir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/client/readdir.c b/fs/smb/client/readdir.c index 47f5d620b750..dabf9507bc40 100644 --- a/fs/smb/client/readdir.c +++ b/fs/smb/client/readdir.c @@ -104,7 +104,7 @@ cifs_prime_dcache(struct dentry *parent, struct qstr *n= ame, (fattr->cf_flags & CIFS_FATTR_NEED_REVAL)) return; =20 - dentry =3D d_alloc_parallel(parent, name); + dentry =3D d_alloc_noblock(parent, name); } if (IS_ERR(dentry)) return; --=20 2.50.0.107.gf914562f5916.dirty