From nobody Tue Apr 7 16:16:03 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF9A43B38B6 for ; Thu, 12 Mar 2026 20:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773348819; cv=none; b=Sh+jvtifLFvf+gCPYT5Un7CztG54tEMbUGsQtwf8jjOytVV/qanH7HNmE/YLrzOjJDicaalrTcJiku8CzzDsMNM7OvzXnRnCiXXCNW7QeRv0NczlTqQ8sjj8V0icBu/Z/klvlHMsbroK8ABLAqgUX1LHsvqa2oSVKhfp1TUlgek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773348819; c=relaxed/simple; bh=Ml3MGP27gKnwVk3o42TvyYhVQZlEVcnjQHGgFhpn3W4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=chB//TuvFpjBmIqq5yUj0Sq4IEESy2Svy1O/eSCsPZBIS1IcsGaQ+1FJ1L3zPZWG4vvqP+mlNF2MbuuBvAZrnXvUjrm87MJsAsXM5a+o00NSOEBeEErSvY4n+zM40YKyuBMQ1Y94okU0NbLAzxzuyZ0gy0dz94//Bt952vzYol0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=MsH4v6d/; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="MsH4v6d/" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8cd77786e97so146165685a.3 for ; Thu, 12 Mar 2026 13:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1773348815; x=1773953615; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eafNr9BwjJfwIWHhaZifojoDqJ10dT0nuYTLu1eoj30=; b=MsH4v6d/6ueTDZgjc7G+k0793yCy+xMyuegsgGXOF4CUaNfIWwlJYRryqZpmAknwN3 e2lTFghWM4REiT2748sRrrWCHeFVS/Ih8BzczXA4jd2hr5YgFR4Ta9V+EDAyWtyI7/9I F8bjEd9BYqkXM6gMZmhbI0cJedyCUw0JhtteetJ/cnCai5dpGeXTk28kgtujBJHjMklW cPbYBLbKd1n39kkLCnD3Rfiyw1fbryz+7gcZ0T7DBuiOYM/b/YGz/kKhuVCCnz+LIVN9 wOqTwwq9i5KAfRwpSiDqe+Naamk8uPCs503C+gCgrYNjnovDd0zwE8a1tAg41Fes7207 K0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773348815; x=1773953615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eafNr9BwjJfwIWHhaZifojoDqJ10dT0nuYTLu1eoj30=; b=QdzpELh3kY5qjVZVMBsWoH6HyvxJKwIrgkMxoJyrEr+46fTCkoxw5Jiag+iwYntI9b 5Vlu2J6BBOMDL791+Qq/3FeenDc8/X9CSPO6gZEIe3ujzFMfKSjyPg3e+xY7HRNdoEji G/MlX6dVdSczrGlF6HQtGbavFEwZCTOrwi3VLWjcSehSnz9VYerUxro6OiMqRb+IyMgR zWw4g88+XRx1oXBUNGLUWidUU9yfo2gMUY5H0kc2RjsWi3/8+5lfG5XD5BhsMgyGA9R5 M3MrXx1UpWPJM8SZBtNiCN0UU6BB957+Z9ACxZ65Cv0oHUuhJUtFruUrJQUKWk+QSufo IIzQ== X-Forwarded-Encrypted: i=1; AJvYcCX+TmTUMHFvsJpitSleK71n2IJBhD0wLZt7STWtvJusVtQnyvuh2SV9ybla0nEU8l+domCtUCXhsiHH/4M=@vger.kernel.org X-Gm-Message-State: AOJu0YwASMnvEHS7nE8Z9Pp7i9ThxmBSDWUb8FqUtLXK6WQgBCh3urBv 07M1+2UiIQC4Bu3RDobpaeoq1yUyscqsZxJmhyHjdrNq0rVX9/2MwPEHSad6M8dCjEA= X-Gm-Gg: ATEYQzwkZ2D9B/Lfd3zIjP64+ask/ngYyBNcRkwx8PH+kY1IFImsczEGjMWILkr1VOk oQ4u9ykjuUE4JjjaDaaRvCuVfHE7bsF5e3dowTyVfQ0DUgH8sD+rjfa4n2OiQib/qOvAVbGbNMb O8YkPi6aw0zF7+I0X/XjsrKJ2EcmH0lW2LsHnvCc6gGS2TyLzLEU4/FEEURHqfxr7egTAoW525m Yur+U0zeUHxYZEzzTqDqXYMKdqpWadXZTh7F6omkhEd77Y1yECxCd/xxNOnUzAwhRTnlvmDP/b5 cs5Rx/j/oe+9OPcjQCS2cmWSLFN/rtEIGUeqe/IOkIKzGdsf+iFbhq1S9woNtc7bImS22ox8slS E6/u1pQ4xG0M0Iadupcx4IhX74UFw8mFCIacISRnId42SGRWCF92TYWMW9HSkpwVTJYeR1EB6Cr XJpgfEfxZj8xzNMZOAWwSWPA== X-Received: by 2002:a05:620a:1a0d:b0:8ca:41af:32cb with SMTP id af79cd13be357-8cdb5bb05f4mr160267485a.77.1773348815504; Thu, 12 Mar 2026 13:53:35 -0700 (PDT) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a6e736043sm29875566d6.10.2026.03.12.13.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 13:53:34 -0700 (PDT) From: Johannes Weiner To: Andrew Morton Cc: David Hildenbrand , Shakeel Butt , Yosry Ahmed , Zi Yan , "Liam R. Howlett" , Usama Arif , Kiryl Shutsemau , Dave Chinner , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/7] mm: list_lru: move list dead check to lock_list_lru_of_memcg() Date: Thu, 12 Mar 2026 16:51:51 -0400 Message-ID: <20260312205321.638053-4-hannes@cmpxchg.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260312205321.638053-1-hannes@cmpxchg.org> References: <20260312205321.638053-1-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Only the MEMCG variant of lock_list_lru() needs to check if there is a race with cgroup deletion and list reparenting. Move the check to the caller, so that the next patch can unify the lock_list_lru() variants. Signed-off-by: Johannes Weiner Reviewed-by: David Hildenbrand (Arm) --- mm/list_lru.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index e873bc26a7ef..1a39ff490643 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -68,17 +68,12 @@ list_lru_from_memcg_idx(struct list_lru *lru, int nid, = int idx) return &lru->node[nid].lru; } =20 -static inline bool lock_list_lru(struct list_lru_one *l, bool irq) +static inline void lock_list_lru(struct list_lru_one *l, bool irq) { if (irq) spin_lock_irq(&l->lock); else spin_lock(&l->lock); - if (unlikely(READ_ONCE(l->nr_items) =3D=3D LONG_MIN)) { - unlock_list_lru(l, irq); - return false; - } - return true; } =20 static inline struct list_lru_one * @@ -90,9 +85,13 @@ lock_list_lru_of_memcg(struct list_lru *lru, int nid, st= ruct mem_cgroup *memcg, rcu_read_lock(); again: l =3D list_lru_from_memcg_idx(lru, nid, memcg_kmem_id(memcg)); - if (likely(l) && lock_list_lru(l, irq)) { - rcu_read_unlock(); - return l; + if (likely(l)) { + lock_list_lru(l, irq); + if (likely(READ_ONCE(l->nr_items) !=3D LONG_MIN)) { + rcu_read_unlock(); + return l; + } + unlock_list_lru(l, irq); } /* * Caller may simply bail out if raced with reparenting or --=20 2.53.0