From nobody Tue Apr 7 14:36:34 2026 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1188539182F for ; Thu, 12 Mar 2026 17:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773335565; cv=none; b=RWfBTRVZNSXe7CkuR0x9kWpswQOksPmjub96oafMmhqcgj7Y6jjA8qUVsYk0ijlSMjWPm1rGXCTZCL3WK2BJnkFefnrF7HdhhofXMidNpRhC/O7as2N2pR+oZ4KOGHDjciuf3vdCu3bOtkX2Bz95BjlC5T1tJtCpvf4cFfhU7/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773335565; c=relaxed/simple; bh=LwGy5RmfdnJ6CE3NTItB5tfCzF35fs9VhWXuqoES7P4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FpC7UmH1+atqt/hJKtwWi0WEDy4XcJ+vi50RGA3QOULUc3rC6KrU0f+DmeNBQVxbm0++2XvjglUcj8kiZl+v6B70S/95dfvj16YmEROTXrZaQNSUBqyagIsVkGHteuQLXUtKAENo13GZV7PNcY8vAh/wzi5gIkeou/nhVMAQ9RA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jqW4tvc3; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jqW4tvc3" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-38a23dd61c1so11052921fa.1 for ; Thu, 12 Mar 2026 10:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773335561; x=1773940361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Mg69a9vrgMcSAwKsm172J4h0Z4L6eK5f2x4mJHkOo+o=; b=jqW4tvc3JvLMwg30xjAN+92NMbmNd4W0gbSuUYP7n6sER803+5/Jf7BQqLxOuTTDQv XHoBBJr2SwUeUwOQjuq+r16TwyzG8MkKOpP68Q/lOv+aVYY1HYNIc+e9wsmaovCjJRVc rOe/76zMDdPFjm9UfO/ynzuqD6whKr5eDm7vDKKoyPK62sqMPXwVIQhUBXfPtQ9Fw6zm i2a++kBbIA8vgW/ItKZF9lj4aidAe4YR96B/fdsplf3bWxadMsVwqN+kwy7hMAmm+3Ot +7g2VFat38W1zFI74sc74ic7UVQNkJy9IH64ar5O2zyxE1qDi2GYnGcZG4OxGhr3W961 +qhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773335561; x=1773940361; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mg69a9vrgMcSAwKsm172J4h0Z4L6eK5f2x4mJHkOo+o=; b=baWWtCseDqDLliMr80Y8hPjxAOjkapwaUQyaz4btiScOQadDsq+xomZ00e64lT3fDT 3lIBm6QTyhWi5P1FX5VKDkesCc3W9HiF26w3R/4okt54sdMG9goXylrkOY4vKDUBO5Qs MxufpzttbOce0YAB/f7s+KbfWm+gK5IzCPmFbRiJmyf3gDNtfx4VMuyBpiBT29gd4DyZ vrwKvT960R1J2T8Pq2bHsuSgS5Zl2xqLCB8qaOwJqkTTaEkZfZc6201Q+h/05IKXm5tB gBRNa2BySP1oJCOkDQgIozpDwgy6Q3bXZPfuwTvKzt4ZDd4wYYr9dXvsduaKcydwHWzg TQ+w== X-Forwarded-Encrypted: i=1; AJvYcCUhz55KmCGqt/VWSn/YqP2eRLX/T0x3rjBSmpt+1jjHXCNBwnnWsmwDmDT0FXFDitxGtxWo8fUBfrUpDvg=@vger.kernel.org X-Gm-Message-State: AOJu0YyNQjJ6Q5Js3vOoC6fvCqlch6rQgpYIqFaA+5waP1Z5HdUrFxTc Tkwnjfr2oPqoAkpeUbUZv27MHynKHBEQkk6jzYitWba2XWFKlBV5/j87 X-Gm-Gg: ATEYQzw16195u4+2mp/htuLJM0eemnQ3egavg+tmRLb6sPPCCKtBQb0z5LQUYFvGcxl 9xnWdi4nnfNH5xzcl7d1nz6mj1na70a9mm+Ex47FUhKkSmPklvpRz/G8UEdnVJXUt3mF4sl38km llN2ANEj2twESb8TuhZThrZukt2KCyFSOLx95WwHnpm+G5WD5Hm1gyoD9nufp41nANGSBZAqao8 RFErhv3AfWwStc3gbMrKsEDyy6lG5CaUwvAA2fwMSMB71/mlmUO7ng/hZBZcwLfNr5IN+lOiz6i +Nc3CGLsPicEJQDKjvbz+sGZT5cEJIpNiYwqIhTveHPWhnwzMoSIxUMizQTVfd9fSQO4rlAI1V1 Xo8ZHm15z9/bmP55QrB3IwLJ+etHrFYDEu8rV2BAMR1ZxtuXLjCKOcl8oHKJdJfIt37I+xQ6k/E DRaIzOm7+TACi/ADParoYnxL1/IChyXOtPpHjS2UIuZCukQ//TbbrpxDsnf/tTRXfap1HmYUkvy hlQWe2d3A== X-Received: by 2002:a2e:bc92:0:b0:38a:437a:516c with SMTP id 38308e7fff4ca-38a896c3ebcmr233521fa.17.1773335560464; Thu, 12 Mar 2026 10:12:40 -0700 (PDT) Received: from ubuntu.. (static.159.107.27.37.clients.your-server.de. [37.27.107.159]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d6185csm10401921fa.3.2026.03.12.10.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 10:12:39 -0700 (PDT) From: Josh Law X-Google-Original-From: Josh Law To: Matthew Wilcox , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v2] lib/idr: fix infinite loop in idr_get_next() Date: Thu, 12 Mar 2026 17:12:38 +0000 Message-Id: <20260312171238.7961-1-objecting@objecting.org> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Josh Law In idr_get_next(), if the returned id from idr_get_next_ul() is greater than INT_MAX, the function issues a warning and returns NULL without updating the *nextid pointer. This causes a soft lockup for any caller iterating over an IDR (e.g. via idr_for_each_entry) because they will receive NULL, fail to advance their index, and repeatedly query the same state forever. Fix this by setting *nextid to INT_MAX when the bounds check fails, ensuring the caller's iteration will terminate. Signed-off-by: Josh Law --- lib/idr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/idr.c b/lib/idr.c index f25bd2b9e9a4..07098eb4ddc3 100644 --- a/lib/idr.c +++ b/lib/idr.c @@ -268,8 +268,10 @@ void *idr_get_next(struct idr *idr, int *nextid) unsigned long id =3D *nextid; void *entry =3D idr_get_next_ul(idr, &id); =20 - if (WARN_ON_ONCE(id > INT_MAX)) + if (WARN_ON_ONCE(id > INT_MAX)) { + *nextid =3D INT_MAX; return NULL; + } *nextid =3D id; return entry; } --=20 2.34.1