From nobody Tue Apr 7 16:13:26 2026 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A17F5301472 for ; Thu, 12 Mar 2026 13:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773321597; cv=none; b=cQD8Smb/u9eVYcty5c4TcyoMoQIdqq+RLMrgtoUKIbsmaPdpcT+5WZjeuR+HufLtVuJYW2+EuLzNsXh7LscyEZtA56mETZaDG2iN9v4+b67C8Wn+xSoBlBPm7VBTdAcYoXsFJmmqAtyUf98oRLKlzJd0UHfCFhtjaXvAKhaNLTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773321597; c=relaxed/simple; bh=jkGwDSg5iKVY4RYB3LXl77Iie5oQ/J/hQiue6Oxx5zw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=d8b2IMxjuWbecjUu8p5M/xrUrXotXJvA4cShEYAHvvpXQzBRFAQO84C/vuAbuF0+yjSbgfX7JYCSnzYB/4ahHh3wMW4lqyLNNEcS2fAKuWnykJOCJCGxYJ54jgNHf3MD0AtdXArKYfDiwu+UO911No6Rc7KSmwMsNu05Rhfp0tc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FxGp3n+c; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FxGp3n+c" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4852f8ac7e9so11601095e9.1 for ; Thu, 12 Mar 2026 06:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773321590; x=1773926390; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UQ7STsHE7rEfwGzRvfZisMH+OggyIloJdy1dOS8CO7Y=; b=FxGp3n+csqMRIfYsZXMVkUwGs2h340mXkS8ZcT/oNK3Vf5ed4a5vc1t4W0m/8CSVuV aKEvx1DxmE8u08+EYXstTot++D72dY+PllPOOu7PD0Tyihpib4GIdrnhAGTv+b77poSi COPowi3Wf3HkqBL43VsYsNqLF6vIq2GMmN7TIZ2OAnSdoamBWeJZPRfTF+Wo100edap+ WY09t2Wm/5DOW2JoXUKOvCAw6PeFmlAJLMEgsulU+dC8TF/T2Z1YwVWlpmpqFjk3xIwk Ubp6RQfE5CiYux0CuqaDRuust/fCvL4qMnskU0UUfXr/K2/7LEWA2uWa0T7OQH0iZc3V CIqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773321590; x=1773926390; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UQ7STsHE7rEfwGzRvfZisMH+OggyIloJdy1dOS8CO7Y=; b=mty48VOqMe1ydJIAKI+T8eC5JLcgLfXlKWqj0qBUvergf03k1GXOtYY8OsjodnbvVU v0PkKdV32FUQs7yTvtMF1rS4olJQMm9DWz/yBpOiSFrdstBtmL71T5mtlp3PTWIvaUf/ XhP3C6uEe3cDN+HoCgy5djeG+l0TDb7ruJRbnSdo/QqbRHTXduWlnTSlwIElID5m/rTA 6qiRBQHYMhhMZzeR9wx/k8wN+NCtHAX8hDL4+O3fUqXNUh4REcDuSnHZNEidu4IYGvYU NfEuRv9QBNpEo97Av/dGYAg1VDVLi2J50Gln6eEwnrdHqMnv5XsseTeTWu7S2IkV3LYJ iT8A== X-Forwarded-Encrypted: i=1; AJvYcCXqMSQJ8osjF2wMf1iy/IdXWctRx9sNSMwelbuG4jdx4thHSAMdJtfASemiwgtFEeseD8eVf7p5ndk4Jrg=@vger.kernel.org X-Gm-Message-State: AOJu0YwsPwGh5qFFOTmzShEYoZpqF4Ep7jpFeO0ktCBGYzG1F2wA5iLD fMCKcz2v7INcfrPCOZynpFqrY2zWInQb2r7G3PbKez105+TlZNGLAbwT X-Gm-Gg: ATEYQzwCHZAMdYuOZfmje2aZFrC8pJpcz7kMUsB40UneUCwbREamPy1pLmoV0k4olbK PBMl0BWxTTmE22vTtXD+xuNu4lihR+Gf1iVY8yaEi4V4WKeX3YFaQTHaBDO76BTRPrjQO6kg/p8 JyGhTMxRMbDha91E7FNc5jz3qT0qXM8RM8DVVaJplRnlmnho3MkUYzGj0cIZzakd5idG8N1vX4B FZO8rIk43LmqGzEr8GWkd5K1unUuuROKDCBXSA+ePNudgyafqf4jCM0r3JJE2tZldczinROCMwS nTOH/VS5mRTBfMuiGRHjCkDhE2y1qItCvh8C9NcC8m1zVkZDWgNlUeqDdIp8p6sfznPNdXMu+iJ +jEosfLPVLzYp1UgiBgSGfmS7KEAGNJULYGWe58wC/bze0Ps///p3pNyc4vTieDdzyYbe6BL5t1 qHtrOfxDbE4ndurj+2BbzQu3pdIe0uHaInCy4TKtvb X-Received: by 2002:a05:600c:46d1:b0:485:35a4:939f with SMTP id 5b1f17b1804b1-4854b1484b1mr106948175e9.28.1773321589454; Thu, 12 Mar 2026 06:19:49 -0700 (PDT) Received: from DESKTOP-BTQF5RC.localdomain ([85.110.79.247]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854a1a4444sm72107005e9.0.2026.03.12.06.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:19:49 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ethantidmore06@gmail.com, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= Subject: [PATCH] staging: rtl8723bs: Simplify error handling Date: Thu, 12 Mar 2026 16:19:34 +0300 Message-ID: <20260312131933.29505-2-b9788213@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Remove unnecessary ret variable and goto exit pattern. The function now returns immediately when an error occurs. Signed-off-by: Bera Y=C3=BCzl=C3=BC --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 30 +++++++-------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2d..fe910cc68 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1124,36 +1124,27 @@ static int rtw_resume_process_normal(struct adapter= *padapter) struct pwrctrl_priv *pwrpriv; struct mlme_priv *pmlmepriv; =20 - int ret =3D _SUCCESS; - - if (!padapter) { - ret =3D -1; - goto exit; - } + if (!padapter) + return -1; =20 pnetdev =3D padapter->pnetdev; pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; - } + if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) + return -1; + rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dv= obj(padapter)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; - } + if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dv= obj(padapter)) !=3D _SUCCESS)) + return -1; =20 rtw_reset_drv_sw(padapter); pwrpriv->bkeepfwalive =3D false; =20 - if (pm_netdev_open(pnetdev, true) !=3D 0) { - ret =3D -1; - goto exit; - } + if (pm_netdev_open(pnetdev, true) !=3D 0) + return -1; =20 netif_device_attach(pnetdev); netif_carrier_on(pnetdev); @@ -1168,8 +1159,7 @@ static int rtw_resume_process_normal(struct adapter *= padapter) rtw_ap_restore_network(padapter); } =20 -exit: - return ret; + return _SUCCESS; } =20 int rtw_resume_common(struct adapter *padapter) --=20 2.43.0