From nobody Tue Apr 7 16:17:47 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BAEC2FF151 for ; Thu, 12 Mar 2026 12:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773318805; cv=none; b=qPKtk4huO5JPTkxTEFVIfAyr0QMqObIaSQcfrSntyUMm20dz0WwRvwnUAD2w2ccFvlZxOzieWqC21Vh3HEa0i9gr76WcueawguCCkjwIYc+L3UWmV4FUpP2tbCcL5VTiF8Xaw7Q1UY+rcGqc5eUJSz7uQ4gUPslKfOyO6GfQ1ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773318805; c=relaxed/simple; bh=MqTuZ66JzGO8ml01Fq53svdMcGAX8nJcWPrEiuKJVW8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZqJrmWntQCBZXSQCppcYVs6A4O/ESlkoY4QPg4kDs8EmDMJAlyPrHbhPjTyiepZgggXLjQCgRVZiOw5rN+cWSLCGM14RG0T2bj873jIAm2tFUqiP15XowAqhoZ6BBuN4VRNp2/YaKZ/gZsi5D8NlqrR6Sszrv5d9U1/U5d1eKLI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=1ECajMXD; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="1ECajMXD" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c737d3a51bdso384003a12.3 for ; Thu, 12 Mar 2026 05:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1773318801; x=1773923601; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oxbk04fd4kGg1i1zk9iwOBpm9KQOAzOfMWKxGAIYdo0=; b=1ECajMXDBM0f1Jzhvo1yhoIbzb2VLEu31mgr1m2w1ueVuYG6v9gAqy1B8kReg258F+ +csLK6VeKehqZTa7oQJ2rYak2yp3EJI/E5kLZAbTVFaPzuaRjKzCwdozOkdaNpesi0CQ yw3YWqSkb4ekgqM8Em8Hye0DjWdwOsjV2SjQw+VNZtLgMftl1410nFGk51tV/NbwfQel XW3qw7hPZxGPsJPMg33PvklSqoOFtsj8DxYUdyYl6XGFL1v9kjv3wMoanPnu2EXr5sid ogthGrhRuRQASRItScZhFWxt96mDYv4qHiQROJfyWCLo9FD6QHFpGFbqYiUlW5DA01J0 EsJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773318801; x=1773923601; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oxbk04fd4kGg1i1zk9iwOBpm9KQOAzOfMWKxGAIYdo0=; b=E3xFBv+/H9WRfv3Oo6uXdXHkLXqRuKnhb+Pa9xCZALDe3CZcDKyY3ZdOL9LyNwoeRz eWjBB72qpfGxJqVO3O0NJsg6i9PedJbwwvteZope2dI6OkhsQlwXIHeFiVAdVJgaXckl krIeMgAR3MlKoM3oLin0JIyjQCPJj0tzEi2oXkcJbiJK38hSr53bhmXf/N9lt1qeyTY+ lxTw9mHBBSwxdg8hrTSffIteuPCcTHDf93L4U3tvCIXe57YhmtcsLBlWiezfFUgz5X3P r25cKCvYiNy2OSbbnzJWY1nzBXx/JhfAnds9wju7S8N9ZlKeE80YdnIDhgcaUfNfd/Yd ZTGg== X-Forwarded-Encrypted: i=1; AJvYcCUuPiGchfFhRIV6V2H1xdOUk3yhooSNSXv34Ri951LX3GfsdNZOFO7BGMbk28zC/Huj8BU9QVa7zdLkaTg=@vger.kernel.org X-Gm-Message-State: AOJu0YwRaMtnzx10TPJKIoLrezuW54IkOK2PMb70fIoA+fjpNlX7XNQB eub0nrDyv40fIdYvtvX8MZNRf2F1yGH1Zz9J9/ysROOjRhLyLn1XMbHqCv5rvXFLYm4= X-Gm-Gg: ATEYQzwPYbwkduxm30ZzfBbokmNsjMnQRqJYe4JUIMjSOwoeqk1NN0uUJDtUm5IQR4c 3oySs4YjiwhteuqAz+Dc2dECOi5kH5ZeXi7Dj3AX528/BGvtgruVx4lsbOBnOtvBmvbGCEVpNz9 g2QAyrmGYHkH3liHZDh2Lb5dVUDtBBFyiOgX18UZKNizMa3ZMeOpJ/jeGksHx24aI+yjB1Oej0x ZNVfTWYOyzZ/tC5ysG3mu4jDEEP0qidcbOrwBBjBJVmvROXvlD9t3Q2/G21kwD78KoQGETBSYPy UsOpQAzfTTZwXbx0YJhZsf02ni2BHRpyMyJiqj8x1qLRTKuW+MR81nGRiqU5QwVyzLZjG1ygYLK 0XCyYadf7GYpfyruJFSfmNsfrPVD+3W2i0QOzzjYIzdZRW+AnAIce4Z7a0GC9fgixvtQ/B7OJu4 E91W0+9f4hZv8sY5iN+Hf4UXoFJh6MMuU9ZKyVSvl74FXc1S93F9BlQs/kfN6ZxveCZl9VsnNoz B4qzBOQXQDD1qj8NdelDq39mCIWn8kDLum2vdeTwPgRdonJaOWmnHQlbQ== X-Received: by 2002:a17:902:d2c7:b0:2ae:803e:6c12 with SMTP id d9443c01a7336-2aeae78c614mr59713375ad.6.1773318801385; Thu, 12 Mar 2026 05:33:21 -0700 (PDT) Received: from localhost.localdomain ([103.158.43.36]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2aeae22217dsm55220555ad.4.2026.03.12.05.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 05:33:20 -0700 (PDT) From: Abdun Nihaal To: clabbe@baylibre.com Cc: Abdun Nihaal , mchehab@kernel.org, mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] media: pci: zoran: fix potential memory leak in zoran_probe() Date: Thu, 12 Mar 2026 18:02:56 +0530 Message-ID: <20260312123303.73358-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for codec in videocodec_attach() is not freed in one of the error paths, due to an incorrect goto label. Fix the label to free it on error. Fixes: 8f7cc5c0b0eb ("media: staging: media: zoran: introduce zoran_i2c_ini= t") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/media/pci/zoran/zoran_card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/zoran/zoran_card.c b/drivers/media/pci/zoran= /zoran_card.c index d81facf735d9..f707bdc1fb0f 100644 --- a/drivers/media/pci/zoran/zoran_card.c +++ b/drivers/media/pci/zoran/zoran_card.c @@ -1373,7 +1373,7 @@ static int zoran_probe(struct pci_dev *pdev, const st= ruct pci_device_id *ent) } if (zr->codec->type !=3D zr->card.video_codec) { pci_err(pdev, "%s - wrong codec\n", __func__); - goto zr_unreg_videocodec; + goto zr_detach_codec; } } if (zr->card.video_vfe !=3D 0) { --=20 2.43.0