From nobody Tue Apr 7 18:08:09 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67822E0902 for ; Thu, 12 Mar 2026 12:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773317774; cv=none; b=s6qu130Wq2k0SthUTw2Ki4jbjF6yV0zu+TkjsE7wDjqJfE3ohTNww6ZhTaWb7oKBoXKlX5MyVI2mZvCPNY1gWW3/ZT8fu3aFtPULLjEZssaTtWKOsjTo8O/Sar5q023iYUTnNpnddeE1BI4LoExVAwmuAiYqgHi+O0wN9nkcYMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773317774; c=relaxed/simple; bh=L1iquWccV2yVTQCH11JwiafCcxb5GJJdUIRGsXkOSjI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZSa4tzsCpjNsixFKp8X8SQnPLxIIAfGoKScM8sbn1m1sKTUFT0/TZXRbNmZMHJ655O8OXoJH+OIPYNPYQEsJHx3gJrtYzcb2BikASBaF5owuQefr00EealjzqiSvtC2YFtm+CPcrcgiLRVLfK+xZpXjbtZ/1Q19LzofWj1Fukdk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=vQBQGIWy; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="vQBQGIWy" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439bcec8613so771715f8f.3 for ; Thu, 12 Mar 2026 05:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1773317769; x=1773922569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=apEGcP2fvlwAgwLrCM8QRJtwowl3Oio23Mz89ebHt+8=; b=vQBQGIWyOtfgeiEyrIzPNDJvaNhKLa+mDPJYKfdyqsPLFUaV2MsgR1oEZHj1gMIrsa KnmUQ5f3jLgG0a+qYpEiTLFIMHjroy/hl8Quj47EBMvTcprx8MFUERe36a71NfzaZZCD OTidePuosxtzs41NmB9Fu3tPvzwZnAH+rWonpmKPc8hBhfH3MgkZG8QgGsKcn26hXYr/ JNLfGQMcwx2kxdkmqp4tO4/hr0SOiY/OyLDGO4TDrfFHWGNE+DpNF+BwpN2CLfogxQP7 cvhV/d6t78ftdX9QyqneM1mZuNxkVSF7gaoEFVD4vMkTVXwlf06WNQ4ekUfX1J1lykMH TidA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773317769; x=1773922569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=apEGcP2fvlwAgwLrCM8QRJtwowl3Oio23Mz89ebHt+8=; b=UvsqcHQhcAEdN/G54W+bx/cY1akcqUmyHYDJe4tNAxhNye6DQ++4y4n7WAv6Hf049k CvuI/9fqrT2W2mR1IsaQVW9JpkhhB3KEu4/AOyyjc96XmOlDS6AyMiJTuKHrv+aDT0Al Oh8YWiSylKRb0m5P2X+r3A2D0BrWPNjOCDqNcS5O/WX2QVtiQTERoeA1105QsIajboKs rj9wh74AgdM5hj2qp3XKUW/o6yvFvPWQzV94OYCUod0VmV0D41dokAzL6ygS69a8DGV2 ZvbsobTcVo5Ha/QisOVlhPosJ+tI2kHdk6kQPTH8b4cxuy8YZOwsBpEgdIwCMMe7zoI2 gf0g== X-Forwarded-Encrypted: i=1; AJvYcCUhPanika6Ivbxw7YwtxZH4GElNgT+UI7f6Id8WVwpWVy4nKhHGmTBrm3NBG+DUnJhn75DSXYXafto1X0M=@vger.kernel.org X-Gm-Message-State: AOJu0YyYcj2LVQUNHngfZEVVnhbADEL4i2yxdDxeUxkd7dddCZEJ5FbO lIKKzjkr6nMEv99yxZLTUk7zPLZqH4lzSCRNVmrM1lWpg/cNaovXHWRDRHBC2Q49Rg== X-Gm-Gg: ATEYQzwv7U15bXN8pT9f9dNYuKg47ppDbN15EuWfS6mhKHilC/pxSTDFQAIFzw5z3Kl Ju1IfVNHiKuMqP/by8tPTIIhh6E2BdthfjvLmykB1hXF9ABP8b3jeQ98JqiWMYEt5CYO/ASWcQ8 ZyJ4yupIhF3b72gdF/cvfyLGB9jYJnnq3sMxS6/rhMvtNz3atYoo6it0Rc9eGLdF3CM/ejZgMFz HDgHaP0SKzKkfuiD/ZCe5Fo95TzlL+50tmcF1wdwYl1BrSNa9xCG9PNIiYIaboWmfHGKwcYTKia Hfo0XV1/k10lbLv6VSajBPxKMwvuQhcAbwDJpIe/Rv52Yu7HrNgYCIuRQopWCvVcOly4zk6DLNl ZnBl1ldzAJ9Ot/yeJJ7SeNsyL7Z4d+FYOdxQ3l1IPFRzGm41cy3OJqH+gfd8xoxXdihm+kbEzlt RtNT5Q6RW6jHyOPb/yX7suHVnqBVxP8F0GciPYtFJHDHiffyFlgVNgGrgtqDX3YoHJtOgDaBant rLk19WE X-Received: by 2002:a05:6000:1aca:b0:439:ca9b:1f61 with SMTP id ffacd0b85a97d-439f81c74admr11574930f8f.17.1773317768726; Thu, 12 Mar 2026 05:16:08 -0700 (PDT) Received: from starbook.localdomain ([212.105.129.204]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20c473sm8139874f8f.24.2026.03.12.05.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 05:16:08 -0700 (PDT) From: Sean Rhodes To: linux-mmc@vger.kernel.org, Ulf Hansson , Greg Kroah-Hartman Cc: Ricky Wu , Avri Altman , Binbin Zhou , Dan Carpenter , Jisheng Zhang , Nathan Chancellor , Arnd Bergmann , Huacai Chen , Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [PATCH v2 RESEND 5/6] rtsx_usb: hold runtime PM during transfers Date: Thu, 12 Mar 2026 12:15:58 +0000 Message-ID: <20260312121559.19197-6-sean@starlabs.systems> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260312121559.19197-1-sean@starlabs.systems> References: <20260305194052.5120-1-sean@starlabs.systems> <20260312121559.19197-1-sean@starlabs.systems> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hold a runtime-PM reference across bulk transfers, and mark the device busy afterwards. When runtime PM is already in progress (e.g. from rtsx_usb_suspend()), avoid forcing a runtime resume from within the PM path by using usb_autopm_get_interface_no_resume() unless the interface is already runtime-suspended. Signed-off-by: Sean Rhodes --- drivers/misc/cardreader/rtsx_usb.c | 38 ++++++++++++++++++++++++------ 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/drivers/misc/cardreader/rtsx_usb.c b/drivers/misc/cardreader/r= tsx_usb.c index 1830e9ed2521..5d818b632788 100644 --- a/drivers/misc/cardreader/rtsx_usb.c +++ b/drivers/misc/cardreader/rtsx_usb.c @@ -12,6 +12,7 @@ #include #include #include +#include #include =20 static int polling_pipe =3D 1; @@ -65,19 +66,42 @@ static int rtsx_usb_bulk_transfer_sglist(struct rtsx_uc= r *ucr, } =20 int rtsx_usb_transfer_data(struct rtsx_ucr *ucr, unsigned int pipe, - void *buf, unsigned int len, int num_sg, - unsigned int *act_len, int timeout) + void *buf, unsigned int len, int num_sg, + unsigned int *act_len, int timeout) { + int ret; + struct device *dev =3D &ucr->pusb_intf->dev; + if (timeout < 600) timeout =3D 600; =20 + /* + * During runtime suspend/resume callbacks, avoid forcing a runtime resume + * from within the PM path. The device is still active when + * rtsx_usb_suspend() runs, but usb_autopm_get_interface() can block when + * runtime PM is already in progress. + */ + if (pm_runtime_status_suspended(dev)) { + ret =3D usb_autopm_get_interface(ucr->pusb_intf); + } else { + usb_autopm_get_interface_no_resume(ucr->pusb_intf); + ret =3D 0; + } + if (ret) + return ret; + if (num_sg) - return rtsx_usb_bulk_transfer_sglist(ucr, pipe, - (struct scatterlist *)buf, num_sg, len, act_len, - timeout); + ret =3D rtsx_usb_bulk_transfer_sglist(ucr, pipe, + (struct scatterlist *)buf, + num_sg, len, act_len, + timeout); else - return usb_bulk_msg(ucr->pusb_dev, pipe, buf, len, act_len, - timeout); + ret =3D usb_bulk_msg(ucr->pusb_dev, pipe, buf, len, act_len, + timeout); + + usb_mark_last_busy(ucr->pusb_dev); + usb_autopm_put_interface(ucr->pusb_intf); + return ret; } EXPORT_SYMBOL_GPL(rtsx_usb_transfer_data); =20 --=20 2.51.0