From nobody Tue Apr 7 18:20:44 2026 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE1293BC691 for ; Thu, 12 Mar 2026 11:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773314659; cv=none; b=QW1VK1sSc5oFbDDLrRWW9I6pQP3Kb0ZVD+H0UW+vcyRHk4F3WSy9IPYIG2stMfehGAwCMCzgLeYvw33Sj4wttCf28btiqWlEmgf5UfO0N7Zo037QjE6GCdocds9AV5TPNOehgkaxQB/egRnnaXh7Ig6wMy31mSKjU0PUB97IsBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773314659; c=relaxed/simple; bh=fMF1zjZtYW/LRVY5l3KylMX1H6YZCmOAWejgja5oIko=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N+EgKIR7FJ8CoMkbLEHOauyfgpHm61Nd68o41GFZnB+0I7zAu7IADxZZTGoy1MYN6Gx2YS36DZobaE7TGGyWkq5p5XgWdn+KTTcZ+54iIIxPInDLFnEE8Pe2gVFpihso/uvx6osp9O0gbps5GTio3BmI5Vn/gEDAYcYE0HoKcr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=Ysb6Dw4N; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="Ysb6Dw4N" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1773314653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cj30hm5HNRXjPMriu/QBk8vWAAIdNsORZxQhVcrPE7k=; b=Ysb6Dw4N1UeM3VN2A8qozSkkIOfpxv3AmBDoJX1u78yU95FQIvQBXz64LSWs+of1uVTZZo SGtZpd8EYeipWTY8pGjeit7WtZ9QUOAhDVWouzZEA3yRH3XhgpeTM6mpkug/TMA0mMU3qa hNV31q3MLrZPvsyt5t/AXWL+dOLfzHIaMUhg6y5RqqJ4LCi6gz0V8fyhBGjsEga6fJwyON WTfYAFgMzRbqFgXWp3RLXV6wj+sxhP5gvnWTEotWrlTHuc4D0FbrdgG9mJhYY1NWtrSUGN ZmjiUq0jUWu4wTluj76YH7qpRYRLtDgqZ3IX23QQF0zz8RJT49r5kWuzX26F/w== From: Val Packett To: Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: Val Packett , Konrad Dybcio , Johan Hovold , Manivannan Sadhasivam , Dmitry Baryshkov , Maximilian Luz , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Konrad Dybcio Subject: [PATCH v2 03/11] clk: qcom: gcc-sc8180x: Use retention for USB power domains Date: Thu, 12 Mar 2026 08:12:08 -0300 Message-ID: <20260312112321.370983-4-val@packett.cool> In-Reply-To: <20260312112321.370983-1-val@packett.cool> References: <20260312112321.370983-1-val@packett.cool> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" The USB subsystem does not expect to lose its state on suspend: xhci-hcd xhci-hcd.0.auto: xHC error in resume, USBSTS 0x401, Reinit usb usb1: root hub lost power or was reset (The reinitialization usually succeeds, but it does slow down resume.) To maintain state during suspend, the relevant GDSCs need to stay in retention mode, like they do on other similar SoCs. Change the mode to PWRSTS_RET_ON to fix. Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver fo= r SC8180x") Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Val Packett --- drivers/clk/qcom/gcc-sc8180x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c index 55dabf6259b2..b116a9c0b2d9 100644 --- a/drivers/clk/qcom/gcc-sc8180x.c +++ b/drivers/clk/qcom/gcc-sc8180x.c @@ -4172,7 +4172,7 @@ static struct gdsc usb30_sec_gdsc =3D { .pd =3D { .name =3D "usb30_sec_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR, }; =20 @@ -4190,7 +4190,7 @@ static struct gdsc usb30_prim_gdsc =3D { .pd =3D { .name =3D "usb30_prim_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR, }; =20 @@ -4262,7 +4262,7 @@ static struct gdsc usb30_mp_gdsc =3D { .pd =3D { .name =3D "usb30_mp_gdsc", }, - .pwrsts =3D PWRSTS_OFF_ON, + .pwrsts =3D PWRSTS_RET_ON, .flags =3D POLL_CFG_GDSCR, }; =20 --=20 2.52.0