From nobody Tue Apr 7 16:31:43 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1DB23A0EB1 for ; Thu, 12 Mar 2026 10:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773310487; cv=none; b=AkFnfmd97xaFnP8Du/RtBI3EHR3rOyuqQxGwf8meInwAZ1FPCaY9fWJ770LfbiIAKfVN1rD+3KJtBgcuoUteoIvGf/IiHu6GVzMJ9oJvzDwHrx0Rb68UO/TtvX1psq6trpdi8hsZy8QUZ2FtY1NDTWqkFl2PDfs51DAJu5qdWXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773310487; c=relaxed/simple; bh=7hz56gYkfLsR7fwZZXQDBS2sB+2fzXdO0TOSAxu3FKU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WdBDTUf8OokJAl0LRTH72kwTOp6MdiSe5eQd1hjlFA8Qmkr6ZJm5uA/HQ5GBBrNKMYBh1QnHgjbgdb8YI/n42dMLi7ed7EvoagKjmS862RSsceTfnnNohJ6hgdt8BI9brB0u+8XZunOb56a91C5rWq3Gy98a/aNSSUugfD5NrJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pi7ewZ9L; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gjH7Kvck; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pi7ewZ9L"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gjH7Kvck" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CA9v5f263534 for ; Thu, 12 Mar 2026 10:14:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=1X7gcYQZXXBsIl3nZSh38k3FlvQMwhCo8hQ ompIzliE=; b=pi7ewZ9LYSmbVYTEJP/TUcZqA6vsodIqkAj9kRPu/Ez+vn/QgC0 yIVmq6qo/HSIYLFGIBhtC6UKsqegRT7lYAFBxc1UZtORMkbrgvagpDrbqhRk2x5+ jXo4r3vWWsi9cXGIxXD2HnpexKSaDzfaldtadVfMr2yqV2V3RRFxsySllce1veP/ vthy2OjmnVQ5l7yv5AkcXB73+Tj0iXWNJ2G4TZg4F0DhNGvraRywHRWo3q3fU7z5 KDgTOf7E07ntRq1M69rcoWsb7pOkxqcI0s7Osd3zstvfHkXembfogVhAe42a9uSV /8ZUW8Kvrw5jLeH94szPbiSHnNMKr8hJJ/Q== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yhq03-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 10:14:42 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-354c0234c1fso1097792a91.2 for ; Thu, 12 Mar 2026 03:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773310481; x=1773915281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1X7gcYQZXXBsIl3nZSh38k3FlvQMwhCo8hQompIzliE=; b=gjH7KvckhY7kkc2mqgUWrt4VONqZgNLmhlavZoKNwfPJ9nyrs+YEXhOOfEoGDi2pWx XEyLSdgoeLZof8vUhVjWmwQHBPJxFnUE6aDSpvcQCWcEYnJ5zeAhoD8A1mfar8iwDfx5 i+43a3WKTDMedkf4PmFPQDsMIDeIEimj802iwQGLR/LeXsLFs8qd3myU1BDxx8qTdLdK PxcIPO3ns2GaJr25AkSPyeVa36tk9HlrXGwwu1pL/uQkX7JNLtkjfN1aJt5Akk5q/qnZ Mx7SEUCuvbFxLLF47SRPrSNGPq9gHqX214OYiubZfVsz0u8Kvp0WXkSLiVzPhO/2Et9y kCSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773310481; x=1773915281; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1X7gcYQZXXBsIl3nZSh38k3FlvQMwhCo8hQompIzliE=; b=eNlIcC39up0477pZ4iCRCC58daQCTn1VF3Dkpiyy7CD2EkleF2agQZS8XXDl/iTjuZ wLucj4cHO41rMT2jKg69LYwH0t2T6pC/O3OqRY6lZm9z+lxoNVOUBcPLq5Q6lH4TBB3+ xn7OZlXhhu8jL+mTJAL95kuzCSSDXeDCrmbrczzBNyjettcvkzWVUmTjYf4ggIv6fPpZ un6GIZWUmAPQmC52eujPyZ79RreOGPNqLLwabWjAHwNzpFkFEIyKPJFxZVI+pqkRxgRY rw7hnIa1wKfLRtTA9CwuMucJR0PZ5nFAqe9QGHC2mt+GOuIyGOz0qdLUbZTiA2AxB+8+ UJhQ== X-Forwarded-Encrypted: i=1; AJvYcCXqrLoxEcY8D0RXCCV8WAw9h7DLuJg4aA7LqpV43JdsJhk/c/RCz1LogOUFuPrWRpvj58LroHHKZEOa63s=@vger.kernel.org X-Gm-Message-State: AOJu0YydWq7wSOUwl42Ra1SeLxTUtTks8L9ZXdzHfoxAzLajQhFQF2I5 tuJ50kGfM4IidHh5Z8//wJCzdeKdjRagUVTZEyv7AY8+MlZ4u483lTZjzzsZRGJIM4GPIs3kB/y JOFHV4bmeL+SMNFObtKxcLh7AZrmR5zI8qiR8q6yvNlFkYm/rPMq8wffzLZTkIrD1QSo= X-Gm-Gg: ATEYQzwWwEChiL7twbsHtW3iL8VhvwNxy6u89vEQH2zAdQCBxpeU52Cs/QSxHmj6K4Z 9R6R59bPK41Iv3yflLUGW2Xp6KU34utUxbr7if/r9eXVLNqZIT3KTezxzZpBel+KVYtxHmDdPCP 9QcGly9iXrahsZcPbMNIQhBijzufKg+URyEMm3NDBf2LjN3pdRftXkV92ELVkKcw5+3BGQDYepR 4wodo8OxF9ir3peUUTErcBBfqe2fySQxQ0bSRicWgkGGyJtUYSh1ZU6S4iWysh1J8X8oBLN0EOv ockwGyBtoGXzHYVB/+/bGTqgmPPEeHHTwZvyuJf3I7YZMATUerv/BhkjZnq2DjzvgUkmGxofMbz Oaza7q8h3kCqU81qZh8oSWFtuNaWezPrNvXX3O2iFUK09TKOVr9iHo7BkjJs= X-Received: by 2002:a17:90b:5607:b0:354:bfb7:db1a with SMTP id 98e67ed59e1d1-35a0199ca2amr5104408a91.31.1773310481410; Thu, 12 Mar 2026 03:14:41 -0700 (PDT) X-Received: by 2002:a17:90b:5607:b0:354:bfb7:db1a with SMTP id 98e67ed59e1d1-35a0199ca2amr5104382a91.31.1773310480826; Thu, 12 Mar 2026 03:14:40 -0700 (PDT) Received: from hu-kriskura-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73cdf248dasm4729109a12.9.2026.03.12.03.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 03:14:40 -0700 (PDT) From: Krishna Kurapati To: Heikki Krogerus , Greg Kroah-Hartman , Andrei Kuchynski , Abel Vesa , Pooja Katiyar , Johan Hovold , Venkat Jayaraman , Jameson Thies , Hsin-Te Yuan , Benson Leung , Dmitry Baryshkov , Anjelique Melendez Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Kurapati Subject: [PATCH] usb: typec: ucsi: Add UCSI_USB4_IMPLIES_USB quirk for X1E80100 Date: Thu, 12 Mar 2026 15:44:31 +0530 Message-Id: <20260312101431.2375709-1-krishna.kurapati@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDA4MCBTYWx0ZWRfX7tcfTAjd0O6b QJ8YFDNFupz3DX5CFNLmywnp25uBuQyf68st8DosvNJiwqnW0gj0rmQWStomsV4gShz+S352Jk8 VqWlxfSGq+gQLURrxW061fW21H23pMmxGMKSzbQSzgMEZogKHQX4qT7OYSKzH+SOGTpFktGhxcp 9Whl/I7pscqAilLNCQDD6lZTCIe1R1H+vfqB82rBvDD8J4FZONpaTJPgAzAIXbvmBVoo7QPRa/b Fmvr8g4zRD9J6NhqUa7saixZI2KvOj7ASFv3AhvHGjOR+YN/cwOljj6qzYOs/60VkMcSY5+ZoJG PPFJXjB9j5iIskmAa/dxEnil8fgv4Wwnm49bQD0VdGepOo7utPpCDBInU5GvxKF/R+77ZlBkyGL /eBevs1LnCzJ370i/BLQpM1JOQLJNUSRl63bRwvx4sL2UwWgX5Fb0B4mZ6N1Js8R8ytr9a0hr1I 0Am78VRwRmARpo8D/5A== X-Proofpoint-ORIG-GUID: Gnn1XQm0U22XOUOH1vRa2RI5owqa2WUN X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b29212 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=B76G-Ux6xhFiTzXwFL4A:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: Gnn1XQm0U22XOUOH1vRa2RI5owqa2WUN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120080 Content-Type: text/plain; charset="utf-8" On X1E80100, when we connect a USB4 capable dock, the PARTNER_FLAGS indicate USB4_GEN3 being set whilst keeping the PARTNER_FLAGS_USB cleared. Due to this, during ucsi_partner_change call, the usb role is marked as ROLE_NONE and passed to DWC3 controller the same way. Fix this by adding UCSI_USB4_IMPLIES_USB quirk and check for it to decide and pass on proper ROLE information to DWC3 layer. Signed-off-by: Krishna Kurapati Reviewed-by: Heikki Krogerus --- drivers/usb/typec/ucsi/ucsi.c | 6 ++++-- drivers/usb/typec/ucsi/ucsi.h | 3 +++ drivers/usb/typec/ucsi/ucsi_glink.c | 2 ++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index f38a4d7ebc42..e042499613c9 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1182,8 +1182,10 @@ static void ucsi_partner_change(struct ucsi_connecto= r *con) } } =20 - /* Only notify USB controller if partner supports USB data */ - if (!(UCSI_CONSTAT(con, PARTNER_FLAG_USB))) + if ((!UCSI_CONSTAT(con, PARTNER_FLAG_USB)) && + ((con->ucsi->quirks & UCSI_USB4_IMPLIES_USB) && + (!(UCSI_CONSTAT(con, PARTNER_FLAG_USB4_GEN3) || + UCSI_CONSTAT(con, PARTNER_FLAG_USB4_GEN4))))) u_role =3D USB_ROLE_NONE; =20 ret =3D usb_role_switch_set_role(con->usb_role_sw, u_role); diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index 43a0d01ade8f..cff9ddc2ae21 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -497,6 +497,9 @@ struct ucsi { unsigned long quirks; #define UCSI_NO_PARTNER_PDOS BIT(0) /* Don't read partner's PDOs */ #define UCSI_DELAY_DEVICE_PDOS BIT(1) /* Reading PDOs fails until the part= er is in PD mode */ + +/* USB4 connection can imply that USB communcation is supported */ +#define UCSI_USB4_IMPLIES_USB BIT(2) }; =20 #define UCSI_MAX_DATA_LENGTH(u) (((u)->version < UCSI_VERSION_2_0) ? 0x10 = : 0xff) diff --git a/drivers/usb/typec/ucsi/ucsi_glink.c b/drivers/usb/typec/ucsi/u= csi_glink.c index 11b3e24e34e2..1cb519cc0532 100644 --- a/drivers/usb/typec/ucsi/ucsi_glink.c +++ b/drivers/usb/typec/ucsi/ucsi_glink.c @@ -371,6 +371,7 @@ static void pmic_glink_ucsi_destroy(void *data) static unsigned long quirk_sc8180x =3D UCSI_NO_PARTNER_PDOS; static unsigned long quirk_sc8280xp =3D UCSI_NO_PARTNER_PDOS | UCSI_DELAY_= DEVICE_PDOS; static unsigned long quirk_sm8450 =3D UCSI_DELAY_DEVICE_PDOS; +static unsigned long quirk_x1e80100 =3D UCSI_DELAY_DEVICE_PDOS | UCSI_USB4= _IMPLIES_USB; =20 static const struct of_device_id pmic_glink_ucsi_of_quirks[] =3D { { .compatible =3D "qcom,qcm6490-pmic-glink", .data =3D &quirk_sc8280xp, }, @@ -379,6 +380,7 @@ static const struct of_device_id pmic_glink_ucsi_of_qui= rks[] =3D { { .compatible =3D "qcom,sm8350-pmic-glink", .data =3D &quirk_sc8180x, }, { .compatible =3D "qcom,sm8450-pmic-glink", .data =3D &quirk_sm8450, }, { .compatible =3D "qcom,sm8550-pmic-glink", .data =3D &quirk_sm8450, }, + { .compatible =3D "qcom,x1e80100-pmic-glink", .data =3D &quirk_x1e80100, = }, {} }; =20 --=20 2.34.1