From nobody Tue Apr 7 19:15:37 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31C7040DFDC for ; Thu, 12 Mar 2026 08:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773303632; cv=none; b=L8gZt4CH4SftYYj1DmXFZ44w7APNvtJ2XiABgcVLjeAmdpx57Qrg4Mh3rWgE93bR/hYJgcb23oRMY/AujicTrX+yUatfDDEf6U1vpq8Nrpc6ZDFZYdnJlxCMMa5VIrbkMao5gQjxjLeb35mQ8piPFLN4enR4xEFUw7EqEf0j/W4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773303632; c=relaxed/simple; bh=utsr2wFERS1dweRxRw6x9TMZVrqawmdGB2Vg8I7kYpw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VYewv+Kv5ZI6UON9qqxNP9lFQ/I5NSNWsqSze/wWSYm2jFUtqJ32Q0tmPdc9fdjGTteaw3QfqKEfwY3M8WzOJDSrDgUMCItoYfK9u1Jj+RPDDxdEvVYrJs88gcNwQL4Br3fBYfRez9dGcRlFFsphQl/0PFY2ABGsq483D8ELv20= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bK48kZMF; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bK48kZMF" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2adff872068so3864955ad.1 for ; Thu, 12 Mar 2026 01:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773303630; x=1773908430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RQzoVC+zbsYW93M6OjzhineZstDtj2uD7TkTjyo4rvg=; b=bK48kZMF2bLtsZQ9S844dQppDK8b8pMYsTbY76/KewJnztp78eD17lVBnBijsyI3Dr xJJAhEJmluWgLDrzPVwAOtVU5hHa5Ei56nLjN1YCA3wxJ/GN0R/FzOYE3zLwrsKklbhH jJS1AFJFBPbqkr+GBuIZiGHTccNiirezm1MJwgnAyrOPc/HFawztREAFCZzJ2vfb5xgb 4938CTfPk24PJS57AciGOBJj/5xTYA9rZHUinxV2Ppssnjs0o/oVpBXhd2TV0M/4SZrR iTdvz+KEBZBiI/3XtZxjVAjeAZSpu9pwNQ07QKdb98apFRg/bPcRfaCo15TgmTmi2CVG Ez1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773303630; x=1773908430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RQzoVC+zbsYW93M6OjzhineZstDtj2uD7TkTjyo4rvg=; b=SN66fZS7Wur2yEdeaWqbB8rpQsnXNwUM5d3/djVcAaQ3uws8aZoLSJ2JP6WxlaQQOV Pbf3E7kLUhHp42e2+bFRAdOqKbE9KJT2VJnmf6u9EeU/trsH6SG9FzMHucNlnwVgVwK7 f43VzFs979mo9SixbQIvM7KatHQqaM37KpM2lORHTKsDVFPmgpZjI/wU5Z74c0+ODrkR x5tQxwUTIHjq45HIyldyXFFUnzmssExkEPAlMEvfYfcnC6E75DaHXKC5uZBP0+Hts310 cPJ9AsHFb7LlvJHME4Bla5NlcHLYifdPGBmAH3wWJebVFmoipbrz8CHyt0PJ50/o/qmL LTMg== X-Forwarded-Encrypted: i=1; AJvYcCVXOl2woi2lCphZAArkbDmsZ0ijuwEsYS9G14dpEAfV1XeqkId5fBy5nptlKHKXZ94cWMvD5ACUYGSS0ec=@vger.kernel.org X-Gm-Message-State: AOJu0YybPZQ3NHgV+iEuSCRWaWZdG2aLdXC2FQ22dWWcayw8pLYeL37o 2yU1+s/q50PBRSqCPDbqEU5vOYwTEzk2XZrF3pQrL9cCjbXSgL+wEh92 X-Gm-Gg: ATEYQzy0hyRWe7BPEFrbEcs/gqx/rro9q4l7VhQIhi+8Br9FEet3NQF99CsYpyF0wlm qkBU6c1il1+C9oKBL5LluZ/gHvJJ9sctBOfOKQLzlS9fgQTWkIPlPfDZ44ZQSJ3nP2pQSgHRgsp 32kcCnSgtUKAsDgOfQPK16mgWXX9XLJO6xGJSUyh4iJvCH8fKAVj3QZJtOAs6Be2UASu4oeot14 pRn8B3w6dMQhiJkDPkDlnxl1/rtszF37vdWw2ufO+KNvyuqyoHm+SuyRI1PRW24LgQgQFNHAURR 79O+CVhNvCUP3Zd40n5A1nXQgtQCsOwGNlG3jbdDLwfaXsISjJ0lD5V2Ul+IL89Fa2044C7SxJ5 XfW8FOR9X4i+d6DxqxwyNOqQTq7EifS40d4EV+Dfw+3m5GdCMgjl+wy2mooIiu33Wozxi1lqwbV UU4x20sd3v0CMLlYF1dhdwZYoAgS+wMB4RGe5vue2saHFuQuXLX+5sRKQqGQF8hU/VxP2rNPKUP fEpqyaCxmdVvD+Rg5K9XKc= X-Received: by 2002:a17:903:2288:b0:2a0:fe9f:1884 with SMTP id d9443c01a7336-2aeae95b193mr56649855ad.55.1773303630577; Thu, 12 Mar 2026 01:20:30 -0700 (PDT) Received: from fedora ([103.92.106.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae24a91dsm64388905ad.31.2026.03.12.01.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 01:20:30 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v3 3/4] iio: accel: mma9551: convert to guard(mutex) Date: Thu, 12 Mar 2026 13:49:41 +0530 Message-ID: <20260312081942.23858-4-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260312081942.23858-1-rajveer.chaudhari.linux@gmail.com> References: <20260312081942.23858-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma9551_event_handler(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v3: No Changes v2: Dropped Header alignment change --- drivers/iio/accel/mma9551.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 02195deada49..65a913972ce2 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -337,7 +338,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) u16 reg; u8 val; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 for (i =3D 0; i < 3; i++) if (irq =3D=3D data->irqs[i]) { @@ -349,7 +350,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) /* IRQ was triggered on 4th line, which we don't use. */ dev_warn(&data->client->dev, "irq triggered on unused line %d\n", data->irqs[3]); - goto out; + return IRQ_HANDLED; } =20 switch (mma_axis) { @@ -373,7 +374,7 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) if (ret < 0) { dev_err(&data->client->dev, "error %d reading tilt register in IRQ\n", ret); - goto out; + return IRQ_HANDLED; } =20 iio_push_event(indio_dev, @@ -381,9 +382,6 @@ static irqreturn_t mma9551_event_handler(int irq, void = *private) IIO_EV_TYPE_ROC, IIO_EV_DIR_RISING), iio_get_time_ns(indio_dev)); =20 -out: - mutex_unlock(&data->mutex); - return IRQ_HANDLED; } =20 --=20 2.53.0