From nobody Tue Apr 7 19:15:37 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D41243382F1 for ; Thu, 12 Mar 2026 08:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773303625; cv=none; b=YbPN8vEvrTLl5iSMhQVLTCd16KZ0cYplEqbgNymcv/jeGZuomHRltKeGh9azt4vxIfRU1LAfbhRV1jJWjIwHYhC55QcjrkrrJxFzSmzGlVgEWj/ikzsZ8DlxcN5NsbQAuVM1t9PyMP9z6YrTJRtJiBGA2ufRbf+wQIF8nLVlxac= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773303625; c=relaxed/simple; bh=ou3lbyq4fDZg+GSVSfhDp3gj9+aEBNAHHddZXTYBnG4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q/gh19r3u3RAmZhjUqvXwvJmtzkDRLkqxdWmwBK3jq+Q3uyk096wQ4vC4Hxsv4YlcQsXPkcgc/ZzYpyQM4PeBb29D3Te7TtXUrkOEMXW8dkATqVDkpPgtYNDt5iu7YrlVoaVnvqOgc9fc0IxKZz89hF8RaXgHf+y7XeGUdRTaPE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eXc+vijq; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eXc+vijq" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so271833a12.3 for ; Thu, 12 Mar 2026 01:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773303623; x=1773908423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UY+BDJIyA8NSf40uEDoQLKUGXr4A905L63hTXYyoJv0=; b=eXc+vijqqGgrzxngjrmQD/SsbN52lq7SQOVc70fhzJKXURlwVb8IlRDOBmT0z0H8NQ Uk9axJvyz9DnO6GhRVglJ5hALkCqiZBJGUKadZUUDUMetPRQmQu08+F10E3/42DGeg2J zdwfpM1O5RvXe65J2mO4+/JwZAR/hVuTu8MYxnyG8qGluFxUq8Ns4obPH0N3DiWGyaui LpEWeIKeHkW/S4SX408ky1QUHbYRV6h/QOQPUW9mmiXdWglKcTJ8o9GHmn0fkfjMzKpT ymmctzF/aIR/m8EDOsqn8U2O0zoQcG4ujTNJnCxQqbCE0+pVw+abSjLimdAnYj+4R3Gm 4aeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773303623; x=1773908423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UY+BDJIyA8NSf40uEDoQLKUGXr4A905L63hTXYyoJv0=; b=bdQ4jY0Klj28xjbVOzqrlEO0XdWQAPNZqAeptFDvi3sY1J+CLvBooFHN9AE82Ib/Lt I9ezgKYUibv1LEvw81qj8NwlWSnLu8snyXFVT/40IDGsYjeVOr4PFLYkzFpDYSIo2MBn uSNFafPp5cxCFoShrkvhbQWg2wVD0NubcVStF+EhoKxDC7tq4ilcVfuLFjZI6zTSHuG0 OawGW8E+G/SxhXnGVn6p5Iswd4bZunpJdzPr8SPiirm0wxc8IVufxJWJ6R1Gc7cVx2WJ +93cjVOxXjznWlYJX1DEIwGUIGqi/sHbaiwwjGiUipisT74C+yG8Jg13bTlE9FRWU4/L StUw== X-Forwarded-Encrypted: i=1; AJvYcCUNYboxP9GJpHnGJW7MSDeOx6JT1VfVXfFXLS/26dS+eCv37Kx+OXkoOsQZaxhXwu9firm46ISFmuaDrCU=@vger.kernel.org X-Gm-Message-State: AOJu0YzmQq56jIyQ6tyCheY0KSbMaK0VVLNoD6V2LvIjEeUY4KaEmg+n lKeGO2fXR/mUkcRcSOy2iCfPR2uTabM8Jg/N4a5KI3gX2DTuu2ISATPF X-Gm-Gg: ATEYQzyxXFCIoFYJTej+/VU/aXTIB0GHjgv4bSxB0ccCOkl9aSgE3kRW03A009FW+LN 3InJnqsTg50D7JYmAxhZqiaEBERI1ZFBmjk9OsaGZt/N+5kNYtsXVreSy0cS7vQNa/Lg2PSIeuv KkVQXLKaA+iHNP4QamSkZEdLHIxrOCPBBCG/w4PzSp8zGdYjrrV8zZYP/0gqsecgqUc1m+KrHED DA6SIEBH0JuOTEOqn3to9OySdiP0SMxoCQFdC6UZAje4ewJWoKvscNC7khmzR86YrPPKF7iFSDR 707UQpTvDRGBKBsQar3Zn24iZI/9UWKexyEw/klNOWjeeExKwzu2XRDiqLIGlrKl2tZ5XMvRADV A8xoAJWHgEVIyAc2WG3y10HQYqz2eTe3ejx1qjw78W7akZSlQKyxFd1rJoLPVMT+2IM3QC78kEH sNK9wUNRnyH8uu3JQxPR6DjysAqgD39mQwkXfhj6ZfZgOyvueeZ+ZM/fmAaTX17nFvgWd+00xC5 FibwjKTRmdnEP9C/+00Rfw= X-Received: by 2002:a17:903:2f8d:b0:2ae:5a28:cbac with SMTP id d9443c01a7336-2aeae85a65dmr53352415ad.32.1773303623161; Thu, 12 Mar 2026 01:20:23 -0700 (PDT) Received: from fedora ([103.92.106.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae24a91dsm64388905ad.31.2026.03.12.01.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 01:20:22 -0700 (PDT) From: Rajveer Chaudhari To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org, sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com, antoniu.miclaus@analog.com, andrew.ijano@gmail.com Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Rajveer Chaudhari Subject: [PATCH v3 2/4] iio: accel: mma8452: convert to guard(mutex) Date: Thu, 12 Mar 2026 13:49:40 +0530 Message-ID: <20260312081942.23858-3-rajveer.chaudhari.linux@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260312081942.23858-1-rajveer.chaudhari.linux@gmail.com> References: <20260312081942.23858-1-rajveer.chaudhari.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in mma8452_change_config(). This ensures the mutex is released on all return paths and allows returning directly without a goto label. Signed-off-by: Rajveer Chaudhari --- v3 : No changes v2 : Dropped Header alignment change --- drivers/iio/accel/mma8452.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 15172ba2972c..09bb205a1b8f 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -20,6 +20,7 @@ =20 #include #include +#include #include #include #include @@ -597,36 +598,30 @@ static int mma8452_change_config(struct mma8452_data = *data, u8 reg, u8 val) int ret; int is_active; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 is_active =3D mma8452_is_active(data); - if (is_active < 0) { - ret =3D is_active; - goto fail; - } + if (is_active < 0) + return is_active; =20 /* config can only be changed when in standby */ if (is_active > 0) { ret =3D mma8452_standby(data); if (ret < 0) - goto fail; + return ret; } =20 ret =3D i2c_smbus_write_byte_data(data->client, reg, val); if (ret < 0) - goto fail; + return ret; =20 if (is_active > 0) { ret =3D mma8452_active(data); if (ret < 0) - goto fail; + return ret; } =20 - ret =3D 0; -fail: - mutex_unlock(&data->lock); - - return ret; + return 0; } =20 static int mma8452_set_power_mode(struct mma8452_data *data, u8 mode) --=20 2.53.0