From nobody Tue Apr 7 20:08:11 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010018.outbound.protection.outlook.com [52.101.85.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8871D302CD5 for ; Thu, 12 Mar 2026 04:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.18 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773290784; cv=fail; b=tfmO8X+kWK3XIddGtFOfbcQ8LQ2IIz0+6NkbY65Bq7Zs7Apcgl21O+XxbLo8c22b6bZGDVQadDw7N3SPBNHhAsy/+sTcLuULKq/ukjLmGWgSdW7PDdRtUNAYskiaxMA2pkggrb523eHRixe7m5Zjrr2f5QCos82h3ASkkMmS7tg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773290784; c=relaxed/simple; bh=YbMChKSN1xitcCNMqxrmFSRzfDnpQmk88nYRUVi4po4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=obF1VzfKafRHoJQBE9GB2A194KGSLoT7/jFygGTK/zVqth4m6p/3pn29dJ45UumhA/6ylRCV5BTSRCgrFrBFFl7rzez+3AAeE04a/Xn7PZaWThvptVuPxo3gvApx2u+/EJIL2kmAyiUvJSSA7ZFP2gpQ3DZn1syyWBrD/2tI/T8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=lDt8kvWp; arc=fail smtp.client-ip=52.101.85.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="lDt8kvWp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m7kxF/iSQphNWzmO9dzNNyB5OsP9wcrkVNwhk0ZtSBWVtQzV45N/nZ4w06GS0AjyB7fTcWNhXeviOH5aLa4ws9FCOGKykqYO63LUYDyIGPaDWqbY8TSpxswui0rNlziuIhMjwrNGCdeswrsNiDVCfA0R6xyrmVfA6T1GGvg60K8JPlXqQdzGRB/Xon+F2f6ifL9UXtNLp6YUSYeQ3sZerHV6vwWyQ/1f2MqAHsZOX136g4ZW+XPZ5nAI1Hf3THhTJNJaoKajUFoA4eCeuq1RQhIVdcR9jZ9SfJuIeevCyHgczeTkaAHQu/Gk3UohSeVNrrciuyuyi72QWK4mnGGGjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aIKQ3PAY/DAOorp7ADSZNYihdJx7RSKOjuUmJDyyBG0=; b=X/0wTECU6WeNgGEbNJpIC4NBdtZW77AeFTNs9MIWLou3ETfWG+ENflUEheOg1jWkjBX5Jukxny8N66btuiW0HOyHZVIq9ayGNjrAsfUscwuBDx1E6QNGtUYG0mEqepb19R8DmqALho2YH5gSwOFj2syrwj655Bk1P+hIRVfUJd2sAJL4xQn+LDwrD3nxq7zdqyOM1bSYJ0SXK4Umgi9zcDWIjGCh5i/+8LOoqsDVr4sRHvy/rVskNDtfBIten6svdaR2TpWjfJIa/K6Q2dS+RSCMTUYqROxrDTp6Fzcbrxu8USMSz5vYIE6Rx0kdNgoyyAcFc+StFjGbCM/xko/Gkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aIKQ3PAY/DAOorp7ADSZNYihdJx7RSKOjuUmJDyyBG0=; b=lDt8kvWpfNUQxLpGQ+nfECYIVj+aV15aqTR1xzp0VheDc/Ubd2zsEYsrYi7tppU2ne7Z6h+52hW5gprpe3u+dtXSDEKbldSbCCTgu7XqIQhqFzTVG6ODD+CB7XLtKEIPohbX0kRE0VnDI3yTgEDu8RqbvNk5V6EOOuIAoCnCLDI= Received: from SJ0PR05CA0067.namprd05.prod.outlook.com (2603:10b6:a03:332::12) by SN7PR12MB6792.namprd12.prod.outlook.com (2603:10b6:806:267::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.6; Thu, 12 Mar 2026 04:46:20 +0000 Received: from MWH0EPF000C6185.namprd02.prod.outlook.com (2603:10b6:a03:332:cafe::e0) by SJ0PR05CA0067.outlook.office365.com (2603:10b6:a03:332::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.25 via Frontend Transport; Thu, 12 Mar 2026 04:46:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MWH0EPF000C6185.mail.protection.outlook.com (10.167.249.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Thu, 12 Mar 2026 04:46:19 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 11 Mar 2026 23:46:14 -0500 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Valentin Schneider , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Chen Yu , Shrikanth Hegde , Li Chen , "Gautham R. Shenoy" , K Prateek Nayak Subject: [PATCH v4 5/9] sched/topology: Remove sched_domain_shared allocation with sd_data Date: Thu, 12 Mar 2026 04:44:30 +0000 Message-ID: <20260312044434.1974-6-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260312044434.1974-1-kprateek.nayak@amd.com> References: <20260312044434.1974-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6185:EE_|SN7PR12MB6792:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f57330c-aca8-475a-5079-08de7ff24dae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|7416014|376014|36860700016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: LXQQCYz580930IDMP9hjPbDv8xrcOEm7hZTEN6QXatLTJChaxgjj47DdfXhWuEinMAmTqHlPWvF3dAAienJ4ZapiUbY7zmTOPrSQXBcczEeV7btPxn6PfT+DN4uzir8m85eHrhns0zP4Gq3kp3rovuGTaUElTe+nCK1I+7x5CS02AdRS3Q2K597FYfE7l327g3QqTghxH9U70Sjfcptwena9gc2Z/het2KHdJc8KKV37/u7z9RcMZ2lIP7lgYVP9pBmMOgoqmiRULd6kUMBVxDKYGoB6UKQOnBGAO0S1CkxkF1byE9Kx11z8livWdYNGrigIBlgSmRY7hIXvryXivZw5XoB965mh+LRDoz/viUOstukxW62BAmyTIMDigq4SdNAb5+RKJuwYtGaK9LLPkxvHWKQHs13P6aMsh3TZkjwQNCStDYMW1myXD6znBpJG9ZYaSOD3jD9DSsxAnPTQ2RoeYTBG1cEsOKMnJikVGqdTqd41BwLc4S5ZQ4Y1GVUPHLVpeEUlORamhvo1c8FYK1UKIASlnqN3zfuy70qJ1NU28ZPLq49QwdDJvkF4cNcsRwM+lEJDVOkM0PpUI2H7/DTygEfuHFRj0z2LIzqv35bZF228ErxT7CpuSN57Qd3oMjA4EcjzcgorTbp9psGmCydxNif1Mh5ClXAlo5Vz8+tqmmJRpw8rrG+ZQLptqhPQ5ZM16klSzwdVIgyO9X/KXv3e2SPex6SXvZSQP5Bt9NI/asqdm8y/m6/bRWttVCxnbXjlNgt59Ongl87m8ExL4A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(7416014)(376014)(36860700016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: E08hHAGdaEILdXhrXjOqjpuYvne8jO5jQbQaVww2our30GBeBlIHCc/c0SDJ1HaUnhrJMmtu9BYVrDNKMP/0rlfaRsD4piIG0tLsxCtxPzjfKV/4eEbPO2//6MNsK+bwhdtqizLFoY0o/jiDM+oxFNPFNdfAKT9B8vFKXFAZqg2xXUazBhNvvhb9OR6F4rM+O+U786e3srpNVpvAzGn+ycWCXGNQiRH6zJgYI0rmD5fEyYzoXyBkSDQ+I79lfmkwyqHF70ngJiCMvgwshiJTWzh3DHRxrrYWb/0kAGE/+ZBGvbGWa5lRhjdOwWsdp2V01539v0nhaAOwRieO9sfzlguSK02WasVUT4pbWlNbKX47kxcq++vFrbf+Ga18Iv6chBIf4kuBeV0XeF/OV2VPyL2syUewxmqQ17/KKxO1eR8xsCl/0tIFz3OUgIFZDsoV X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2026 04:46:19.3928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f57330c-aca8-475a-5079-08de7ff24dae X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6185.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6792 Content-Type: text/plain; charset="utf-8" Now that "sd->shared" assignments are using the sched_domain_shared objects allocated with s_data, remove the sd_data based allocations. Reviewed-by: Valentin Schneider Signed-off-by: K Prateek Nayak --- Changelog v3..v4: o Collected tag from Valentin. (Thanks a ton!) --- include/linux/sched/topology.h | 1 - kernel/sched/topology.c | 19 ------------------- 2 files changed, 20 deletions(-) diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h index a1e1032426dc..51c29581f15e 100644 --- a/include/linux/sched/topology.h +++ b/include/linux/sched/topology.h @@ -172,7 +172,6 @@ typedef int (*sched_domain_flags_f)(void); =20 struct sd_data { struct sched_domain *__percpu *sd; - struct sched_domain_shared *__percpu *sds; struct sched_group *__percpu *sg; struct sched_group_capacity *__percpu *sgc; }; diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index ebd955faab40..963007d83216 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1609,9 +1609,6 @@ static void claim_allocations(int cpu, struct s_data = *d) WARN_ON_ONCE(*per_cpu_ptr(sdd->sd, cpu) !=3D sd); *per_cpu_ptr(sdd->sd, cpu) =3D NULL; =20 - if (atomic_read(&(*per_cpu_ptr(sdd->sds, cpu))->ref)) - *per_cpu_ptr(sdd->sds, cpu) =3D NULL; - if (atomic_read(&(*per_cpu_ptr(sdd->sg, cpu))->ref)) *per_cpu_ptr(sdd->sg, cpu) =3D NULL; =20 @@ -2392,10 +2389,6 @@ static int __sdt_alloc(const struct cpumask *cpu_map) if (!sdd->sd) return -ENOMEM; =20 - sdd->sds =3D alloc_percpu(struct sched_domain_shared *); - if (!sdd->sds) - return -ENOMEM; - sdd->sg =3D alloc_percpu(struct sched_group *); if (!sdd->sg) return -ENOMEM; @@ -2406,7 +2399,6 @@ static int __sdt_alloc(const struct cpumask *cpu_map) =20 for_each_cpu(j, cpu_map) { struct sched_domain *sd; - struct sched_domain_shared *sds; struct sched_group *sg; struct sched_group_capacity *sgc; =20 @@ -2417,13 +2409,6 @@ static int __sdt_alloc(const struct cpumask *cpu_map) =20 *per_cpu_ptr(sdd->sd, j) =3D sd; =20 - sds =3D kzalloc_node(sizeof(struct sched_domain_shared), - GFP_KERNEL, cpu_to_node(j)); - if (!sds) - return -ENOMEM; - - *per_cpu_ptr(sdd->sds, j) =3D sds; - sg =3D kzalloc_node(sizeof(struct sched_group) + cpumask_size(), GFP_KERNEL, cpu_to_node(j)); if (!sg) @@ -2465,8 +2450,6 @@ static void __sdt_free(const struct cpumask *cpu_map) kfree(*per_cpu_ptr(sdd->sd, j)); } =20 - if (sdd->sds) - kfree(*per_cpu_ptr(sdd->sds, j)); if (sdd->sg) kfree(*per_cpu_ptr(sdd->sg, j)); if (sdd->sgc) @@ -2474,8 +2457,6 @@ static void __sdt_free(const struct cpumask *cpu_map) } free_percpu(sdd->sd); sdd->sd =3D NULL; - free_percpu(sdd->sds); - sdd->sds =3D NULL; free_percpu(sdd->sg); sdd->sg =3D NULL; free_percpu(sdd->sgc); --=20 2.34.1