From nobody Tue Apr 7 18:00:36 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C1AC3A257C for ; Thu, 12 Mar 2026 11:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773316405; cv=none; b=XSrzTqScNgbag2/HZsfWnSQ7Sl0DiIlcJpzPZ18CUdR7vVndZbRoPjrl44P44Su/IosSHyd4QjeSkEnud+esVgQKAlzKBUpjB5Glz1hZ/4LRa25OQZ7LJGsz010OZka9orYUgX5ADa3ahK7+VaPnvq/x9GIoHL7uKeS1Hsm9ETU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773316405; c=relaxed/simple; bh=6TUyoJLJSqeungB5Dy08vZAqsI6zizoCJy5q8AmL2/4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lGokZ84r0jXzMMBN2cDzA6w4WHg+PT/hcetJztCxTR3Uoy+SQD8NQ6CF9B7FAMH9EhDEIbbTijNqwi0u0QF9X/V30IQ7OHW0kU17EKksEIdFaEdCGAecjzxLaI/b7aPTvY1PSorqfxETquNsUIEl6/09AVdzfiZvHUSmPCcWmyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DxLbspGt; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DxLbspGt" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852f8ac7e9so10594445e9.1 for ; Thu, 12 Mar 2026 04:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773316403; x=1773921203; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zJtLWo5ws6cOY8PPBgpE01aNyBcJ7pcov+uZ7h1HS6E=; b=DxLbspGtxz9Q6QNkA6okY2YiBQNjpHb4sbbGAYsNfczWxfyTi8gijMyWahB+xf5Il7 9Cu9x1uwC8gYz1janyFJvW2Jrl/45h2weuIa0T8o7/cL/I5HDHXP0ZRCd0m/q3bkX+LT sN/2TsH2EyzMK6ka0PYNHUOHTCn2d1cZEKKMPykwnFL0UjQOjv2wNYerZjNA3PvzFjQT yzlhgzL5KetUJTSMfn0VlW/QUT2W8FuC3agq9Zo7OVeUSuMgVus2ud0HLs+f9k40CG/X JvyrmC08JE1sszAEmmbOtk7hJGG5/XhcAjQGWel0fe+Jgz7ojURYAxD6r4zLhn4G38vt w8Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773316403; x=1773921203; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zJtLWo5ws6cOY8PPBgpE01aNyBcJ7pcov+uZ7h1HS6E=; b=FaqQH0ojhMPqvdBSYW91/5AQ8IwzSUh+sS+x3ovCNeRT/1+C9Jwsixg2eh0SSsrmWA 829xuEQYBRyHDfCmLe7N84FrhDNU0M4RxiRtrb7hmXFJvjqGr4BMiera3domWLYGJ10B qpVgqPOhs53GJSKuOzoPxhpfNlgKMCK5dw/9xkhcfqumGai0G5M05VgoXdFC+Fg9KS3W bA6J2A+RSFoSNFliJ+nfei+6selM1winB5WE//LZXSmDEzOB+6q39etzRQ2G5aZBmJ6b iBS7ZDUSSU1H0eLge9c8xWSOMUtgnMO3dHl2uWB7qIvXJ4JSz8dKi3l7IMjAKVjIg6s5 R2ng== X-Forwarded-Encrypted: i=1; AJvYcCU+2Wp04UlHeS5/l6cSowSNPYODKUYKDvF1eCBrdcIuVvcpZkU5RkCmjA8KTY+YoilJmQ+H71jj0r13mpo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz12FHtbCH5H8osi4K9C21hIh8+A6KCiuDSYmA5wCRmCSbnScwM UUVb392jzdJg2Jzv1QNmTNq7Mwuuo7OytNyGs/+Ga6buZ6+T/9f1kh1Z X-Gm-Gg: ATEYQzzsjWIwwKDpvEKqrsOEPLFOOnm4wa7Nv+AHqV6xRvxfIdD83AfIYowIOuDfK1A IEN2gLirCvEGMGYOk8m8UGzsVWgN92T7N98DCQW5Whip8nfJBc8UVf48T0WqdcoUmm2cfx7bZI1 Toel1ngXhNUkqk9Tz7N/ZnorIaGB2XR0MzqNyEaJ7QzsQfx63pyWTtXT8PwZMDbUmSiCEjZGVlP 5RZ3ghR4/Zp9nSkZsDWOI8TtucKaP1evlGMIrjafQbo9o/y2pHh+WN8oG+1TzsDgHb+g6aU2NY9 89Ke/kXq1IftEF/7Duka5pg5r92ONTaJwtrZo4qUKbkkvOqlPHF7b4dRyZY4aAD7427hLjcFMvp Rszlad9u+16hnfRSn9lXBFFl4QwmzZBEpwaQaz51AncnfZR19HStlFlGZci10mtUizzYEd3L51T jN8sxcDwezUhZ/BXe5gwbcYclP5Q== X-Received: by 2002:a05:600c:19d4:b0:485:3ae3:b394 with SMTP id 5b1f17b1804b1-4854b158082mr108421115e9.31.1773316402466; Thu, 12 Mar 2026 04:53:22 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe22529csm7044960f8f.31.2026.03.12.04.53.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 04:53:22 -0700 (PDT) From: Erikas Bitovtas Date: Thu, 12 Mar 2026 13:53:14 +0200 Subject: [PATCH v2 3/3] iio: light: vcnl4000: move client->dev in probe into a variable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-vcnl4000-regulators-v2-3-2bdebbcbb58a@gmail.com> References: <20260312-vcnl4000-regulators-v2-0-2bdebbcbb58a@gmail.com> In-Reply-To: <20260312-vcnl4000-regulators-v2-0-2bdebbcbb58a@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Move client->dev into a variable of its own and replace all instances of client->dev being used by it. Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 04bde498aec4..36a3d8075eb3 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -1987,9 +1987,10 @@ static int vcnl4000_probe(struct i2c_client *client) const char * const regulator_names[] =3D { "vdd", "vddio", "vled" }; struct vcnl4000_data *data; struct iio_dev *indio_dev; + struct device *dev =3D &client->dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -1999,7 +2000,7 @@ static int vcnl4000_probe(struct i2c_client *client) data->id =3D id->driver_data; data->chip_spec =3D &vcnl4000_chip_spec_cfg[data->id]; =20 - ret =3D devm_regulator_bulk_get_enable(&client->dev, + ret =3D devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(regulator_names), regulator_names); if (ret < 0) @@ -2011,10 +2012,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 - dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", + dev_dbg(dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 - if (device_property_read_u32(&client->dev, "proximity-near-level", + if (device_property_read_u32(dev, "proximity-near-level", &data->near_level)) data->near_level =3D 0; =20 @@ -2026,26 +2027,26 @@ static int vcnl4000_probe(struct i2c_client *client) =20 if (data->chip_spec->trig_buffer_func && data->chip_spec->buffer_setup_ops) { - ret =3D devm_iio_triggered_buffer_setup(&client->dev, indio_dev, + ret =3D devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, data->chip_spec->trig_buffer_func, data->chip_spec->buffer_setup_ops); if (ret < 0) { - dev_err(&client->dev, + dev_err(dev, "unable to setup iio triggered buffer\n"); return ret; } } =20 if (client->irq && data->chip_spec->irq_thread) { - ret =3D devm_request_threaded_irq(&client->dev, client->irq, - NULL, data->chip_spec->irq_thread, + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + data->chip_spec->irq_thread, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "vcnl4000_irq", indio_dev); if (ret < 0) { - dev_err(&client->dev, "irq request failed\n"); + dev_err(dev, "irq request failed\n"); return ret; } =20 @@ -2054,7 +2055,7 @@ static int vcnl4000_probe(struct i2c_client *client) return ret; } =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret < 0) goto fail_poweroff; =20 @@ -2062,9 +2063,9 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) goto fail_poweroff; =20 - pm_runtime_enable(&client->dev); - pm_runtime_set_autosuspend_delay(&client->dev, VCNL4000_SLEEP_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS); + pm_runtime_use_autosuspend(dev); =20 return 0; fail_poweroff: --=20 2.53.0