From nobody Tue Apr 7 18:08:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F97A3C9EE7 for ; Thu, 12 Mar 2026 13:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322191; cv=none; b=KWptYj9wddydaEJXR8kEjFihQlNrDGRP071MB4Mlk+0JmZEEsbya1aiJNimxHrX1uYaQZeLgwFSx0B+g//HDousLfZUKE2zVNMnDnHcyVc0PhkVVO0WtUnQ/ql/bCIYAMDWBzihUppCjr3tLOmOvhBNMcJEgCHrwNdZMVPG6f0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322191; c=relaxed/simple; bh=f+xu0X2Dvffg/en/Ri5kZ4UL9cHuySjQYKW8TgamZik=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rh/MGKG0cUw9m26tl3Fuao8dqUhtRz+MJtV1DnjJBnckMzRaWmEsyNtgGh04msQNEzqFqm3V+svqjEPHfnfDSFrXz5WhyyFHVhs7xYPmhQvBIa8IU2ioVTgwzpfKUUhnuuR8rUsLCoo9F6EM5cCD/2FqQRHEnum74/jc7PUkEVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zz/zUjYw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RsqDf7hG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zz/zUjYw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RsqDf7hG" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CAe0P4263527 for ; Thu, 12 Mar 2026 13:29:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=Zz/zUjYwUoaf5Xpk Xy8d2SdjHkMv2MT4ohrq9AiBk8apgsgrWJAdthKILsQZJSUk9vGXVVyy9zJzMTb5 aKfTT8gfWYamRRGp6hSgFtfAbUFuJ+t4uESjiHHb1KMPh85NUegARZ8XeRVOdRQz QkvZAth2r1toGRes5YvaJ1KkjSzJzoBeJWWBAKDOJZuSiGi1mZ5XF6JCEt//ru87 2T0vQzeQ7jOXoWH7zjoSkXN4l1bkCG7Y9oHFYZEYVgP3wm3WA6uCJn+JWFM51tFE S1gB+FNKixldkQFCL+1DQstXRoAXEaaO4Luz0mzKOXg6PlO022C4j9bbPAVn+Fmk Hd1FzQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj64q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:48 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd76ff19d5so587213085a.0 for ; Thu, 12 Mar 2026 06:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322188; x=1773926988; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=RsqDf7hGt6q4s6KS6Kw7qZwU9oobA4fUe7ptWVWfyhJh4wICmK9o9xRKoIGvy58fON 9lrMZOi9cyWdxb2dzJj+14X0VqLKx7oayvu1uLtn/zXVsSkOkW7fAzzPBsSSo3zSEeqo bmKBQotQi3/AaEIVPs9c2DBfZrRu0po4QiXu3eGV0ylcbbT+rtfQNmck7M32v71XzGPj NtdbWNeXTf0a27qV3UF1jikZRP0ZbwUmdae/lIQj4TRFODIe9nsTIiWHgXFBm6G8BKFn AWrOCve6/wUytycoNWEZxdvMmyEjJSqS7enOUpbIzCtwq6CbWoPDmZtRVpkE09+IaHs6 LFIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322188; x=1773926988; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=waapWgSr+y0b14NQRUUGRnElRWzI+NkPyt77kizq0S6XMmSscZQ5eJDX+c7WthGHZu KX7vmlb7MORg6LB4qamVmrkoVVm+fMChs4vZ8U1TrSjItV0tORzzMRYA9uMb08gKw6Uq ybRPjZPFCBpjb26Bjj6i+gK0zuE7usxHn/j/luTfZrOSyJPk2tke4P+V+A8FG/zAOP1M D8zNOGYdcifIDrQKnnl+gZ3bUAsqEkQm7UKBDkCk+Yu62oX2NXosjo9y6PgVCr7AG4NT smGeTSkKffMHlkz0kU0TTV+aPNT9Ac5eE0IvhljV6W5Mgg+5TtvTNNh3/aTy6PLIHbyb ZBhg== X-Forwarded-Encrypted: i=1; AJvYcCXq7o36pF1ZFXCIqaRFnct50ytb8vbMEcvbCIpSebLZDj05R80G29XOxCKWXe5fuOum4OsXXtP43cbKbko=@vger.kernel.org X-Gm-Message-State: AOJu0YxqKK9NDfwbJ+YohUr0mSZwqUuxETIRIM+UdnqnLTy89nPhGhdi +Uvh70SfoABcb97brRP8Jht4weWSd6tppUSu6wd8+NZTSSUMNpdMdMGVKOEQWnIV2+iMdUK5FLV kW7VbDTwR3IB4uDMsyJgYJZSYR++TlYhoNc+NRA6dOE2kxgPROTSgq88NqIUoVXdY5Cc= X-Gm-Gg: ATEYQzytB0Yj9bMEcFy/JkFNOgciGcBFbpFHrxNgblNBte6H4s1uA1dX2h39yruiMCV 8xZGT0roalHVk3OXOlBGuZ0ldZsmmqa1GfsDRJdVGOSalM9OizxhpBUPhfdinwxpBc5NC86WfAp TBG8E2qkaS2MD5ibr+sfiIwJmuQER/XgR5e5+eUfdRiaQMTmNm17X+MKIdMWfm9Mou2RTt8UrRw tAYT8gjyxwlFmXRS6lU9F0zg4OoP8aoh3C5lWiLUzyPh1mE2u61jzBzaVjTUibrVJn37MAZ9NdB vuwd6uWZjDhIsQyKTfPbHadgNq6UWqB4w3H17esk4/K64BmX37PNW6tivqj3kTmNYx2qcbJE3Ly 7yy11ac4tbcmrzU87c1GjdO844L/QPfoV3DBEQY+iKoV2fpKataeSigwdDkQB38uuGf9VZIOFu5 WkkrYqINxztuAYGeqIUg2YRmTRwUbtXn0kx+g= X-Received: by 2002:a05:620a:d8c:b0:8cd:79f2:dc3d with SMTP id af79cd13be357-8cda19f812bmr830433785a.26.1773322187948; Thu, 12 Mar 2026 06:29:47 -0700 (PDT) X-Received: by 2002:a05:620a:d8c:b0:8cd:79f2:dc3d with SMTP id af79cd13be357-8cda19f812bmr830426785a.26.1773322187398; Thu, 12 Mar 2026 06:29:47 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:46 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:30 +0200 Subject: [PATCH v3 09/27] drm/msm/mdss: use new helper to set min_acc length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-9-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1832; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=f+xu0X2Dvffg/en/Ri5kZ4UL9cHuySjQYKW8TgamZik=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1jHsb426zm4uBrGigV+rm0TCVg4UZFxS4n iCmaHB12Q2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1a+EB/9I+Mufht0YPVIuz1//POLvhN2ER/ApEdvJrcFQQ9P/xjK9eewewKpmFQWZ31l5lnmdj+B WDjRexmqPBJ89caruMpnFqK6O8DifeAq5T2YtPGtS64X2XXIXIEGSNqX/wRegJtKAhzxL9x8DCq jMeXyG75jz2ezsqphslt3BdjTGb+cWhnatfCUFihx+Z37Z6KC1zf/hFtlBYA6AH8yvcYhjoOboU 7rf2G5eyvk1R/0UV1alrzhdfUWqzv+Qu3Uh2JLNN9RwfinudH4dmtbh8OTQqEIDFHYsSKXzQsaq wea1b1Yx4MLs906RQZO1iy5MvwOI9QSVmZoMYbFQyPvh4h7L X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXwQdWRauKxFh8 q+3VDzyyPqtjkJqDpaKaw+FsFEBS3sp3J+aX70zaSCm2UpkakH1tnYBkGsQMjnTs4aJq/VU23dk h7zjyyaDyB5oWnIaRHA6K4iyOb83TahmKJ2RJZ/jzOnpOnWq9keNGEAwAGBucA+9Roe0jZgUUFN KRt0KalNnT0T8EJ+VAV0GOCimt0nQmH2PXULtRKkKrg7/FDNMiZ6tSp2hsr3qQLRpAMujmgslJB n0t/hjYoCE3+7JDNpBlPT8ul0mJ1+vyWEeQO3wFYy7Jw2FxA3NQ2We06UQotwxA8BDoGoL7tcri q6VErz98lNG/6MT6ldpI0O0YhzS6RMXWtWi9i1q7plfVcTav9hRR338bBObtNwe8dnYqa3Keanx BC1adIEMeOJQchw8Id3mjyxSsWioUVrepNr0LgiQr1MvbZTyC1m7xnFtSAz0If9NybAnuNFVd5O 9BAyh+Lm9o/DKv6ZD8g== X-Proofpoint-ORIG-GUID: PIXv2fvq5Sj62316kULPhsE4WeIT4ijR X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfcc cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: PIXv2fvq5Sj62316kULPhsE4WeIT4ijR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index e2ec1ee590e7..565e671ee402 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -172,8 +172,7 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm= _mdss) u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -190,8 +189,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->ubwc_enc_version =3D=3D UBWC_3_0) value |=3D MDSS_UBWC_STATIC_UBWC_AMSBC; =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -209,8 +207,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->macrotile_mode) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); =20 --=20 2.47.3