From nobody Tue Apr 7 18:08:08 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1AD3C73F6 for ; Thu, 12 Mar 2026 13:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322187; cv=none; b=DxcrcsgRR8q2NYvApam498WeQuC0QljxAWY4BnkYVipG2tholP4iWpMkgkQ0N7HYgrPPJ5z7Az43NUk8YQ8EnHGJWlSt8jL2zDPWv8EK59xHEdmUnsjWfFCD7osurnzJyuNm5QXIUB8oh8G+xh6ctiNGlZkISZeAR85bxEs/qCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322187; c=relaxed/simple; bh=xO+dmVKeAgw+NPDr2h9siH1EsNMcwlIuWzCr5f2QIyw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GEhOW0DQC18uZ0BEdX39NpTQQhYu07pwRfTrP0N4ekbclj9Ap3PkFgDqqEwK4w86LPS97g2HWnAmqRTGY3j9xKevZb3mUBqgZAjZFnIFZcPijZjlmYcgO7wbo28c/4MKErk2qvsT0UDOkISqmMx2lRADOlmY+egdxGnthhsiSE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NK9vMxAX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LLaryOIm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NK9vMxAX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LLaryOIm" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7eF01510100 for ; Thu, 12 Mar 2026 13:29:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=NK9vMxAXLa+1OCQ4 /RNDXVlHxuqQ7vlDp6mpnN2BZqNsfMjUy/P12K0O0EmB+hLGVZ9VUt9UOYHxNra0 DwJkI3CnW+e6XOLsc5VBNv2EK2wf7jAPtZLyjr5BbPNwLfAS9/rx8jDt+yY1CgrE JBN66tsYUTlxI8CBbsdrUbfockLi4vESGpNkmn5szRSIJv35cnSaxvl5aZhIqUce 5vmMYV2uUvfp0oZbH4f087OzMrCpDXFdAqEHQOULmmhEUGgnsFluO4ldo1c6ooi3 LOCQA750ZcnQ15hAMllFf1V6UyavnHuRNkwbEv1Ui2+L/qX8YhPhyz1xheUzGDTt 3ClSFw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vbf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:45 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd7774be64so603688085a.0 for ; Thu, 12 Mar 2026 06:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322185; x=1773926985; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=LLaryOImPSeR5CrIZnalCYA3cz57I3UvzuZI0gXeZtavr3WwzqYNAddyEksBNCWVAZ NzLd5enmqfWOFPxyKYLlwN26lRynO937xPW75IUJ6oXscQda3UBrmLDsrl4HP4Fh1I8T 8qQj8o0sKBHlgK6lNZAeMb4MJtK1bjoczj65+mIaKHryGzrNTmYt+o8Q0ZCGbBGATOOh Rc9Z3h36udg/1BnmOigaO4sqr51SAtGtkqhWumPs1VdCPeimestAVyjfHxObP2SFNDff WX6Az2sluf4CJWcI2EnsufsdIc58OHcCJ7JW1KqKvvExjI1h7bA6m7fY2gZjfz60Vdyp VJjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322185; x=1773926985; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=XYyN4o/ZNEwH/ElfouA2yATnnfJcVLkMpT7ZKXcAxRmDl8KtxAb2lMrnvXY61L+Iyl PNOnJ5XFpeLbIRc9xI8OKrVoLLami5BB+rDrnvE7EiwpBW5wTr/FZPOOUrUXSnS9k2/R m7HVCNKjTxZQw3w+MAEbqAX6e/Ho4/KCgeeE4e+TnE8djz5ng/+zvD/uqmWTFA410eSQ T8IWYumB3yNMy0q0dg0xqMDboLFg8ZqgE/NekP5oL4wmCDlHR7m4kjpBkp+KONqaruJE XiKfRDxSH3pbRgnNnN/sGKgJRQGo9Uvs8Xq5qT89lGWkwqlWqxuWitXnlkF3M24QM/z5 oX5g== X-Forwarded-Encrypted: i=1; AJvYcCX5Tiry4SbGdpontnLnKGV8DjV/QFn4HZpFg5rMN3XBaJs62+4AY1a6/oFwEhMM34kfO1brVVdKqA3SLb0=@vger.kernel.org X-Gm-Message-State: AOJu0YxX3IqBwusal7abpb/PufbuK0iB9ZdG+03x0ShKhkwgSanmPbzm 7G9rDMZPaTnfz86o1QClOIP1N8xYrv/HyovASC4eIFwGWlDX7oe8XHj9jH4aQi/5LZVNarW0LT7 byUOZxuQ10XMurVdPwjCHgT6ShFptj4BjlemxCGtkemjP35m61lMgFImTaqk3vp4np0w= X-Gm-Gg: ATEYQzx1ovt4wX51/EEL5Rh38749EtLLC78gcMbe/IlJvOI0wLqjxUicRQf1qJHP62g jWOfKZG5u+5irD2uDVZp0BcwBjHDgW0bZf5Bh3KFUI9aJJL2EWmKLlAxIIrUQi47mZX6zjr+Yl2 EntoaJbh/usyrb4tzWy5IMtiO8gJ8yAefgBzJbTNod9F2m5K/4eoEcGubO+qXdKr1hIn4r1hrfJ LJfgMaSXdCnMx1hzQGRfkCsXAyLgiJE/Y1k/gujNXvK1tRv3y8QX05/N/LCW/+2jIwg3CkeSxrE XTC0SLJ35w2OmvlPprvI1BIUMt0rQw0eZhFWhXPGXDuP8Dhosdh/u1g5lF9beMfw001Yf/wyURr NjkPYX401StDvMvaQqtGQKTljvHvrCWkfqpeY9Pm0Sh0VyPFRKELsm5bDBV0TeQrJvKJbXct5CS nP7GwQ4mFtdKnGUAiSLW1GGp4fcieuGlCKLyc= X-Received: by 2002:a05:620a:2a06:b0:8cd:97a7:a334 with SMTP id af79cd13be357-8cda19bb33fmr749042585a.4.1773322184987; Thu, 12 Mar 2026 06:29:44 -0700 (PDT) X-Received: by 2002:a05:620a:2a06:b0:8cd:97a7:a334 with SMTP id af79cd13be357-8cda19bb33fmr749039085a.4.1773322184565; Thu, 12 Mar 2026 06:29:44 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:43 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:28 +0200 Subject: [PATCH v3 07/27] drm/msm/mdss: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-7-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1662; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=xO+dmVKeAgw+NPDr2h9siH1EsNMcwlIuWzCr5f2QIyw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1jVZdIm4Z5c9SotutkxEHFGXzgCmOArpB8 PqwvUHddbyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1aqdCACzDFSUZDp9hHVRuPmRYu0zC16Brt8euwkDH2Sl1Y9E0w8FpOJTHSXVaJFuoE+BmChs6ao UGCBQ3NL87uHHw3x+8JCMXbaIRuo/4HrR9maQ93bdxtGRZiHrTN/sr/LR5JcgOxsbsTjKoW1euQ FO6gVqu+ArbG3jxLUonRzhBk2E2PwSaC8v39zYBnhNs+S6Z3vXrFo5wKf4OdlWOuijXHI60wFeE Bwpoyk9m94uTpd1mZr/WjTc2Ult0FANct/wvS1WxEf6BhNGgEpziUpe3P90k3FuDaFreSPva46V rO+JFmwrOvnIKRju0rm5E0jU3lEWww+jzGi90OUGq7EnLt/X X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: laZu9R9CUTHUhXXpwXc4DorgPGGhTsSM X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfc9 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=qBJULKV797PGQuHHbA8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXxBvR8EkWGNsP uWmAfc0uYzRqlcKd7cUI4rN46UOFkP/2WWiUUREENWtu8EXr6RbL0geCQqJnfzKSyGbUaOhZDB7 /005h0u9s4dA03/mjFX9ccyqD5XjC1qvHxjsjYnHG1c1XA1GdNBdnc3XI/BbXJBuOeweoyXB79v +Y3zOVih7qmiH8kkHpO9dwzU0NEd31CdBYqiyrrYAydLqLsjVde702GWsAcphfU2mWBq8heZdXB qcqPUxfapdYoWum1d4pLFUKa3ye06UUMUzLHO+7AfINNF07ewhU4yPVHmUHXlsmAT/vatll4sPW w4a4pXbFQNO7clSc08Xw5h4KIAl1WEJ4DgXuFFlYAKpbbEqiYfwUppvxUpaKgu5DXVrqEx+bwum M/Oqiyry2R4RySZf0bEM502ZbvSK4pD1tOzEo1fKtL8MP3SXt+gM/ZtjE+evcnBSOgLsa7jpZ12 +Q8tWujLBfy03LxGTIg== X-Proofpoint-ORIG-GUID: laZu9R9CUTHUhXXpwXc4DorgPGGhTsSM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 7cb8aeaa7ecf..e2ec1ee590e7 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -201,7 +201,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - u32 ver, prediction_mode; + u32 prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -219,20 +219,8 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *ms= m_mdss) else prediction_mode =3D 1; =20 - if (data->ubwc_enc_version >=3D UBWC_6_0) - ver =3D 5; - else if (data->ubwc_enc_version >=3D UBWC_5_0) - ver =3D 4; - else if (data->ubwc_enc_version >=3D UBWC_4_3) - ver =3D 3; - else if (data->ubwc_enc_version >=3D UBWC_4_0) - ver =3D 2; - else if (data->ubwc_enc_version >=3D UBWC_3_0) - ver =3D 1; - else /* UBWC 1.0 and 2.0 */ - ver =3D 0; - - writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(qcom_ubwc_version_tag(data), + msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 --=20 2.47.3