From nobody Tue Apr 7 18:02:52 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDEEC3CEB8C for ; Thu, 12 Mar 2026 13:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322214; cv=none; b=c7PA8P3r+I0aAETv5YAmatUwrVToqbgCBlQh/3To9CEQQWPaGa0PXIAOtjPGuvj+XZ3S6yGlbtcmDyo9Dczip5pZjWQkxikOutn2JFoQRECMknycXRVDxm+Lsv/gogV44MaKw45vmH6RMy6Fb40fZh2D2himqMlPsfqGlrBGn+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322214; c=relaxed/simple; bh=KD/5YpHJHM0f6NYFyEdCILO6HpJWSM4YvU3pMSgxMM8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m3RRUhWCYq510r2ML0ONLkUElkIj3qkm/vChoLAHy+SNDrCX88U/RX1+B1oph2OixcOWQINT9RdKDee2pQn+Za7QzTAQULAw55XaoSL/cSxLgQkqTK9v+V0nwlim7Bk0MWt9WQewkJFUMhjojCBrapiOyDMIdhvtiLTCcFC0B9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SFuEJoZk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hgCZopyV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SFuEJoZk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hgCZopyV" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9eBbR263524 for ; Thu, 12 Mar 2026 13:30:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kFSRcCt8po2OuKoAWsGSR2ULXOVtIcBGFxgqU7X+u+o=; b=SFuEJoZkPifOqLUh TOLXT6Mw0f82G4qAf58MFms2INup0bIPdOE5eR1gt1bMM1b+W42hVQkRkUXvlVGN pbTlQOzsUQy1In7UEvLcu88iALi0cq4GvBdyVnZU+jRFG1/azDPyd1ALEwJFP8ye gSz3GRipachh2jrKCvclRbdjt9y0sCrjhzpKTfwAs/HzZqvknjhiabPzOAY1oUhI 1UqMpdZkFpAFdpsyenGyZR7arBsse/89FYEYmjkmEMH1jd4Vn3VSAZt7WiZgqIU5 zcwqWknv9hKXuOYRtQezBx4gc5JSL2CJbmp4CeVBYzOrQbDVwiJsez78W9BXsULs 2TDgew== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj68m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:11 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5090e08dcfcso45198381cf.0 for ; Thu, 12 Mar 2026 06:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322211; x=1773927011; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kFSRcCt8po2OuKoAWsGSR2ULXOVtIcBGFxgqU7X+u+o=; b=hgCZopyVz86vrHFGFM92brCc79aMe/Jl/AdTpH6uEBhDVNaVzj7EsQ7P3XqjaPVvQn vt3zRZFtPrNEm0HMHO8jDKLuF3eOAoa0wQP++YlPv30aNxBgWnY8ViP6zkDuBzUOrtfn Jfgt2cJv1WUQwziPgKTssl6qhoWCMsx6HBuXDi7nmTgYNkbGBA9gho3p3z3g8DRM/S/9 IZdjoUdlRZjmVXjpDJ0KCxqkR6DXsAh+rY7v5Khjg0gmVhaGMjXynorLmjnJfYRBoZwn w2s7llP3fX+SIbaBXlJzCFpjnyhp/ChzIzzVRlx3Ylg5GQUMYwfUQPlEDeWTauEh5/OQ zG4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322211; x=1773927011; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kFSRcCt8po2OuKoAWsGSR2ULXOVtIcBGFxgqU7X+u+o=; b=EeT4vltzihI5gyTBtOcDI9HRLn/7MK61dY1iZ1xijzJ5j//Ib03qn4xDdqPe6pUWcy 2tKAvpli1wZ/uqpxAQQCC3ienBEW9mXG+5hJI9ugT7EaKYiJ/uUMprAMa59KepB94N/u 5oSdaEFAslwfeYKjBn/YOUk2QYHzEYoDFZcAwi3QY623ErzRIjtY3JN7H3ih6Ls24LKm FwuUHBjaRE5QvWO9kcr2dvM0NB2Z+OfSrGahS9w29iLpGJ3qlq+sZ8bwHL12+scMlsPF Qdl2eURQ00RSeFbYgK/WOqFYbEqzVbnOM2S6bs2R0bNRTJf/qb7KMewLSm556xgNtKMv IzmQ== X-Forwarded-Encrypted: i=1; AJvYcCUlWJjGDqwsg2kixSDRxnZWI3yXU2zIB++/cHpqqdmsA+7lUN+G/1/cEqwLUyGibnkdBnHpnrajNEML37s=@vger.kernel.org X-Gm-Message-State: AOJu0YyJD+7MdMWndix+NP65OqLWYh6YM8D85COaAjMX7afIYJiILsJJ ABzn82U1BmM8Nyc8XnnzyjtOtwqihtQDEqGeCRs8c96nHlDHgNk4l7JNltYhoM3f5z8faFPgJnm wNbUUK1bRBmtObZV1NS49xIgHiimOaSjmi6j43YQjKjUzKifRZD5DZD44Cii/zeQYM8s= X-Gm-Gg: ATEYQzyRHT6aFjt0BLcDQZYQ/mOat13uQ50EJ3/LOLtWqtUPYGGYqGPexDpZX47B+WO g9XQtkD24MS4HvyeFl4zimN5OLS5RJpNj5iJVtctaQh+gThLfZLYii3vu8RfrYJIZkHEfH97x35 n9G45b804hf4GF33SSYXbtuHsMuLFs7r3VxeyBJWcss3bVjfnKPf3ikxwimpX5XHTqdH4qv7l8Z NapKctvdFrDfNmCLpDg7D7CAa+183c7RuG82rKBU7hbsDgkJ/a+sQIfFR7Kpi79jA2TyUJ70gcv /pFiingxQPKcLx178e4gdkRy53nZf2Ui8IByyM9pd3/dIBpuV6pCdg8SDJiykSfBXxuOA/d2RPn WLhSA7M1vY7OCiXJU99RzwCguX6kIiNxBIGWgxNsVIjBzoUXJQ2MYMwDJ/f4F/vBGaB2ub/61PI wwevD2ACzMMkeeTBFhW/FwBbHJ3Kp7FpplFS4= X-Received: by 2002:a05:620a:bc5:b0:8cd:9365:f277 with SMTP id af79cd13be357-8cda1ac4ed9mr823286585a.62.1773322210555; Thu, 12 Mar 2026 06:30:10 -0700 (PDT) X-Received: by 2002:a05:620a:bc5:b0:8cd:9365:f277 with SMTP id af79cd13be357-8cda1ac4ed9mr823276085a.62.1773322209969; Thu, 12 Mar 2026 06:30:09 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:08 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:44 +0200 Subject: [PATCH v3 23/27] soc: qcom: ubwc: drop ubwc_bank_spread Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-23-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5290; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=KD/5YpHJHM0f6NYFyEdCILO6HpJWSM4YvU3pMSgxMM8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+42s6zRoRzNX4/u4arcGCvSNjTR7yJXr8II POClR06pQuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/uAAKCRCLPIo+Aiko 1XXuCACuVSv7Z14BzcGM57AF9mCB9V1GFPY8kEaGQzqdoc4CJV5YQomnGKDlR5SmoEuD17Pv197 w91pe2dD5CfVOeZ6/IDi20kfpAeEhbLVH8cZkLjar7IarFkkX4lWOrAg4hU5t3Yl8qtFmJNP09L QpVe424LpKLScJPJjzzbxhqCa4eN4YCp1O2n5IP8bw42XVTRxlDJEcVj27HHiY8FSutxpC4O8v8 kq83k6OepvT4fYWxm7/c+hcD/2bFL/URosgaI6RiZF51nZLk3PcV9Pw+O8FWSgBzs0kR1iccM0o uaU8DsN/HbOPKnYvgJdkHKn1kA5hq7P/OkxHRmFh8ybHi0Q+ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX5NZlw+lxHs0q chkLFb0M2KtOJvwFXBvA4CW4X/6E0wE2oXblBFUjXzaEhIVo9VJbirCP9KR5tTmkmU+GuLlmhaJ COF2zl1EPvtvUk7Ef193xBv0Rqw3P4cpKRD/wWlBroVHc6Xdha+qO4F1T0Rg5IzJFNY5BJ1WuXU e74VuZHyiazgQixJeMBmi4mXkLsteYCNMyQDocpXCKbrzJwm6zqt8oZcvIQfZ2dAH3GnA9TWv/H h7BcU3RyGw470aOc7WauYCdX2TPjZHNGe8VcYoP42aE8w+gWf61rzVA6eVoahlZKE9OSXLds8jP MUTt7dynJSLEiKFLtdnzoUuM6US3jSj35wEwUK6+pqqd4Yu1ja/92q3I5ZIL3M3WQLXT+nTcZYu 1ACbZCZ0KaXKCkCoBs/8xBkcMB4Bp4QQGMmDDPN5U7m+6o8jsZtmosjjWVRXHtD8HRjklSkAHwG vI9Ej2aF649VtAGl8jg== X-Proofpoint-ORIG-GUID: zzGBxVvXzP0Y2bcc--EpWc8eaDBJZ8lw X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfe3 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=j0qWcOM9GDCbVNQ44DEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: zzGBxVvXzP0Y2bcc--EpWc8eaDBJZ8lw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 According to the documentation, UBWC bank spreading should be enabled for all targets. It's just not all targets have separate bit to control it. Drop the bit from the database and make the helper always return true. If we need to change it later, the helper can be adjusted according to the programming guides. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 13 ------------- include/linux/soc/qcom/ubwc.h | 3 +-- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index c5c7fcb4d013..070bf97e134e 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -20,7 +20,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_enc_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -49,7 +48,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -58,7 +56,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -67,7 +64,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -75,7 +71,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, .macrotile_mode =3D true, }; @@ -92,7 +87,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -116,7 +110,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -139,7 +132,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -161,7 +153,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -171,7 +162,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -181,7 +171,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -190,7 +179,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -199,7 +187,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index c3f9efae5db8..254721f5ea3c 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,7 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - bool ubwc_bank_spread; =20 /** * @macrotile_mode: Macrotile Mode @@ -85,7 +84,7 @@ static inline bool qcom_ubwc_macrotile_mode(const struct = qcom_ubwc_cfg_data *cfg =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) { - return cfg->ubwc_bank_spread; + return true; } =20 static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) --=20 2.47.3