From nobody Tue Apr 7 18:02:52 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683523CC9E3 for ; Thu, 12 Mar 2026 13:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322201; cv=none; b=qIp2JMNloZoOfORyTE9dTqUcOLHNaBeQnhqTD5Tj4qYOVZkyhnV515o4Nzdz0INpeFt/5wMFoehJ9xP3+FzjXIWzfvVSc5k8Ukeuqntoj9MTis1otH/86Sb8cEw2sBZLoV5aspSR8IqLQCyVV0fiuts9ZXUx3nmjzjBFCeMeRLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322201; c=relaxed/simple; bh=TtYxTDlV4ADdZSME8a7mAAI2svRlACyoCBLVOWAbvo8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yrp1ozSOSXBVnW3Jh9XvQx91KS7h4QMSur0MM2/yMFn+b4RcsXEvzsNAh/e2a4mA5aWHIeQwJlz3Hs3MnMACzuDbCXjtth+wRjsAKBo1iuPURsw2PFPS/zuKqy4l7i9SI38hV7ydopJtop0Coo1sT9Wo2FAg8HDR8T7Wwg4xOwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rdfy4LiU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M5zgSnkY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rdfy4LiU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M5zgSnkY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7e3ns509808 for ; Thu, 12 Mar 2026 13:29:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BRGxG3/EH5DbV/qm/ujSo28MLbGNL8h5SekKq5Cws5g=; b=Rdfy4LiUFOr/CHJC ZXwzD8Kdes47Ov2XgqR0+fQDpKJY0ADsjsStABKGPGKU3cWJImPLqaVbURDduaGf PwOqW5zvIDr6XuvcGhbuXwp+GqgTXZ4o4XVsskf2SCPHbzcf5GXtc6EF8R2GatgB QFIZnrnAZeCPxVhey0FXciy534ci5K6NVDaPZm4pwpNOVsDs0TPjyN2hdXmz+EcM VW4CT2l2t5dn6PFIyOK6NpsezUsOt4SnlDpUoUHVdBJrnEI8hxClQfjuV5x+yg2F HnjjeN451LJTqQsvwOeOfO5kscfXv64xAEBqeOJfufZa140j3RhG1wx8fqbtzGww tGLt4A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vdv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:59 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd773dd409so140759685a.1 for ; Thu, 12 Mar 2026 06:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322199; x=1773926999; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BRGxG3/EH5DbV/qm/ujSo28MLbGNL8h5SekKq5Cws5g=; b=M5zgSnkYmXHO0si7Fj7ftcUT5g5/lJa9UDoBwHG6uLn8fx0CWHDYl2uQjtU5mQnwNW g7NYAvgl/SoBnNCuX0QU5bpEOnKwUR3bT4eAPID8vdPKMQgjPqAUqwTQBEJLYpsw/L0X zsZHvUKLqIWt10NO5a2Sq/aXkxjSU1A5UMzKSLDRpPBlFFHP0GVQ6Sk2anVrrCgxX9hW BK7tr2v1jHGTH2tUhYJJFo49tF2yb1v6igi7yd06p2Eyjc9hNXblBbpUYBBDH+2x1bHH RVQP/qVVB2XuJpZBLKkFQcUpWX8XNE/8+wJnvPef9adrxpDmU0d30rdm19cjoPdnD42h T65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322199; x=1773926999; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BRGxG3/EH5DbV/qm/ujSo28MLbGNL8h5SekKq5Cws5g=; b=l5t77QXa4CzDu1rMYWD2NkcIMHp0aFrgn1kE9WSjPr6g8NwOuQHFPOYshe1n82xWKm VyL8NEppUmh00ja3RJWpVW2JxKjwPH2d4L31ewpAS2Ox0npGi6OpT1PI1dK77Zcb89MR 01dQBcgNBe85cxwudFlaPZfj7Ez26GC4oi1PgDzF7jcoQ7AElMlrNhNjugT2aFEFK76L 0nX6qQoqFKwYdsNZibKPghOWgpXS4t7kgiwN/xeRx0+kinY43YiIVaCRqv8j+QUeP+bj jVMrkEmiWHGOTqlaM+KDDmuhAkl3W3upjGcXzRzuPn7Dk7Pal1fgd0yicz8q8IxlCPhu 0fQg== X-Forwarded-Encrypted: i=1; AJvYcCXlI4bInF9D7ot8OmMDbzE5rCQDY0M1OvAgFWqHjOvkssUklvqFKNykfUrctDcE3aVXrF8RWe2OCv6Ugl4=@vger.kernel.org X-Gm-Message-State: AOJu0YxWdfYZ5rSBa6HhO6geh8j7BfCnabYzpKBVjDndFI14aNQ5hrEn cGbcqXRFbbJtm5yqnC8duJ/pBVV9j3CJ8uCEHjXQFsivO9JLEb+B/bh94HJ02UyesicF5tsfy4F iQ0Zp9Zv+5Wd6CmDHk4wyzAouEoAyjhjB6aHuM2VvNCNPgXqEOD+EWqcJ7uHKm6Y/fxY= X-Gm-Gg: ATEYQzy92rlTkg+awi0q69p+efjytapjUJ4jiVcqKZtCkKBTyiLeUtkhpY8ix/TZ3tP Vrpz9DWCCK/FGL44JkBXdBm5D0s4xWiiaElDBPrqKzul6Z+TcnyzH5jcMSGPqaTyXr+CDKTYGqb i7J6f2ZJ7g2yX/NyjXuudjQS+1DBN/M6tU9rKYi1FrKpF8qg4pmosIoOgC7I2tE6ko8KW3MfW2T arJ/v6qT9DooMtOBaGaIFe3ZwxdUkVgM4U6quyBbZmnd/qU9ltebNhpUhnQmAS7evvnd/HOLRqm wKHIC3czkUiFHprJJABFDYEdTG0IRBJMStE3JsGREYFXj8uelEUOSQ3k8AJ1FG4rVakHRsLsSgx eIf0qbd7TfR7mkDRZxdpQLYvedcpjXrg803JU65bPOO3JCo3o2D9KAXj4Y4AKXlfR8zn5ijuUSg U1ZndUWLEeeLw+ilOuUhO6BtsSQRhaQi20hrg= X-Received: by 2002:a05:620a:4692:b0:8cd:8fb7:7aee with SMTP id af79cd13be357-8cda1935caamr806943485a.4.1773322198799; Thu, 12 Mar 2026 06:29:58 -0700 (PDT) X-Received: by 2002:a05:620a:4692:b0:8cd:8fb7:7aee with SMTP id af79cd13be357-8cda1935caamr806939185a.4.1773322198316; Thu, 12 Mar 2026 06:29:58 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:56 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:37 +0200 Subject: [PATCH v3 16/27] drm/msm/adreno: use new helper to set amsbc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-16-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1854; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=TtYxTDlV4ADdZSME8a7mAAI2svRlACyoCBLVOWAbvo8=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+am/dvbtp+eW7DQsPfqI+kzNWrBh67frSmTWV4xXSxk5 ouztfuZOxmNWRgYuRhkxRRZfApapsZsSg77sGNqPcwgViaQKQxcnAIwkbWP2P/pcF70bfol8eTf hcUWUw/HbL+inXi76P7c6e2neKYGeFe1HFxx/dOSKTXbpVpfbNqU8bar0vq9pNzjTwwHHiebhqT Z5U3g/yK/LWpndtAWxSyhFwlvV4uVN4T3rotJCGJN9gw82pT6tiTlhrQfp3Q5p9DCp1cZvKcFM5 Vo1rj1a2lsUWgrLmthMvq37kxFVcrl8vApyawvFurb3l54PrXOc3Pvsak6y8Xq03aZFwd+lNYTv bMkcGlAgOSs9imrLKovKCmmRm7RvrhBWupKbNnPh+4Pl5ZKmXkGLTLKk5Rssyrl3Wusu8Rk1XrV xFj5H8khHc6bH7u3Lv4oGpc0SUJrH5t4xGpHXTfDPAM/AA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: bOQNP7gKzDG0-i2c-f_zXe9fU2E72aUp X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfd7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=PQquZ71z7Ybx5dfXpIIA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX4n5AcPffch6U DCmgIssP60SBpBMHxo1Wr7IhQ4K7LvivxR9Xcg2MmdI3yQdaDwCnQDDYrg0c1svKZQPH8zhODvb pYWwYRsXw0Hw5P0IE+gH4LbXrWcIDz6UhcAhlZdahv8/P4mzmSGXv/iVXAyHXrFRPT5xYvx4Q2M 36QhN97Tb9cSYkEjixDLvC3RVKl+wFrGrtDY6v/Se8DF6v3Y4ebNNhDZ3S9TgHhhYUeIRs+MCZ9 njQauhHqMq2pFNc5Hh9KRdxvUF/xGLY6fXc0NS16DlCoD4FQY8XN8nRxet48wWw857Agb+r1/1L Lld+Voq5PXYJae8eY8xFHA49sB4wRgg0RQXCxk1/a0AI8kncfZpIXuSkgUoEMUxh1Q5btPIAe0c dCjKx4ZOjXbypDJ6rWJu+wWagCXwXUpaqP0RHnJeaUI0gqzXWiJ8NvO8qZegcjjBAX9h65NZIhi oxwWgy2tM65fYDJziEA== X-Proofpoint-ORIG-GUID: bOQNP7gKzDG0-i2c-f_zXe9fU2E72aUp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of checking the UBWC version directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 7be31de3b525..f6bd906f2ac9 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -743,7 +743,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); - bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; + bool amsbc =3D qcom_ubwc_enable_amsbc(cfg); bool min_acc_len_64b; u8 uavflagprd_inv =3D 0; u32 hbb_hi =3D hbb >> 2; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 680f0b1803a1..63934d21c831 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -275,22 +275,22 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv =3D 2; =20 + if (ubwc_version < UBWC_6_0) + amsbc =3D qcom_ubwc_enable_amsbc(cfg); + switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; break; case UBWC_5_0: - amsbc =3D true; rgb565_predicator =3D true; break; case UBWC_4_0: - amsbc =3D true; rgb565_predicator =3D true; fp16compoptdis =3D true; rgba8888_lossless =3D true; break; case UBWC_3_0: - amsbc =3D true; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); --=20 2.47.3