From nobody Tue Apr 7 18:03:29 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EAEA3CBE85 for ; Thu, 12 Mar 2026 13:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322199; cv=none; b=G/c/nTAJDnrjVwuxE2/dEUIT9QnU+CYs6lbUgA0Upta6ciWSdB8pALz1/H7L3cS51Sa9SSympEPZAMYkB060Wb/ALxkNYnP4G+MF2g+4vLK8tdSoOTROS8eHYRcCIM1tbYtCvglQJ3gtTOGQvdReWyVpwO828kDmplUNEHZmGsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322199; c=relaxed/simple; bh=CN3kZ0/IBWNiI5YHIzLGKD4m0aY5Oisezj7zkRehZl8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=unBl7KbwrJBD8hZOy5PRnEkP0+ts4F9sqCxSVLpZqziTGuzrX6nMLZdwYW8d/sgqQ93awNgEiffe1kM0hZtilk8KcgvxVwMc5RuKJ9zmFnty0YDh0pLasVwQjbJHRAgd3MC2m1qRmk3hExHM2qi/6Eo9cC5ExSUpnOpgUoXILXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nrGJls8F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fwMK741/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nrGJls8F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fwMK741/" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CAM8xf1756601 for ; Thu, 12 Mar 2026 13:29:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=nrGJls8F6+SNjwuV UpZi9Q2c5amWPB4V7Izz5ZPeUHb81ExPklqbeIJ5hCi1qUQq9VZ3q8GS7+vtzpL2 cCgIU6uWwI4/zMUcJXVHkq59uLrdAXl/6j4bvEcgB2/bdqKfKOG0FxXfQ+KmgGXG 4xTGUeNcdyK2e1P9mf1iGLKfeKdkZlxImJuBUKi29cF20ZaYX+IQ+zJSFr40hOYX zN3Hoh3VwFDUpfITXhFdIFNipPu6TFAgBfebTDuK3VGGFdQ9EOKJa9+UGxlwC4p6 AhjN1xdLIgT7s2Q4q1Wiqzl//hegv2daKtag1JP4W4GDGmjUSfe1Zl9PLdueAK4N NzsY4A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53j6us-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:57 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd781c0d90so1189567985a.1 for ; Thu, 12 Mar 2026 06:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322196; x=1773926996; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=fwMK741/vMwJ95Y1TLqWeVISPbjrX/0j49VGjipJ+Fhjfb8kHLM+8VmXwDQIByNhge XKNBQUf1Hco+aZgmCgwuLkwqcl0mSQfmNNlM15Y5XqvL3K0mcD+73q2UDuSwAFH6x3eU oFh/ig1C262B81feukyJwRqEkC4fLTaApoE9ONgreggM03pIS+N2wh3BXF5xO++/Dhy3 1c3Yh7k/+TOlXi2QKPZFQTDclwtiwQ7C88DZsyKT+/E15SWUMAQG5Xo/HpxH2GmOkuEK 0WLh1cInVXq7/PIM6QMmBy+TQ3vWkchb066tg8AKjU68OY/sfG4aZC3/MBD/g/C1uHdS 4REA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322196; x=1773926996; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=mV4raBi+GWIU5FyP1V4/mvDnK3+wb+cEGzUBaoiwVwj1GGVMmZ4sPTIDjOYYH1V+Jx gZe690hlQrVA95Lj6GgsBirfkKZ8Hx/7HBQe813tMXMtGOg4Rx71+ke6w0W21sI8/0mL 1ACuRPT7sUDVJPuUzyD9lFDR4cjtbEDgqt0/HiDmxtKLbbXaxJc7c+fyFB0KyWodRIK8 pLOPHcKFqts5MibaPVrvoGEfImRYWw+CdSnsh0NlSCtpOEKxs7i3pgmmbakycpkvN6bR IHjgg/IWVGcCoVsWIIvuF90/+CguB2CBya75mAzt/s/y6RrB+pzDyABFcQpxzeGY1oRW /fzQ== X-Forwarded-Encrypted: i=1; AJvYcCW2k+IJRaIhq1n9nB1Y9xDhuJlFNvRuMCu/ZnxctIv2ko++lIDMbLbk/d1d46rBRsX806RXTrY3iy19zbA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt/CM9kxe0k5kSMpNtBKICgcbuJsj+mchKGurLWzf/5WkZeXWd d4vfStftXrHDclNLLUyLm+KB4bDGJ4tLA9YmESvMBoGCIfV010CIZcQpzWbRIyQ0JNcrrTvhKQd 3TG6Tsh2405RfUfGvLdPFj7fmqs+x6Vn3b4Z6cOhqosKChQ4FgW7NKuIzC+LZwARnbji06wQJdI uuQw== X-Gm-Gg: ATEYQzwgurtqw6TuzAZ2kP46lbIdgSq32bTviBrimj81PjYowNQ2SHrR+f9zwQJW/zG tKryoHsMzf5y+XNyYHSJ65q7sdCT9um1TiSuGM9VRQNRX0B3eIMZ0L1VzAD8escMPB6o6fA9R+X hnZFnsODD+QDyErobM0JAdN33AMGiVqOVl12K5IUGPBlrtm1Ivz01zgQ5PQxoN/qQABl5MRkoTh dLPMFbKLFBTYJSAQQPHcMT5cy/p8KOMA8y5sTrT5pxPd4jJOFchmByrXdLgtf5m/iGcAmOedR+f sDC3MoEGyhfkMExrbnOt0AcNys2rDFuDKeYfhZ8Qjq1XyWJHL1B/jPhtx2kn26MGdYh7xvPOrFJ uRWZjlm6qJi5Cwcr2sqbxsueki0qB/HH0UiVHpXGSFUH8sE+4UW56phS/gbi6OkNv74cOiqu4PF moVypqe6jTPDxpHOkwNmKQ7fdQ4P7lXkVWepo= X-Received: by 2002:a05:620a:2608:b0:8cd:b341:7593 with SMTP id af79cd13be357-8cdb3417670mr86995585a.19.1773322196633; Thu, 12 Mar 2026 06:29:56 -0700 (PDT) X-Received: by 2002:a05:620a:2608:b0:8cd:b341:7593 with SMTP id af79cd13be357-8cdb3417670mr86991885a.19.1773322196158; Thu, 12 Mar 2026 06:29:56 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:55 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:36 +0200 Subject: [PATCH v3 15/27] drm/msm/mdss: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-15-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2044; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=CN3kZ0/IBWNiI5YHIzLGKD4m0aY5Oisezj7zkRehZl8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2jQT5pOrOTTeC5VX0xsxPmWNd6PDBdjyjo BZtm+GouG+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1TX4B/9882VAuHu2t29avT6n+6Ies3TV9cF9fpKejG/Jz07h8LsQAhLyQiGiqjTzD/4UBVi1XQN oZf39xifu9Fs9UmrPRMwkFI2XVppauY1PP2KO1xR0f5PXFDcBLtbVD1nmgG2ajqxr2kahDgS3EQ BFIonfPtygQLDnhdp4W/Km7Rlvfd1PbbK9JRZHvhKGIRoAqYjRkBz7YgV3/Iagq8gXNqfRW/7+s vYbdMq43QRKkZ50RTYyKltULaB4cQ6nI7B3yMmc3RIDIq4tzZXr7CQcRuOhX/s5liAhCiL/K2Ps ZtzhrMNMQIrA3N06rMNVDoocwKHB4YkC0pA/wNtdkh99k7cy X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b2bfd5 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=crYPmtHWi7n-_IQ59sQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX01kaxf5Lru8Y fqbMltzCkimrIUsHasy63uWOyhbLL40X2Xk7Rdcn1OE/6GyyUPPPUQPBoAoH6msVW2mQPdJi/ZL ZHPGP3YDc4TTHQAFB3lo+A/LtSjVXyNHdP+nxi5uoM6qvN5OAOLln8KRMSFJCSNOLdLpRLxHYn6 YQteKohiJWSfyZVtU2IEfI+WpP/nTnjkAkZWimwGLW9yIvnUQb04JPqSneLVEJlZHJzb2I81esl 29eZE90fCOKfyRujVAr7adTcS56QgdSd0hR9932n43kOQMLTtLQjSAf21DKaJSpbotb4YsedB82 2HschG0oTb8r3i6mSB+0uBC00+vi+LcFEsUFnLDXtoolzX0leZa7/J1R6ALzO4r7LyQRmU7BtKw bt3q3P7Y0GxjU8m9eT2SXhm1NwVEu8XlniK06DydYKaz21epqjepPglp3Y8WukLzzeVFoTSu93T iH+jB4VqDBqGZzoggPg== X-Proofpoint-GUID: p8Hq-DuWmilwBZda4QXvsC5SDujNaChP X-Proofpoint-ORIG-GUID: p8Hq-DuWmilwBZda4QXvsC5SDujNaChP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 76657a4a8f65..ca59bcdde7b2 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -169,7 +169,8 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *ms= m_mdss) static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); @@ -180,7 +181,8 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm= _mdss) static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (qcom_ubwc_macrotile_mode(data)) @@ -197,7 +199,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; =20 --=20 2.47.3