From nobody Tue Apr 7 18:02:52 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98EE43CB2CD for ; Thu, 12 Mar 2026 13:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322196; cv=none; b=TO/OtvHNtMAmjD85SPqyo3r6GQNLm0a/HNuUtT9b496sICCoDUVv2+3mNGl338SSnNMLlUQ3jsgO24TIHD7guoz5tkr+mJKzzQsYTCHHbLhnjsKZemHYMzCbLgOBJKnKD+iWjE3vwUaT8TyYCCbJF6MJXS3TXjAv5caXt6GsZ0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322196; c=relaxed/simple; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k4sNhyZJAJ1owsrP8lbMKIYxOzpCf6m8UaxlouNRPHIc/S51bO0jKzGFEc0bJ6dr5pjnz6hMmulmLr0WfthIZSSAZhXCuHu5SNa9qNmPl/hrqjuEjZVSFhiwZuEWNqu/DQU2mmz7rrrpjfZGZv3wXQ2klZnxtQnsgJP45ijvRpw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DaggJIDs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jL+DUjRs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DaggJIDs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jL+DUjRs" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7dj3B509249 for ; Thu, 12 Mar 2026 13:29:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=DaggJIDsVY5RU+X+ YNy7fh0t4BrlIakQoZhXZdtsbNqgsjL4XN4cYLSNflG1O2YvZ9xmq2/WgmTkN+kH I7i0sizRJsaH3Ro3EYRpTA5zoXgs+MhVby3UJQcalXWREZcr/erpwfDH5aDOHadn I05kyZGOpCf3JeMatlG4rWlqt6ycIX6m2I9iXSYpkqFjZXWn+l2uJl1lUg5pb6zh Bf5swOsoTPRQiN9ntvmzLvEs4qsijF8mbnqI1H3fDgOxA/EZT+UAg8itJrl44CQZ Lq9ihf+FiQF1iZwujBWDcOBQVvkVOA7VWwSkqBdxsY9URMChi1xSq95RuUxsWg1B GD8wMQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vcx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:54 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd81ce6fdcso978645985a.3 for ; Thu, 12 Mar 2026 06:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322194; x=1773926994; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=jL+DUjRsCI+VzQooBHQqphsz4FuUXUc2q+M04ePVXWDWgoG4u5tZmRslMUeNPJbgRY I6sTbiF3coWV7fSLZ7ovYmK8bgsniCifNYPhqT+DVapgyTJyoKAmOBIvTeoHmWroQA3T YXnGbBDobna7DMdZ3XONDAPhFHbtULjulbooS0+0IFVU5H5mPyCzbMxnSwUviXV+zemp gUMbpEUePbwddVXexvclHVqeakAfKnWwESsxOslSY8S6Yy7m/jqq0TMSIZbg68xAqvuc GqJqxQCYREIt2QtEmHDdjdodcWR4q0sPHMx5NCjWKG+dB8zbTLta/acwxmy/KkAztItW cmmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322194; x=1773926994; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=YBUM0ka92PJfvrDXjPxOHoScC/gWCye978atWsG89eJKyGopd9i9Su+v8EVVyeWAny xUCXVXIPzoArMGAtd9eY7TZ4NPOgq/RVPLk5cmVQfadlwCKJuRjbRazRaWV+x3KRcyKE QL0AoA4/iegueHC5DAuim8fmOzLmK7KeQufhi8ecrlUu8SI7I4hjlrPWDbodvOJhsK6x BtNAhyXplWPztpiPIG/F45wHA+uDA463gRzGFhyzeLn+MkkCMO22wCK7kXUyfNNd0pH1 Fyt+rau1MN/aeYVNIpjpzwkRwTGgGB35uGkvpNhY9DDl59OVK/VpdxUOaT5JOkHhMWFu yISg== X-Forwarded-Encrypted: i=1; AJvYcCW9m23T61JrycBPzGjN2thaQ4ezH9x/7HpW3O+WRUh7U5e7X1NT3HXZ9ti2KeCaX45tAArfz+YXlTjoqLA=@vger.kernel.org X-Gm-Message-State: AOJu0YxON+pljBPuTjT4ZdhhZU/GBSRZIfinuO7sHwTVTxuABNHBMUQS dq1oL7IEfrbPygw9cvOreT0KYdcAKR2L+oDJAUY8spz7hs8kOnxcgfo9Qb3kEP7WaUcJtz6qchg 8+bqsciTBX7dNlCnU7waGwDIK2Rahxa3GGzNRCZvi42AqpbuHGd1uQsSTYzg2WwwGFcA= X-Gm-Gg: ATEYQzzPbQcRdRkUDKulbpfu3peANy1BiUDyDE17uWdzsUN2EOglJ1lyX0YFnIOo0MQ +lg/v1A7ep0c0utJj86K+GQYOLYJj+bqt/CIsBEu24AuZlJj037DruSR3oKgpS8fm5Mau1EpEIy /SrucP10fairuj/YE8vOqJnO5vej1VBe/FcE7y8ma6AROodpo97vh77hGov6GP4uw1WGl3t9sli Rf+A4z1X+h0EBIILrfaUj1/9SJomMyWPSLDAFcToclvkKCcqAHYS9bNUnFjEKOh3fyA4JxlhYOE tOkBdLmSWmTUm0pYOZewyklR3JsIgq69Sa/gcaIcaX3ZoprcBx4STswqI5nYxqHk3Nk/xUD4WfO eINv0i78dflpF8IYpIJ2jBGQ9vcCrPJXu6hZvlwyJ8DWCywZC2dpKdh3oQb1IyHvrSnek9AwYhJ aArPiZ1131QYg+8JQqmT54zcQbJUZvoZBBoSI= X-Received: by 2002:a05:620a:d83:b0:8cd:9446:cef9 with SMTP id af79cd13be357-8cda1a562a3mr778066685a.60.1773322193789; Thu, 12 Mar 2026 06:29:53 -0700 (PDT) X-Received: by 2002:a05:620a:d83:b0:8cd:9446:cef9 with SMTP id af79cd13be357-8cda1a562a3mr778062385a.60.1773322193329; Thu, 12 Mar 2026 06:29:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:52 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:34 +0200 Subject: [PATCH v3 13/27] drm/msm/adreno: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-13-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2707; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2JtEAtBmQ/NcrldvywY10gImttE0oGu/aC LPb10BpE7aJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1QL0B/46X+E2kxsvXxWD3d7+sr2ywH20dgQme/s+FJAEU3/0Q+AmAS1DhEZTNwdxMa2StPQKvLY WB4sO4ENNQg/OzFo60K+PifFsL1nLEIBCD3BW/CCyg85AVRm3ds2vsUXHrYPDxZ11r4lB75wIBI 6m1OJB0qZ3tD6svcNlKYGbeWAzc6fcOkD/9a7cGO/0Gza3SJT/ZI2MgJSRkjvvwfYOjJUi0xEVy 22ffARkP3Xz8IDEZ1yrQyZLJCk1jjobRMxZbRRSScvcp22LSb8rtxgKO7Vg8gacxwPiA8vRbDR/ PEmVcvQvcYIlI3qJsEBTMJKOlBZv+baZB94HMtaL/2yR7lzs X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: HarRisNYO-1_1lovkQBow3qj72Eyg1hj X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfd2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=0JjmiBfSQHijSEXDZO0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX91KUk2xS3ldP ZIMIVYWM5dBiac/drjfbOndboaP3X1+z9elbAOoVZ5OvybG5AI/N50sIJasf04icSsnNNptlfyD jqsJP4hdRXVT5SLh9fiY6Z6HI1VsR4zmp6zMZ2ZmxFiw/nMHAbq3e8NkzGsvErrenjOhhAzkL3s TKi1wjZd9725LvDKiFskFQliXaFs4os5S6SCde9zWlhREUxoP57+5SpIPtCOFlsT558LkUqL7aO L8RCKCWX6vhFpaNlBvrO6q5dMexRgpTcNEHooKUGF2I8bcVr2pEx7EiU3bt9uH5aB/jrExkGzLg uhI+teaNy7ZeuF6dil4Ad2akywNEBffnQJR6i+iibyGnHp4mLAtSrTyoMxIPUu1p9peufrG7sQA LIg7H/n2YLnAzMsFoejajVMOvAKVWEfmGd5/SR1d0KOnMOlXJ+FtbzScDSz3ciQfLKwgabxuaF4 uUWwFApfBc2o9TbiWdA== X-Proofpoint-ORIG-GUID: HarRisNYO-1_1lovkQBow3qj72Eyg1hj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 56a820ffa613..7be31de3b525 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -741,7 +741,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) BUG_ON(cfg->highest_bank_bit < 13); u32 hbb =3D cfg->highest_bank_bit - 13; bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; bool min_acc_len_64b; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 6dc1d81fcaeb..680f0b1803a1 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -265,8 +265,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); const struct qcom_ubwc_cfg_data *cfg =3D adreno_gpu->ubwc_config; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); - u32 level3_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L3); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); + u32 level3_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL3); bool rgba8888_lossless =3D false, fp16compoptdis =3D false; bool yuvnotcomptofc =3D false, min_acc_len_64b =3D false; bool rgb565_predicator =3D false, amsbc =3D false; diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 4814233d8dba..cc21b41cae26 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -432,7 +432,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: - *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; + *value =3D qcom_ubwc_swizzle(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_MACROTILE_MODE: *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); --=20 2.47.3