From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68AB93876B0 for ; Thu, 12 Mar 2026 13:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322178; cv=none; b=cZ6A91K1G8lpolM2noWOm9FU6QL/b4TsT6wNxCaEc0cXWLYs3sX6Kuw4Xk1U5G1GEri6Sv6wJuGrQjUUaAiAX1dZL33s1m4qQcQQS392OdcetOSYWCCBLPrH0fL6s0BZk7Y1N9EuAwu+O8E0vSoVUWqpDYgT953Rn5M7RbxMgJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322178; c=relaxed/simple; bh=FcXX+QO0E2e2UbnHHDWvIWF4Nm+gAqQ21/54o+KGzd8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pbE1XoQNL5aWLXgkOEC8DMOjwZZAZaGTmPc01dFq6AZrK6BUeqoCOTfIyK4F2ftEhydirueJV9yMhhCYnp+aF7Cmoebj7K5VN9Tv38KT7SnBvysqwllKtKTr33ZCSx/7aojC/mPeUmWJ2q340eDgHbg6Besx6UOTpGuD7bYs9Oc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d5dAh1qV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PGOGt83w; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d5dAh1qV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PGOGt83w" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C99npD263416 for ; Thu, 12 Mar 2026 13:29:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /2lO51oxWqRuqIMOMa1LT63isf0ox5oldYaFyA2HvGI=; b=d5dAh1qVWvXcYlzw 7TY6mbPMaRnyCfOjsNGXlEnX64c8RrE8ij29OyV4xIQdu6ruEYFbjpYvZ3plbMFl BAqx5Rc6qLAeZzy0y05YY8BXyI92DosUGbo1zrFKllDvLRCNQlWnU078ykqVYAnO z+4Ph2mwP+KiuKit8uO1blPiEWm2geLI1cAb+i6jawO0NC4D8fK/OUq0R4lUYf9l y77RQqYsYjkGFJ9/lRo9W4cZKoj2YdgBSb3p1TEpomI7u14VETUiQbl/9G/sIxxg sMFG7Kjx4EXl/7AGYcnbcy4X/DuCpepUAwCWGFP7GEGpsOvUd8lcAK4pgSaWmJCy No+LzQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj62p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:34 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd7c4ab845so451336985a.1 for ; Thu, 12 Mar 2026 06:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322174; x=1773926974; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/2lO51oxWqRuqIMOMa1LT63isf0ox5oldYaFyA2HvGI=; b=PGOGt83wELKJO8Tg1YRaJUBOlUTG4nNmvxZhmRNFDSoJDrwXGoHSTb5Zi1CH9d3g7y yhM4sd3Mi4mrtXgsl9hYi/D0GxduZcm8+ex6shfdNKZYGt1GV9QC78c5XLV5CiH76+dK hbTO4s/rHzXFKmjcDJMsmiMyD4fhdasOgq02DJZE/EDMlpzuJogN9rlP7wZ1YSDrRxsW AQAfTGL4lo1cWY68QftLFM0uhfyv9icj44Qu1LDm/T0wB64LpV/KK6dsEkrDbCLZCxMR B5fpvtVqnls4/E0ngduoMxOV+IK6n1vqwN8AQ9EBwhf1w7Jx+sUSYxOeTVwhgH2uqKH0 JoBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322174; x=1773926974; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/2lO51oxWqRuqIMOMa1LT63isf0ox5oldYaFyA2HvGI=; b=lDT5EwRoZF2XQiFEtLs4eWfE5sDza64/D1snccVYe4hR+5x8ph6RToApJn7E18OdJP hg/EzLvZyXJhJSVUjGYIgSyUADEVinExInePmyj+ItrLsQ/Bmjk1aree26pQgOAT4rSu cok3ppKPwY+j+A/dCyorInmBXKKeoAIcq3ScQ3IA6fL2ye/8GikQtLCr8ptAm4nyuIzQ uAnURbrXnzfDtlEfJhMd2T+u5iU/w0qqdJtGan8bpNgTAjQvYA18sqBoPdtcyqhkIJ70 d/s2W8L1LtFMS9G+dwkAMTbyx9y6MA80pQ/YkBScPCInDTc7jQee27J7JanEpWkKYmMe owDA== X-Forwarded-Encrypted: i=1; AJvYcCXvTynRLZqk3yReV1BzGnC6URbLiT1ObhvrUTnvjjByO+wvDU4OZQx+GHRlBRuDBy13Pc4xf7cXtBobWjc=@vger.kernel.org X-Gm-Message-State: AOJu0YzgLBz/QhUCLvbSH2KhxQevSmAn0vHraKyXVn45P98x+0xfBW5q JSyIXZf37yZNIoFuqEIqmGMo83YO5kf1W/3cB23VrWK4pOtHQUHqEhDeBmxkqTu0XMDlAhKxju8 PsRVsXdr+lNa/Ej3szPcDD/6wL/qNK4VfolpClgBJuTXjB7HhOdTl4pB6m80uk6uAbGs= X-Gm-Gg: ATEYQzx4j1qAlWdIaasO54lzXVdLZpQHxJoBhN5ZAAizUnAy84YFPEVzU/1om81eiyy 9Yed1kpSSaoECD1QIUzm0vVbqc9FSIcJKHiGvf0LkU9S9ACh9maV+XJ1G694kMCwpxcuNBsiZjo BIw9Q/BwgyWnF/a1uHcBKT+XldLclD+OYepSWkvunTuYzZI8boX60g6G3/GwfqqNog2kDgct48/ oiRBGz5EHKYtq1zf+8TDOW5mDq2SqH5W5lIbh0bUiUWmIWwb6ji4tc5Wa9edy1PRT9EzmKXc9lw yvGT/EqJNhu6rsPoBLQWyC88Dhixssp6wxwas8aWRR1eYm3SANIX7moB8xMqgjTwABOrnCqLamE tVkHLYs3f4RTA+JhqE7k/9UE//wiwfrnzLtxE+bDIx7CNws0C1ZZq3Y2nIcBcUx4QFt2qtTlZcm PqdsHLlMA02bj+FivBcDexME8/aGcSsUkDO80= X-Received: by 2002:a05:620a:a3cb:b0:8cd:b317:a0b3 with SMTP id af79cd13be357-8cdb317ae33mr79320785a.24.1773322173801; Thu, 12 Mar 2026 06:29:33 -0700 (PDT) X-Received: by 2002:a05:620a:a3cb:b0:8cd:b317:a0b3 with SMTP id af79cd13be357-8cdb317ae33mr79318185a.24.1773322173216; Thu, 12 Mar 2026 06:29:33 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:32 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:22 +0200 Subject: [PATCH v3 01/27] drm/msm/mdss: correct UBWC programming sequences Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-1-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=6614; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=FcXX+QO0E2e2UbnHHDWvIWF4Nm+gAqQ21/54o+KGzd8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+0lEjFyOEH60Ac/jnZa9bs33g2Aqfq+Yj0Q Pwa09NPO72JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tAAKCRCLPIo+Aiko 1WpoB/9VZxaclHZBWaXPVLeLx4Siy6u3v870jqaZoKW6oUPlJz4Qd/3CCRJovsYhcDTolDy5OJO +kMIzcHfsBP758n6gxunzEe3qyFeLoiNkfzzPnuGsLqmjSHXlaLKzYjvPAeWd77ApUe/oiFWinh bajw1AQPTrqFf62864QM8skUdsNyr/+nblqSKAJJLNayAE5kwb9hIojsypsQIbjfY2iFIxtRNEQ TOtSK/QG1ZFjxymqKb8pFbN56mdp1lG9lQBTF4yWCdJXIonQeotxxd2E2NK2j2EkojtvXWRAkP6 UKgFrmNcFO13o8JeVzQnF1UM1Z3CvAa0H6n82ivux0dXrLya X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX5e9yd3Dj6ZIW U4njHA1NbnL3211hwopiq8deSU/cpB0YKemFQ0LUEBfSEtYV1KGZNaswFe202qRNnrXoFELUwdl WkmKVuhcS6HiA32llYqIUYGcI71N4Tzrlgk+jwIxQ0N2SbzIXP7vuHwiNnW8Pv3oPu1n0PWZ4Er ntfhe3CYr8NY+H6wNCsKwtomuTCEobE4NYy3JOXm2prk/6XcfMOO9d6CHiQenHy5aVLq0LPEVVh pM0929+dcVBPypB+x3fscqHAvK22rpJCVb+GHj4gTBiF4NQ7794Fq0gDOtA6sN5DbSbZEDY/zSd SWjzZnYRGhTF/pYToOcxguBNORidkjBTUlD7OlOR4XSBpTI5wdfr3oS0uMVKfq7MEzsEkOUUoj4 q4ANjUUOTLWqDhBRbgcG82jhOtviMH7kbQZ3odn+ywhTjM6XazSMjKRfqyrZS5xGGVG6+pW+rDX +/eZlRF9u8hd6V8nLrw== X-Proofpoint-ORIG-GUID: vBHBK9PdmbzWmEMjp5ucl8P-zWFo0BKh X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfbe cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=hQCg4X1xv2bm5S_WMKMA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: vBHBK9PdmbzWmEMjp5ucl8P-zWFo0BKh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 The UBWC registers in the MDSS region are not dependent on the UBWC version (it is an invalid assumption we inherited from the vendor SDE driver). Instead they are dependent only on the MDSS core revision. Rework UBWC programming to follow MDSS revision and to use required (aka encoder) UBWC version instead of the ubwc_dec_version. Fixes: d68db6069a8e ("drm/msm/mdss: convert UBWC setup to use match data") Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 115 +++++++++++++++----------------------= ---- 1 file changed, 41 insertions(+), 74 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 9047e8d9ee89..7cb8aeaa7ecf 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -166,22 +166,19 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *= msm_mdss) return 0; } =20 -static void msm_mdss_setup_ubwc_dec_20(struct msm_mdss *msm_mdss) +static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_bank_spread) - value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; - if (data->ubwc_enc_version =3D=3D UBWC_1_0) value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } =20 -static void msm_mdss_setup_ubwc_dec_30(struct msm_mdss *msm_mdss) +static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | @@ -199,11 +196,12 @@ static void msm_mdss_setup_ubwc_dec_30(struct msm_mds= s *msm_mdss) writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } =20 -static void msm_mdss_setup_ubwc_dec_40(struct msm_mdss *msm_mdss) +static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); + u32 ver, prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -211,45 +209,42 @@ static void msm_mdss_setup_ubwc_dec_40(struct msm_mds= s *msm_mdss) if (data->macrotile_mode) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); - - if (data->ubwc_enc_version =3D=3D UBWC_3_0) { - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - writel_relaxed(0, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); - } else { - if (data->ubwc_dec_version =3D=3D UBWC_4_3) - writel_relaxed(3, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - else - writel_relaxed(2, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); - } -} - -static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss *msm_mdss) -{ - const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | - MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - - if (data->ubwc_bank_spread) - value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; - - if (data->macrotile_mode) - value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; + if (data->ubwc_enc_version =3D=3D UBWC_1_0) + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); =20 - if (data->ubwc_dec_version =3D=3D UBWC_6_0) - writel_relaxed(5, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + if (data->ubwc_enc_version < UBWC_4_0) + prediction_mode =3D 0; else - writel_relaxed(4, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); - - writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); + prediction_mode =3D 1; + + if (data->ubwc_enc_version >=3D UBWC_6_0) + ver =3D 5; + else if (data->ubwc_enc_version >=3D UBWC_5_0) + ver =3D 4; + else if (data->ubwc_enc_version >=3D UBWC_4_3) + ver =3D 3; + else if (data->ubwc_enc_version >=3D UBWC_4_0) + ver =3D 2; + else if (data->ubwc_enc_version >=3D UBWC_3_0) + ver =3D 1; + else /* UBWC 1.0 and 2.0 */ + ver =3D 0; + + writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 +#define MDSS_HW_VER(major, minor, step) \ + ((((major) & 0xf) << 28) | \ + (((minor) & 0xfff) << 16) | \ + ((step) & 0xffff)) + static int msm_mdss_enable(struct msm_mdss *msm_mdss) { int ret, i; + u32 hw_rev; =20 /* * Several components have AXI clocks that can only be turned on if @@ -275,43 +270,15 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss) if (msm_mdss->is_mdp5 || !msm_mdss->mdss_data) return 0; =20 - /* - * ubwc config is part of the "mdss" region which is not accessible - * from the rest of the driver. hardcode known configurations here - * - * Decoder version can be read from the UBWC_DEC_HW_VERSION reg, - * UBWC_n and the rest of params comes from hw data. - */ - switch (msm_mdss->mdss_data->ubwc_dec_version) { - case 0: /* no UBWC */ - case UBWC_1_0: - /* do nothing */ - break; - case UBWC_2_0: - msm_mdss_setup_ubwc_dec_20(msm_mdss); - break; - case UBWC_3_0: - msm_mdss_setup_ubwc_dec_30(msm_mdss); - break; - case UBWC_4_0: - case UBWC_4_3: - msm_mdss_setup_ubwc_dec_40(msm_mdss); - break; - case UBWC_5_0: - msm_mdss_setup_ubwc_dec_50(msm_mdss); - break; - case UBWC_6_0: - msm_mdss_setup_ubwc_dec_50(msm_mdss); - break; - default: - dev_err(msm_mdss->dev, "Unsupported UBWC decoder version %x\n", - msm_mdss->mdss_data->ubwc_dec_version); - dev_err(msm_mdss->dev, "HW_REV: 0x%x\n", - readl_relaxed(msm_mdss->mmio + REG_MDSS_HW_VERSION)); - dev_err(msm_mdss->dev, "UBWC_DEC_HW_VERSION: 0x%x\n", - readl_relaxed(msm_mdss->mmio + REG_MDSS_UBWC_DEC_HW_VERSION)); - break; - } + hw_rev =3D readl_relaxed(msm_mdss->mmio + REG_MDSS_HW_VERSION); + + if (hw_rev >=3D MDSS_HW_VER(6, 0, 0)) + msm_mdss_6x_setup_ubwc(msm_mdss); + else if (hw_rev >=3D MDSS_HW_VER(5, 0, 0)) + msm_mdss_5x_setup_ubwc(msm_mdss); + else if (hw_rev >=3D MDSS_HW_VER(4, 0, 0)) + msm_mdss_4x_setup_ubwc(msm_mdss); + /* else UBWC 1.0 or none, no params to program */ =20 return ret; } --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F2FC3C554B for ; Thu, 12 Mar 2026 13:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322178; cv=none; b=rs27aFVOAGWQrnCmNkcJaMIos+nb0NeI/E88arbxM+ytJz5MqbCNzcRLq34Pu26f3VIfYtvwF78CoHqrShQAEC2Re1NYh60Fea4fkCBRK0PybhYHqUuHiIy3otQyZcUj4fmsuLXVV5096zrwdlwqVDAJJ5d59RI+39Ggs9c4krM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322178; c=relaxed/simple; bh=0jnnTKmBVzx8ajx5YR0+k88TfAux9nzkeECglU8qUoc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JluG6cDFTY73dLk07emPXS7ZFnq9pZezzDQclGO0uXzNHFt2qtDNOESK/EAcPrU1z8ZvirDl32LNTjLOz/daUF+KZE6zmIpFNLdxp/akEM0o4P7h1M/GERqV/Bg2ZeL3vv07cmTYUr+COflMGJL9i+Eea+5KCqd1qdjzvOcMaS4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SWa70JMX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SQDkKkHc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SWa70JMX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SQDkKkHc" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9eMsm3666914 for ; Thu, 12 Mar 2026 13:29:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DhLMvVZQbF3J03WMc2id/1RoXxcDZvjE9wQx5sGd7p4=; b=SWa70JMXlC0X12dL AILf+ASk3C1/ih8h8qIVooo7H+rlrhKpgMe2ulwlOcf7QY63JzAHSTDXo4AKqSts TQ2rpd8rpUe0vVfA8ViZL1X9V6EoWYLPcCLQ56FEZJFbDCtvg1u2oGs0useMGNp0 IveZWx+b60ZBUgqcdoTliEB6oTSTcOVMzHI51lFrLrZmJe/UJ39PDbO8E63BePtq fBYXsuoc9zmsGgkjXUMubiyngQ1O+PHUv4fO+dQaHJgIaZEo08PSiTcOGjWZw/+c bV8Os/xpfSROl11ST3v310k44uw+DriKPjRFKpmz3peAiYHpTEMHy+qLYc8D9MIF 6XtPag== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh60j7s1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:35 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd98d96382so120152785a.0 for ; Thu, 12 Mar 2026 06:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322175; x=1773926975; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DhLMvVZQbF3J03WMc2id/1RoXxcDZvjE9wQx5sGd7p4=; b=SQDkKkHcO+fWcHYtmCbH7zqorpVocF9Atb5FtV6nUmE4Kkn8U8Tsokiw65OCnV1bxC M6nDhqAqQltLDO4KxP3zD05wWGz2qPZJY1I9W18ALVNyWeOyq7nCybs4GBGHmQlPUyuL O7NC+yOdPJ/wmeEnZEURlggBW6PXHkk1u9tmOjFYZLp+uznDSXUbjVpIIvfsPOHaOQFW wAZODeK6tSjUmzUbvMuExYH+gqfVSZ3WFB0Sjr/XFi7ssHnbl4Ly+0FhxXpBNd12K1UY nY7QmpFldjM3AGgdRUOWKkI3lcwJrgV7OgHor6GW9G3JCS5QUipDA2HtNFK/kczAUp7/ wpeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322175; x=1773926975; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DhLMvVZQbF3J03WMc2id/1RoXxcDZvjE9wQx5sGd7p4=; b=v/BfPGGkoY4aUAxT1xrlHqg1uq1bdvxwrFD6TOPlfyRHzd+J5XQXJqUILUq+/5v+5Z N4Soj5Pjh3ol4Go46ZFElRjYVMTfpkL5GzPKhuJgFqW9ouO1V/bqYJON4yfj9ddgsJuv dO8h+oo2NY+INTWb3EJr5WW6Vhvh3gI1PsecYqcRTYryiAvIss3hhWDwMQlm9abkKnqC XIevjccCZyLzkip9B9FnKruEKaL2Nderl78QC3iUhIHTZlysZpJ8U3IqJ2fKvz41c//B tUmhBPlldwSIhUtEMoqquchT0Rocx4MQdPcjlO28wb40HPAj0aACt5OQ0JWDKXM+yFs8 K/KA== X-Forwarded-Encrypted: i=1; AJvYcCUue2n/cMOUVCUuuNlCc7E0uMI+B/jpIK3f5v8Q3Rn5s69e1cVHlmE1lRucbXeE9UjpV8RINdxeQNC0TmY=@vger.kernel.org X-Gm-Message-State: AOJu0YzERp9YJfOz3Yq37AjPl31WFDrh+uRT7jTQhzJeyvAnF0nfpMTh Xco/YBU0DSYPMXrzzahaCesGkD1IVy99eDqo/hxm7yUYaBQBxUY0184sc8Uz+mWBqKdtiHKb9lU 7UUhdU6KOlQrfJxT3dfvqYfizxKQQjuWayVM1NdCPHEdQKtDgS2FbcrzyYVLvOGQLtHQ= X-Gm-Gg: ATEYQzyi+1r1b8tVAPVEYpqQ40sjlJtiODzXOyA6QsU1F53NIueYQErM3M1m9LR3LLn MvWwsu2AiM3PYgajzLTGsVAvDSommGFNtPVoURpBhtMq2MONqxAF/qhnRIN8YcXAJC2yyYQegDa Cr/EGq2+2YaCWADYtNfN1b81OW9mswCLGjFaj0OsJRphG7KUQRkuFEK+T59RV3gN5y7KqoJahsq 1yLh43+FW06LR2qFzrFiwedzF/5dYvmjYJ8yVzgQmL/cP8fCKtxf+0mR+yejTocSLYmCtpU6OWQ DOUxewW5QYHRtwKIKIcOVTkQAQHWUH1RxkALxSicfU4D/ln8ZozVwftUlYqrNf9c0rJBz6L3BtS gwDmz/JoK73RQV5w3T+t1XSJL4xPl9MJoq3SEq/K3+EtwZrTzY67vIl/U6HbAw53RTkD9lDrL+k KOBEwhmpeJSG+jEqW4N8PVmeB7qhsWINco34k= X-Received: by 2002:a05:620a:4629:b0:8cd:79aa:6932 with SMTP id af79cd13be357-8cda196c6a1mr725103885a.30.1773322175300; Thu, 12 Mar 2026 06:29:35 -0700 (PDT) X-Received: by 2002:a05:620a:4629:b0:8cd:79aa:6932 with SMTP id af79cd13be357-8cda196c6a1mr725098785a.30.1773322174729; Thu, 12 Mar 2026 06:29:34 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:33 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:23 +0200 Subject: [PATCH v3 02/27] soc: qcom: ubwc: define UBWC 3.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-2-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=914; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=0jnnTKmBVzx8ajx5YR0+k88TfAux9nzkeECglU8qUoc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+00aU84TlXbICszP5LjuDGDcyy/pSUTU05q g++gL4431+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tAAKCRCLPIo+Aiko 1SUWB/9sOpBSd02RZ4YD+QhJMIY6PQ9+GWRAmfC4iYUMoQA0P2RHGhA5F1fyMkpAQM5oS2d+NEX 19vaOHqqdmZMVDImQJF/4+R9TqQTbTb9u+Y2MwdIZYTeKELXF7tULAiiOZQ1xG68Mw7eamfi/bS PMWPhcwYdzNfRYwSiMbJNN5YG9MpOf7MB/dRDZIK5yaM87E7d+G2cb5fHbhLEW4Nsw2kQmXiPzO /YSsS/uilico0uYf7XWiuoVNh2DguGKSWf0Maulyogzml37RT2cAs5V+zda2hpTlG/q0tsomMjJ c5lt2MjCfgbAIb07/spNuKFWJFDG4SHtnGnTxYgpUNOhKH2t X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: tWdsVaqrja2lKobAeVSyeRBwndzL8URb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXxPhoQNQ+MDKa MfUm4/Z34iHcNWlZ4uzH9TBtMqy1usVVnBj+58YpQo9tzoAJ41c+p865v5PmMyyoZXC0o9A4EAF bzB6bioWqRZZro5c/hqb50o0wsH1WPYx87BMATMaW4PK/w86vcNMeMfOzWLjSrCmKyCYP5NdS68 1Hd2WC4IjMzV+wQc8+e2LJOctmESFzF4eTLcLGXbRC4hyqjMteJsoFHK5R/I09M+DP34+x+MIVM qQJyCAozNLBFZ1grDOVb8KGyTvwiJ8s/sQ+/KqRajsY3bcp5Y+KKoDWyctQEBmdtUyCr3ypDEDw kR7ddmr1mYUndScawL7YnPpUWGla16kTVdIzzzwV2kIzw72JIhmkwhjRE249uvohWqqWMNj4naV qVEQpRzc+Ldx6M8XOdUTqo2Iy0jj0lh0+xk6nzI7q3znEM1Z9QMz3kuK7RB65SDmG1DsVnVzN0h K6lqtCmphUCad813juQ== X-Authority-Analysis: v=2.4 cv=DsRbOW/+ c=1 sm=1 tr=0 ts=69b2bfc0 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=o8D1m1ilSIXDguKSM1sA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: tWdsVaqrja2lKobAeVSyeRBwndzL8URb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Follow the comment for the macrotile_mode and introduce separate revision for UBWC 3.0 + 8-channel macrotiling mode. It is not used by the database (since the drivers are not yet changed to handle it yet). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index f5d0e2341261..319caed88775 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -50,6 +50,7 @@ struct qcom_ubwc_cfg_data { #define UBWC_1_0 0x10000000 #define UBWC_2_0 0x20000000 #define UBWC_3_0 0x30000000 +#define UBWC_3_1 0x30010000 /* UBWC 3.0 + Macrotile mode */ #define UBWC_4_0 0x40000000 #define UBWC_4_3 0x40030000 #define UBWC_5_0 0x50000000 --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4099B3C73C4 for ; Thu, 12 Mar 2026 13:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322179; cv=none; b=g25YN/+1r8dDWUcio5SgzIYfECqYUAAazwcg7rrIobk/27tR0DIall+4EBxAZo0Q86XKf4pP0uhylTwxSz/pv7OARAQNVpgTQOLkkiGSF6hZv0Gu+qIS3gZk5/NIRvdzE6mTBQcoJe7xIc0Aql5uTlBtQXoUm0PNxiCSs77MgU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322179; c=relaxed/simple; bh=NJiVsMMKzJws+Cks3lRdvlT1mL0gwv+c/6r+WaGQjLw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XNkLKeI0Vhva37JQfsB34u9O4TkEE8LyhEL4HVe3ON8vWZ/uQPekjGHSHocQDjimJdi5YB0+1QCBoUuG9MJw0jSv9ejehLJN1rDuJNWoyvwx33XrhFqZFlIOpVpopM4wbijTvX5Qn+dJbzPraNhduBHOGJLPmilu5A/aF7usJk8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TxS9q/7q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ea/196sw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TxS9q/7q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ea/196sw" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9PmFD4027299 for ; Thu, 12 Mar 2026 13:29:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Jnv3IJHVveO9Wr2l9i2vrKyKNiwoqkqE7X6w0Obsuxs=; b=TxS9q/7qk+t4W/H2 ICWcGoKgarAF3G3k+38xKi/fIWqo0UHNdLr7Cbcq6tz+eNEGNHUZZU1ECgYNiVHy +3kd0zYDr2QMWPX06Fk8HOPGsovOfzjTrpWnR/tC6BSLBh9vmaokznaXcnUUdJKq osPgJ7lFDXxRCpPy38rQ9Ss5txGFRQyAUbLltSsFAhPiDfFFe+OB4T3vKS1E9lpA 45TLMZzPCmUwd2dIDg3eqYRdJDeWbjsEBrQNQreAQmMORrfHNYBy/MovXXy91WEZ 43YRwXGLaSZAlRktekj7VrTfJMv0Q12Dnp/T7F1T4kJXTmuo0gCfPoirVjdSemKR /0TrJw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh54t5q5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:37 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd773dd409so140694585a.1 for ; Thu, 12 Mar 2026 06:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322177; x=1773926977; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jnv3IJHVveO9Wr2l9i2vrKyKNiwoqkqE7X6w0Obsuxs=; b=ea/196sweJrPxcRQHliXpy+hLDsQc4+Cg80VyviR7APtrC6zOsIyLSfM2wgTeTiKFU pUG0lQtfXRdTx0bmg6I9YBhIARGU5ib02wZ7m9utc+Wat99bWNBUcpNtDfe/t0by8EX6 zpLA81m47lS/w70FEkyWQ46LLc4oJonMo45/g4kIW8/qiwIXU0l+i/vNI8kQguD41CCc ERTmD69EJjympmf+96PuHa/FM9Uj+NPQvSZjmw4e1iJ/IzmfPWkhA4QfQDUJMheD4AGB s2O2rLq6dvumwyOuZYoOFwRR/kWGh6GQkvheei0tlp7Z6N3oubWRGUj+YyMOmcuhV+cZ Rymg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322177; x=1773926977; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jnv3IJHVveO9Wr2l9i2vrKyKNiwoqkqE7X6w0Obsuxs=; b=jOlCvT2gGWeFJYTWeJjkYCX9B+wpXM4fbUbPoYQAUDB3jhn1KCqdyq/ZLuPWoaOmVr hXpwWHkAyOALV7pmB980WRUZ72ODGjap+2JnB0XM/w1miF+kJNoXX5mG6fq8Next+HCn 75d1sjbf3dTHbWgbBJZfJAcQ9KKsfjj5D5vfptg6wMlDfsymQ5XfxJhxTerLEjbPiYYw 7DvCrvHr4arsIfrvxni9ipUfMI2Ao3VYqDBFG1q1RgIeh1Vv45CWSKOcFqrxfYDk6aqE U9wmMJ2qIqKnODl2rbMVQnhgWUs8Emt1I68oKPG+WkfxJHLFX81Jg88omBmvbfcDekhQ 9DcA== X-Forwarded-Encrypted: i=1; AJvYcCUUWajwU4LeATSLjOpeO/O8GaR1dDt2DnsokPdDQ8Dz+aqyWqNywwvqDwR3U1t/TnmFvbT2ILL2itgbgww=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg5irLYxsdZ5SCvcbqI9QfP2GneywjCO/H47Gy3t3Vdjxksnlh OpO+hs2jXNmp597kn0R7lPD85sWrT+W8ET87lg4fLXEp2yLbfmCpS13GVlCwJwQhA1nQYSAhj7B 41RQ3KGSD2PXzumQygERFbbLCZJvmqP42MFmBa3JsIqvPrDEK3gH7YT7WTiba8wRhW7M= X-Gm-Gg: ATEYQzzJR5x/kQ6UTvPvEUx/G2POY55SDaQrHUHe5HdOgReqznGE2Auop9aj41Ho/bw 53rWGsLk9L+Cy68zkwh7/kOVMI4/TnlzQjoeFVXmzR+ttLBX5Q1c+szcm5FZrAFWE9oaK5hmR01 nvGVhwKyvqLZmQJrPyjOx24BbQp4DJIi5CG5tkgxoo+EpCr4Bwix/2g9SjogohKy3c2XM0Q9z7i 5oC9jTXyUUicwoFijaWg6C0q11hP+tB77NypP6ZKBGwu0inayMf5LXhXhpeAEpwoT9YzHFOcd0h XNYv/ZjFuRQ/luy2dz0nlTJb3pBc96ASFeOEaPDNlPTW5fiArDLrq8LWILhPynbDcIMWcRQTVAe eqTrbD2cuRNUoH3pTNaC+90MoFajShggijudwhmlVp6B76dNsu6d+mroyWDQP/Ap8i9X0jKTK1m 8vOAUtd+KruYdgnqmVZ1gqpg01argm1Ymvqc4= X-Received: by 2002:a05:620a:28c8:b0:8cb:391a:48b2 with SMTP id af79cd13be357-8cda1a8a7edmr758766585a.79.1773322176753; Thu, 12 Mar 2026 06:29:36 -0700 (PDT) X-Received: by 2002:a05:620a:28c8:b0:8cb:391a:48b2 with SMTP id af79cd13be357-8cda1a8a7edmr758761985a.79.1773322176278; Thu, 12 Mar 2026 06:29:36 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:35 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:24 +0200 Subject: [PATCH v3 03/27] soc: qcom: ubwc: define helper for MDSS and Adreno drivers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-3-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1061; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=NJiVsMMKzJws+Cks3lRdvlT1mL0gwv+c/6r+WaGQjLw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+0jEsZup8bwLf4AYfAOUkDjBlXm56HF+8bb L0ifc678fGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tAAKCRCLPIo+Aiko 1ffQB/4pkEP5QysPU2WXii2L7BaLj/kfMFDQykhYsnigr8VVstqvzWNYWDXkgQ1UleXcBnFCBq6 +X3uHskk9PTia16oZqI9g3PVG13vrlJcEWx4z9HrTbPEQa526acVu8rpv3NpZyL3wt0/jDd33bs 7jLwtKfzrjAvXeIRBpsPnMcW2MYo2GOSkaW5oPax4meGtssxMLAaxlEk6+AbmgG8RkDNFZl6a2S zp9cIOikreDv9BH+ZbgDZg8tE592khKXI1mXTGZQFfNxoR0256R8XZdnqCJrwaEQuE4feOC0bZ9 r0f1xP3fupvOQYMyZp7k1qfuHA3gOFQpDzgEXvlcGeojgUZn X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: iQHcTcgl5UonM_-S07CjgddAKHNf7L-C X-Authority-Analysis: v=2.4 cv=BNG+bVQG c=1 sm=1 tr=0 ts=69b2bfc1 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=TXJx5zmxIxDbTTGRO54A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: iQHcTcgl5UonM_-S07CjgddAKHNf7L-C X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX7TJobruZgSP7 PTh+jN6eT1RWb53YU2lNZNAt7nmR5DKyJQs6pFCetOejeYV5kSLIasM9Nwbn0TBujgkbCpgOPz/ ZlYqawamNKBsHKoIrp2Dp5lFa8u3bOhBQbFe5QGGtL/He3uuqTe1Q8onLACpoqg/3RQ+2uy3Idr DCZ9xIX11s89v/UsLBZG/PeMWMOlhpC6pfVuqcd2IAeht5V8h7Nfzt+9VjAGug80urXP6VTnxsh DOGO+b3MySMo4db8S+jtIxbjy2oJs0ZB5ljLBDoPC2RFcn0WKp/4dLBUlnBzGA+uUSHRlDdopiM YT9pzkQ32eLUmR9EiUJorAfsvGIAKG+eD8n0gMbvgpy7yU2yZozRRumwNX+lT+q83TLby8aZJlt Yf1xlDOu2IYe5mqoyNEHNkBPupdEiKK0kGrZ73rKNI6KtNxhmLEtFxSfHo1L2kXLdKEaBlzN7n9 Ia1+nz9HCsTg3v/J3SQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Define special helper returning version setting for MDSS and A8xx drivers. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 319caed88775..8355ffe40f88 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -100,4 +100,20 @@ static inline u32 qcom_ubwc_swizzle(const struct qcom_= ubwc_cfg_data *cfg) return cfg->ubwc_swizzle; } =20 +static inline u32 qcom_ubwc_version_tag(const struct qcom_ubwc_cfg_data *c= fg) +{ + if (cfg->ubwc_enc_version >=3D UBWC_6_0) + return 5; + if (cfg->ubwc_enc_version >=3D UBWC_5_0) + return 4; + if (cfg->ubwc_enc_version >=3D UBWC_4_3) + return 3; + if (cfg->ubwc_enc_version >=3D UBWC_4_0) + return 2; + if (cfg->ubwc_enc_version >=3D UBWC_3_0) + return 1; + + return 0; +} + #endif /* __QCOM_UBWC_H__ */ --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04ACE3C7E0D for ; Thu, 12 Mar 2026 13:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322182; cv=none; b=FgG3q+E2RawaTLAInYfrube+2jWLES5pdsi400RLWi951C06+obR0kGx9Qk3MPl1rCba5bMvxHUvkopaIK/OauBeuhtAqNZVFv+/uzPCYwItRWhKMbA4aaCBsH9AGozmDsHb/m6ayxYpir0oWJY+1wnI+6YT+AhIFUjPh95A/BM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322182; c=relaxed/simple; bh=DVzUVHYL1LwQyydsa5bse8Qdux0+ATejKvt7PdcnILs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=agMV5A7T2MjqGuCyfAGXHOLDEJ4l4QKzDLN2X4FfpYs+L6ysS2DFGRYSUi+gUTFXPh+kZfh6XIHZpq5oJ4p+Io8dopJU92t6+3H1jAj5+vgo4qDuSXIDf7SR43l7NoFpqnlZ6VmVnI+2RFzfXcrjLzMAdIjqMR0eG4Cjd8HLtnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DPC7C6Bs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EWmqOyVH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DPC7C6Bs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EWmqOyVH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C2bruL1740582 for ; Thu, 12 Mar 2026 13:29:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l4shwfMjGLnh2T+SL6QX2H/uv+6YZBYhzZVvBdIDpp0=; b=DPC7C6BsDEQjSznf kkKXFAEyIoMNf0D9kut8GIj4Lh/VI5vn3KGqcZJyv7nDDMWwGmk5CJEopyz1Fym6 awbeyCvhPQVYuyGz5QHxahcpZ4BBlIaFvuWGkf5Ln/25YuuEsASx8SmswmQr0Or0 Dippv63PvZ4GJgGf93NAsgDCjdOHjY78m+V6i1/LDiY6pGE4Va+259aGg8j70x/y Mt3kQ0sebFNHDaPTgbaV7I7lUcVCT7KI8P1321+3vlxrYcJNkz69gsQ5aqNow/Ek HwQPAw8mQN8MZ5ciIsNb5SC+MIxxlNZHRmHM+ytyxLCoI3ly9bxDC/fAA7O1LFHA 1hatfQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cumvdhjrk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:40 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd820c6a4fso887795685a.2 for ; Thu, 12 Mar 2026 06:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322179; x=1773926979; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l4shwfMjGLnh2T+SL6QX2H/uv+6YZBYhzZVvBdIDpp0=; b=EWmqOyVH+E4vN/A2+30fzPtNXkfDLAsLoRVVJTCyIKG7hjAgY3HLtd8+pPXClNMgnC iIwlqvwvgHhovyzMPwDtq3lvF6LiCjz1cyUSWE1yaxD+2A9PnwJYWY4VEx1dfNOiiSXj gYlDGbCzZCQGqrZ/FDpXuNxgfgKn3iyOoxfPhTNP1oSWHNTDpt2Mv7O2uhOKYuF8HjRu VN3niRYPd92+10J11HaMOek3fw9V5+dsS8NiY6sqvT0eYz9YRyoeuiuZCttr49xcuFam ggdDRV/jGTDj450LmX2UtD1Q22Ua2ioaljrCyjTMSgKTIYmSPG63Xsa40GENH7/1zcN0 Mokw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322179; x=1773926979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l4shwfMjGLnh2T+SL6QX2H/uv+6YZBYhzZVvBdIDpp0=; b=bK9BYubD2NVbVu6ybN173OICLMNastCHQ/6TLk54bTpl8UDRe5SESdwgCpc12oz5Rk nUdO6W/jL7YLeLZXVX1Pn8/Vu73rbJR3Pu7qpJua5gVfX7LlI06kSKRhlMnPl3LbCkL+ nKZ3Yn1Qk6n78RRkhBqgTUrcxpHAgvSdySaQDDe/sbkzpI7oF1e2DOOO/qxCSYA9XhJs xFo9knVwwVaarIJyczJb6ZdhnKso/nTvNhcJcArkyXIiVkM3lNI6Yy+zJqVXfWlPoe0y vVUt5SuxL53u051vza9Qa/8fgtHs/WoD5I79rVlj1elRNLB/MbBZtls/o5VBtjrQGJGf Foag== X-Forwarded-Encrypted: i=1; AJvYcCXsFnvPFkSn2QrG7F3ZMfjD1NijUOFPO1m3HNBDNBIwj4plYfs3L33Deh1jb+tk4q4tjdXNRWSi+Rfk0TM=@vger.kernel.org X-Gm-Message-State: AOJu0Yywj+HaeOoHoT8ZxwHrDKteqK8d4jLlwj6zvST/2bypMKxlllnt gxy2gpbdokyboDC1391hWmpUYc+sY1iz4/deg2TVK4dJRqdJVLep2IdeBh3S9jqBoDBXu2jkfFV GTTZT0Ks20+jgEU6tr5pL79vNxf1kLlXwEliXB5z+49sJlxMSkWAVrDWrghRAaaxMsnY= X-Gm-Gg: ATEYQzwD3t4c34jXkejxVAUtDkhthVr8FI6kZfidSbXfmGyWInn1P2uRGIpv5/XfUR6 ps0RvTTquwNTDkc+rJVXBKJeD+nEW/vIlGBWglZq7qJdlarSJbDgBshLdZjfSp9NbYVxR8BJ2+6 mEZlJxAYYOA7jwSpzvfZUzBlwOEpopdFLyhxXQEsb84NiYGX5NhGEX+lsfzZB/IsYYFzL4sU9I6 H1b8Jsbiy3Cgj+Uc6rNAHC3PdCQB44m0TALJsrql/YjZpPwBEwug7KwMAyGGgb5iAEL3B0IgxN/ QLaGCB6Ny/rf1jl8QRFbwJUAUGlTwJJ+p/JHKnLgdjCWhdNYCMk5TEGlsHiTQCclUgdsu1Z9gzq FFdHVIbd1Fo8yfCfpz//JHgxD6hypFL7MDJn6zL9+kXNAhSwlmd/+/b3MOHdTW+gDOIGVR/xhDw U9b58NHF3V1q9cNZ2A9RvVDdI4KUMPpnYwz38= X-Received: by 2002:a05:620a:450b:b0:8cd:75d9:f110 with SMTP id af79cd13be357-8cda19b9e65mr792733885a.12.1773322179401; Thu, 12 Mar 2026 06:29:39 -0700 (PDT) X-Received: by 2002:a05:620a:450b:b0:8cd:75d9:f110 with SMTP id af79cd13be357-8cda19b9e65mr792729785a.12.1773322178927; Thu, 12 Mar 2026 06:29:38 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:37 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:25 +0200 Subject: [PATCH v3 04/27] soc: qcom: ubwc: add helper controlling AMSBC enablement Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-4-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=758; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=DVzUVHYL1LwQyydsa5bse8Qdux0+ATejKvt7PdcnILs=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1jSF3ceUSLZoScyBFkXU1mvss7emi4l2/n fwzAmEbAUWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1aQOB/9CNdjt8rSQCnJaGvFDn+NgZIMmvVSiFhBRy2x8PweKIs7pbwve95+HWMQnvMeqLzVl21A geVE3PlbctgE0VpzqH3oKtdh0GfS9jL6TVYmt91IhtvvIQWwCNP//5OejC1WuCbk/o/Eh27uwYZ MCpmDESQBRaPQgsNhq3hMzkFEyalUVse3AbWYJ4sVHJo/Vg7rOtSivIcyswbZyXJPSRS0HUOdMx Nc3m4yrNtiWo4BIb+ZOp6yRjtIx5cYMwTJzrKtQr5agQ6bVLIU0cM4/N8LKlMbLpmX625rxIsAx JGoUdpF3BVmlO3R6vFUERECdwHib/DMO9Hb9UJRg1tMpVa+Q X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX6MGceW47VHbw qwrKbIYF6ZJQJW6+th94HKoyyhLULEnsX6yGvrIijyl4uAeK8KGy3Ip0FwJ54Go+TjkKrG79ZCr uWAAKBgQGpsMn5RHfcIeQDU+tUlMXrUTWTAxvSV85RVCgW+IS7O30NbBxbYyb8pQtj/7uXY9Oxe TNWx+UC9d3qGuPm67pFCQ/l/BmIDMtU7IvIjTH1fO1B0+Y7CPnXrs4pzcBuWD1L5nUdnFrWvnvL 1XPp0eW0zihSzgZdnB7CP0aSVfGi3EASO15BVxvfzqiDWhkBA2kDS4VYqc0MokhP6OkyfTS0UAv T4UXdJFl13clVOhFyZSq66jpHz2nusEBY92T39O887RjzpomjFNhLrxl9CJ5CwCcZxA5EWdwZfR BHmSSGWp7MbbjHUrvzqnHHTh7JFB/xXCHoTXO6Lb0TyA3LMZYfRaJp7HZINOPqg+nQAZ2qlkwkE WB7Gzra131ai5uxiyVw== X-Proofpoint-GUID: Bzk-KjZP9eYE1ThplzmBO8bbfXPvCNTx X-Proofpoint-ORIG-GUID: Bzk-KjZP9eYE1ThplzmBO8bbfXPvCNTx X-Authority-Analysis: v=2.4 cv=XsT3+FF9 c=1 sm=1 tr=0 ts=69b2bfc4 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=WuC1ZyUpIfxNvbBu5HYA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Adreno and MDSS drivers need to know whether to enable AMSBC. Add separate helper, describing that feature. Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 8355ffe40f88..83d2c2a7116c 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -116,4 +116,9 @@ static inline u32 qcom_ubwc_version_tag(const struct qc= om_ubwc_cfg_data *cfg) return 0; } =20 +static inline bool qcom_ubwc_enable_amsbc(const struct qcom_ubwc_cfg_data = *cfg) +{ + return cfg->ubwc_enc_version >=3D UBWC_3_0; +} + #endif /* __QCOM_UBWC_H__ */ --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A871B3C4576 for ; Thu, 12 Mar 2026 13:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322184; cv=none; b=FpsoDzue1LBHwyJMuLAFQETcZHHRwrVcKTgVxnvo5jamhHEf3V+u2utnvUvAmj2oQ5hw91I9aqDuUaQD0DUfVxONgpRDOWLtww0JWESodSDTxJ0LnoFlDTFWmocSgp8jaD2VH95EIyFyiKhz/gSWnQg6lhsSwmQQpFdbt2zcEeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322184; c=relaxed/simple; bh=gndBRl4Z4xRh4kFQivFGZ2SUW+Ocdg1Tl9bo+8948vQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b/IiLY4f//Yw0IH6JjNdY1HxdAeS3Cd3aFn7BLhz8NWezdN74sQgnglvlzx6retKh6UMGJBXu6hJVEY5nK6ZloOgjlpMj+tfwRX2n1v2GC6QxjSZ+GK+zDcYk/nOiPx57xyXbF7LH/6NpyxZp2HVUxwCVxIQYSm1zfMx6tTAvB4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mgZcgscQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hzzY1X9G; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mgZcgscQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hzzY1X9G" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9x2Bc1756014 for ; Thu, 12 Mar 2026 13:29:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wdo2GXNLuey4il0IRDIYFRsck7+hcgeJ1IZK0URwteg=; b=mgZcgscQ02PjXWUx xdt+c8cv9/ydhBJ1TAhJl7H6Iy5889y0cZ6zTCSYz5+vH1/TNSIbXhSBF5Dr5jQc uETYOU8W5ZqwnFL2wh2KC7mIGTcSTWGMZHfXnPJE3LM/WAWKzY6e8ohXc4qeTzbk KnXaZEjeWeWWkvBRsqz0BUrep+IQqGY1kTIsgkVsGETOPuq52poNGWNi976EJ26k a9D1fEWv0DQAYl6Kvv8V7GUfvZUNbkyhK2iTyVeANyix5Nib2DV4jaGFpgswy/bI zBtVEjG6kldLfN700lIP6rJ7IqY7S+Wi0a1aQlZWVq0CocKTgBD46N8tNatpkwpv e0387g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53j6s5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:41 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd858e8709so1159229685a.3 for ; Thu, 12 Mar 2026 06:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322181; x=1773926981; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wdo2GXNLuey4il0IRDIYFRsck7+hcgeJ1IZK0URwteg=; b=hzzY1X9GHEC/Ym+s+8IosddfzCjAyCv/ssmAgR8a2hDJZfsKwBapjB7ZmPM7xdPU0d OpwVkIKEmo0EoTQLcI09XDv6YpW6RuV/delTuR7qFaYO5Q5VL1VeMf9FG/XLkhXBTwB9 pX/bjA1jiGDwSQCd/4JthIMBznbsHP/rZUq0ftjmkaz1AwbkbBpQwXjsln6qqytGF/G+ KIbCpN07+SxBypHLLKwkuha2kob2KWCzt7qQ+JI06Z1d5MBdWXY7BgqV2rdous3nk9Ti 7RXeF0xJR38cV8uKwG+qPupbnh0l8/LyyL5kfaGJsp3O4O7+wEExRZcfklb4/Pz8Lf+8 Vomg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322181; x=1773926981; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wdo2GXNLuey4il0IRDIYFRsck7+hcgeJ1IZK0URwteg=; b=UuCPM3+6vdyLAefWqdwLoEZcNSBYtRSnLEOunGqvOJX4J3cm9PRD+5HeRGQwwDX8hF fM399SIuaS/6wGEoYslyW1QztJIMlF95sYbbe6j25BJ6d8Vdm/mlLu+J0z/3Bz2JLfK8 0R06wsCvo6TMOP8ztSaWftuGhwodDT/wNuxX3QQYqXeYmoT0ri1ShFEJNqYCYNFXVDAQ PXYr6Ibw6V+YlcW4CTUd+dVZhwQAL+VaZblN8XtDEzLNUdWHxVee7AZwUyEF5QT3xDYR 47OHPGutx7unljlgJ8eir321d4Vp/022Zf1URmBkvRwIW6TReXzu8agnb3pd4IcS1XvY DKAg== X-Forwarded-Encrypted: i=1; AJvYcCX8DRNjEuRYRdjsOmsKimQ+PrbMGuomKyaMO2nfgj0E3EZ3k0/QciNOlHOfVFwMhtWB5wvYZ/P/8qgOjfE=@vger.kernel.org X-Gm-Message-State: AOJu0YyTf0qpeKEsJwrSBbEDbSaKHnEGkSRL4igg3AH/B157hhXQ1MXo jkXr+CsgU1xDscbFMbLobs3R40ZuuY5GVsCkyLLu/wTJ1FWk5V7/nd9rmeSu37oPxEvGq0GExw/ yoOxuxmU/FEGnX6cwSenBd5N0ERtL7jnZpEN9EDICwoOwMMKO1+wNdkRJ3xAQji+76j8= X-Gm-Gg: ATEYQzyLMiXshkeYIqwh6DVh+VB91ZgRRmkfnREqnRIj0DXycVWeOpmLXkIO863skC7 RK2+gQ1TOXsluWBtfzGd1c3Gb2wMleJEp3GlORCZ8NvATsipcWtp6cUJyhkwTxrUdaxXpC6t3dG i678a1cmcZWG9vHkEH//2cq35wg0Z+GYqDn1Klni+otmNAnSYAi/QXS3XUibW55u/eUFljQ0eVj oXiLSCrsIMiREZvWxx2l8NKpm+zSLYKaQ1UKk+i6lLQFh+0PKW0fK0H6cRqSLqJ3rwu7qL8W0M1 55MBd3jD1K7iROHfUWjdcLxUZ+HL61u9pcAhfu/5+Wm6meXBjwYh05Q9IXQJz7iT2sqWZHhNB80 WStj8iNMNen7E2zz1duNMw1wMxLXlyfAHpKiRLO3gtDy/UUyuh9mVDxDFuivkYg9fooX+oVkx/F JxCpeB7CYDPHum/1WDZbKeLSGxpH54jXS9tDs= X-Received: by 2002:a05:620a:410d:b0:8cd:7811:9418 with SMTP id af79cd13be357-8cda1a88115mr853818185a.45.1773322180977; Thu, 12 Mar 2026 06:29:40 -0700 (PDT) X-Received: by 2002:a05:620a:410d:b0:8cd:7811:9418 with SMTP id af79cd13be357-8cda1a88115mr853810885a.45.1773322180342; Thu, 12 Mar 2026 06:29:40 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:39 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:26 +0200 Subject: [PATCH v3 05/27] drm/msm/adreno: Trust the SSoT UBWC config Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-5-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5880; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=E5AQkqpaNuM1RXBAxJ/mn1wbVur7sOZpcfQb1l6t7DE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1ZZ1VL0esfykadZwLa20M9PyGGoGxQofe4 2145JtAJhmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1X69B/4wo2C/IzVyMnnSwpzQ/jCwMuw8tqFrJpiAekQksRWYKMAAbH1gSHDbCCcpEs8QScqudu0 Y2W/GMoXe8sEuxooXs4fEyzPHR7/lPCcSnHUmxcznTrsm5Wu/y6Llxg3dfFNLi9eg7w3bx+g+7i v5cLkcYyzchUo+HVgSYPLIxIi4G6RmAa5BzSGSq5a6Vyk8BtnHFdTeLnvDHKzhyeIlAu0XA082/ x2YiGE1j8AyuAtAkS7y3nharboer8I66eVcS9pu5V5yv+yzJCbIsCittxDXIC5QVCJiZp+SiMg6 cK7/9q+pA48OVjPavOUt/4/FTDXSbELmAaCus4S5sk+iXJwx X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b2bfc5 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=IhcC-CrlSmvFA89tYH4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX130TxuoOQemZ uoTZIpqVw1S9fKQqE9fab87FEkfkVs4N0MLFa9aWtgwIXuesRiuElZY5sLdNwtNaXURHMcyHmcn /cVnX50R335qjVsZ7lurZ3yDqOj911Wjmqu+8IdgGUNFOo8lRPy+W+b94rbpAl30WdlUXwEeZr+ BAKS9QgwLQltM4MlJfEtaVHsQlP5hqGChrGVI+KT0gfCxe3mCxubWKkIsAKkGsJ8/Y4gT8OrpQq kpNtNJbvUKctcuJXZBCAjgT/QazAV1ruIrDLFJ2/935k/uwghVxXjoZ8yed0qSwcymVPZCtVbjp dNkNIqyolfbYdzFf8jE3EzDhKz0LoHyOGZAUnzKUsUld6z6Sq6ZBVUVLhNxH6gw6qb7InJ24VHS gi88Fx7cjpG6Uci7UCeRyp/4Xr5qnbfSC8Id3yn0ywzJBO1HnCvY6Mo/NFgSp8W2++2uF8GI+vk 2FFme8RCuBzbGVFEGpA== X-Proofpoint-GUID: bw2Gw9gVylkhp6N0yj_LHbVvhNm7Rvxx X-Proofpoint-ORIG-GUID: bw2Gw9gVylkhp6N0yj_LHbVvhNm7Rvxx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 From: Konrad Dybcio Now that the highest_bank_bit value is retrieved from the running system and the global config has been part of the tree for a couple of releases, there is no reason to keep any hardcoded values inside the GPU driver. Get rid of them. Signed-off-by: Konrad Dybcio Reviewed-by: Rob Clark Reviewed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 11 ++--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 82 ++---------------------------= ---- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -- 3 files changed, 6 insertions(+), 92 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a5xx_gpu.c index ef9fd6171af7..513557741677 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c @@ -1727,7 +1727,6 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_devic= e *dev) struct msm_drm_private *priv =3D dev->dev_private; struct platform_device *pdev =3D priv->gpu_pdev; struct adreno_platform_config *config =3D pdev->dev.platform_data; - const struct qcom_ubwc_cfg_data *common_cfg; struct a5xx_gpu *a5xx_gpu =3D NULL; struct adreno_gpu *adreno_gpu; struct msm_gpu *gpu; @@ -1765,13 +1764,9 @@ static struct msm_gpu *a5xx_gpu_init(struct drm_devi= ce *dev) a5xx_preempt_init(gpu); =20 /* Inherit the common config and make some necessary fixups */ - common_cfg =3D qcom_ubwc_config_get_data(); - if (IS_ERR(common_cfg)) - return ERR_CAST(common_cfg); - - /* Copy the data into the internal struct to drop the const qualifier (te= mporarily) */ - adreno_gpu->_ubwc_config =3D *common_cfg; - adreno_gpu->ubwc_config =3D &adreno_gpu->_ubwc_config; + adreno_gpu->ubwc_config =3D qcom_ubwc_config_get_data(); + if (IS_ERR(adreno_gpu->ubwc_config)) + return ERR_CAST(adreno_gpu->ubwc_config); =20 adreno_gpu->uche_trap_base =3D 0x0001ffffffff0000ull; =20 diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index d6dfe6337bc3..6eca7888013b 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -729,82 +729,6 @@ static void a6xx_set_cp_protect(struct msm_gpu *gpu) gpu_write(gpu, REG_A6XX_CP_PROTECT(protect->count_max - 1), protect->regs= [i]); } =20 -static int a6xx_calc_ubwc_config(struct adreno_gpu *gpu) -{ - const struct qcom_ubwc_cfg_data *common_cfg; - struct qcom_ubwc_cfg_data *cfg =3D &gpu->_ubwc_config; - - /* Inherit the common config and make some necessary fixups */ - common_cfg =3D qcom_ubwc_config_get_data(); - if (IS_ERR(common_cfg)) - return PTR_ERR(common_cfg); - - /* Copy the data into the internal struct to drop the const qualifier (te= mporarily) */ - *cfg =3D *common_cfg; - - /* Use common config as is for A8x */ - if (!adreno_is_a8xx(gpu)) { - cfg->ubwc_swizzle =3D 0x6; - cfg->highest_bank_bit =3D 15; - } - - if (adreno_is_a610(gpu)) { - cfg->highest_bank_bit =3D 13; - cfg->ubwc_swizzle =3D 0x7; - } - - if (adreno_is_a612(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a618(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a619(gpu)) - /* TODO: Should be 14 but causes corruption at e.g. 1920x1200 on DP */ - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a619_holi(gpu)) - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a621(gpu)) - cfg->highest_bank_bit =3D 13; - - if (adreno_is_a623(gpu)) - cfg->highest_bank_bit =3D 16; - - if (adreno_is_a650(gpu) || - adreno_is_a660(gpu) || - adreno_is_a690(gpu) || - adreno_is_a730(gpu) || - adreno_is_a740_family(gpu)) { - /* TODO: get ddr type from bootloader and use 15 for LPDDR4 */ - cfg->highest_bank_bit =3D 16; - } - - if (adreno_is_a663(gpu)) { - cfg->highest_bank_bit =3D 13; - cfg->ubwc_swizzle =3D 0x4; - } - - if (adreno_is_7c3(gpu)) - cfg->highest_bank_bit =3D 14; - - if (adreno_is_a702(gpu)) - cfg->highest_bank_bit =3D 14; - - if (cfg->highest_bank_bit !=3D common_cfg->highest_bank_bit) - DRM_WARN_ONCE("Inconclusive highest_bank_bit value: %u (GPU) vs %u (UBWC= _CFG)\n", - cfg->highest_bank_bit, common_cfg->highest_bank_bit); - - if (cfg->ubwc_swizzle !=3D common_cfg->ubwc_swizzle) - DRM_WARN_ONCE("Inconclusive ubwc_swizzle value: %u (GPU) vs %u (UBWC_CFG= )\n", - cfg->ubwc_swizzle, common_cfg->ubwc_swizzle); - - gpu->ubwc_config =3D &gpu->_ubwc_config; - - return 0; -} - static void a6xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); @@ -2721,10 +2645,10 @@ static struct msm_gpu *a6xx_gpu_init(struct drm_dev= ice *dev) msm_mmu_set_fault_handler(to_msm_vm(gpu->vm)->mmu, gpu, adreno_gpu->funcs->mmu_fault_handler); =20 - ret =3D a6xx_calc_ubwc_config(adreno_gpu); - if (ret) { + adreno_gpu->ubwc_config =3D qcom_ubwc_config_get_data(); + if (IS_ERR(adreno_gpu->ubwc_config)) { a6xx_destroy(&(a6xx_gpu->base.base)); - return ERR_PTR(ret); + return ERR_CAST(adreno_gpu->ubwc_config); } =20 /* Set up the preemption specific bits and pieces for each ringbuffer */ diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/= adreno/adreno_gpu.h index 1d0145f8b3ec..da9a6da7c108 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -237,12 +237,7 @@ struct adreno_gpu { /* firmware: */ const struct firmware *fw[ADRENO_FW_MAX]; =20 - /* - * The migration to the central UBWC config db is still in flight - keep - * a copy containing some local fixups until that's done. - */ const struct qcom_ubwc_cfg_data *ubwc_config; - struct qcom_ubwc_cfg_data _ubwc_config; =20 /* * Register offsets are different between some GPUs. --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27D8C3C870E for ; Thu, 12 Mar 2026 13:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322185; cv=none; b=ZTJgBamhKrFvBA42sx8FLTa0TTduKvF/UbwrEPdzp9/IhXnUGhcWURg2uQnCV9oSQFOaeKQ3eESCax0tHQhYOUGgYSjLfDb9JkIQTwSfon/q56wTf1Jjd3ffMDsrQNX9jtLoKv6cWjWx07k7UiINRGXcydiL/MPzOMfGltgrXGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322185; c=relaxed/simple; bh=DQjdkhkQRL9h9cv0XC/AXKUXCFPEB+rX9LBo0dUvSGs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZetLU28R1LilSQ62TN2tEXFa44gVsP+bVh3rzwWH5TLoL5IdyV0pok2p3ykcM6eMaY//BNrnDQ6+wmVQLPO8VRFGqPAlNq+A9/cyBYFfwANrH+aK4eF8V3aFWrEO6RnYTHH55dVgP0wIAs48/Ol2OqeZoXG7dzjqypPrFFx2tp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bG521vMv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c1BKD1SF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bG521vMv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c1BKD1SF" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9vLoY3668464 for ; Thu, 12 Mar 2026 13:29:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sHFCV47opCKmI6D1ocvZj16p1AvAwvvCv03JYIx/BSQ=; b=bG521vMv0yieGuBN dmFKWcfXKc9GMuUgr262oyG6+/HDAFMo5r4scp9GhFmmxsCzMTafIcsJu3HG/KbK Abl2i0iM9/cpax9yL/1Ld6jessyQr1w3xu6+EuMAZyRr6iXESoTzUe54++zgSfm2 s1CpRHFnmbHP4ty+9/a8/37X7b7E6FaEAqXewmfz2EobEzYsfs2sWcLjX5Y2v5Lx WyVcB7G3ypXX+iDp4vjqtHb+2VjLOYWCDkWyxBHqaRJoCIC6PXKEWBdAzN0Q+z7x mx+KX0y+IkbtQdK9QOUlnbCsCoy+tfAoN/zMuzL8ri9JN1SDNt6eNsiQW0rCy7qp o7nQww== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh60j7sr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:43 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-899f92be718so63506666d6.1 for ; Thu, 12 Mar 2026 06:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322182; x=1773926982; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sHFCV47opCKmI6D1ocvZj16p1AvAwvvCv03JYIx/BSQ=; b=c1BKD1SFymQiXVRmVQUAwLBIgSPUQsvwXlDZ0MF1qM4RGRc8bbDoS3tLvb7d2m/nzP vYQoUDq1KK5kctPWYTcAaocNfHa2g06b5nANiHz2I7H84KykZxLUskub45xX2+R1lfB+ WtVXUNXyaP3ttS1rRlM5j3ooNzA4R3rIjUYcQykwHayLnPioHS7dPXzQ/0IubulpZRcJ 9lnoi/gN9CG0lr/SsdSJ52DRXrUi6OskDx6rmEHFSbtxs5kG+CDCfy33q9dlI4knawwZ my01sWVVLt3/9aIX8SVXP+L+9s0loWCi0bLhYtozFrNBFuRIUPWtwCGmDcUGF6IVmhk8 Vj4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322182; x=1773926982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sHFCV47opCKmI6D1ocvZj16p1AvAwvvCv03JYIx/BSQ=; b=P0DiZJ2EEYX4pg8UQDFpdkadsth9GgunWSzZXpW0ZL9Jc9VEZHUBuLlCc60K/oOJg3 kLVbA4WaynosAq57Gcdshzfd9vc8eBC6lHUB139cgcXO2l+D8Z/jzrQkGPq+WvebXTFl 4+VY7pkosFW0aauFTwAkNDU4xG1kymbGBm2p6JEExyFIM8J+87usy6yTK07bKGNdQnkg pK6EZFaCkqPcfhoeKU9WXYCfnl6YElwZ9D/KPGaCJg2lxsPwUkC5g0+fsOSQf0VVvhy5 Z5l3mdwEmWKpYgbmqJlSalgS3/F7PWI7kK09hyFjsUzjew05gMtdlcKN4EyT5iD1sMJq iwmQ== X-Forwarded-Encrypted: i=1; AJvYcCULk0pRYe7nXZfFybVSKr2LWGwsKyqD9u3xp8Uxwz9R0Jw29KoPMSX4CDVIqTEjE8RQpwaQJX58D4SJrMc=@vger.kernel.org X-Gm-Message-State: AOJu0YzatYowLZptR3mooGsYLO9MnQuXS3r/7vYHGbWBKHOaMKs1VQZw z3v2VjcprOquWX6KbT7jS94ckAZuxkLqkmzIVvB0kd24/vGvfov5JccQGmaaz88hC9ZZXT5kDub GKd1POLs/58PUaV0OXZbI2SgatTlqkUeWsc7kSRinGUgjh1MDa2gXf3QVgUy4XoY57iA= X-Gm-Gg: ATEYQzyAz1MNXPrmVJ8GNBIUc/EVijxtfV8pxP7jSikrr9OdtXJXKP6ziqbMiehSP5l VWTG7R6LsFXfwlVyciSXmAvQI+JVUivxtwXzPdN6Ag0ti6Om0r1S3RppNqJGkHP/eeKPG9uTPhb GllTPu7IXITVSIkH7ooDQA9Kb+zvkPgwDLNhK/1rJVZZvI+Q5shYgGZBgnmG4s8IXjaD0YZ9OEN iFO4wxjjd7h/V1CelTjlnFxw/6wfS+cFxGKV/L4CyU97AghB8XHJfRMo9xsD6bWXORq9Gl/N+yZ 5NtEgJv28wO9dNlDYkL8U3e0w382QDr/TqSMBzJRJxd62WofZ2+wla2iKcbBWBC0IfTa5Ub+Eac 6BK262nyHxrwWzYhH26/oY9/9wtHOZ1GMbUfWm9LsiiU/+FDFkUG2CoHh9MnvwiKpu2/Bw3aADV cHUPwSpJe4d3YlYTJ/76B6lyN37BNMrz4S0tA= X-Received: by 2002:a05:620a:4153:b0:8ca:305b:748e with SMTP id af79cd13be357-8cda1a5595fmr745380485a.57.1773322182348; Thu, 12 Mar 2026 06:29:42 -0700 (PDT) X-Received: by 2002:a05:620a:4153:b0:8ca:305b:748e with SMTP id af79cd13be357-8cda1a5595fmr745376285a.57.1773322181888; Thu, 12 Mar 2026 06:29:41 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:40 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:27 +0200 Subject: [PATCH v3 06/27] drm/msm/adreno: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-6-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1565; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=DQjdkhkQRL9h9cv0XC/AXKUXCFPEB+rX9LBo0dUvSGs=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+am/VtnHMnvvR96T/uUSHm4LvOX8pl3BBIeszYfPXB6o 1XfovTZnYzGLAyMXAyyYoosPgUtU2M2JYd92DG1HmYQKxPIFAYuTgGYyPF69r+ye1WtdxVsL73B /KGFXdA7oo3/dcjU0OC0FXfDtER5jqxbbPeiX/6EZekflc2C7w88zdlqeI+t1ijjqg1veUF84cN t67JnLJ7bHv9t0Ycgh4Kr75fkzZe3WPN/f9hEXavrzDplFb9yE5hO/su1vl577OzR5TcL7ttMEf KTD56Y/9VOsFw91PGydvrUB/LmibNu5UVdV5jSmGXzl6l24faF77YbPQzYuDjt7aYp4kXfXy06X XeuW7y+Y6nru6ajVgV3u1zPenBpcTkkbujSZTsqmNbL2WMe55UQKKy6+bGMilCwhRGX7c1eLoao hthbqS/T/4oHbV12vaKb6WamVX32gvpsidC+kGhmN3leAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: 4iU9lnzCjCdjmO8XuAizruo--dYbVbGj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX8tVm716h3Cb2 bfxv8wxtmQ4bHHbIUI2E/4+Z5CxJJPIoxX9ETmXS8VAJH7OwpOruh+xHbvi+Z7ss0pvqm24RONs JRvACOm0/Nu0Y9lZMWdjVEZDSaB/V6GEy65XzjDW5892I2T2TclCskAGkseOoL+c6GyN5OIwtP9 wzOPSbiBzRt/XY/EOZW9xuXb0/VlJz6RcofH+ZWrR0Jo0WZ4/rZp9lS0NCXRuV7dDXXQktzp87Q zHYALhifFMoo6lx+zpaNsjfcRUIW3ce4s3NvgHk3fPDCTfbPa+EJ/Ntk1C9oOwfWfuPhR1IUXzQ qm9X/qj5sOvSFBK+ERmmhw6azV+XED4Nl1txgBMHHZAjBw2bhauF4BUDgCXupIz89JR5grQDtwO pvhsMtXZ8ScBUe2Fo2RfSHVUYLurYk8cI8+YJ7soigDKOf9PF4ie21B4MBZaG+Nztj07bZzuLn8 ZUF+gn6amyWuDTlEALg== X-Authority-Analysis: v=2.4 cv=DsRbOW/+ c=1 sm=1 tr=0 ts=69b2bfc7 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=xoTxleRWwXRO4XdZWWkA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: 4iU9lnzCjCdjmO8XuAizruo--dYbVbGj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index b1887e0cf698..6dc1d81fcaeb 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -272,35 +272,33 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator =3D false, amsbc =3D false; bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); u32 ubwc_version =3D cfg->ubwc_enc_version; - u32 hbb, hbb_hi, hbb_lo, mode =3D 1; + u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv =3D 2; =20 switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; - mode =3D 5; break; case UBWC_5_0: amsbc =3D true; rgb565_predicator =3D true; - mode =3D 4; break; case UBWC_4_0: amsbc =3D true; rgb565_predicator =3D true; fp16compoptdis =3D true; rgba8888_lossless =3D true; - mode =3D 2; break; case UBWC_3_0: amsbc =3D true; - mode =3D 1; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); break; } =20 + mode =3D qcom_ubwc_version_tag(cfg); + /* * We subtract 13 from the highest bank bit (13 is the minimum value * allowed by hw) and write the lowest two bits of the remaining value --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1AD3C73F6 for ; Thu, 12 Mar 2026 13:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322187; cv=none; b=DxcrcsgRR8q2NYvApam498WeQuC0QljxAWY4BnkYVipG2tholP4iWpMkgkQ0N7HYgrPPJ5z7Az43NUk8YQ8EnHGJWlSt8jL2zDPWv8EK59xHEdmUnsjWfFCD7osurnzJyuNm5QXIUB8oh8G+xh6ctiNGlZkISZeAR85bxEs/qCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322187; c=relaxed/simple; bh=xO+dmVKeAgw+NPDr2h9siH1EsNMcwlIuWzCr5f2QIyw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GEhOW0DQC18uZ0BEdX39NpTQQhYu07pwRfTrP0N4ekbclj9Ap3PkFgDqqEwK4w86LPS97g2HWnAmqRTGY3j9xKevZb3mUBqgZAjZFnIFZcPijZjlmYcgO7wbo28c/4MKErk2qvsT0UDOkISqmMx2lRADOlmY+egdxGnthhsiSE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NK9vMxAX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LLaryOIm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NK9vMxAX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LLaryOIm" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7eF01510100 for ; Thu, 12 Mar 2026 13:29:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=NK9vMxAXLa+1OCQ4 /RNDXVlHxuqQ7vlDp6mpnN2BZqNsfMjUy/P12K0O0EmB+hLGVZ9VUt9UOYHxNra0 DwJkI3CnW+e6XOLsc5VBNv2EK2wf7jAPtZLyjr5BbPNwLfAS9/rx8jDt+yY1CgrE JBN66tsYUTlxI8CBbsdrUbfockLi4vESGpNkmn5szRSIJv35cnSaxvl5aZhIqUce 5vmMYV2uUvfp0oZbH4f087OzMrCpDXFdAqEHQOULmmhEUGgnsFluO4ldo1c6ooi3 LOCQA750ZcnQ15hAMllFf1V6UyavnHuRNkwbEv1Ui2+L/qX8YhPhyz1xheUzGDTt 3ClSFw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vbf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:45 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd7774be64so603688085a.0 for ; Thu, 12 Mar 2026 06:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322185; x=1773926985; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=LLaryOImPSeR5CrIZnalCYA3cz57I3UvzuZI0gXeZtavr3WwzqYNAddyEksBNCWVAZ NzLd5enmqfWOFPxyKYLlwN26lRynO937xPW75IUJ6oXscQda3UBrmLDsrl4HP4Fh1I8T 8qQj8o0sKBHlgK6lNZAeMb4MJtK1bjoczj65+mIaKHryGzrNTmYt+o8Q0ZCGbBGATOOh Rc9Z3h36udg/1BnmOigaO4sqr51SAtGtkqhWumPs1VdCPeimestAVyjfHxObP2SFNDff WX6Az2sluf4CJWcI2EnsufsdIc58OHcCJ7JW1KqKvvExjI1h7bA6m7fY2gZjfz60Vdyp VJjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322185; x=1773926985; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IE7+voqoAHNNKrIs7WzVDBWghsRgS97+vaqd0IwCOgE=; b=XYyN4o/ZNEwH/ElfouA2yATnnfJcVLkMpT7ZKXcAxRmDl8KtxAb2lMrnvXY61L+Iyl PNOnJ5XFpeLbIRc9xI8OKrVoLLami5BB+rDrnvE7EiwpBW5wTr/FZPOOUrUXSnS9k2/R m7HVCNKjTxZQw3w+MAEbqAX6e/Ho4/KCgeeE4e+TnE8djz5ng/+zvD/uqmWTFA410eSQ T8IWYumB3yNMy0q0dg0xqMDboLFg8ZqgE/NekP5oL4wmCDlHR7m4kjpBkp+KONqaruJE XiKfRDxSH3pbRgnNnN/sGKgJRQGo9Uvs8Xq5qT89lGWkwqlWqxuWitXnlkF3M24QM/z5 oX5g== X-Forwarded-Encrypted: i=1; AJvYcCX5Tiry4SbGdpontnLnKGV8DjV/QFn4HZpFg5rMN3XBaJs62+4AY1a6/oFwEhMM34kfO1brVVdKqA3SLb0=@vger.kernel.org X-Gm-Message-State: AOJu0YxX3IqBwusal7abpb/PufbuK0iB9ZdG+03x0ShKhkwgSanmPbzm 7G9rDMZPaTnfz86o1QClOIP1N8xYrv/HyovASC4eIFwGWlDX7oe8XHj9jH4aQi/5LZVNarW0LT7 byUOZxuQ10XMurVdPwjCHgT6ShFptj4BjlemxCGtkemjP35m61lMgFImTaqk3vp4np0w= X-Gm-Gg: ATEYQzx1ovt4wX51/EEL5Rh38749EtLLC78gcMbe/IlJvOI0wLqjxUicRQf1qJHP62g jWOfKZG5u+5irD2uDVZp0BcwBjHDgW0bZf5Bh3KFUI9aJJL2EWmKLlAxIIrUQi47mZX6zjr+Yl2 EntoaJbh/usyrb4tzWy5IMtiO8gJ8yAefgBzJbTNod9F2m5K/4eoEcGubO+qXdKr1hIn4r1hrfJ LJfgMaSXdCnMx1hzQGRfkCsXAyLgiJE/Y1k/gujNXvK1tRv3y8QX05/N/LCW/+2jIwg3CkeSxrE XTC0SLJ35w2OmvlPprvI1BIUMt0rQw0eZhFWhXPGXDuP8Dhosdh/u1g5lF9beMfw001Yf/wyURr NjkPYX401StDvMvaQqtGQKTljvHvrCWkfqpeY9Pm0Sh0VyPFRKELsm5bDBV0TeQrJvKJbXct5CS nP7GwQ4mFtdKnGUAiSLW1GGp4fcieuGlCKLyc= X-Received: by 2002:a05:620a:2a06:b0:8cd:97a7:a334 with SMTP id af79cd13be357-8cda19bb33fmr749042585a.4.1773322184987; Thu, 12 Mar 2026 06:29:44 -0700 (PDT) X-Received: by 2002:a05:620a:2a06:b0:8cd:97a7:a334 with SMTP id af79cd13be357-8cda19bb33fmr749039085a.4.1773322184565; Thu, 12 Mar 2026 06:29:44 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:43 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:28 +0200 Subject: [PATCH v3 07/27] drm/msm/mdss: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-7-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1662; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=xO+dmVKeAgw+NPDr2h9siH1EsNMcwlIuWzCr5f2QIyw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1jVZdIm4Z5c9SotutkxEHFGXzgCmOArpB8 PqwvUHddbyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1aqdCACzDFSUZDp9hHVRuPmRYu0zC16Brt8euwkDH2Sl1Y9E0w8FpOJTHSXVaJFuoE+BmChs6ao UGCBQ3NL87uHHw3x+8JCMXbaIRuo/4HrR9maQ93bdxtGRZiHrTN/sr/LR5JcgOxsbsTjKoW1euQ FO6gVqu+ArbG3jxLUonRzhBk2E2PwSaC8v39zYBnhNs+S6Z3vXrFo5wKf4OdlWOuijXHI60wFeE Bwpoyk9m94uTpd1mZr/WjTc2Ult0FANct/wvS1WxEf6BhNGgEpziUpe3P90k3FuDaFreSPva46V rO+JFmwrOvnIKRju0rm5E0jU3lEWww+jzGi90OUGq7EnLt/X X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: laZu9R9CUTHUhXXpwXc4DorgPGGhTsSM X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfc9 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=qBJULKV797PGQuHHbA8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXxBvR8EkWGNsP uWmAfc0uYzRqlcKd7cUI4rN46UOFkP/2WWiUUREENWtu8EXr6RbL0geCQqJnfzKSyGbUaOhZDB7 /005h0u9s4dA03/mjFX9ccyqD5XjC1qvHxjsjYnHG1c1XA1GdNBdnc3XI/BbXJBuOeweoyXB79v +Y3zOVih7qmiH8kkHpO9dwzU0NEd31CdBYqiyrrYAydLqLsjVde702GWsAcphfU2mWBq8heZdXB qcqPUxfapdYoWum1d4pLFUKa3ye06UUMUzLHO+7AfINNF07ewhU4yPVHmUHXlsmAT/vatll4sPW w4a4pXbFQNO7clSc08Xw5h4KIAl1WEJ4DgXuFFlYAKpbbEqiYfwUppvxUpaKgu5DXVrqEx+bwum M/Oqiyry2R4RySZf0bEM502ZbvSK4pD1tOzEo1fKtL8MP3SXt+gM/ZtjE+evcnBSOgLsa7jpZ12 +Q8tWujLBfy03LxGTIg== X-Proofpoint-ORIG-GUID: laZu9R9CUTHUhXXpwXc4DorgPGGhTsSM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use new helper defined to program UBWC version to the hardware. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 7cb8aeaa7ecf..e2ec1ee590e7 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -201,7 +201,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - u32 ver, prediction_mode; + u32 prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -219,20 +219,8 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *ms= m_mdss) else prediction_mode =3D 1; =20 - if (data->ubwc_enc_version >=3D UBWC_6_0) - ver =3D 5; - else if (data->ubwc_enc_version >=3D UBWC_5_0) - ver =3D 4; - else if (data->ubwc_enc_version >=3D UBWC_4_3) - ver =3D 3; - else if (data->ubwc_enc_version >=3D UBWC_4_0) - ver =3D 2; - else if (data->ubwc_enc_version >=3D UBWC_3_0) - ver =3D 1; - else /* UBWC 1.0 and 2.0 */ - ver =3D 0; - - writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(qcom_ubwc_version_tag(data), + msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073E63C9451 for ; Thu, 12 Mar 2026 13:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322189; cv=none; b=TQrKJBgvrtUIWAKphktkyC+zV+sggCvjzLCktLnOG3EBrYygfw98+jn92qzj3gEKhkD/pWN44/XL8B9C/cYqIkZDKzQsBq4VGl8P4hxYOfAkIb/1AFBPmDd/wFjT79EPC94k6OCBKkTmgW4ZVitj6c8tTZtLVX6tEoDRNA2dx74= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322189; c=relaxed/simple; bh=vcRHbEAGLYLgXe4iaZftIzhetGkuS44tvnfyt/ZXY1c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TtMUe4dA36I8SW/WQrp1yEFcLzDwZP8Ed91/vUOp84bVJLkATRvenFpF7PiPOFl69htv8oegpSAid4eVa5Ty/28yFfpsai+Li7sA6dM7MqEw2DeE5+ftg9iqIMUsUqc5QMcgv6LWiKwIrBR+mnAxjqNHJkK+6FS3FXEKuilHsR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IlvWnZY+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KTCNo93z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IlvWnZY+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KTCNo93z" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9PmFF4027299 for ; Thu, 12 Mar 2026 13:29:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=IlvWnZY+mW3yuJLB 60borKwhsVIPGWbcwdqQipWGHZ8lFPiDl+WjkyfhrKIOn/prUIQw1O2SeLgrBGaj bidNLEEZ08qfNh9CqbrCRUmV6Il8LthjjOh+LxgFi+hlWEQ6vcXb4alwlA/5UB/3 niBja0IKTPWjICEiUuEvwLMVz7m0dEMpGqb4nq+hd0tU1O8gfcgWeoZtQ0eHg2OW q1TV/Nbf3IYQZ8JVkpMpvm6pzQ8WSFqBYKsDhqBmyM5e+C9ze60rb5XJN+Osz17f YBDbEFe99xQvAm4YRvOWbdlnMfX2+jkt+z0AVqhBuK6KQK4JWLhrAfxKUpf1PIvG TKWRUA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh54t5rk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:46 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-899f1c1e4d6so189222076d6.2 for ; Thu, 12 Mar 2026 06:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322186; x=1773926986; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=KTCNo93ztSoGp1XmLiIn+aPuitl6NLKkd8rXDS2/A3L1zuYbCc0XLxaeFG7/VmxEO2 ScF3Pvo7H8PN/Cs4hKtcFRYR1NwYyXCRnLJGWKf9EHLClYFKyvhsw3fgBR/2ASDaPKXD uEQc2Br/iJJDRD1BB1OALCIt6CuSHORdVMImKna4+P4wh/EANUNah4XJBRT0JMUpkRiP 3CIeKrR56t9U5KVkzByh0RtZe7ZC7F7xiVUj4QtOGWf4vzb3b3002RNUN+1KxTCt2uMa yHw+jkQYehqOtnj8ufSDQDXvdGOa4qSdj42R9oCCdmxcPsfxxPpg8QtU9IdrQSGKOTwg cUnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322186; x=1773926986; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tABjXUq/OjxQFlltJI7qwEI7Ulj0yf3Q34M6i0RzZsQ=; b=oG/LkrZ4lFKm0muG/XAzjcr4jRCwFtZ7WuUcytw/qLsnsk3kOqyqekp8sPk0SeHCbt 1D+q4QLszidJtypGXkQ3oYRWuwSFoWD0E4zr73O+HtSVpWZ2kItWgWuZz8one3mjul/9 73bZTI/JVbKCq4I1Pq4n0JPbeMB5KWEU524vKYmKVczT5jp+EalaLyO1xbg+no+/rMh8 qEnIUnuzGMAuZVQ4Hs2gW750eNWy6igs6HRK2BHYSWaLnCcnBT+SYG4onMqzjwhU+vFX nq0Kr6ZRKIduEHT+v8havPwz4jym+fUxkcSvf/Dd5FRohX5665IULfYnhdFSkl6LTpNF kuqQ== X-Forwarded-Encrypted: i=1; AJvYcCU4LUc2BKbFsXmu6KUxKwVOfKLlQ6L4Y/dTI/8XXISt7ut/zPi7XNRwRY6RIKmai6AYPlATyxWdlfz/S0U=@vger.kernel.org X-Gm-Message-State: AOJu0YzlDub54W7frRGBFNxkTjK2IvIPB971GivNbyY6uYse+/OQpbtP E0ejBESFQBhjyKcUQ8jLHRmJomRUXNIeUnT9/hFS8s9e0Sur6Csvf4ywhV3sfOMLBv5aPuC4V57 qcl+GTKsVZhQZFRmJE0ngqGGPnYxT5bNEEz2hbHWf3BA23r/rphnBu0aa7Jxd5czl/mQ= X-Gm-Gg: ATEYQzwRvKhMtJAD3v3I2XLGDSgZwdXBfPmPX2KQxffzm22LM/pZsDypM5JN9U81aSI Mw0ndvk9DB7TdkesJfPjCcipd4dtejszdFSV3TrBe4M98g2csbK1LN2xfsligkqbL3j568kOaqG 1MMVVsQsC+EBg1m8+x10wgsmN7BCDKh0XEKI2Z4aRJrTvIZvlvOQPTYAGStLVVlRnc70WcZkNZl t4uLVfnQE5UgxIWyhFgZzezi40oNHupa3acN5rGu5/9WouSyPe+1dYypYv9xLPZLF4YNCR+zCL3 sHkJrOWkxxFI6sBp5iwf3uyW92yvo/8tZREaHTXYAgaM2UfnRmI5PTnRdeIsmuAR+n5zaHqezw9 5cUiPO1RcjAgxDtD/JVpFgj6+/hW6Z4YMbUq6nuzCr4lxhRniKcJBMLLMjQpSq2PasJ9yCk+hEz YGel5HMfUjBGZpjUu4F8dqNRuIchil3WHds48= X-Received: by 2002:a05:620a:2916:b0:8cd:8ddd:2699 with SMTP id af79cd13be357-8cda1956f9fmr801124385a.24.1773322186386; Thu, 12 Mar 2026 06:29:46 -0700 (PDT) X-Received: by 2002:a05:620a:2916:b0:8cd:8ddd:2699 with SMTP id af79cd13be357-8cda1956f9fmr801120885a.24.1773322185943; Thu, 12 Mar 2026 06:29:45 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:44 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:29 +0200 Subject: [PATCH v3 08/27] drm/msm/adreno: use new helper to set min_acc length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-8-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1349; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vcRHbEAGLYLgXe4iaZftIzhetGkuS44tvnfyt/ZXY1c=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1rj+PHUNlD0J8j3P+ZVuif5d8CEw9DAHQ5 ab5tj69UE2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1XSjB/43r7ue2sSmqHbXg7+6qoUEbRedeQX3JwYda/B/TL6hkDaz92L4KI85wgZFVOJ46+V6C1Y LqWePdp5OnhNo4QXCFSFY8XdflEfMhWA6mCqo6ifFJ9qF9x0H/z+4jsTMqZ4sxPcylTcaLg2Eo9 eYR29itoR1+Tk6aQcQ88K88I8g/SQoH+24vB2qudT5X6mvmnbJBqp0kbbqMKilWPgXPsJwGHpmr G70fHNeUKKjR3PRpwcDmLkRubSg/7Nh/9h0LwaWee9DNoecIAWVBvvjBdT5ujNbDr152Gb3wKQu /fVGIPQtzaiQX6AiuwtDtQTAcqxCO0SkU7NI1J8dU8xeS1vS X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: q1ltpJCMKZB_ejITfurFNX7_iorpGzE5 X-Authority-Analysis: v=2.4 cv=BNG+bVQG c=1 sm=1 tr=0 ts=69b2bfca cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: q1ltpJCMKZB_ejITfurFNX7_iorpGzE5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXyiHQ9GT1HY1i NzOWnt36HjyDL7cCwKeTI3ljB0UxO33PXxCji2EiN/Rv2oh+dJPKoLMwZFoC2vA6SN0Id1TtETf ji5jG7rfN9BgJrUzX6IRfq9Ud+PZvCwCGXxRiMy18Y81UnSjycc5BBSZS5WGVh3bWL0azrm23nH VLA4qnVlkmbk9MPTXExQaCl1awoDPNuvOllr/Qp3ZEGFnwgH5MB+z5xj6nrLzZxUtVANMuY8EMv iDxmIp0EfUTwjwPRSjIdQEhNv9vgGBvCcaIDBurtGeLo3AkAOzxalFvo6NFDPaoBWOhxsSmP3l8 rBNK0JT3qVtxRzumQVABk3BRefi150h4ThU7b4Jwc5n65zVaOWquo9iM77JsiYLy2dJbcszj5Id 1dmhbG2VvNPKgEMrmIGQK++ePzk+9bm9HCEVVDvhaCwsexJy29ZAn3hxk5gpxb6ENkTb2HySS56 OU+BVYIMw1KTIOu5SYA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 6eca7888013b..2027e479d5b1 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -744,7 +744,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; - bool min_acc_len_64b =3D false; + bool min_acc_len_64b; u8 uavflagprd_inv =3D 0; u32 hbb_hi =3D hbb >> 2; u32 hbb_lo =3D hbb & 3; @@ -752,8 +752,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) if (adreno_is_a650_family(adreno_gpu) || adreno_is_a7xx(adreno_gpu)) uavflagprd_inv =3D 2; =20 - if (adreno_is_a610(adreno_gpu) || adreno_is_a702(adreno_gpu)) - min_acc_len_64b =3D true; + min_acc_len_64b =3D qcom_ubwc_min_acc_length_64b(cfg); =20 gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL, level2_swizzling_dis << 12 | --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F97A3C9EE7 for ; Thu, 12 Mar 2026 13:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322191; cv=none; b=KWptYj9wddydaEJXR8kEjFihQlNrDGRP071MB4Mlk+0JmZEEsbya1aiJNimxHrX1uYaQZeLgwFSx0B+g//HDousLfZUKE2zVNMnDnHcyVc0PhkVVO0WtUnQ/ql/bCIYAMDWBzihUppCjr3tLOmOvhBNMcJEgCHrwNdZMVPG6f0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322191; c=relaxed/simple; bh=f+xu0X2Dvffg/en/Ri5kZ4UL9cHuySjQYKW8TgamZik=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rh/MGKG0cUw9m26tl3Fuao8dqUhtRz+MJtV1DnjJBnckMzRaWmEsyNtgGh04msQNEzqFqm3V+svqjEPHfnfDSFrXz5WhyyFHVhs7xYPmhQvBIa8IU2ioVTgwzpfKUUhnuuR8rUsLCoo9F6EM5cCD/2FqQRHEnum74/jc7PUkEVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zz/zUjYw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RsqDf7hG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zz/zUjYw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RsqDf7hG" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CAe0P4263527 for ; Thu, 12 Mar 2026 13:29:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=Zz/zUjYwUoaf5Xpk Xy8d2SdjHkMv2MT4ohrq9AiBk8apgsgrWJAdthKILsQZJSUk9vGXVVyy9zJzMTb5 aKfTT8gfWYamRRGp6hSgFtfAbUFuJ+t4uESjiHHb1KMPh85NUegARZ8XeRVOdRQz QkvZAth2r1toGRes5YvaJ1KkjSzJzoBeJWWBAKDOJZuSiGi1mZ5XF6JCEt//ru87 2T0vQzeQ7jOXoWH7zjoSkXN4l1bkCG7Y9oHFYZEYVgP3wm3WA6uCJn+JWFM51tFE S1gB+FNKixldkQFCL+1DQstXRoAXEaaO4Luz0mzKOXg6PlO022C4j9bbPAVn+Fmk Hd1FzQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj64q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:48 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd76ff19d5so587213085a.0 for ; Thu, 12 Mar 2026 06:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322188; x=1773926988; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=RsqDf7hGt6q4s6KS6Kw7qZwU9oobA4fUe7ptWVWfyhJh4wICmK9o9xRKoIGvy58fON 9lrMZOi9cyWdxb2dzJj+14X0VqLKx7oayvu1uLtn/zXVsSkOkW7fAzzPBsSSo3zSEeqo bmKBQotQi3/AaEIVPs9c2DBfZrRu0po4QiXu3eGV0ylcbbT+rtfQNmck7M32v71XzGPj NtdbWNeXTf0a27qV3UF1jikZRP0ZbwUmdae/lIQj4TRFODIe9nsTIiWHgXFBm6G8BKFn AWrOCve6/wUytycoNWEZxdvMmyEjJSqS7enOUpbIzCtwq6CbWoPDmZtRVpkE09+IaHs6 LFIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322188; x=1773926988; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JSQrds/2TP9Ues0FjNkY9V1Kd4kRgiqfrKRrWp2sgaA=; b=waapWgSr+y0b14NQRUUGRnElRWzI+NkPyt77kizq0S6XMmSscZQ5eJDX+c7WthGHZu KX7vmlb7MORg6LB4qamVmrkoVVm+fMChs4vZ8U1TrSjItV0tORzzMRYA9uMb08gKw6Uq ybRPjZPFCBpjb26Bjj6i+gK0zuE7usxHn/j/luTfZrOSyJPk2tke4P+V+A8FG/zAOP1M D8zNOGYdcifIDrQKnnl+gZ3bUAsqEkQm7UKBDkCk+Yu62oX2NXosjo9y6PgVCr7AG4NT smGeTSkKffMHlkz0kU0TTV+aPNT9Ac5eE0IvhljV6W5Mgg+5TtvTNNh3/aTy6PLIHbyb ZBhg== X-Forwarded-Encrypted: i=1; AJvYcCXq7o36pF1ZFXCIqaRFnct50ytb8vbMEcvbCIpSebLZDj05R80G29XOxCKWXe5fuOum4OsXXtP43cbKbko=@vger.kernel.org X-Gm-Message-State: AOJu0YxqKK9NDfwbJ+YohUr0mSZwqUuxETIRIM+UdnqnLTy89nPhGhdi +Uvh70SfoABcb97brRP8Jht4weWSd6tppUSu6wd8+NZTSSUMNpdMdMGVKOEQWnIV2+iMdUK5FLV kW7VbDTwR3IB4uDMsyJgYJZSYR++TlYhoNc+NRA6dOE2kxgPROTSgq88NqIUoVXdY5Cc= X-Gm-Gg: ATEYQzytB0Yj9bMEcFy/JkFNOgciGcBFbpFHrxNgblNBte6H4s1uA1dX2h39yruiMCV 8xZGT0roalHVk3OXOlBGuZ0ldZsmmqa1GfsDRJdVGOSalM9OizxhpBUPhfdinwxpBc5NC86WfAp TBG8E2qkaS2MD5ibr+sfiIwJmuQER/XgR5e5+eUfdRiaQMTmNm17X+MKIdMWfm9Mou2RTt8UrRw tAYT8gjyxwlFmXRS6lU9F0zg4OoP8aoh3C5lWiLUzyPh1mE2u61jzBzaVjTUibrVJn37MAZ9NdB vuwd6uWZjDhIsQyKTfPbHadgNq6UWqB4w3H17esk4/K64BmX37PNW6tivqj3kTmNYx2qcbJE3Ly 7yy11ac4tbcmrzU87c1GjdO844L/QPfoV3DBEQY+iKoV2fpKataeSigwdDkQB38uuGf9VZIOFu5 WkkrYqINxztuAYGeqIUg2YRmTRwUbtXn0kx+g= X-Received: by 2002:a05:620a:d8c:b0:8cd:79f2:dc3d with SMTP id af79cd13be357-8cda19f812bmr830433785a.26.1773322187948; Thu, 12 Mar 2026 06:29:47 -0700 (PDT) X-Received: by 2002:a05:620a:d8c:b0:8cd:79f2:dc3d with SMTP id af79cd13be357-8cda19f812bmr830426785a.26.1773322187398; Thu, 12 Mar 2026 06:29:47 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:46 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:30 +0200 Subject: [PATCH v3 09/27] drm/msm/mdss: use new helper to set min_acc length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-9-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1832; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=f+xu0X2Dvffg/en/Ri5kZ4UL9cHuySjQYKW8TgamZik=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+1jHsb426zm4uBrGigV+rm0TCVg4UZFxS4n iCmaHB12Q2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tQAKCRCLPIo+Aiko 1a+EB/9I+Mufht0YPVIuz1//POLvhN2ER/ApEdvJrcFQQ9P/xjK9eewewKpmFQWZ31l5lnmdj+B WDjRexmqPBJ89caruMpnFqK6O8DifeAq5T2YtPGtS64X2XXIXIEGSNqX/wRegJtKAhzxL9x8DCq jMeXyG75jz2ezsqphslt3BdjTGb+cWhnatfCUFihx+Z37Z6KC1zf/hFtlBYA6AH8yvcYhjoOboU 7rf2G5eyvk1R/0UV1alrzhdfUWqzv+Qu3Uh2JLNN9RwfinudH4dmtbh8OTQqEIDFHYsSKXzQsaq wea1b1Yx4MLs906RQZO1iy5MvwOI9QSVmZoMYbFQyPvh4h7L X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXwQdWRauKxFh8 q+3VDzyyPqtjkJqDpaKaw+FsFEBS3sp3J+aX70zaSCm2UpkakH1tnYBkGsQMjnTs4aJq/VU23dk h7zjyyaDyB5oWnIaRHA6K4iyOb83TahmKJ2RJZ/jzOnpOnWq9keNGEAwAGBucA+9Roe0jZgUUFN KRt0KalNnT0T8EJ+VAV0GOCimt0nQmH2PXULtRKkKrg7/FDNMiZ6tSp2hsr3qQLRpAMujmgslJB n0t/hjYoCE3+7JDNpBlPT8ul0mJ1+vyWEeQO3wFYy7Jw2FxA3NQ2We06UQotwxA8BDoGoL7tcri q6VErz98lNG/6MT6ldpI0O0YhzS6RMXWtWi9i1q7plfVcTav9hRR338bBObtNwe8dnYqa3Keanx BC1adIEMeOJQchw8Id3mjyxSsWioUVrepNr0LgiQr1MvbZTyC1m7xnFtSAz0If9NybAnuNFVd5O 9BAyh+Lm9o/DKv6ZD8g== X-Proofpoint-ORIG-GUID: PIXv2fvq5Sj62316kULPhsE4WeIT4ijR X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfcc cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: PIXv2fvq5Sj62316kULPhsE4WeIT4ijR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index e2ec1ee590e7..565e671ee402 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -172,8 +172,7 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm= _mdss) u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -190,8 +189,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->ubwc_enc_version =3D=3D UBWC_3_0) value |=3D MDSS_UBWC_STATIC_UBWC_AMSBC; =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -209,8 +207,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->macrotile_mode) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - if (data->ubwc_enc_version =3D=3D UBWC_1_0) - value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); =20 writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); =20 --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC4EA3C9EF9 for ; Thu, 12 Mar 2026 13:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322192; cv=none; b=Zha2buRD/oY13Tjyy2JL6ytsP1CLW40/xxXDS8GTJRymt7bA/cPXkryyIk/bbi0h4JEMgxyBXTnbLtF/8tkwZ4EKmm8W/lRdlskVMzuL+DQx7OHOws3WrjYIJ4rZ3d55cx8WThKQqfdfQbYwpHqDHI4GQ3W6nkaOBEXhKqTBbHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322192; c=relaxed/simple; bh=2pmZHdByL6nsS8Ik/InzKdBxSCO/78Oop/N0tOJ6bIw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IY93NJ7cJnBAdD5WoL9LQjFp5BG/jBgydhrDzA9t5ClJZ+Rwyle+ugrGeboA5aHXXWvBsBUxxDkNemk4DNF02d4c63buImmeRN75Qf70CkgBJLTlN62qYXe8LC4kKhqy653oFdzbOuxtJu6IinA6F5sT0Bgh5H0qFmvZCYbN2mY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G8DWxPof; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Fdw4fLuK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G8DWxPof"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Fdw4fLuK" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CA6X1R3666482 for ; Thu, 12 Mar 2026 13:29:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2imLQEZ3DP0uNNL0l/EieMjW7GOO6W8UDPQGg+15sw8=; b=G8DWxPofbQvKcwBj X8ziP8NOUFL2EPSBzGECGyJA5C2A8V9QzzBBk34NoYZJzGJ73EVbkeEnETLKYwfw t4kawe/EVs/ISUse+fG9kEVvA5b5Wcki6V5aG/A9xd5mFNtVfZZdsuWxNucrgkA4 yDNoiIHa6gqYUbekyKxne16nuYCEutq3ALMmFDhh79Y814P5XFu3DH868SxxZ+AO 3aCwPzDgZUREY0rW8iuKWkL+W06TX4aFCMRTiwC1MEnovIaqwCKcRa84Og90X+eE Z9Ec1rj3xsuKOEvxOKktdWKRHnvP40ogrffjsN1bZc1vfAq5K977/6vDc0dQCuuX eeeDzw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh60j7tr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:49 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd773dd39bso772256985a.2 for ; Thu, 12 Mar 2026 06:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322189; x=1773926989; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2imLQEZ3DP0uNNL0l/EieMjW7GOO6W8UDPQGg+15sw8=; b=Fdw4fLuKSZpWBVD1gkfeSMjVcRkyOjxiGeftKtt3xeHJ00wY8U3fzn1yYplZXEOVe9 OPLVseOKvnO6i7L27ou5mZV+Ocx4ZUh0J5r8mfJ0wg5vadKmCcHkj31XLQ411Zep2z9H qoxCQVImat4L8HvG/vCc2LqTR5UneSvRXMTGIlih1USPlADRqf2zpuHPFo1gdZpqyFIG DJRw0hXYUi48H1hijavGj1VJ/P1RMG1Foi9KnUhmgd2Q+i9AGLXb+we1+uuEgGopWVTB nuZVCXx409YCKcv7AGGVBKwDRvaqjEk/xJ16C6fzjnn19qQqTJYw/tVQkj1tpNPQu4t2 nIAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322189; x=1773926989; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2imLQEZ3DP0uNNL0l/EieMjW7GOO6W8UDPQGg+15sw8=; b=CN0a861WRpxgqFLi1JEx2W+FqKb2mP6mVERRykYVvQuL9pgEx9/J8RQyHAqf1uhooT utltztrUfdpI6gFcVypF5IkLVZCYrA7qPCYo/wpMF5kfizEm9Y9amv3QIEBB2RwASI/L dmSTQ/htR8/isW/Jzl4MFV5VnBemmMDVu692n3tMc7/waVLF/eZ+qn8PgKGjswO3cMve C4grvMEvgFz0Iu2i/IQMWdwiN5wmaetIRdO7H+Wzz5cqMrmFSp9NgqxjMKr9KuRCcRg8 jhzmIblmrYzqO+lWoFc15EMDDKLvK74VhdDr7oGKxbY/7BqhFvTRiXWy1NJduJGAt6v+ khxg== X-Forwarded-Encrypted: i=1; AJvYcCVubdYSj9YQwro/AS9j0dB82AtFGNkEvne8MYVy+gZoXZ/klojdIlOcjATzQK1eSQXFDJfWzzCStttOR8U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywzv7oYRuYTbMtIer/U1JZpnYBH7oZUenKLj4f4DeiCtikWFrOV 8Ms/oT4buAkal6eHE3TN3kEEMTcHZNc4OLk+fxmPbzqGitYIquXyKtWkxEpSZjPOlfqpMsDWcuV A7aH+IWLTBGN6WltD43SLnRYP/xypd9FXeyafQoxLqIxalPv3uba/bX3lwsN74LI5VsE= X-Gm-Gg: ATEYQzzNSGg8f9ZlV9KDYHJTg4DFhvHx5FOnSH36EyTe3hXkDP1IFBnF6IGIvb1sLhn UgwWcJuQhtXEpxUlOzqtPf7XK3g8kG9pR25bjVLHGKuUEb2TidTZtw49+UV7EvnyHHyk4WuHjxu VTS+c0R2jdLvC/GzVvzHc8QZnVSOz5OTUKipfLb40B8wZ3//1ebjhlyHjflcXnCdySXrZLSWHpi ZbnZYVV7CaOiJAZs35BPHKDhOM014xnAeT3DW46gxiV8d0LOyJ17ikavYhCgXeehXMRer+TYO3q 1SaGlADqinMN2yxmec4XlMMUq811XRwjfaUzY+iJ4AFL0Mo34oN0ujn7yogFrDA0ynl1fbw+uZE vIDnZ9uGFEkdozRcczjf/KNmYgSLb8qUdzUR8+tJhx9elOyU4AQ1a9UeLtLg0lnuiTXaT7yBBtq hGg1lF4uS58y8NJ6VzdspR5qwurwe2OK5lSPU= X-Received: by 2002:a05:620a:2910:b0:8cd:8fb7:7b06 with SMTP id af79cd13be357-8cda1a1b56dmr765507785a.40.1773322189418; Thu, 12 Mar 2026 06:29:49 -0700 (PDT) X-Received: by 2002:a05:620a:2910:b0:8cd:8fb7:7b06 with SMTP id af79cd13be357-8cda1a1b56dmr765504285a.40.1773322188910; Thu, 12 Mar 2026 06:29:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:47 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:31 +0200 Subject: [PATCH v3 10/27] drm/msm/adreno: use new helper to set macrotile_mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-10-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1533; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=2pmZHdByL6nsS8Ik/InzKdBxSCO/78Oop/N0tOJ6bIw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2eMaAGaf5hR8bWwe1nteQfuL+tKx9L2Nug kEjft9zFQWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1RTOB/95xo979UORIN1WeB/ydhhdUmlVwQ80hr4mwQnoZbXsiIotxewSmkof9/5oYQT9oKmhHPQ X9zxqcKN2GzszeNwCbyx0/KTzF5VxeKzjWLuMcAXw1bMl2DE6VHLpVsexk53BPpRdohqwYuPuua M4pCE8UHqbYJMsmxzuU1urOe54BFyzlsYPVx+aFlxgtrzbHhwhEh3g9CLNcLdwTCzEKYgZVJ1t/ AhxI+pDmj8AntjBRvvsO6Taq13bHLo0L5nUn3fTtJPj8ZJ5afGpjVnNi/S4fRMgvU2z4x60Cyhv gd2vmfGbPNF3riQdk52pPfBT3gNGt3eWrtShZLBDHZ6ntLdO X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: fhRC-twp-FO7-bAgrqcUP0NSiD2jfcn1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXxrWT9VHTi2WG /208hg0fpF8XiwY4ZrX4YorPrQAwt6VN8aJ5RR8C1Iunakfrbkjm2+9tkxJ/iS95NxaD2fkuwql NSg8zc4V6wKrFg4z1mnNRQaJXe0AVE8sIkvZMFfgWpW4HFRMb+J0c40rfIZ85C0b1ZUzPzav+AD f0/tB7+bGRaDdcjkIi5samyIbZLkp+7UJIwPV46vD8bYnn+J99ZBAq5I7ZPx7Lxic5mbzOykEkr Mi8RjhKRKbX77FuqWV5wJVuGH8wIouUSXMoUGAKL1Ao5DDc6dViPJ+8q9gli8vjZE+Cctvwdjlv lLUWmh9lcSWR1bnkvKPz5CMgjcRcjXHBuzRpei45YGoZv17yKmq6tbslyJF7A/o/Dww4KHB6XVo Sm/zOsIkH3b6D8G3ukA/fGER7s+5XK1JJzd3VXtSN9oE81UPqA4fAfXoymbOn0WgIIt+Vl1iuSc Hrvj2u3PP6MVF4y/n0g== X-Authority-Analysis: v=2.4 cv=DsRbOW/+ c=1 sm=1 tr=0 ts=69b2bfcd cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=8BxV0iZMnHvn5dZpj2MA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: fhRC-twp-FO7-bAgrqcUP0NSiD2jfcn1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 2027e479d5b1..56a820ffa613 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -787,7 +787,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) min_acc_len_64b << 23 | hbb_lo << 21); =20 gpu_write(gpu, REG_A6XX_RBBM_NC_MODE_CNTL, - cfg->macrotile_mode); + qcom_ubwc_macrotile_mode(cfg)); } =20 static void a7xx_patch_pwrup_reglist(struct msm_gpu *gpu) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index d5fe6f6f0dec..4814233d8dba 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -435,7 +435,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; return 0; case MSM_PARAM_MACROTILE_MODE: - *value =3D adreno_gpu->ubwc_config->macrotile_mode; + *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_UCHE_TRAP_BASE: *value =3D adreno_gpu->uche_trap_base; --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD9BB3CAE62 for ; Thu, 12 Mar 2026 13:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322194; cv=none; b=q//T/dvopHvYK0e7Ox3pOlcG7oMOAhjdjV9bWXTsS73kJdKx7zszGvAXiZBy5VT4PBOWLopUu+FliYjIdSXrHp0Zdw6U4hZa29UDi68i3Huldxg3iG97+ZqmLs98/Aonv/Q+6fkIhRxUGxyA/7yQBaUq3/XmtQF9Fmdl+5noflA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322194; c=relaxed/simple; bh=fgMYnVyPuAQnxDWOJRtoRoZ5nPUFMHGHRdMlLxdeUlg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jwk0/2T4F4UIn7sTXzKJmob4j+VD5SkVHaitlqne+KIiRf1l+JGuDOj7p2vlXgnDo3pu9rZ16u+UyhSoM/uiO/FuB1sHl2zOUMq0yUaVqxUk1aLg7ePtgo430/4yeo5tZoVogzRUscefAsPMxs9Mx1IvrvG6HJX13BAw1MaSfLc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U3xsOWpx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fWFqRmMM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U3xsOWpx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fWFqRmMM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9PmFI4027299 for ; Thu, 12 Mar 2026 13:29:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c9EFvSk5+mUnrmi/1uJHFkMUvy6FeW+DFTari/Y3gp0=; b=U3xsOWpxjwoNJe0R SeMn8NPzXjf4TS1vUSDqNI3TJ1mWYqnB64o91CV92bL6r8gIqyuiOUlGVvt9luFf ZxoH6NSRWeXgQiGLa4p0+49httBQlXHY0FBGVtRYAPG9iIz0ERYAeI7mQirG+/5d UwTzs86IElL5BiTTp9fM6mM0MBslmwTm3af8hzdPfpRYtgyz9yT/78J+fl4kiuD4 9wC3w1UzFGC3V6+YCTSdM+Kb8yCHHFD+RLEFXk60mETParEw6ha/vCMaoHB0q+QM Cx1IxMP29PALvRmvTqs2REtTUE42aL9B/8649BBcaQ3bXoyXlN7YTz15Q/Tw2+w6 lp3GEQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh54t5sm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:51 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd91c0262fso694707785a.1 for ; Thu, 12 Mar 2026 06:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322191; x=1773926991; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=c9EFvSk5+mUnrmi/1uJHFkMUvy6FeW+DFTari/Y3gp0=; b=fWFqRmMMYBrx2FvMS1bYUHPI8Z14pkJhwM1cxLGdNUH4hB5vOOqXoaETD9/gysNUbJ /YwnBWypv+sumofLwfTnC1nYSN1DFJEe/EjDec0O1VgoucQI3bSXWJkgYqrvvyve5hdA b9OE1USwh2ZfOTAFccUc50J7MaQH/bq/INEI6fTTdYNyQaMHn99OfW/UmdS7iZjJ9/+S qIugOP/E4RL7rdS8hA2a3z0u9/+Sjg9UQrbHq2p68a0QXBnqauGkNFeJS94BU8qNCx2V UXy5iJPhOIAnpjZ+U/7WKgPfC+KCzTk0CF8SBGpYF03hfKYEMfbEA9TL5iVPmRbAf2cp OnRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322191; x=1773926991; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=c9EFvSk5+mUnrmi/1uJHFkMUvy6FeW+DFTari/Y3gp0=; b=eYfgAIihu+c99HQOpNjmvDIW8AfUnsGgIRac8VjrADKJ4A7oWcc0Xry9iU0znzTUUM f9C625u8dNDQ0eCpWD6owKmKjrbf6nKuV2B/E6M4fbCzBaUq7VylvNovLwlBrMXE6Njg oZgIV11VQBAuvY9IXLNanSpqOabgBErIufVoS6FAXlFR19j7IuS/87AA3FXZ5psgyFNj 3htUCBX/s7X7L0RMJEJBC77If9DFWN49MxCQcdveWdIkVkYNiKfChVMmwj+Eqri1NFRc wfWeqYE7LG/N2CuHUBl05kJDvHlGTS4UqgmnlGhqpDQjI3wVwZ1ugXDwFgXO/ntG4dsN HnOg== X-Forwarded-Encrypted: i=1; AJvYcCXseA/7O64nY+WMJ8VM/drqHLd/fXEtdDCBKQLi6qmBrXriN44Y1qxCMjODl01e+gnsDVzB9kHXpqjlR30=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/uD18PVISiPv7Oci3pZmnAmZOWvU7eZC740m+a2O0XpfsbR0u Y555xd/W6rg0DJDigINdtkaSd3nAMaofo6azjufuPYzKNBhtNjpCAhOp9JjQ9qrciw0ohJNQfIz 1c362EufMZm7toa4e/ICyBg2ESgdi8IS4RnYgV7iC8r9OI2onJiQgn6uVm13V7lxYpB4= X-Gm-Gg: ATEYQzyL3knJqa3tAPIR2lxRj1OLZrnY10vE4aa15ekNc7shwWM7E/f99DmBQ5vvZxK aDBE2Kz77GztFOkyrBQWO4ic0NBeio0MjJDN08XMcmhBBAe9DEi7LpFt5RSVJUsl0qFyBdF8ANX 6jQPCD3JjW3M+X5dqzPwCdTqCsPeWn+Zxc5REI0C20DkYpVuAdJ9Am89rSjUisRdS0D7zMiYsu7 y019oq/PL4Sptzl1z4Z4NIVh1e/J6ktzYw/Tx2GahAvWrM7/uNQrlggKu4t6eMeQiT150MArbsr DDwzI7Pb/aFxt92fgU/rT7B0WN396hmLEUmZIuzlWbDFJbYF3OyTH7uk7vBVBi7KMk9BUfnYtBt JQNj45+jicjZx38nGBDmcvBpmWQ4yz09G8zAtzWOUZPtrqs6Iyns1YW8BjMr6l6QQ4mzLxmqN/9 MdIgI4f87ljB6aJb3K6D1b1NGmfJKGIdPE37Y= X-Received: by 2002:a05:620a:44c7:b0:8cd:7cea:aea9 with SMTP id af79cd13be357-8cda1abaf1fmr789339485a.64.1773322190937; Thu, 12 Mar 2026 06:29:50 -0700 (PDT) X-Received: by 2002:a05:620a:44c7:b0:8cd:7cea:aea9 with SMTP id af79cd13be357-8cda1abaf1fmr789335285a.64.1773322190380; Thu, 12 Mar 2026 06:29:50 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:49 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:32 +0200 Subject: [PATCH v3 11/27] drm/msm/mdss: use new helper to set macrotile_mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-11-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1276; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=fgMYnVyPuAQnxDWOJRtoRoZ5nPUFMHGHRdMlLxdeUlg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2PHXln+GxAhv4rZpGkmVzg4UbcjjY2I5wr hNB/RdxueqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1Y65B/9B78W61F+4C5Mxta78QZuIxh4tslI5LhCH3hMdR5ojQfZSsmB8XkU+uH+lqb3vFGXExF6 vwASD1dRDCEHvkIh8mXTAVKilXxxgsqU7a/nMAnC3evodzdJ4vMpKEmTYnwMVWlLA49a+TLhrW9 dmhbt3KwHePGX3EWRcuz0/qoY90idgtAMjQKwgFrvX6A2ezJBRbYARgaqW3DEN8ws3xSbYEpDnK VJB8iwpi0nHfoqBBqplAOrjJZrxQ1G9a0u4HJCtPOAqcCXBKZA53uvDGx83IfupeMyGSsCRKW6E CGLVFhUU6RPUCp05sbUgSJZtkFw3MCG1mOmXE3tupMju2XrO X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: dzIWmOERNbAtsIYukVin98i5-GvjABH6 X-Authority-Analysis: v=2.4 cv=BNG+bVQG c=1 sm=1 tr=0 ts=69b2bfcf cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=ujCctoy6CNRHcyqwK_8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: dzIWmOERNbAtsIYukVin98i5-GvjABH6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXyjT2jn4xR+/0 p4x8pwSOYLX0R+4lSX5Aqh28cSAhpIq6UL11eYSQpq9tY28gaZkEywuJhkWhoPSjL502dbjn4TG O+GDFf+IJTYYOeaeEWRbK0fjECgrlm5WiJVHBsuRKxPVCKNhXPR6f4Hn4H2wuGd/7UT5e8yIuuH bT7HdKIGb/Uqj62b05cuQeS4CMwV1zFGHlcobSa6RyrjQ3gxgM8nYUF3qqcKWkEEE9m1gpYqWkY 5HpI/6BZDZBkkelwJ/zY16VVTLQxJZaUKVRYMJkIMzBJRWnUrK2N6wHVlpo3Ehnjp5M/FJ011ZD h3HAd1nV2Q6CRS8VDiOq/Qw0+W0y1z0iixQ6FR47eCLmE5piN2Gzw3gPNJPtwi5mSRJtAtcd6L7 93/e/YQCXbKPMavMSCak91gfMnWHmA7Ox2HggKeSukGvE1kzp3wszvp4+FJRO0U8IsHz51qV2sk VKBtqwi2hTJfJULByXQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 565e671ee402..453be86c3420 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -183,7 +183,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 - if (data->macrotile_mode) + if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 if (data->ubwc_enc_version =3D=3D UBWC_3_0) @@ -204,7 +204,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 - if (data->macrotile_mode) + if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A243CAE72 for ; Thu, 12 Mar 2026 13:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322195; cv=none; b=KRohjw22ONpIWf6qwT7ycv0KcvN9l8VBZdW5dL8YmDLOEtKdwBLwL0109arhX6hGZX0DFmve3ufqH48MiHWZI5tSKybyGu3c2XWplk1sX9r0DWqzvemsCMYY2VxfGzUujrUAzlENDrVxQZHK+cflw2FARiT2KYXmMF00dSUAhOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322195; c=relaxed/simple; bh=JOt5df65NmH24+iTFsP3gw/fBTSNHiBWXeHyf1rSg48=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X5dD06+c1VDTzXyFuSTfAHO1W0SNH9P75MzmtLUB/CN+Si0KChPAi1+Oz4ozJOhw5G/4K/tnsVNGUbslp0pKmgJgutdINfE6F+FnIFWPwkLTmdDn8cb++rgwO6cJQLlegYHvh1qd1gJTfVy37eBWaylmIw0IZpdCTrEw6vf+8Zs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fs8BPgeh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=elfAJsGa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fs8BPgeh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="elfAJsGa" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CA4c3H263424 for ; Thu, 12 Mar 2026 13:29:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e4LPJrHt5PphqDtRIqvbuMWAWBhobfystAANNIuWCU8=; b=Fs8BPgehBMU6DTZP PVmIw6mz39FBtyG+v07dj/+woVhMeJ5cPJZ3RDoBI6AxB31OvZqCRZAWIvbjXqX7 vCTzkOyrdkD6DJCYfoZJxnhSHhLZbB4IAKxV29VTyGqE4FPsHrRGxFLBvLXSZ8Y1 QA7YHKiAL1gFIhKQDiQhTxWWqjfA832DswWgmNNmz8aBw1EE+AaYeE+FIkXhbffB LNHWVkm4EHk83M9vGB7vmQiLhfuoJco82GrO8OasvVmHaZYtg8gxeiRugFdJ5p1a 6PWv5ICOsDcVusQ2GSP0RAaJsOEzXfNOb5Q5bFb0SYXskbfssXhhpsDzay694hyq Tkyh/A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj65g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:52 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd80bea54dso602263585a.3 for ; Thu, 12 Mar 2026 06:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322192; x=1773926992; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e4LPJrHt5PphqDtRIqvbuMWAWBhobfystAANNIuWCU8=; b=elfAJsGaoEr12ymcrzFViTKN6WhCQnQWjn1g/pAbPEj6uEIh2DE127gbztVba8azIO CPCQbjnuEtCHShXH8EjQmcgwYy12D467J8/gfHXkuLjQsMYkC91HVyNHHtsQ2lnWbrzj Mep6ACSbVUSmh3p4qklFavJOvtDatrtZG7ZuVM5kYbl8meEphX20IOZsCbzma6OXTLSX vHB8CmM025SaUCuENL1gJmq8ePntAO+EYJ2FCasViX4cmJiokU+7+LPMbC50R49UXRvX Df1TAGBaqHe2Nyn5JlpHRiQRaE3TRY3dZYqAU9EjlEFhD7YiLyPYbcaVlPTEeo4ULEv0 uhgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322192; x=1773926992; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=e4LPJrHt5PphqDtRIqvbuMWAWBhobfystAANNIuWCU8=; b=fYgsPD89Lw92LofZTN7PUxFoNt+alzW4dpaeUWnrViRSg61LleHl/mL8yTMHmsx2S7 IpaT2hFP+uznpveYjOVnitCZIMqg2UDgboS8N7In99OqdpWXlWyvbHXf1jgqMHOQibaq bBDjTygK9hxeGJ3MFSdlXRGerYs9w8vYoVMn5Tw3UezEZhjT42fQhcZI+3za17y5CMaR sTPt7A0Vc4YCCTv8MvbQzdM6JI2ICzijOn3wqzLKEu7XFloccQxsV4HMP2pwtQK7VD+O 9bmxAaS9YtMMMTqDMeiXEdyTFB815mes29e1H76vusbwgJ2vFqUQyU+apoWNldrcs7UE wZpg== X-Forwarded-Encrypted: i=1; AJvYcCVmMlfyvdvSZQLt/ti2X8+QVjQN+z3jG/yTrAyp585PLSO33CZqdEiTw8wqHwHsXcbr+nTE6JoLItJxCkk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5EfSbSC8XGt4OYV4q2CD6Ja80O3TNVg7G/Y/DjRHlEtz87T4U I6e43LXE3e9xwV+lV7shkqEDA+rZQ5UMu9ziA0LB/tTDczqjVqytk3PpdOGtMqbR1hoAL8N7LY/ qVsTogY5xBFqV63Eoya9LDozTLYJ4NIfwBPj28qTpnaKCvV/IrS6EO84KsXEPIta9lxY= X-Gm-Gg: ATEYQzxd09H+ztGLt9q3M8zji7K5nTQLx8Um0V/wo+4PQIrUwUcIHGT0OFDp96whj8H iBQeH/1LY7LWWLhXoPgU8XXK39aPPHTphOJfx1AmXUOmqmpGrfXhecuFO+ylGEB9idrSYqZqfAN 5YWaobtauKq0Mulog3qeAS6DZSUaAKUTnw1UkI2Eob24AmTrlkr9bo+gcyKpAT1b1jJd+t4xzHU EiwPJNbiTmLfswvDCaGx4fBTiyo23MwTCG28aBmPaHRMlbhHSIMKc22L4xpLpL4759+dH6dPDwy n3GBXlRarRDil68eBlo8l/6X4LUDERrtofkn+02eLNTFNO8BEe/dHAMQA6PUeq3sn71VVgNqzU0 6BtVg+BSNFVxV1Wr/FshnRVrBcbhplKM+M/l3JBY55YGVEdyimOer8Mmkc6t7y5I0VdSn1rSQm3 jQd2EDZFXi+9y0w7rQX0MPKViKKSa/VA51LBM= X-Received: by 2002:a05:620a:d8c:b0:8cd:7685:760b with SMTP id af79cd13be357-8cda19f6121mr873694585a.21.1773322192313; Thu, 12 Mar 2026 06:29:52 -0700 (PDT) X-Received: by 2002:a05:620a:d8c:b0:8cd:7685:760b with SMTP id af79cd13be357-8cda19f6121mr873692085a.21.1773322191924; Thu, 12 Mar 2026 06:29:51 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:50 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:33 +0200 Subject: [PATCH v3 12/27] drm/msm/mdss: use new helper to set UBWC bank spreading Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-12-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=853; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=JOt5df65NmH24+iTFsP3gw/fBTSNHiBWXeHyf1rSg48=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2G1HarewjfLVafCYRROn96lUpB/3kNNXI6 w2kBgXpseOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1c2xB/sEXxSK8CqsbWxg+V09F5jUrxaXX+WVJmlIxlWPndBSeVgv3rJPo0DojV7UQUS6E8H9vJY D8Wuf/kA1Jxvw4owhsqAdkWtOZsJVChbjTeJgl70kl6Ar9B+C96aKTApNTnx+t7+mWG8P+SLT4g 2LVt4DgQfZwKNDc0J0Jch65BtntHb/DUufYctRcuv59zlFrgC8A5Pdr+I7aWWPOnuI/P93JlCxR wDA4rNemzM8h+PolJcTvAJG5POGhafs41REY+XwYqKVmRZl4eu658HWdR51og2JheCMLSti0oS+ HtSp5bzBesBQ0fbcRhF1LToAehy+wvKPwwTVgkY3a/7dTc6b X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXx530PZ/pNZWR GSrkFZeKX0w7NfmWYwPItat4lrP4cRqjVxVg7pJmNZlALtH9GUI7Id9exF3h9Mr4UGqJ+2Y990S oDgJdqOTj7VOE4UpcensVN4FEmhSUxZQqKQ3BhiLl3xggbA7UQoMdMHM/98OF/ofj1f3SZAKXGi pSUy9lMMiXEovJhQZ9MiXq04w41LGmk2sQk1Z8IWgo5cK5EP0pWQmVWcpj9jDSHsKdSH6X+kn8j t0MDI8ywBWA8Y2nIYiQ1L9YvqdR47SOsKLVUdGEHEipj6WX500zKXXQEynYz7970qmS/MWwcNxE j3wsRYTK5fzF1a7OCI2/6JnCjstnvnqxcxSoR3K2McqCU7ie9GrOs5wUHRuWzJEFIGt/pSAZi54 s8108rJ9ZCUo9VFmuCK1WnoL/9hfw1oWo1aR6I3aP5x1NwYhpmLeIFbxqckI4vnEAxxV+9/NaAi T0W4RwvYOkXefNq9tbg== X-Proofpoint-ORIG-GUID: Qxl6GouS5xrFQB1V-306Gy4hdHQ20DLM X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfd0 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=vkIeKiNhsAXvYQN2DwYA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: Qxl6GouS5xrFQB1V-306Gy4hdHQ20DLM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 453be86c3420..76657a4a8f65 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -201,7 +201,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; =20 - if (data->ubwc_bank_spread) + if (qcom_ubwc_bank_spread(data)) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; =20 if (qcom_ubwc_macrotile_mode(data)) --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98EE43CB2CD for ; Thu, 12 Mar 2026 13:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322196; cv=none; b=TO/OtvHNtMAmjD85SPqyo3r6GQNLm0a/HNuUtT9b496sICCoDUVv2+3mNGl338SSnNMLlUQ3jsgO24TIHD7guoz5tkr+mJKzzQsYTCHHbLhnjsKZemHYMzCbLgOBJKnKD+iWjE3vwUaT8TyYCCbJF6MJXS3TXjAv5caXt6GsZ0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322196; c=relaxed/simple; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k4sNhyZJAJ1owsrP8lbMKIYxOzpCf6m8UaxlouNRPHIc/S51bO0jKzGFEc0bJ6dr5pjnz6hMmulmLr0WfthIZSSAZhXCuHu5SNa9qNmPl/hrqjuEjZVSFhiwZuEWNqu/DQU2mmz7rrrpjfZGZv3wXQ2klZnxtQnsgJP45ijvRpw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DaggJIDs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jL+DUjRs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DaggJIDs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jL+DUjRs" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7dj3B509249 for ; Thu, 12 Mar 2026 13:29:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=DaggJIDsVY5RU+X+ YNy7fh0t4BrlIakQoZhXZdtsbNqgsjL4XN4cYLSNflG1O2YvZ9xmq2/WgmTkN+kH I7i0sizRJsaH3Ro3EYRpTA5zoXgs+MhVby3UJQcalXWREZcr/erpwfDH5aDOHadn I05kyZGOpCf3JeMatlG4rWlqt6ycIX6m2I9iXSYpkqFjZXWn+l2uJl1lUg5pb6zh Bf5swOsoTPRQiN9ntvmzLvEs4qsijF8mbnqI1H3fDgOxA/EZT+UAg8itJrl44CQZ Lq9ihf+FiQF1iZwujBWDcOBQVvkVOA7VWwSkqBdxsY9URMChi1xSq95RuUxsWg1B GD8wMQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vcx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:54 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd81ce6fdcso978645985a.3 for ; Thu, 12 Mar 2026 06:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322194; x=1773926994; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=jL+DUjRsCI+VzQooBHQqphsz4FuUXUc2q+M04ePVXWDWgoG4u5tZmRslMUeNPJbgRY I6sTbiF3coWV7fSLZ7ovYmK8bgsniCifNYPhqT+DVapgyTJyoKAmOBIvTeoHmWroQA3T YXnGbBDobna7DMdZ3XONDAPhFHbtULjulbooS0+0IFVU5H5mPyCzbMxnSwUviXV+zemp gUMbpEUePbwddVXexvclHVqeakAfKnWwESsxOslSY8S6Yy7m/jqq0TMSIZbg68xAqvuc GqJqxQCYREIt2QtEmHDdjdodcWR4q0sPHMx5NCjWKG+dB8zbTLta/acwxmy/KkAztItW cmmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322194; x=1773926994; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=YBUM0ka92PJfvrDXjPxOHoScC/gWCye978atWsG89eJKyGopd9i9Su+v8EVVyeWAny xUCXVXIPzoArMGAtd9eY7TZ4NPOgq/RVPLk5cmVQfadlwCKJuRjbRazRaWV+x3KRcyKE QL0AoA4/iegueHC5DAuim8fmOzLmK7KeQufhi8ecrlUu8SI7I4hjlrPWDbodvOJhsK6x BtNAhyXplWPztpiPIG/F45wHA+uDA463gRzGFhyzeLn+MkkCMO22wCK7kXUyfNNd0pH1 Fyt+rau1MN/aeYVNIpjpzwkRwTGgGB35uGkvpNhY9DDl59OVK/VpdxUOaT5JOkHhMWFu yISg== X-Forwarded-Encrypted: i=1; AJvYcCW9m23T61JrycBPzGjN2thaQ4ezH9x/7HpW3O+WRUh7U5e7X1NT3HXZ9ti2KeCaX45tAArfz+YXlTjoqLA=@vger.kernel.org X-Gm-Message-State: AOJu0YxON+pljBPuTjT4ZdhhZU/GBSRZIfinuO7sHwTVTxuABNHBMUQS dq1oL7IEfrbPygw9cvOreT0KYdcAKR2L+oDJAUY8spz7hs8kOnxcgfo9Qb3kEP7WaUcJtz6qchg 8+bqsciTBX7dNlCnU7waGwDIK2Rahxa3GGzNRCZvi42AqpbuHGd1uQsSTYzg2WwwGFcA= X-Gm-Gg: ATEYQzzPbQcRdRkUDKulbpfu3peANy1BiUDyDE17uWdzsUN2EOglJ1lyX0YFnIOo0MQ +lg/v1A7ep0c0utJj86K+GQYOLYJj+bqt/CIsBEu24AuZlJj037DruSR3oKgpS8fm5Mau1EpEIy /SrucP10fairuj/YE8vOqJnO5vej1VBe/FcE7y8ma6AROodpo97vh77hGov6GP4uw1WGl3t9sli Rf+A4z1X+h0EBIILrfaUj1/9SJomMyWPSLDAFcToclvkKCcqAHYS9bNUnFjEKOh3fyA4JxlhYOE tOkBdLmSWmTUm0pYOZewyklR3JsIgq69Sa/gcaIcaX3ZoprcBx4STswqI5nYxqHk3Nk/xUD4WfO eINv0i78dflpF8IYpIJ2jBGQ9vcCrPJXu6hZvlwyJ8DWCywZC2dpKdh3oQb1IyHvrSnek9AwYhJ aArPiZ1131QYg+8JQqmT54zcQbJUZvoZBBoSI= X-Received: by 2002:a05:620a:d83:b0:8cd:9446:cef9 with SMTP id af79cd13be357-8cda1a562a3mr778066685a.60.1773322193789; Thu, 12 Mar 2026 06:29:53 -0700 (PDT) X-Received: by 2002:a05:620a:d83:b0:8cd:9446:cef9 with SMTP id af79cd13be357-8cda1a562a3mr778062385a.60.1773322193329; Thu, 12 Mar 2026 06:29:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:52 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:34 +0200 Subject: [PATCH v3 13/27] drm/msm/adreno: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-13-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2707; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2JtEAtBmQ/NcrldvywY10gImttE0oGu/aC LPb10BpE7aJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1QL0B/46X+E2kxsvXxWD3d7+sr2ywH20dgQme/s+FJAEU3/0Q+AmAS1DhEZTNwdxMa2StPQKvLY WB4sO4ENNQg/OzFo60K+PifFsL1nLEIBCD3BW/CCyg85AVRm3ds2vsUXHrYPDxZ11r4lB75wIBI 6m1OJB0qZ3tD6svcNlKYGbeWAzc6fcOkD/9a7cGO/0Gza3SJT/ZI2MgJSRkjvvwfYOjJUi0xEVy 22ffARkP3Xz8IDEZ1yrQyZLJCk1jjobRMxZbRRSScvcp22LSb8rtxgKO7Vg8gacxwPiA8vRbDR/ PEmVcvQvcYIlI3qJsEBTMJKOlBZv+baZB94HMtaL/2yR7lzs X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: HarRisNYO-1_1lovkQBow3qj72Eyg1hj X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfd2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=0JjmiBfSQHijSEXDZO0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX91KUk2xS3ldP ZIMIVYWM5dBiac/drjfbOndboaP3X1+z9elbAOoVZ5OvybG5AI/N50sIJasf04icSsnNNptlfyD jqsJP4hdRXVT5SLh9fiY6Z6HI1VsR4zmp6zMZ2ZmxFiw/nMHAbq3e8NkzGsvErrenjOhhAzkL3s TKi1wjZd9725LvDKiFskFQliXaFs4os5S6SCde9zWlhREUxoP57+5SpIPtCOFlsT558LkUqL7aO L8RCKCWX6vhFpaNlBvrO6q5dMexRgpTcNEHooKUGF2I8bcVr2pEx7EiU3bt9uH5aB/jrExkGzLg uhI+teaNy7ZeuF6dil4Ad2akywNEBffnQJR6i+iibyGnHp4mLAtSrTyoMxIPUu1p9peufrG7sQA LIg7H/n2YLnAzMsFoejajVMOvAKVWEfmGd5/SR1d0KOnMOlXJ+FtbzScDSz3ciQfLKwgabxuaF4 uUWwFApfBc2o9TbiWdA== X-Proofpoint-ORIG-GUID: HarRisNYO-1_1lovkQBow3qj72Eyg1hj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 56a820ffa613..7be31de3b525 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -741,7 +741,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) BUG_ON(cfg->highest_bank_bit < 13); u32 hbb =3D cfg->highest_bank_bit - 13; bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; bool min_acc_len_64b; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 6dc1d81fcaeb..680f0b1803a1 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -265,8 +265,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); const struct qcom_ubwc_cfg_data *cfg =3D adreno_gpu->ubwc_config; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); - u32 level3_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L3); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); + u32 level3_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL3); bool rgba8888_lossless =3D false, fp16compoptdis =3D false; bool yuvnotcomptofc =3D false, min_acc_len_64b =3D false; bool rgb565_predicator =3D false, amsbc =3D false; diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 4814233d8dba..cc21b41cae26 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -432,7 +432,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: - *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; + *value =3D qcom_ubwc_swizzle(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_MACROTILE_MODE: *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD003C7E0E for ; Thu, 12 Mar 2026 13:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322198; cv=none; b=tmM2u58os0SPzqbhzkpI/fG1XE9xguBxUiEgDMGKMPSLHnQbnpYRUTFXRY0eTsQz7Vm/QrD8bfh6Ul6rIi2ThilJLbMcX5YU20HEKzCD+Q0j4g0eHOjCgFWI4lzsU/rMDJLpF5DJvLtpa4NHNkuDCHxmzcgTJ3D7WnT7VS4vZ5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322198; c=relaxed/simple; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I/iAjutXoDMU7ouD4KeRY319bVzXndZMQHjHY10CzWWKTzCmn0p0Z68kHluy9goSsbaFrq0tuUnxMMXHkgPCqYYx9sfDdJfdKM+wbQxwCvb+AoOKe4UXN9bm2JRgI/TDFCzDq2G81KUfLV299gLMZpP01SuacOQItONPLTXRcHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LlV7KYE1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TGU9sD1s; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LlV7KYE1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TGU9sD1s" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9w1RV3666500 for ; Thu, 12 Mar 2026 13:29:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=LlV7KYE1TbX8pTa+ YgFsjbh/gIgk+VM7wm6DMI7vzq+cDYuEIXlroRUOElyXdRD3IGEH21CSZ4kAZva8 JoGfzWT3OWPZOhs4t7URmdFHOfPaET6tG+B63a4TKyH3kv3Upkyxwo+2vNKuKEtd E+e1pEKOq6Dpb9aviia45BolMxf/MVWPTcBB8wVZEXrxgfGB/oAd0uySn50CrNHb uF9aU3CCxodB2UvN7IuZSuqL3ncIqnV2O8cRLNNE0+YQ83McTzzuspxAJ2uVhA1a iusKv+7b/VbhQi6NuBJiG7A9/oLFYGT9SHGfgsRguWbmzBtfP14FDLtkHmJ94W4G HyaH3A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh60j7uq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:55 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb6291d95aso1087823185a.1 for ; Thu, 12 Mar 2026 06:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322195; x=1773926995; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=TGU9sD1swsU3TEMuF8ORwMEM7cwCpZlRzA6kr8klJb/9s0ReOMJJh9CVuAEnLLvXY4 yokDD9ybLgx6iVwCMyAv26qQmnVNOfDOwvfKGNVwfAPgiN9kLsQmbbHRrtOOf4CyrID/ Cgb+Cb5TFMKGYRuYMUj55xfA1yx1QhoPAYqtA+H03BRAgZPGrASCGq2txb/rKiGNkB2B 68qTnAaRpoV79MvqlG+KZjsTETKg4qFIisQV9dSCJGPAFLEZea1otpg+TWhjSRnErkOb j+oSW/ECFs+mMKh9cVhQi0Ob0MxgMOnL404LbvfM82qAt/S3UkJasN/o5HfXmHoTMe83 /pow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322195; x=1773926995; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wJB79bVUZrsbxSexjswx340+SsqpUDunWLmQTkIAkcU=; b=tFx4KiOWNvYK7aE5kzQ/z73yhsDXkx9MM21ZWKVvzMIZfQOL9unNrSc50BcptzKpjv 2VjEs9hQwM5Gd0M0xzDBmFwh1/ArC7W1K+JhbdY29H7DrEcZRsWkCZiinZOBiON0ldNU 1MLfmV5UX+f9MzD+d/mTcq0+liAUf6JX+If4JZZ1taIRN67fSeA/rBWB1vhzaxIl+/T3 QPosZHeqqRhxylkrJXHsxNg8FKj5/YzCEOjm4j14qrXMVQr9QBZTPVYfjkKle/UVeOZa O5Yl8mhrKuGK6ean+2Csj0qMP7QDcwwV8F9071zn3ncOQZ3L+bkgAAMIeJh/wUmK6l0j dF+w== X-Forwarded-Encrypted: i=1; AJvYcCXNzBJ8ZNR7TAfYtCBHBhOiyNGlxGk3AG17/gChDfyAyc61q/jEx7ESKdNHRV6sLkT8fF/6K7aKzS9ousc=@vger.kernel.org X-Gm-Message-State: AOJu0YwdtdGcMC9BFAaMznOeHv9zZy/Rxn+ohA0e3GXLUtQkl+9USlZ7 P0mcQhS//SrFt6yYUhie8nvfV/c0PbkZ3w5xL1gVcXc73xaJPbM2E51hQp+D3Mz90CaBVora+qf mzAlNeBIUPejLESL0qaGJB+Lg8fDsabd4b6SNYzp0Mts7+MG02jhi/TlGJfsMgEHkoNU= X-Gm-Gg: ATEYQzw+HS7zd8COU1y99SFjMsw0uYEhGOwmzeah6CA09Pjzj6uPQ8PCLl4RG8n7nN5 V/vfmjkxUdTWH6qqaxRpuizUMbEMW4FdkjefUYDuxNv1cZG0EeY/bCw8L02ntrkOl6nGalNmtp4 n+QP1ONwqmVxMbWGanm1cDBCKp/0ZERcCUSxMrHMOd43tIDLfNKLdCa3zIhh8+TmUjhIoKWG1pa zsbNyfLmONXFRsVHQDHctRyt5yHHc2UsHNVE3vyE9hd2bJwWA1+PwR+QJOkQ/PA0I2tZTFOAHV4 Fa135UuNa0KmkS+WXMFfMCJGU7YT5tYQiaYGb3Rp7yrGxCTmIw9NpnMEUel5mNomXqP0bVsZWyQ v4oBRaSN1IJU5SkPqFdD2VSNEdSzaT02tY5KbJOuuadn/H+NaeQBwqTKHqsDK78EtjxnPQ+SrYt Pm+Vwqn/rCwZWXSsUK+CUKjU0UFGbiDU1F820= X-Received: by 2002:a05:620a:d8c:b0:8cd:988e:c946 with SMTP id af79cd13be357-8cda19f6294mr859449185a.24.1773322195221; Thu, 12 Mar 2026 06:29:55 -0700 (PDT) X-Received: by 2002:a05:620a:d8c:b0:8cd:988e:c946 with SMTP id af79cd13be357-8cda19f6294mr859444685a.24.1773322194771; Thu, 12 Mar 2026 06:29:54 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:53 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:35 +0200 Subject: [PATCH v3 14/27] drm/msm/dpu: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-14-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=BQXxAsNkcgoIebP1VAZBuBHx3qvfk0HLeeYsTxoyeyM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2anppC3ym8KO6XdcRCp1SnmFKlx2bhqppr 3Vr+RU265aJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1Zf6B/90dYQfJofMo0jzPjYwCBIiQVaMZ5/4eRlYzzGNQoW8TFbe609iQZFNio8O2JS7QCh+EpK 350LDlV7+ha8b14G3gaIML0qRx3W6EGk71G+94lXvHP3M5b3xcYcHN3Og669ZIQf8EvNKGA5KDX u+IRFP6dKFEEkQbMpyGFht4qqn2TOLD9CNl9itmO+WUGM3gDXzeuaCa4yhnI1DWDij0wU1la3S7 OlPgxyfMfYTRF6wTk8GMAHl5ipF+yrHpBF6JQZbUXqbBtSCDbsV7ejq/2cpnjOJ9ZdGeIKHWDAr qUcvehsSdbCvxqoF27h+i/r2TRGyUlq7lXABSoxHu1RYvplz X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: ONDRUQ8zlTH2fWBMBz8rLEaHe9VYegJJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX+KX1t9Hd9tT8 hNhUqbWM0y0UGEpoZNhg9DYLqTXJV8Y2bCS7D+2f/ceAtahU9evSIYKcwXwFqSKBTo3gTym72Jl bBcxb1E8n/kLqpcjxIZ79uC3b1vzz/RM+HPaPB8LvallujNOho9MjJdTx6+VnW/zSATvTeqAy7B 2bDZaEx/5n/0b4a6leCUUsCmmhXQBTGOPPaXAraU39YYDcrYbG2vsNScMCUNj12hax8nGCOBjwa EyG1c4dpYWqnux4/E0IO2IjSAYMaFJgZcBdPBL6y3nw6pM/nbQQ7WTL9ltj5pbnQr9fSByTi9ic W6ZMolRKkbdCWbk1HwXP+uk012elx7BiU/8mdDMhaeou4vOlbwSDqpi7a5/dCvO8c9HycFHpCnt W27CTjsBo5qEfq+r5RODbfCFMvdsVDJymO0TTRLuKujzpBLEsS9oQUNljpIdGOxilvQCR31ndGt /TjzFTWQ7dgZjH30Tcg== X-Authority-Analysis: v=2.4 cv=DsRbOW/+ c=1 sm=1 tr=0 ts=69b2bfd3 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=46QewcZEoJiMQYndSOUA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: ONDRUQ8zlTH2fWBMBz8rLEaHe9VYegJJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index d3da70009234..6089a58074ac 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -318,13 +318,14 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pip= e, const struct msm_format =20 if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + ctrl_val =3D fast_clear | + (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | BIT(8) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { - ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EAEA3CBE85 for ; Thu, 12 Mar 2026 13:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322199; cv=none; b=G/c/nTAJDnrjVwuxE2/dEUIT9QnU+CYs6lbUgA0Upta6ciWSdB8pALz1/H7L3cS51Sa9SSympEPZAMYkB060Wb/ALxkNYnP4G+MF2g+4vLK8tdSoOTROS8eHYRcCIM1tbYtCvglQJ3gtTOGQvdReWyVpwO828kDmplUNEHZmGsY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322199; c=relaxed/simple; bh=CN3kZ0/IBWNiI5YHIzLGKD4m0aY5Oisezj7zkRehZl8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=unBl7KbwrJBD8hZOy5PRnEkP0+ts4F9sqCxSVLpZqziTGuzrX6nMLZdwYW8d/sgqQ93awNgEiffe1kM0hZtilk8KcgvxVwMc5RuKJ9zmFnty0YDh0pLasVwQjbJHRAgd3MC2m1qRmk3hExHM2qi/6Eo9cC5ExSUpnOpgUoXILXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nrGJls8F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fwMK741/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nrGJls8F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fwMK741/" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CAM8xf1756601 for ; Thu, 12 Mar 2026 13:29:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=nrGJls8F6+SNjwuV UpZi9Q2c5amWPB4V7Izz5ZPeUHb81ExPklqbeIJ5hCi1qUQq9VZ3q8GS7+vtzpL2 cCgIU6uWwI4/zMUcJXVHkq59uLrdAXl/6j4bvEcgB2/bdqKfKOG0FxXfQ+KmgGXG 4xTGUeNcdyK2e1P9mf1iGLKfeKdkZlxImJuBUKi29cF20ZaYX+IQ+zJSFr40hOYX zN3Hoh3VwFDUpfITXhFdIFNipPu6TFAgBfebTDuK3VGGFdQ9EOKJa9+UGxlwC4p6 AhjN1xdLIgT7s2Q4q1Wiqzl//hegv2daKtag1JP4W4GDGmjUSfe1Zl9PLdueAK4N NzsY4A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53j6us-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:57 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd781c0d90so1189567985a.1 for ; Thu, 12 Mar 2026 06:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322196; x=1773926996; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=fwMK741/vMwJ95Y1TLqWeVISPbjrX/0j49VGjipJ+Fhjfb8kHLM+8VmXwDQIByNhge XKNBQUf1Hco+aZgmCgwuLkwqcl0mSQfmNNlM15Y5XqvL3K0mcD+73q2UDuSwAFH6x3eU oFh/ig1C262B81feukyJwRqEkC4fLTaApoE9ONgreggM03pIS+N2wh3BXF5xO++/Dhy3 1c3Yh7k/+TOlXi2QKPZFQTDclwtiwQ7C88DZsyKT+/E15SWUMAQG5Xo/HpxH2GmOkuEK 0WLh1cInVXq7/PIM6QMmBy+TQ3vWkchb066tg8AKjU68OY/sfG4aZC3/MBD/g/C1uHdS 4REA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322196; x=1773926996; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IHkjxAifHisAGsBgDLIKhhx6s1dp+Liwk96nqDXbhiE=; b=mV4raBi+GWIU5FyP1V4/mvDnK3+wb+cEGzUBaoiwVwj1GGVMmZ4sPTIDjOYYH1V+Jx gZe690hlQrVA95Lj6GgsBirfkKZ8Hx/7HBQe813tMXMtGOg4Rx71+ke6w0W21sI8/0mL 1ACuRPT7sUDVJPuUzyD9lFDR4cjtbEDgqt0/HiDmxtKLbbXaxJc7c+fyFB0KyWodRIK8 pLOPHcKFqts5MibaPVrvoGEfImRYWw+CdSnsh0NlSCtpOEKxs7i3pgmmbakycpkvN6bR IHjgg/IWVGcCoVsWIIvuF90/+CguB2CBya75mAzt/s/y6RrB+pzDyABFcQpxzeGY1oRW /fzQ== X-Forwarded-Encrypted: i=1; AJvYcCW2k+IJRaIhq1n9nB1Y9xDhuJlFNvRuMCu/ZnxctIv2ko++lIDMbLbk/d1d46rBRsX806RXTrY3iy19zbA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt/CM9kxe0k5kSMpNtBKICgcbuJsj+mchKGurLWzf/5WkZeXWd d4vfStftXrHDclNLLUyLm+KB4bDGJ4tLA9YmESvMBoGCIfV010CIZcQpzWbRIyQ0JNcrrTvhKQd 3TG6Tsh2405RfUfGvLdPFj7fmqs+x6Vn3b4Z6cOhqosKChQ4FgW7NKuIzC+LZwARnbji06wQJdI uuQw== X-Gm-Gg: ATEYQzwgurtqw6TuzAZ2kP46lbIdgSq32bTviBrimj81PjYowNQ2SHrR+f9zwQJW/zG tKryoHsMzf5y+XNyYHSJ65q7sdCT9um1TiSuGM9VRQNRX0B3eIMZ0L1VzAD8escMPB6o6fA9R+X hnZFnsODD+QDyErobM0JAdN33AMGiVqOVl12K5IUGPBlrtm1Ivz01zgQ5PQxoN/qQABl5MRkoTh dLPMFbKLFBTYJSAQQPHcMT5cy/p8KOMA8y5sTrT5pxPd4jJOFchmByrXdLgtf5m/iGcAmOedR+f sDC3MoEGyhfkMExrbnOt0AcNys2rDFuDKeYfhZ8Qjq1XyWJHL1B/jPhtx2kn26MGdYh7xvPOrFJ uRWZjlm6qJi5Cwcr2sqbxsueki0qB/HH0UiVHpXGSFUH8sE+4UW56phS/gbi6OkNv74cOiqu4PF moVypqe6jTPDxpHOkwNmKQ7fdQ4P7lXkVWepo= X-Received: by 2002:a05:620a:2608:b0:8cd:b341:7593 with SMTP id af79cd13be357-8cdb3417670mr86995585a.19.1773322196633; Thu, 12 Mar 2026 06:29:56 -0700 (PDT) X-Received: by 2002:a05:620a:2608:b0:8cd:b341:7593 with SMTP id af79cd13be357-8cdb3417670mr86991885a.19.1773322196158; Thu, 12 Mar 2026 06:29:56 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:55 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:36 +0200 Subject: [PATCH v3 15/27] drm/msm/mdss: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-15-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2044; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=CN3kZ0/IBWNiI5YHIzLGKD4m0aY5Oisezj7zkRehZl8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+2jQT5pOrOTTeC5VX0xsxPmWNd6PDBdjyjo BZtm+GouG+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/tgAKCRCLPIo+Aiko 1TX4B/9882VAuHu2t29avT6n+6Ies3TV9cF9fpKejG/Jz07h8LsQAhLyQiGiqjTzD/4UBVi1XQN oZf39xifu9Fs9UmrPRMwkFI2XVppauY1PP2KO1xR0f5PXFDcBLtbVD1nmgG2ajqxr2kahDgS3EQ BFIonfPtygQLDnhdp4W/Km7Rlvfd1PbbK9JRZHvhKGIRoAqYjRkBz7YgV3/Iagq8gXNqfRW/7+s vYbdMq43QRKkZ50RTYyKltULaB4cQ6nI7B3yMmc3RIDIq4tzZXr7CQcRuOhX/s5liAhCiL/K2Ps ZtzhrMNMQIrA3N06rMNVDoocwKHB4YkC0pA/wNtdkh99k7cy X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b2bfd5 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=crYPmtHWi7n-_IQ59sQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX01kaxf5Lru8Y fqbMltzCkimrIUsHasy63uWOyhbLL40X2Xk7Rdcn1OE/6GyyUPPPUQPBoAoH6msVW2mQPdJi/ZL ZHPGP3YDc4TTHQAFB3lo+A/LtSjVXyNHdP+nxi5uoM6qvN5OAOLln8KRMSFJCSNOLdLpRLxHYn6 YQteKohiJWSfyZVtU2IEfI+WpP/nTnjkAkZWimwGLW9yIvnUQb04JPqSneLVEJlZHJzb2I81esl 29eZE90fCOKfyRujVAr7adTcS56QgdSd0hR9932n43kOQMLTtLQjSAf21DKaJSpbotb4YsedB82 2HschG0oTb8r3i6mSB+0uBC00+vi+LcFEsUFnLDXtoolzX0leZa7/J1R6ALzO4r7LyQRmU7BtKw bt3q3P7Y0GxjU8m9eT2SXhm1NwVEu8XlniK06DydYKaz21epqjepPglp3Y8WukLzzeVFoTSu93T iH+jB4VqDBqGZzoggPg== X-Proofpoint-GUID: p8Hq-DuWmilwBZda4QXvsC5SDujNaChP X-Proofpoint-ORIG-GUID: p8Hq-DuWmilwBZda4QXvsC5SDujNaChP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 76657a4a8f65..ca59bcdde7b2 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -169,7 +169,8 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *ms= m_mdss) static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); @@ -180,7 +181,8 @@ static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm= _mdss) static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data) & + UBWC_SWIZZLE_ENABLE_LVL1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (qcom_ubwc_macrotile_mode(data)) @@ -197,7 +199,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; - u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | + u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(qcom_ubwc_swizzle(data)) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); u32 prediction_mode; =20 --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683523CC9E3 for ; Thu, 12 Mar 2026 13:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322201; cv=none; b=qIp2JMNloZoOfORyTE9dTqUcOLHNaBeQnhqTD5Tj4qYOVZkyhnV515o4Nzdz0INpeFt/5wMFoehJ9xP3+FzjXIWzfvVSc5k8Ukeuqntoj9MTis1otH/86Sb8cEw2sBZLoV5aspSR8IqLQCyVV0fiuts9ZXUx3nmjzjBFCeMeRLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322201; c=relaxed/simple; bh=TtYxTDlV4ADdZSME8a7mAAI2svRlACyoCBLVOWAbvo8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yrp1ozSOSXBVnW3Jh9XvQx91KS7h4QMSur0MM2/yMFn+b4RcsXEvzsNAh/e2a4mA5aWHIeQwJlz3Hs3MnMACzuDbCXjtth+wRjsAKBo1iuPURsw2PFPS/zuKqy4l7i9SI38hV7ydopJtop0Coo1sT9Wo2FAg8HDR8T7Wwg4xOwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rdfy4LiU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M5zgSnkY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rdfy4LiU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M5zgSnkY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7e3ns509808 for ; Thu, 12 Mar 2026 13:29:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BRGxG3/EH5DbV/qm/ujSo28MLbGNL8h5SekKq5Cws5g=; b=Rdfy4LiUFOr/CHJC ZXwzD8Kdes47Ov2XgqR0+fQDpKJY0ADsjsStABKGPGKU3cWJImPLqaVbURDduaGf PwOqW5zvIDr6XuvcGhbuXwp+GqgTXZ4o4XVsskf2SCPHbzcf5GXtc6EF8R2GatgB QFIZnrnAZeCPxVhey0FXciy534ci5K6NVDaPZm4pwpNOVsDs0TPjyN2hdXmz+EcM VW4CT2l2t5dn6PFIyOK6NpsezUsOt4SnlDpUoUHVdBJrnEI8hxClQfjuV5x+yg2F HnjjeN451LJTqQsvwOeOfO5kscfXv64xAEBqeOJfufZa140j3RhG1wx8fqbtzGww tGLt4A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vdv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:29:59 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd773dd409so140759685a.1 for ; Thu, 12 Mar 2026 06:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322199; x=1773926999; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BRGxG3/EH5DbV/qm/ujSo28MLbGNL8h5SekKq5Cws5g=; b=M5zgSnkYmXHO0si7Fj7ftcUT5g5/lJa9UDoBwHG6uLn8fx0CWHDYl2uQjtU5mQnwNW g7NYAvgl/SoBnNCuX0QU5bpEOnKwUR3bT4eAPID8vdPKMQgjPqAUqwTQBEJLYpsw/L0X zsZHvUKLqIWt10NO5a2Sq/aXkxjSU1A5UMzKSLDRpPBlFFHP0GVQ6Sk2anVrrCgxX9hW BK7tr2v1jHGTH2tUhYJJFo49tF2yb1v6igi7yd06p2Eyjc9hNXblBbpUYBBDH+2x1bHH RVQP/qVVB2XuJpZBLKkFQcUpWX8XNE/8+wJnvPef9adrxpDmU0d30rdm19cjoPdnD42h T65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322199; x=1773926999; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BRGxG3/EH5DbV/qm/ujSo28MLbGNL8h5SekKq5Cws5g=; b=l5t77QXa4CzDu1rMYWD2NkcIMHp0aFrgn1kE9WSjPr6g8NwOuQHFPOYshe1n82xWKm VyL8NEppUmh00ja3RJWpVW2JxKjwPH2d4L31ewpAS2Ox0npGi6OpT1PI1dK77Zcb89MR 01dQBcgNBe85cxwudFlaPZfj7Ez26GC4oi1PgDzF7jcoQ7AElMlrNhNjugT2aFEFK76L 0nX6qQoqFKwYdsNZibKPghOWgpXS4t7kgiwN/xeRx0+kinY43YiIVaCRqv8j+QUeP+bj jVMrkEmiWHGOTqlaM+KDDmuhAkl3W3upjGcXzRzuPn7Dk7Pal1fgd0yicz8q8IxlCPhu 0fQg== X-Forwarded-Encrypted: i=1; AJvYcCXlI4bInF9D7ot8OmMDbzE5rCQDY0M1OvAgFWqHjOvkssUklvqFKNykfUrctDcE3aVXrF8RWe2OCv6Ugl4=@vger.kernel.org X-Gm-Message-State: AOJu0YxWdfYZ5rSBa6HhO6geh8j7BfCnabYzpKBVjDndFI14aNQ5hrEn cGbcqXRFbbJtm5yqnC8duJ/pBVV9j3CJ8uCEHjXQFsivO9JLEb+B/bh94HJ02UyesicF5tsfy4F iQ0Zp9Zv+5Wd6CmDHk4wyzAouEoAyjhjB6aHuM2VvNCNPgXqEOD+EWqcJ7uHKm6Y/fxY= X-Gm-Gg: ATEYQzy92rlTkg+awi0q69p+efjytapjUJ4jiVcqKZtCkKBTyiLeUtkhpY8ix/TZ3tP Vrpz9DWCCK/FGL44JkBXdBm5D0s4xWiiaElDBPrqKzul6Z+TcnyzH5jcMSGPqaTyXr+CDKTYGqb i7J6f2ZJ7g2yX/NyjXuudjQS+1DBN/M6tU9rKYi1FrKpF8qg4pmosIoOgC7I2tE6ko8KW3MfW2T arJ/v6qT9DooMtOBaGaIFe3ZwxdUkVgM4U6quyBbZmnd/qU9ltebNhpUhnQmAS7evvnd/HOLRqm wKHIC3czkUiFHprJJABFDYEdTG0IRBJMStE3JsGREYFXj8uelEUOSQ3k8AJ1FG4rVakHRsLsSgx eIf0qbd7TfR7mkDRZxdpQLYvedcpjXrg803JU65bPOO3JCo3o2D9KAXj4Y4AKXlfR8zn5ijuUSg U1ZndUWLEeeLw+ilOuUhO6BtsSQRhaQi20hrg= X-Received: by 2002:a05:620a:4692:b0:8cd:8fb7:7aee with SMTP id af79cd13be357-8cda1935caamr806943485a.4.1773322198799; Thu, 12 Mar 2026 06:29:58 -0700 (PDT) X-Received: by 2002:a05:620a:4692:b0:8cd:8fb7:7aee with SMTP id af79cd13be357-8cda1935caamr806939185a.4.1773322198316; Thu, 12 Mar 2026 06:29:58 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:56 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:37 +0200 Subject: [PATCH v3 16/27] drm/msm/adreno: use new helper to set amsbc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-16-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1854; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=TtYxTDlV4ADdZSME8a7mAAI2svRlACyoCBLVOWAbvo8=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+am/dvbtp+eW7DQsPfqI+kzNWrBh67frSmTWV4xXSxk5 ouztfuZOxmNWRgYuRhkxRRZfApapsZsSg77sGNqPcwgViaQKQxcnAIwkbWP2P/pcF70bfol8eTf hcUWUw/HbL+inXi76P7c6e2neKYGeFe1HFxx/dOSKTXbpVpfbNqU8bar0vq9pNzjTwwHHiebhqT Z5U3g/yK/LWpndtAWxSyhFwlvV4uVN4T3rotJCGJN9gw82pT6tiTlhrQfp3Q5p9DCp1cZvKcFM5 Vo1rj1a2lsUWgrLmthMvq37kxFVcrl8vApyawvFurb3l54PrXOc3Pvsak6y8Xq03aZFwd+lNYTv bMkcGlAgOSs9imrLKovKCmmRm7RvrhBWupKbNnPh+4Pl5ZKmXkGLTLKk5Rssyrl3Wusu8Rk1XrV xFj5H8khHc6bH7u3Lv4oGpc0SUJrH5t4xGpHXTfDPAM/AA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: bOQNP7gKzDG0-i2c-f_zXe9fU2E72aUp X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfd7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=PQquZ71z7Ybx5dfXpIIA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX4n5AcPffch6U DCmgIssP60SBpBMHxo1Wr7IhQ4K7LvivxR9Xcg2MmdI3yQdaDwCnQDDYrg0c1svKZQPH8zhODvb pYWwYRsXw0Hw5P0IE+gH4LbXrWcIDz6UhcAhlZdahv8/P4mzmSGXv/iVXAyHXrFRPT5xYvx4Q2M 36QhN97Tb9cSYkEjixDLvC3RVKl+wFrGrtDY6v/Se8DF6v3Y4ebNNhDZ3S9TgHhhYUeIRs+MCZ9 njQauhHqMq2pFNc5Hh9KRdxvUF/xGLY6fXc0NS16DlCoD4FQY8XN8nRxet48wWw857Agb+r1/1L Lld+Voq5PXYJae8eY8xFHA49sB4wRgg0RQXCxk1/a0AI8kncfZpIXuSkgUoEMUxh1Q5btPIAe0c dCjKx4ZOjXbypDJ6rWJu+wWagCXwXUpaqP0RHnJeaUI0gqzXWiJ8NvO8qZegcjjBAX9h65NZIhi oxwWgy2tM65fYDJziEA== X-Proofpoint-ORIG-GUID: bOQNP7gKzDG0-i2c-f_zXe9fU2E72aUp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of checking the UBWC version directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 7be31de3b525..f6bd906f2ac9 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -743,7 +743,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); - bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; + bool amsbc =3D qcom_ubwc_enable_amsbc(cfg); bool min_acc_len_64b; u8 uavflagprd_inv =3D 0; u32 hbb_hi =3D hbb >> 2; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 680f0b1803a1..63934d21c831 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -275,22 +275,22 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) u32 hbb, hbb_hi, hbb_lo, mode; u8 uavflagprd_inv =3D 2; =20 + if (ubwc_version < UBWC_6_0) + amsbc =3D qcom_ubwc_enable_amsbc(cfg); + switch (ubwc_version) { case UBWC_6_0: yuvnotcomptofc =3D true; break; case UBWC_5_0: - amsbc =3D true; rgb565_predicator =3D true; break; case UBWC_4_0: - amsbc =3D true; rgb565_predicator =3D true; fp16compoptdis =3D true; rgba8888_lossless =3D true; break; case UBWC_3_0: - amsbc =3D true; break; default: dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C495F3C8715 for ; Thu, 12 Mar 2026 13:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322203; cv=none; b=Foyn2G2S2azK+Yx+8BTH1W4ikZLXDmtxQCSCEiIwFNZdnQGZWXn/J+VVAbL26sJ5EsLp4uqLiAsgzu+TnF8C85FSQXYSuVUE4FwZWAnrHZGUFdqlEnisFs4k3Y5WRw+AgyyTLHaUkbo0oe830+stBh/nzfgqQMPz9FNIjR3V1uE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322203; c=relaxed/simple; bh=oMEm/PoPGJyi64CJ7YjawXSAAJStb9rr/IdLW4TZb/4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wc2kQFoV+eJpy5zR7fUkS1lf17/+c5cCAy4KLWUrJeivPvzkJpBfZ0Cm86VTPQl9OsxGBi0e7mjYfdcdwAczhBPoiUJpGgvuoATR73HLvGN1wQInoKfml+2RVwTzjD5ugANtNaS/nApSBtXFLB5AUJhWvX+kPWSArS+SHO0R6OQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q4vC7xBD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b44JqLSK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q4vC7xBD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b44JqLSK" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9nAQJ263530 for ; Thu, 12 Mar 2026 13:30:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r0tY90zt+EixmK5rB9xhMfhGNKcOPEXVA78lLnDAFnI=; b=Q4vC7xBDMf+2S+JS TmKZ6K7sZpPgKC9IPuWhdFGygcRWVRsuUDiG03VV6dQILGn2B+Qs3yHJ2CpWO2Pu BsqvaEau9jf4rCdY0XFam/jKf7165jUENI4Fn+JZiWADlg7GCLz7ZpHH3efieZLB eh/i7VY1rLwbYLU/Gsa1SuvSFqjyvRdhesl/bBxl1A38Eq1oiHBnqKvWPRewX2qJ xuSH4vTI62tjl6E5Wl/uKClvk7gZaVY1/5wg/Ao+rENKvwXyZ0PqFCj4qJTdVpVZ STUYsJRvstO5ahgnVGtqtBbIhbeKbURG07tFlhIWOn06dYdlUhtTARDDjQqV+9JJ ZHWIwA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj679-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:00 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb52a9c0eeso1013031885a.2 for ; Thu, 12 Mar 2026 06:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322200; x=1773927000; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=r0tY90zt+EixmK5rB9xhMfhGNKcOPEXVA78lLnDAFnI=; b=b44JqLSKFYOVW+pRlXrKQ6ohsnsT//eYzG/Gh0h6SPsoi5RU2w9CeDPk9Jf68WYgiv Q8FbDRAV6UDevIZySN2e6ysU92/pjVMTQyjLwWk+hbcE15k2pY6Oiu1Bk+bFNPqgn7/Y P9/Bpmki4BSUlSc335esto9/xHWFL8D4ETpc5VQXlaQg3EROQG/9pUjHZgIbcENn7X5c xAUyLNbU0FzzOTHXfaFWVkAlkcewmhRoFlG38BaWm/S3McGDZAkOpv1h+jV5nTPR75cH H6HSZb8cme2GANBvnMAJ0IuatZ47gWw7D+CgydWGZrHJbylzki74Ff8HYKJDfl5koEZR qEMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322200; x=1773927000; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=r0tY90zt+EixmK5rB9xhMfhGNKcOPEXVA78lLnDAFnI=; b=NziH1fV/PFP9xfFOmcCO78RKURQkUNPmWJ08uz36sdvUXHVhAh04SXLUHGS/t2L1AJ EjJbPZSs0Oqy+tJsHKcisgYHI5KTYMQFqFZun6jxOLZx/RplVWLgnZa0wEZR4j8aNba+ LEGD9aElhP7XMUNg0t9TrIZIBej+lggN7qPQZDzNYJGhoAe2pYo5V6axwoiHoKrJMmp0 YiFayd4OuRRy7fHw06c2h/bYxf9d8wWOLgbFy783scteaW5lFWTLAf33ftTd5WY0JwA9 97vfP+n0SIjOFV/p6dD/9H33rRD5QMQ4LNIC9Wk3tXTl4vFfrcI3gVxvmvzmjBUYD9+A UcQQ== X-Forwarded-Encrypted: i=1; AJvYcCXAhnNu6nQGloTmok5tOUPX5w0nGJ0LVDYFO+0MHljxCekycxEEE3/l4BV3YO9cDA0EVt4i18+Go/Q1yDo=@vger.kernel.org X-Gm-Message-State: AOJu0YyjVOVSKxBdg3XO1vIz8A8/8Ykvk9Udi6J1B8h//NqHphTUGcN6 spR8nbSAkFtuphKuRipAALEfe0GnJcNsfleSaw3EvYDXzTIXcjZOwTb8AriPd5roJLdcF+zLGnK z0sqj27eSXcxC+S9PDZfGDgyIHAUbPwZVGe2B80h0A7Lw4+rTITYVG0u5Q+L1ilHt8Q0= X-Gm-Gg: ATEYQzxIKkTP8D2uCDMg/ooNa8WdnsYzMk0SPOa9a13PbRAc1kR5kCmk2IZQyuj78Il lfvBZx5Sb3Q46dzNJOd177rHfs1WaTRI95kozTRvgIJ8nkBZF4XUcDjdjbLMbE37Yg4TDDkiiEg mbRqIg1Br+boAdu9U9zd11XOnhDwEXh6AnMHVJb7CFq7FRdCCIRGhciEqnfPdjbedeBmm7AslAF /Wi20lAdrBGyPiThIfx8XQMnKTJTHjeLgUt5Bhw4JlLJsRRUCOudQrZu6jlrD3Tyb33ufS25XMF SjuTUrIYWB1Ien8xtyKaVIgk5A5h41sw74JqAHI8mp383BCs2xy9H0jOxVoYKekGsAnNNjReGx0 ryBiy9qEtAWZKe0YNg1zP4jvjUbtKxlPDfAYapjdNlsc495kMa0EXW/J0agGCo3rDy2DCV+oVDX CFVKjWGnypplbVbeVNQanQyh6hvxU4WXVI7d4= X-Received: by 2002:a05:620a:4103:b0:8b2:e058:de83 with SMTP id af79cd13be357-8cda1936221mr790909285a.15.1773322200210; Thu, 12 Mar 2026 06:30:00 -0700 (PDT) X-Received: by 2002:a05:620a:4103:b0:8b2:e058:de83 with SMTP id af79cd13be357-8cda1936221mr790904985a.15.1773322199750; Thu, 12 Mar 2026 06:29:59 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:29:58 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:38 +0200 Subject: [PATCH v3 17/27] drm/msm/mdss: use new helper to set amsbc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-17-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=831; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=oMEm/PoPGJyi64CJ7YjawXSAAJStb9rr/IdLW4TZb/4=; b=kA0DAAoBizyKPgIpKNUByyZiAGmyv7eh2xlijC2Ywmck0cgwp9QDCHWz8Sq+EvSTEgjQfnPKZ IkBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJpsr+3AAoJEIs8ij4CKSjVHswH/31K 5W5vwlr/H6zY33xEcSjGjJbEvrK9D8tDi+Bf96GfGW6+bWkwluQBb5k67TrleO32wcamXAt10Fq FcB9zTNOLr85T9gkukmWTWKDtqRegSefoRAAy1gsFFDhasMacPoRIFo7PADuLQZGIYsTUW09ys2 97ID3UvT/YKgXz+IdlnbqNdUUEoXU9H9dpdEh2eOp+iXr9sDuBZ9/a2bXXmYLvGA9y9DilBTLdl weGaLGfv2OO+Hz7BZDjpDA9PHdE00wOJg0z4poF69JPHOX/su4ilWepPoBUY3tmhn2HhOwTd7Wa NNWWNK6vITAr+krTbmzY7FHVZpuRHZPHA8plyUs= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX8janODsFQe9M eoiulnIfaLHbKDXY2srh8quMdESOa59sgvpbKn/vr5TtlxXEyCa35RSoCJa05fLg+sR1Ylktac1 WhhOmyqigCGy/yhzDFLq9ZvGa8btIrDkhbUO8oZFFGR8GTcmIpOtmgTlxYL0UUG9nWIusQTgB1R tenBudajraoeUx7frL17caSkvHfkFbRm6TWSp4DTL6Its6NddAY05F+roXRkda1wbZD1ho6jGO7 /W406ms+9HN6+XQX82593ITrENFxA3PuZz/rGZC7UuDR3ZdZ6d0CL4yLIDlwXzk+J3E9nIt0YIt 2MZ3lJAC1LgHSv1pdFD9dIbkPO7dOVbjJatQfAqSuofsYPXuVzb/SYsJjGGww5UP5+sC1828GGW hQxJQVEqL07oxZ4R5WLJ/qxFeg3cQwJYkG5TWt2toWtlRTH4o+AYe87uXFjAZ+Nbqc+EHjN+h7g T6yuxougxuhO7QjamQg== X-Proofpoint-ORIG-GUID: Q6-F9uljEQZ3Jpnfb2lxoii84g0Dqo7q X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfd8 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=rfiAuV1fBCuPYiFmeCQA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: Q6-F9uljEQZ3Jpnfb2lxoii84g0Dqo7q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Use freshly defined helper instead of checking the UBWC version directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index ca59bcdde7b2..04efc29f38cd 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -188,7 +188,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm= _mdss) if (qcom_ubwc_macrotile_mode(data)) value |=3D MDSS_UBWC_STATIC_MACROTILE_MODE; =20 - if (data->ubwc_enc_version =3D=3D UBWC_3_0) + if (qcom_ubwc_enable_amsbc(data)) value |=3D MDSS_UBWC_STATIC_UBWC_AMSBC; =20 value |=3D MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b= (data)); --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BD343CCFC9 for ; Thu, 12 Mar 2026 13:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322206; cv=none; b=THTnkhrEpaf2/KEp7vbklp0Rt86DX/XXBpK9ZvZnDUfNQZcO82QlGsGXmUYtl7iR8EFBk3CVVqpdL7Xa0WGxQqZeKGVjrlCOORse7EJr3TkXG5H+HYb/ZqgVNP/KcMQMqMldMiegtv+wFCvRc/oiCR4PUMrIripMt+nHT2+hKgM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322206; c=relaxed/simple; bh=hheiMl8VJ8rTRpyUKrTSw/T/7nX7ElA8etZcspaY4GU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a9TwZHMmx1tzhzM+KqwCzFOJInsWA5QtNIs6J9/285c2W1lE/kjgxZTkXfG4HHb3b3gZ7cqWqdNptjeibPBuyn1xe5mrv82NEk3jZyyHSGB9v8gXdOU9Re7NmjU/xV6FqLhYznTprw5ltF399VVmcTR2Cu7sx9c49E99PxReek4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DMp3EMPh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GIOuSIqR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DMp3EMPh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GIOuSIqR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CACiqU3666960 for ; Thu, 12 Mar 2026 13:30:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h4ycaMV7nlSUQ5du4YcIwqCqGJ98D+lbtRqht+ED2K0=; b=DMp3EMPh8cH/zFJY yi/3ISCFm83kJOxjvjsEx+ECAD0V+iHYp+UDVd3y958Sk9/1vDct9vleEJF0FZMH pI160iOlSkzLIqqGSg7cJIHE0uG739yDRBXaHwyT/iOw78oq2kipQVdrPhXiHtk7 1Uwzg3l+SHsSF1lVmxN4N/VHCY2fwd9Hpnq1+QDnrMpS0qGNnFBMfFpZT/NsQaAc i1OB5vs7C+/cpC7CDkEi/L9eOC1r4hpJJhwldHZVO/UNwA1KCh8YxMw/jngKL+k8 U7sx9SQtiaRDMXBcsZjXFrXhfoWsuNfHbSgSUhpFX4gyYDiEwH/Xm+jxoehWBQfe gc5oFw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh60j7w5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:03 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cdae902bccso302102585a.0 for ; Thu, 12 Mar 2026 06:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322203; x=1773927003; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h4ycaMV7nlSUQ5du4YcIwqCqGJ98D+lbtRqht+ED2K0=; b=GIOuSIqR4Y35bz8ZLvPSLT0/N/p6OmHurGzpUJTSxH36o6PrACABtebJIC9vaZC4ae Lz9FLyU7QQbO9CTC2FCV7zz85B4Msleyd+yubr5UwcHXDJENSKyAq1umw7e6zoxlnjAt 3Pl6K84LbmbSyxsaFrWOlKE0pZD340w9rHWz7HvUgMFzD91VOk4+J1McEmo6tYYFShm9 oc9NzikJoGdx/UteiwO3ujnM+f4xCJ1/dCcXck62ZhpFIkvb5BVnqCQZegmmftIU45jx +4VeVK6Gwg0ra3bHOxNGsqENDWqZXgdLBDJdM6S8B0V5clMqiBGahAFeTQS6Pf4K5Sks +OEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322203; x=1773927003; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=h4ycaMV7nlSUQ5du4YcIwqCqGJ98D+lbtRqht+ED2K0=; b=Ld0EaBb7sLfHMpY3GiCHWEn/VVjS8Qdycq4RMG9rBAL6nSXxdw1fKlXHPiGk56REn3 XiyjGQZJITp7a2n7sgSWwbNrV8XJu6x3h4y9SMKqt0qTzypyVlrxEUOxn15WUhGxaqmD zAodTB1FjuG5wYH3k/rnAHfCvjij/lAX9rWohj7lbgnyO2Y3V8PoT/0SkpqaCCo+OlGb HlkBw76R6pV8o0q1hjMOMyaC6Be6xZLoDQ6BsQ3H2Y8mtmTCU9lY9QXf4/q+m6Sr0Ksy k4z9yZib29ahDzAH5CIaH1xkj985Z7XIZ5tdTRKVJtiFh4rOeKVLunjlSyH74O5BiUYE 2pYQ== X-Forwarded-Encrypted: i=1; AJvYcCUIzGYV+L3zFK4eBMVeW7vnbIYVGP5r7fTdYZERcVOIcNE5OU74vdRZ5tiIoWBvsMu7vCir8IF8j4QuQp0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8ZgrefC0VYAuFQeg6U3gUbQzVLMkhqcmajKy7LAlPDPO7OcOd tLSW3Y0Z+LMT22M09qVX0BBCXpKXYnhQQseUr6fa1Yf/cUxWhnRA/pha2wvjK9a+pwMGcyojWDE AtzEXoSxBTiAXM66wjNMFUk17ohwB9cCtSInV4aBygcYayxrEOYkXpOHHWl+RArPeLmE= X-Gm-Gg: ATEYQzx82t23LOM67hYooS7309OzkCxEtSMZA8XKqD5mEo4nV9MYvOxL19xZpm0w4c3 sdv/OATlM/mgRFfhjMra/P/Yvk4d8Z+TK3Yb4PWOVzBkXhlZ+QuRAd2zgNgwSmJfD383fN8H6Ff sWdv1CSxnwLmsWJldW0pI/GUoFoaVAfWPAmKIPJW9AFDPmpCBL1kR+SAJgkLPRS3Vp2NnKZy+gS 8wSuU+adyDMVaafpwvfOgVPuZdsMAcoAohCRb476leHlXum7Wp65Tpd19kHbZ5D5G7itSiRSE+5 SyiLZuHETJWd1nzUoycMrKyLc/hSLps3B+z4gwoKXOQau0NDkh1BPMLNJGqFFIrlKKNg+7jkFp1 gv8E+0bv+MLAGURZSFN5F8Pjb0c5uX2HV/3yqTPJP9TjsQCWxEHzJhxx6z94l/VVLMsqhmXtpUJ I6GqzO5dRXO87HkZz2I9cuas17n4RriG3vbVY= X-Received: by 2002:a05:620a:459f:b0:8ca:2a02:dfd5 with SMTP id af79cd13be357-8cda1976568mr766527985a.30.1773322202980; Thu, 12 Mar 2026 06:30:02 -0700 (PDT) X-Received: by 2002:a05:620a:459f:b0:8ca:2a02:dfd5 with SMTP id af79cd13be357-8cda1976568mr766521785a.30.1773322202315; Thu, 12 Mar 2026 06:30:02 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:01 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:39 +0200 Subject: [PATCH v3 18/27] drm/msm/dpu: drop ubwc_dec_version Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-18-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1070; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=hheiMl8VJ8rTRpyUKrTSw/T/7nX7ElA8etZcspaY4GU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+3daaSStaL8hHElPZDYT+zGkLHda1WcyhLO u7SDeCf1mWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/twAKCRCLPIo+Aiko 1XORB/wNUAQ5nNTJ9ijZ5rhBsfM1jo1v4fNzrUbKr52xNsNp4w+nxyLRFcetCNG7nrzLksYTbtW IfqVhLIgDZfr9acdUtP2TbPnHbnuKkrdDkfgXIb44Lccjuq2cmXgsKNWfJOPsOEUXLgx3KGt1tu kb5P8pR2YSMWti8t43bZBMIMX4yRF44qAIDytVB5SCdENDhymNHFEmjqEJ3Yrsyy15tj6dN/fDb k5D+iJvr7T73ZtRM6ah4RUZL0lEI/3wAIXulWd60m2T7IQUhFG5WoYewujLft2KpJYJ/D7YemEY UaeSipoS11IoXIkdlqqZxKbpPri4ke+spdDUXbjZ74o4L3XB X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: o3HH48a4IxV6dE6fa6ljqWCcNlvz_Q3G X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX/N3wldlmL5KC RiK7depYfP3969MDD8POOsE6+aPhuVcNqs1uSUNKEh2HRTJ+MrFJr+XWSERBKvtbTkO4Q1dPdbK 6j1BnxQuOJgnL3hHqXisV5aWz3bbAKDIbZhgbsqgvlpO5YGfD/muE2qFYOUh+rY9KWue+A5vWuv COMs/e6HC+pHx4hdMSXSnKreWWjWvUSkcvPfbKtlTq2BvkHBF6OEz1Mf1wKIMPFUsxWtfwr5iBK NQ/AUqVbnl7B9YWRAyb3TIwbDO6bF7ItwDD0o2ZbkuIvtTNNAc1qp7qJPIhL8tetsWBUjtNPuHS fWDscTSokQRamb0WMifhk0UVsOpS8AmxlpVBwHTJL5Ha4WmklnOKYlhsSEf+WgEa2974kcL50HS P9OlOD3L2gy5YGa5QoCRKqhAwk4f5ZTQFqCUYBiT7UeNLlSZQoQ67yRbb7zTPT8GwC8ND+5RiU8 1m+lfnoXdVVWC5tvYtQ== X-Authority-Analysis: v=2.4 cv=DsRbOW/+ c=1 sm=1 tr=0 ts=69b2bfdb cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=OFVxzADIxEWc22agC70A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: o3HH48a4IxV6dE6fa6ljqWCcNlvz_Q3G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Stop using ubwc_dec_version (the version of the UBWC block in the display subsystem) for detecting the enablement of the UBWC. Use only ubwc_enc_version, the version of the UBWC which we are setting up for. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/ms= m/disp/dpu1/dpu_plane.c index 547d084f2944..f424be5ad82b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1718,8 +1718,7 @@ static bool dpu_plane_format_mod_supported(struct drm= _plane *plane, uint32_t format, uint64_t modifier) { struct dpu_kms *dpu_kms =3D _dpu_plane_get_kms(plane); - bool has_no_ubwc =3D (dpu_kms->mdss->ubwc_enc_version =3D=3D 0) && - (dpu_kms->mdss->ubwc_dec_version =3D=3D 0); + bool has_no_ubwc =3D (dpu_kms->mdss->ubwc_enc_version =3D=3D 0); =20 if (modifier =3D=3D DRM_FORMAT_MOD_LINEAR) return true; --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B28B3876B0 for ; Thu, 12 Mar 2026 13:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322207; cv=none; b=EEQhZ6/sHFJ6y4mDUB6zgmVcsb52WAM3rQNJ4NozFFKxjcp4bDl3MgGyVH1LYfKXFmGakaW+sHfcX0TxNSgDo6+sknvjDbI5HPqts9yA6NOydQH0YKnJAGsNUfDfLV0s/sx2SaLO0MtJoUw8wg6phTd8WTDW5sF9SaFS0rjksJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322207; c=relaxed/simple; bh=OzjscEd17vm0sEmzoIKCQmPPncmXbh08UBSisc3cBL4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jbXHBA+1sFcLrn/m3X62rIl7t1T36rLWrmCtNk6XzNxd77W7moFZ62HTv6MVMCfD12FjZM4N3w8FmXAcAlUSHea7XqqVuEt6qjvWKXE7KgczRN884jCCg8faXPoYh9clW0DjtL/yZFOGfSezVI0TH9gzLHBVd7bzQDe/WY2Tlvs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U48nWBVH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RFIM9NQ9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U48nWBVH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RFIM9NQ9" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9x2Bs1756014 for ; Thu, 12 Mar 2026 13:30:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ibXJK/eidhWImTas3nSeFi3FQ09IZIZ6J+RmgmMVE8E=; b=U48nWBVH4h9ccIGx G5G9l+/VMgyjuh5ma+kKIydrM2tmHFnmH11tmPWqFdTqAainp5KKANP0w3kEoJyo 51xLDDT5z7xL0441yX4uOQLBGTCovR3vH02ZmcGY7Uj+heD/jeLu92Nff4x4MVVm da9xGv0HRCuIJ6hu/+QC18YJazkJqOaX8pqj6cvZpsWI7bFqU3HA9gJ31Hav2Ydb /DqdeIIBIMgci6piqU0Q75uuo4h55o9UcjQyeEHNqOyp0Q0Ra3n9Mp1dTm25HsBz AZZ9oQs+IM0NPeTIOVi6u5rT5ELcAhNw3OkCzN8hR05xWdTeDTFFzVBAxz9k4sQn P28mwA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53j6vq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:05 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd7de0e161so653564685a.2 for ; Thu, 12 Mar 2026 06:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322205; x=1773927005; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ibXJK/eidhWImTas3nSeFi3FQ09IZIZ6J+RmgmMVE8E=; b=RFIM9NQ9WTf6o0YsMBJECXOndl8mWXv7WQ3eCi9pnuVuwnHe2tyfwXN44QwneKQ7IX nWSje4mi0cfcpw8sDT+H8rcZax+T5wuG9qrSzn1jnJvSMTO05dqGsZGdvUFq3b/UOA9u h3kyfgq/Vs3+f84kb6FagG/Xb14OBNSSbW90P1qmUSy4JgLGbTDEZ4Fn/XCMhBs96r7i Dxil+Saftj0krBbsv7njfT5HnnU1CkMV8GwQUI4qsgbu3p12lqTd1rrq2FippsSPP0vZ duwKPkxN1AfbAJ6x3IVLF+9bfDSAaKXekCzhaVVviYr6s9QKJSol2W/EW920SwiqqK6O uHgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322205; x=1773927005; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ibXJK/eidhWImTas3nSeFi3FQ09IZIZ6J+RmgmMVE8E=; b=gBvqcQEzxD80hg0PMaN1He3ovdPmo4uBYxxaP8JxP+WtLRYj+9I5NEsjeEIaIKnu2p uVJ5vRUHEPYMfLucO748xocyxDN89GJkbrHSAOvhR2wPG6bVdoBZ1kRA2HWMJaC28A47 oAoEKp6cLbTn8yX42xwuR+ntzqXJvzpUEwNjA3qaVhEoU5QWFV856fwja928pDXy+pwH 5bojdYv5SRjiq1+ZN9sRvtsRvjBQmGAvtcyFx01w/QHmUYoAsOFYo+i1YrUSVDr/PI6a 8+KzgXaAoR5vpUpWbZCVOnQ9Gd13VSbCC08Bj/MGT1rrA4NpawT/ExqII+2ml4OxsfTs VnlA== X-Forwarded-Encrypted: i=1; AJvYcCWXhaIrpbabqJsApbYHC/jxMS1cWfhsoeQYOHVs0K5vphRNYOc6dZAHOSO+bCISCUZhRNjLPHXLvmnLVOU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGQmzG8+egkrz7XQsxIeuFsg7QKo89qs2B8HxQ8LDO0Yc76qml RNQWE6YTYUt8+cHH/3LiX4DLao+hmEJMIx7ibcCD+8eGhQVDK0C5REIXYq+Co1ER3fcIYwyfVvC Hrypvkp7X8DBBFSRcRaeoprO49P8gtitzbA0rCvjdwpa1pWVDUtXklusAKkvteyccRJk= X-Gm-Gg: ATEYQzwzUi0q9aDTaRDSmpD6Z/sFSd3qfpVz1Bx2tmVvEZpcH0ExapbphR42T98maDV 0ndfJAA+A85ZgEQeIA2DIrF8M5WJ56yZTkWHYiqbvuEZYSSmmLpGjASNxNkZOa6YVos1GkrsGZ4 bfAGIcndXGffyBSf2FDktVzvNkiNfCnq2gLMFS8RVMG3rvonkSINpiLZ9GFdZvclFQMbJ62maj3 Gh3GJ0k13hlBir+JPLp2WAiPCreksyILsCCLcNZkNFXtXwvHzJTzFIFikTUnA30eNfLa084KuSJ ezSNdB0/TdeKgmdWbzNWnIxCE4hN+aiCQD5hLNBwOhagC2kcvim1B4xU/VTBhpZeu4Aju/J59V+ a9/wuzIWv2XIpzFPPrYNfBjmHajgXGnxUAlUhUaxHoPymRLodU7Kxz3VTVNNlBwQP1gYE3dWMOE co+622LptXc9tV6xrVc4PdPTTBhVhFHi8HLSw= X-Received: by 2002:a05:620a:4413:b0:8cd:917a:2026 with SMTP id af79cd13be357-8cda1a8a5ddmr897758085a.79.1773322204439; Thu, 12 Mar 2026 06:30:04 -0700 (PDT) X-Received: by 2002:a05:620a:4413:b0:8cd:917a:2026 with SMTP id af79cd13be357-8cda1a8a5ddmr897751985a.79.1773322203931; Thu, 12 Mar 2026 06:30:03 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:02 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:40 +0200 Subject: [PATCH v3 19/27] drm/msm/dpu: invert the order of UBWC checks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-19-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3131; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=OzjscEd17vm0sEmzoIKCQmPPncmXbh08UBSisc3cBL4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+31jp24c7kNb3Kn/dSjdS4l+mxF8W1rI8aW F/HpdgD36qJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/twAKCRCLPIo+Aiko 1YtBB/0drMmDeVpRsOqPVuUA9kPWhmGIlenEluBir77EGPRRGSpKMOnfXzFsdoDCU6u7C+1NXdV e9FMebCHKxWML6QKtiBZNGLOCuRzB/h4Q+ZlOKLSyazTVaTkv2eKpy3bR4tWABzAyeDVkitQLBX 41+S0155PayZa5CCA//b5wFm6s/MRpPcUVWFJbFjBEqz6AJNVvBDJ6xAj1q5secQEGB4WTtLiIO u3GfRz97H3+/jJ7JWGXGQh1XNu4nwMIfrT6iBMY8MS/n81lZen2anVo/Q86THWuhM14Vm044UtN GQSEMwM8Y7QZGL/UwTiIACMoGDJwQ4C2SKW+OEeG2m+mPjdr X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b2bfdd cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=l4KHnsLLE-ungWRp-RkA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX4zM3facsAfHX gcivZ7Se78cdVO2MireYfc3N9ONRgYgKF2osZdgbh3O4J7JyNmEp5lKd/Dhqxn1DTCOWcoOXzUg jtyl8yaaHY6NHvSv3emLp8JkzncVr9BtqXlC1QASpCMqxYM1G2PQIXnjRXPp6WzXX4JL3yI8oU+ FbKyzP3bwNhDY9ElUgr30jcfX8jZdh7ktRiM3vfJdYVjJdtYTgWI1XQNsE22q4WZCMLSz2OKGjn QMkFQrhWtBI6dzmYpkDbjUNLxPfLViDAwvriHdeYHrCc04QsTmGL9YKvfHY7Jtd9b21UHGjgmRs bUJqLzD0a+LnxkRDTeI2tJudw0rnG1XLuxbODXWqh9xzo/A44zuLMITfq2vtmKMeu4lZLHXBiC9 2frosrQO9oBfpT5XynNqUshooBOHt26tNAw/vEu3XgqmHJtBltGp44L5cEvEa6WUXE2v/vNMeCC vaB5kWcgCHv95OxkprQ== X-Proofpoint-GUID: _cchh_wTr-ucdY4Ep9GVW2yI1p0AI43m X-Proofpoint-ORIG-GUID: _cchh_wTr-ucdY4Ep9GVW2yI1p0AI43m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Unlike other drivers, the DPU driver checks for exact UBWC version, making it hard to add minor versions if necessary. Invert the order of UBWC checks, letting the DPU driver handle new minors transparently. Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 36 ++++++++++++++-----------= ---- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6089a58074ac..b5e50fc1916f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -310,35 +310,35 @@ void dpu_hw_setup_format_impl(struct dpu_sw_pipe *pip= e, const struct msm_format =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; - u32 ctrl_val; + u32 ctrl_val =3D 0; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ =20 - if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { + if (ctx->ubwc->ubwc_enc_version > UBWC_6_0) { + DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_5_0) { + if (!MSM_FORMAT_IS_YUV(fmt)) { + ctrl_val =3D BIT(30); + if (!MSM_FORMAT_IS_DX(fmt)) /* and not FP16, but it's unsupported */ + ctrl_val |=3D BIT(31); + } + /* SDE also sets bits for lossy formats, but we don't support them yet = */ + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_2_0) { + fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; + ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version >=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; ctrl_val =3D fast_clear | (qcom_ubwc_swizzle(ctx->ubwc) & UBWC_SWIZZLE_ENABLE_LVL1) | BIT(8) | (hbb << 4); - } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { - fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - ctrl_val =3D fast_clear | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); - } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { - ctrl_val =3D BIT(30) | qcom_ubwc_swizzle(ctx->ubwc) | (hbb << 4); - } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { - ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); - } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { - if (MSM_FORMAT_IS_YUV(fmt)) - ctrl_val =3D 0; - else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ - ctrl_val =3D BIT(30); - else - ctrl_val =3D BIT(30) | BIT(31); - /* SDE also sets bits for lossy formats, but we don't support them yet = */ } else { DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); - ctrl_val =3D 0; } =20 DPU_REG_WRITE(c, ubwc_ctrl_off, ctrl_val); --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620723CD8B2 for ; Thu, 12 Mar 2026 13:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322208; cv=none; b=oFR0WjSik5weEEOpCIloqRGINvqRYkqzKSLzwQMSvCzg11iMapvGdUrxokdXQobugbxGc+CTc/fHyF4Bw9DmWYJl4EPSzo3PAtxoVfg4owXX0UPHx/8CtweZP2VTh5iBdbiJpK2sYW7lbpsUlRue1LDT0XDzxqdAxFsSE4hYNe4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322208; c=relaxed/simple; bh=ffK+O6D6vNEMnJEMM/tky7u/BwlqJOyoW6OX7dYRjJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uq/yq7/rV+0nIQ53VB+xBMGou3dBqW3AQaMvmnhm2iF9Z8WIyZk8A5jHZhzPoQshz23wcy8HS7vMeIdsD4lcTzp6QkXBAw0yjEatJQVrNx3vHCFPMRWI4jE50pT9EnjtVhchIE7dHC3uU4gnR7wnAJHvgQ2I1Uy6MOhHbAappyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=blOgwmYA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Fznvz0Jm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="blOgwmYA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Fznvz0Jm" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7e5fX509874 for ; Thu, 12 Mar 2026 13:30:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KHDCJ96vbTYJbdrHJg2LGldtamq3JQy7Ivw7gaZRqFM=; b=blOgwmYA/0t1q2nQ z+h2EgQzs+vBdjDboYhPCf+8YDTdI/KcXMYUihgS3uFBHjzpl36Es6j57fVZsZe9 cCTgj0kW4KBNcMHIvHGaqSfA6cgj+aktV8nTUvQZ8RsBNMpGEX21t7EuCRCJqyUd UoCwYCgjbiPyFHFvhwbAnf8ZUoxYIf/bYlkDrti89CFwd8v9gVJRymcx5dbiIu9y c3AYmmRN6A/4ushuw1e8SxpcfxFGdsrFPEozSod7lQc4YJxXEeWWVhPt/ZmZ+Jgu FjmTwioNol93LBgTZQp1fDZM0yMyM3gr4Vy2bAnYY6i0Kf7A3w9zu0TieDPYwNLW a6bwqg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vej-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:06 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd781c0d90so1189634085a.1 for ; Thu, 12 Mar 2026 06:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322206; x=1773927006; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KHDCJ96vbTYJbdrHJg2LGldtamq3JQy7Ivw7gaZRqFM=; b=Fznvz0JmX8aGKsNDQD/j5vcKIZ9vWSb5X09+FijQzGkCKmn/9Ovgmz3i1LdgLsun6z eUaSM5WNjisiWwivDpY/jhRRYBd619XG3JywWT7OWSAsqyyyupPRAgIdi+mFReqQy+wQ jVRZXRg3guQHJ5XkaQPFJjI7I05c2rfm+AX4k33fSLzDkrDl8hRaNvNya8LVxg2XKDYW z8GPGp9tY2V6opBNcSQIet1DGADVgvDd3y4TZRg2NJXQx6BLiPAIV5wooz4paGH3Tffh DHAeY/OuUXO0SoHNwRh1n4OIFtxIalTbLf8m/eYjtlILc7QrThoTrbL8T+lLb9nEsf12 SHsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322206; x=1773927006; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KHDCJ96vbTYJbdrHJg2LGldtamq3JQy7Ivw7gaZRqFM=; b=uq57BPklPcbVZl9D6QwDv7IhmEONXIety+AZkzel7kDVa+5160BWjxqF6Cwg2WQpHS RLFmfzBpIxSTyiV7/mEbUumyJpt53v4sLStAYeJlwamcrGUlN7mry9KKHWzcQw54T7X8 4pQ5rONoDhmMII+z7SdKDlk/Fna6e4Nj+UtvvajUAnBMjCg7wdTilotRoG0Qqyx57DIz ELhwn6o5r8P511q4a8kF9ic1NJ9ajtcUavqRNMEkNBRmGhXZHGWydYYt0oGGx0jWpjeo 6bFOdVLelW16IBjCEh+Y+HTV5a1AEj39o1ZI7QkIIa7SzfeDT/g+dW+a6aEx0FecJ+84 /1xA== X-Forwarded-Encrypted: i=1; AJvYcCUM2AO128jEfJ8Py7iC0BKRV7agiUF42W6TdIya2gxa3I8vU4n5Q36Wj4iAGsVKE79Tg0QQiWp3W7O+G2w=@vger.kernel.org X-Gm-Message-State: AOJu0YzYrjgbJaoaIcdxlg9cVhQDwHJNcyRT/mhBYHOhOQFAg6rDDegb Jma0UTbUri9QHvPhZuUY6mAJhpVqAG72T8X2UWM2jXWBrvMK1ugSk2O+gllqLdWj66a9RKA8UcA i1OspiB3t0Wbmtyl8Ef3ZiBGc/o5RLAZMyHKvoQ743+c86WQkEX5Nh3CjnexPAMpXW8Y= X-Gm-Gg: ATEYQzxvkYi1Se9OXXpJyZf3oGB4DXrC6JgapHY/0g8EACSLCB137L/JzOyShhqQs5+ DsB9JN8HT+J1vLOempXqfo/Ki5Ewxu3nN4cueOMIK6yhH4z1pfLFS5FoCqkrLEktuD9+N4Zrab1 +sJFASxu8ugLgn5K6DpC5d37jOJr6pBC4bWvq7ZK0jw6WuRdtab6XP0o8xpVb+0JYQWwzmWfs7M PSAWuFEBJDMoHb2fqW9gO6tWz9ebJsI7qx5YVOJYCeUySjeCu++5yWmeUvpjAu5T+h9uJFl6GeG jRqsHpukzmuizT9EHzO8k69jYyqdN6IvCH/AstRxI5JdYNM9NPDz3DxRjhLLjEkU+fg10Ojdz8o POc8HAWwUbOFJ6lqAHSotfF10LNP3Sk22SzNypT50gB7xAcff//+bS2uv032Eib/TaZqytc7fwg BboLB+qb8EbTHCEOgdI02JvIB42MCWHJMnqk0= X-Received: by 2002:a05:620a:3727:b0:8cd:7833:7e3b with SMTP id af79cd13be357-8cdaa777ef2mr432818985a.6.1773322205843; Thu, 12 Mar 2026 06:30:05 -0700 (PDT) X-Received: by 2002:a05:620a:3727:b0:8cd:7833:7e3b with SMTP id af79cd13be357-8cdaa777ef2mr432813085a.6.1773322205381; Thu, 12 Mar 2026 06:30:05 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:04 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:41 +0200 Subject: [PATCH v3 20/27] drm/msm/adreno: adapt for UBWC 3.1 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-20-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=738; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=ffK+O6D6vNEMnJEMM/tky7u/BwlqJOyoW6OX7dYRjJY=; b=owEBbAGT/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+3pyNJcy1gFw8sivFR5nHbRRGXO7kFW44t7 sM/NCHEc8aJATIEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/twAKCRCLPIo+Aiko 1YL3B/de+6/sWkudSyDY/t53dq8uUdLYFUjlm69O9qatQz6hr4nEnSmV7KOuVYsOpSJ0i/CF2tP 1+w/R0r+BYPDs0dGZW2Ls11n8bsg60pIinhKSQpwhsM+gqRSt8t2QJay9wu1WQ9115pq+qw5qmD 6Vn5zNbe3t0B6eBpc1R5WwhVJaVqmLdBwT+mjLJkbe9gLSztS1KCVRecS4tMi1bhKH/3b0V0TIP 33qEsGu6FDuBgvA2lIk6V/lu16PAR6iNCB2NfTYkIKMrj88rEVOypeo+enia+Svq55yMPUhUhHK OUQwPYUfJZ0bkn0Hjy543xYPWA1W9dTUmAmF4cIADZKYeVQ= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: i8ElEztdH7JXgMwa_D2lcHWy2fcwYyxn X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfde cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=h0EdKdWjJzRczO_IdhYA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXzbNK8FncaP8/ 4FnlHCh7FdLKc2UibyY4wZzOlVvhnu5vipKW5Y8xclNHEZhz7GbzH595rJ7Qoy8KvldLYk9oFnR H0kjCp3Zx7GOy9YSbh2vm37poNlnJyVFnl/jjkjXtK+NAzqInc4U2qSQdlc7NQR2X56QxP8778L /pygG+YacJnGLmZv2ahg0xPQ/4oWvmZCr4UvEX47GRD69DgB/Wuw2cL6nPKU3wf99kxKkeqlL29 KMqDOnxws9cCMKS2NznWKpy6899dEOt9S32/dSqVVq7in47h701s7SIR76dGvC2OSBnwIJxGNkU jA65qUMfBiltxtu/QWqkym+DYDoIDf4vPqU0KYNoEVpp3Mcrc9XEdkETZdp6e6krg/HPzSBNTJC rR1h/hU05OSLZ1qvwerak0BoFvkog8LPcZzjQDW/pEV/cfSewqso4b6cq1XxfClKYgLiczIN/Xj pHUdW++jR3Y6RmFVjYQ== X-Proofpoint-ORIG-GUID: i8ElEztdH7JXgMwa_D2lcHWy2fcwYyxn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Extend the driver to handle UBWC 3.1 (in the same way as we handle UBWC 3.0). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 63934d21c831..e030e9e87ff6 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -290,6 +290,7 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) fp16compoptdis =3D true; rgba8888_lossless =3D true; break; + case UBWC_3_1: case UBWC_3_0: break; default: --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22DBD3CE492 for ; Thu, 12 Mar 2026 13:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322210; cv=none; b=epq9b3ea6r6auAettkVPjo20HYBUFwapYW44ercuzzG8RnpqgYufYN5hL1FjffborosjeGfdKFgG7APaSh0893pkDBHr5yAtd+ExlXXX+isLJDk2/4aIYXxma4+jDPcOWYO3bFfFl21sjMwFIS47sFzIN4i05Uk0PCL2NXwJCnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322210; c=relaxed/simple; bh=Nxn0ECja9MOevPIO6hY4R3LL49hKUqZQoSFEB/QFA80=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t67yQ8RVKr+ocs9zN3k3TAm7i7lPwUHgHuOuqiDuWPBciWw8JAVZtZ0DDWJ6dgsXFzvqWY57CYVJ2UMN93MB/QJtS1UgGShJx2gQ6YVjsnIiL64FhH0bL53uX2WQvFHr+KUE0DwAlfUAq2iErCi81OwccI9K+XBRRuFQlmi8qCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YhY6ts+Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=daC4EILN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YhY6ts+Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="daC4EILN" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CA28bg3666447 for ; Thu, 12 Mar 2026 13:30:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HGml7biXVVWjOOR6Y1Gdb7Ld32RnBgrsNfRj6o0i/eM=; b=YhY6ts+Qkdwhw/Dk cJpeM8YDspD5JZ9ozkij7iRc/SaojpmJ6MxETPtVGCx8B1hSeYimaLFNejUjsryp biEtdi4IqSqpzv4rN2vlDulDc1hexMwaGHuAfLZhowDfjb/wPyEOy57Jfv7gIZsM mCErwm/NVxCWVlhfMQcqABYB/9JX6vEURkRH9uNcQyu9A9QlwlOxkUq4M1mo97YZ Fp7GJRe95uArqnBG+j4yw4zQyDqhUWWynVemqRDeXK1n9/O4UVDoE8Ys5WQjNmAj xq0OpLN7s/6MIu8LF5us29w9ExUuS4ADqks106Dt43ICSumARy9Ee85djW4wKoxz PC1Tsw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh60j7wj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:07 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd781c0d90so1189643685a.1 for ; Thu, 12 Mar 2026 06:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322207; x=1773927007; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HGml7biXVVWjOOR6Y1Gdb7Ld32RnBgrsNfRj6o0i/eM=; b=daC4EILNrfs7WEYYIhWzb3cKURJ9RKa+6GAo7uVUJV2/8HOu6KUoputLixRa919g+V mt1UZBTjY70PRYlkDpE6VSaRD6At9r06cbZOtTo8TdZvR2S4hbkcfGgz/k9YEYJVWRVZ 9RsF22Gt/FfyNCe50hLjsdZ7ktNo4//GFpBFMry0OXvyef5Y0F0efElsumO+e/RDDW63 ifX/8MGPinmghEGDWf/x00AhSg7uhBLHwDvObm73pK5x2rwZgHRq+lj2CduDdU/rs82I yLmA9j+Sq4eOTyscM8N6Beb/tg1/Y7R9+cyqZeDqUyu/l+NSNnL+ahbMR63Fx64SsDkS sllA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322207; x=1773927007; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HGml7biXVVWjOOR6Y1Gdb7Ld32RnBgrsNfRj6o0i/eM=; b=UxMTvQsQ0HiawkAiFnvadRO/7fAhTWUuFr4df6gWuxEJ/SV5T8zagrONwQwD8AxlBf NOKCFY3CxTz7o3Tha/j18gew7yIh9QDq3nYefW0fLUH7dZKmMlgY99p1OGRFqbGw6kk5 uP75arD46NhlQaCFpjyUH0uAKUokAcl4CbyLmIi8Evmqw0+JcXw39WM5Bl9HjaBtZBSj uz8uDZGNxc8tIvO6GFHHQ8umB+AN7LsygXgLvjnu88aB3t0K5KmIXp9pFVNB+KzAx7mO HFrVU0wvR8A5fjUFNvXcAn+7HCLbrcy9PtgZFmJ5pSejEkHxwUNPLjK8vqBFmFuZ9l/l +TLw== X-Forwarded-Encrypted: i=1; AJvYcCXJxTVbn2iETx8fN/q2ynEQQU9iLATADN08QHfNYm6AicIv0x9wMLJ81T/Ixsh6XDCGi3Q9RGIVitgStcY=@vger.kernel.org X-Gm-Message-State: AOJu0YxSna/d8sox3rZxMJMjDw5G+hAazkESiCJIo8vJuwsDkS80Ioty MpJyunlvhUph6/fQvQLvmnmwDBU2HnmNfuaasRECIp5aYDFASCQaUkaOczEP8Bu1I4tA8cTMP90 jZuPYd2gnhmpJAYcexzJH5amHj2QGUCIbEk6WcoFSbeFzeDaiLe0/OBOQCmZnq30g7y4= X-Gm-Gg: ATEYQzw1YB1GDxRfJ3Ji8Whva1a1NzteRZuc2m2iyv+9KZhVfb1EoW06Rmh1GDj6IOQ AxkJ5DeL26NPOLrYwAtpTfhOo90vl4YnTGjAzyc3ceoLD+rbqas9sc9CsgIVsLHlfaUErL3YSTu qoBfIHLtHnpDBHYzuHQ7zb4ge+Zqni7zadE+fbtDLXSc17XDgF9RxEeAPFWDOok82XfwH0VSd6t lSskGM/AUzLUXvjCIqX9HJYbXQBeuqt0XIfN9nhHetX0rzNGj0dtph+75MOuI5QfWOdhRDTiGWF 1NqRpr6yxHXSkePhp/ekXvGXSIjaRe7LvBPQkgIuGYH2lQ+WzjvUh61ze3weqoQvyFxGcEPmwGx ypQ8e2/btAl/nNAW1lsc8aA9sa+wPoLret+3HaWyXF+VsrVQXFqiFlO8gha6bTT1O6YNIDV+78j lpaJVwvkR/EvqbRv7xDpvc5FEhfbhk30bd7Nc= X-Received: by 2002:a05:620a:298a:b0:8cd:8ce4:c0ad with SMTP id af79cd13be357-8cdaa84c2demr403218185a.22.1773322207321; Thu, 12 Mar 2026 06:30:07 -0700 (PDT) X-Received: by 2002:a05:620a:298a:b0:8cd:8ce4:c0ad with SMTP id af79cd13be357-8cdaa84c2demr403212385a.22.1773322206855; Thu, 12 Mar 2026 06:30:06 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:05 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:42 +0200 Subject: [PATCH v3 21/27] soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-21-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1469; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Nxn0ECja9MOevPIO6hY4R3LL49hKUqZQoSFEB/QFA80=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+3byjVkNF3y3+4p3LyoypV4BXqUSQ8HNv8i i0jXZ1Z7rWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/twAKCRCLPIo+Aiko 1X/rB/98/Et8LZv7iT0r5hUpUVKze5Hwk4RvgpuE135qe4LNIXOyyXLVVtvTmw27099CiZOqkJM nJbzHxTW7/If+0H+yQE+XVIcCdWawVXAaImmQIpSAkOeG4vnoHE/OPqdRlq6koaAPTcmY1qa8Nc 9lMW554ta1i2lYklFFEXOEQXWXqDG0no7CxRkg8J4Tw2Ymwv2J0MBkWVenAYiXUedOj9fDSPcbB Wm1dfdpQsMkmi1ExiycJi8Dm/O348VRVDSpiSg5uJzDHqL5+ubdid8aC1ywwFUkfa1Az0UwjE9Y ZUR5FNOsxqZRtDuzw2trWXC1kU+zwo8MFMmrGrdDlLX6R7bM X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: ZKHRj3EICTBVKGA5hYomNpdr-fJx_ovU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX9Fv4ufW1JRAf KT43rHaVF38ZaOkEJ7tUBdecNLByga+oTEYcguWgB8//xWtONV0yUNEblnGTYC+hfqCpOmrVKBm 9+X6Ohu3vwY3IV6Vk9vIpUNlJogSRRkmmWbRXiMxc5rqIAI9sCpMzaYroXKqDK7RBg/BgqrC3Vl tbW2gGH3mFtx5gXx034x4Wz9lu9wO7//l2Omo2ElNhFhjKux9EHav4HLva2R6FhNfUfpmPTVOBP AV+MuFEFjAOIRaDXhtcCVSFszAgYLS051FriZA2eNsxvmTnNOTss++RGbx7MMCBvyYwPeS2RBux XhTKBnZxWIgzTbaJWdHlGrBAuzhnH/8/QXVDC9kPkRWNBq5wV0W04mGwTmA/enNNuPfUVJQ4EUh Fdcs+QWMZMi/wpUdNHPQQ4mGd9gsqZ80Z/fFTetraltWCBo5B02UwKsZ2dZJthZOjWJOKx+lPiQ TI9nCgFhi3OaERVw22g== X-Authority-Analysis: v=2.4 cv=DsRbOW/+ c=1 sm=1 tr=0 ts=69b2bfdf cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=5ZsywSmvcCt_NWGkcqUA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: ZKHRj3EICTBVKGA5hYomNpdr-fJx_ovU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 According to the documentation, the MAL should be set for all UBWC 1.0 targets, no matter what is the version of the UBWC decoders are present on the device. The helper comes from DPU / GPU world, where there was no separate bit to control MAL before UBWC 2.0. As the helper is now being used by other drivers too, correct the helper to return the correct MAL value (Iris doesn't support UBWC 1.0 devices for now, so there is no changes of the behaviour). Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- include/linux/soc/qcom/ubwc.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 83d2c2a7116c..0b5aa9d0343b 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -75,14 +75,9 @@ static inline bool qcom_ubwc_get_ubwc_mode(const struct = qcom_ubwc_cfg_data *cfg) return ret; } =20 -/* - * This is the best guess, based on the MDSS driver, which worked so far. - */ static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg= _data *cfg) { - return cfg->ubwc_enc_version =3D=3D UBWC_1_0 && - (cfg->ubwc_dec_version =3D=3D UBWC_2_0 || - cfg->ubwc_dec_version =3D=3D UBWC_3_0); + return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_dat= a *cfg) --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E00F3CEB81 for ; Thu, 12 Mar 2026 13:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322212; cv=none; b=giZH57Bz8BhgX1e9XGQGMyWi1nhzvNW7m/fwaXrc5UaAn5QKJ89HDrXZKwmVUG58x+U51ZVi4tO8VcrkUwTNaUPJXzeUa9yaV35A8GSFsc/mD19f/wI4xa05mou81Z+eKn2btQgvYAT3JgJ0IEkYmOBqD0wGic38fcx7yH2/a0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322212; c=relaxed/simple; bh=LSluZwsJdsGyaDROP5csbwtPVQCwJHNeWkTj020h790=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lcOvHk2e5D9eyBMVx1yDrpTZ6PfB8ZbQqYC1u0wqj/3n0bfZT0sNI1ZTgQ+Ut9qEfmVKGZMiJ9k0lSqFhrPKbuLms3NIf+ZwozfrC5rAdBkeBwcJxxDukYOU33+sRnJJ9K+hJ6kL5Ss6lE833QmqVNO4+D39wXd3csoUfJEE54s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NojoTzVD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WRBYqyMK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NojoTzVD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WRBYqyMK" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CAYXPq4027231 for ; Thu, 12 Mar 2026 13:30:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aG6WWz3Rg90Q5nuUQjZSHvpWUje1SbHhLnTAkmh3AsU=; b=NojoTzVDGp8MYNvs YuTHy/QmDjL/+QzghPLw/apWgLQFvO+7hDmQgKOdSdepucOh0OgrGPqV+PX3NFjc SfBR4me7Zv4Ymj314/aND5xUU45N4HnIgULiHhmwUACsj4QRCe4aCJZSgeFqbWTP kmELXsfuQCdyvibdVJXWJrEslC/evxmUzQjWyji0B+kp1CRl4qkd/NX+/fREkxkk RXz0cag3d1u6OcqaVK6cTO5WbOA/XN18BN0aOsQn8gNG/k+t/u14pzqVsBBoluCd gbL5S52BcD8cYvZUsVmuYLDhqNoPDfGFfNFfJMjBLVzQCyWTakdZepzm0bRD0GLy 5dJBBQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh54t5vc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:10 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd84943c76so1471797885a.0 for ; Thu, 12 Mar 2026 06:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322209; x=1773927009; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aG6WWz3Rg90Q5nuUQjZSHvpWUje1SbHhLnTAkmh3AsU=; b=WRBYqyMKQgottX+TfA3KfQ8F6vXYSs90IMCxpeeuHQGyO6DxrV/g8xF8JjcsIavB4a oenQyb/b14TfEglbXbreZCIf1gq6MKDasS5zt4GXSItWAEggmgJ3O+Xh/dH1T2hyoh2d ZOUI23byCQAd6EXImjd5F3zjsUlDlIMe5o+zgGHnAgIh6nZDZ2cYzAy4EHSbbcTn7Oec /tkW5pe+tcKveihLbtDHvkxDL3ulvk3bqWNpLW+H6bQRLZOxr7gUlsRMhOyQOnUyeb8P SsRp3e58ADYIX2cuGGc1r0KpdgxCSg+5h+VUVwpF5/5cxoC3Expeae9gj2PDuxuJPflK A+ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322209; x=1773927009; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aG6WWz3Rg90Q5nuUQjZSHvpWUje1SbHhLnTAkmh3AsU=; b=XLXN7+gX2Al48KFV/iEk0Ll+4sXZWCTJkv98aV67y5wbFK4tp+EOsHHWxOgcMjoKVF DAzeK1vlfgqtqzFx2UyjIiszyNe9nJnx4VrVfgn5wYCsXX0QbO/UYyerkbcHz5Fvown/ mS6IlulHUIOhRD4gjiiyvT5stLoPljoDaU5g+R72r0HvBbFPtMovd3q9Np9wyetcM7gl mUHaE00YdrRE6Esls8tcGjTkRusuhgNgpt/co+SC0tZZy/0Szgjj3FfE5R/QuopyziNS 47VkZXtR4sE994aJ83nOA2T3vQ28rSiBdU7vrelus8z/2Y7feVYbpLDDTaZgF3wrFIYY OcDg== X-Forwarded-Encrypted: i=1; AJvYcCWPKcNrevIujo1zyh/HmFOWXhdxXCq1p91WPmtc0JHrxF7hdAileCtioC2PfNeqkVZubzXMotd+lMLqX8s=@vger.kernel.org X-Gm-Message-State: AOJu0YxBYbxda7NH9p5YmyQ509OFmfYjdtPFfrnDMczU3rI1cg1YNSwM FlrPzkaq3FKQ+7Z9NrRYB2hrZ8W5djZDikWx9zr+NHpRnF2QoTBB/cQgtE9ubkKCttWbCTDOaip jt+e2IRJHGMzhC+ZujcZ/2LWXfsEwWtCoYwBoKlH/U0lslhe7ZqVqbFOyo5dwqFlhWxI= X-Gm-Gg: ATEYQzwWMY+T7/flVbcnb4aEvULHySpFY/409cVzgPVimoN05O8DwtnsW3YaF4iLL+w Q0AHHDmo7pn6wvEScHkYJFV4uNexPTNc/HWBuha8uBMQRissU0CJ9Kv2A+HM3efKk3BY8KIvlig H+ZkUoiFUJjTcSPE6NQLXfyQk4CEn/jymuncaoGAwzbYNqq8keCGf6faV/OMCib8OEYFBplqTiG tRHiBv2KEi5p1gbfFCeQNbGteCmsXGQ4UgRMRzKtuZvJOySKkFFfE5uq2QeF45CgTlGFxQ9xRK3 vtv3j4umyIbxvFfMR2cowTOJYdZ/kyMzo3IqrN/LvOnHhv3XZm/TpwtDob7F+qUcwn3XeVGTh0E YGc8y3E1YcKG3lwd+JSA025SVuacU6ScHcJTLkBay6KKcsr8km0UqFKUNTbxEmIhRj+zgO24DE+ 75dT+gNrMIDCmZSgwySp55GxbtuUrtTqkT8RE= X-Received: by 2002:a05:620a:4441:b0:8c7:110e:9cd5 with SMTP id af79cd13be357-8cdaa8c59c8mr458842885a.45.1773322209115; Thu, 12 Mar 2026 06:30:09 -0700 (PDT) X-Received: by 2002:a05:620a:4441:b0:8c7:110e:9cd5 with SMTP id af79cd13be357-8cdaa8c59c8mr458833985a.45.1773322208450; Thu, 12 Mar 2026 06:30:08 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:07 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:43 +0200 Subject: [PATCH v3 22/27] soc: qcom: ubwc: drop ubwc_dec_version Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-22-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=8046; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=LSluZwsJdsGyaDROP5csbwtPVQCwJHNeWkTj020h790=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+4l3Ko26/Y3svi3Oy2rMDak0u4jXAac41JU 8oQWrSgN2+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/uAAKCRCLPIo+Aiko 1WCLCACGiptIVN8WwsXvOgrRnbl7l5jkpiuG/ToAYoSX00jIBZj9xuGmTrQ7ck6xyWPOva21EIJ MBAFgUcKU6zS5vdxj8B2cMJvZmg/uUxNLa7UL4tcjjJw2bQpQtK4NLJukngS/8gyq9qtLP+cB+T GW5wQWKZe6SdZxBdf8yIT5TMHj35fCRWqe096yuujGItur284+oTCVsop8dM78Pj/8jumfoqmfo aDaZDFy+8miqkqX41dnLgu1XEWCO06pm0l6gxjfCIkIvSb1kMTPl+yNsYwRkabXWv94Pw7kgRl3 7sYfqV/PKRKUcRrPs6iXfkqV7ckbcWeDSvcV9xeW46ofsl/B X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: kXLdU5Njnd5ispUwFKqKfrlK3dgEXXtB X-Authority-Analysis: v=2.4 cv=BNG+bVQG c=1 sm=1 tr=0 ts=69b2bfe2 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=LGEa-qlQBoucZRe8vqkA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: kXLdU5Njnd5ispUwFKqKfrlK3dgEXXtB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX5v98YD7JM2eN +UGVD5SEwM2XI9f/kBnu/SCywG6z31WDyQlxO9mqxWnm4NpWVgxx/j8S7YMe2McNOkmC4YtcAhO xznh8wCKZWcnbBYRRB5mU2hnEV6UpbfeVh+RmNOTPWuLEzjeZ9YdwWFR7O9RRV1MeCgEfiZXPUI zzH9zk1kDzsiRE+60kHWQlcDyLMrkzJGvZNnE5nBE+Ebqr436h9nyXXGVofYfNrKjpTWmhhq2Bq ubpZkSyzAnjiB6P7YMZ8K+q/3WbQT7f6wk67YmB86Qhnt5cT2KPIGl5sKgslkpej8fHlg88WXfu ZZllyaIN0iO+ERiPJERFH8riKFFA7zGM+ikNTk5OTx9lP1DM5U9CL/iHwB/+QhFr6twBxzP9S7h N8NgkOoASNjFG/yrNVAobqt+YCueog77w7KU2nZDKAZc21rMJgMQCd5vKhXMo1CWBA4q8520NPG cT1nmwJaKT91lA41rOQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 The ubwc_dec_version field has been inherited from the MDSS driver and it is equal to the version of the UBWC decoder in the display block only. Other IP Cores can have different UBWC decoders and so the version would vary between blocks. As the value is no longer used as is not relevant to other UBWC database consumers, drop it from the UBWC database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 22 ---------------------- include/linux/soc/qcom/ubwc.h | 2 -- 2 files changed, 24 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index e63daf748e30..c5c7fcb4d013 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -18,7 +18,6 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data =3D { =20 static const struct qcom_ubwc_cfg_data kaanapali_data =3D { .ubwc_enc_version =3D UBWC_6_0, - .ubwc_dec_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -28,7 +27,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_1_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -37,7 +35,6 @@ static const struct qcom_ubwc_cfg_data msm8937_data =3D { =20 static const struct qcom_ubwc_cfg_data msm8998_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_1_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -51,7 +48,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { =20 static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, @@ -60,7 +56,6 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D { =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ - .ubwc_dec_version =3D UBWC_4_3, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -70,7 +65,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -79,7 +73,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -89,7 +82,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, @@ -98,7 +90,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data =3D { =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -108,7 +99,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D= { =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -116,7 +106,6 @@ static const struct qcom_ubwc_cfg_data sdm670_data =3D { =20 static const struct qcom_ubwc_cfg_data sdm845_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, @@ -124,7 +113,6 @@ static const struct qcom_ubwc_cfg_data sdm845_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -134,7 +122,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6125_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, @@ -143,7 +130,6 @@ static const struct qcom_ubwc_cfg_data sm6125_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -151,7 +137,6 @@ static const struct qcom_ubwc_cfg_data sm6150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -160,7 +145,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { =20 static const struct qcom_ubwc_cfg_data sm7150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_dec_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, @@ -168,7 +152,6 @@ static const struct qcom_ubwc_cfg_data sm7150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8150_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_dec_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, @@ -176,7 +159,6 @@ static const struct qcom_ubwc_cfg_data sm8150_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -187,7 +169,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -198,7 +179,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_dec_version =3D UBWC_4_3, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .ubwc_bank_spread =3D true, @@ -209,7 +189,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_dec_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ @@ -219,7 +198,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_dec_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 0b5aa9d0343b..c3f9efae5db8 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -13,8 +13,6 @@ =20 struct qcom_ubwc_cfg_data { u32 ubwc_enc_version; - /* Can be read from MDSS_BASE + 0x58 */ - u32 ubwc_dec_version; =20 /** * @ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDEEC3CEB8C for ; Thu, 12 Mar 2026 13:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322214; cv=none; b=c7PA8P3r+I0aAETv5YAmatUwrVToqbgCBlQh/3To9CEQQWPaGa0PXIAOtjPGuvj+XZ3S6yGlbtcmDyo9Dczip5pZjWQkxikOutn2JFoQRECMknycXRVDxm+Lsv/gogV44MaKw45vmH6RMy6Fb40fZh2D2himqMlPsfqGlrBGn+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322214; c=relaxed/simple; bh=KD/5YpHJHM0f6NYFyEdCILO6HpJWSM4YvU3pMSgxMM8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m3RRUhWCYq510r2ML0ONLkUElkIj3qkm/vChoLAHy+SNDrCX88U/RX1+B1oph2OixcOWQINT9RdKDee2pQn+Za7QzTAQULAw55XaoSL/cSxLgQkqTK9v+V0nwlim7Bk0MWt9WQewkJFUMhjojCBrapiOyDMIdhvtiLTCcFC0B9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SFuEJoZk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hgCZopyV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SFuEJoZk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hgCZopyV" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9eBbR263524 for ; Thu, 12 Mar 2026 13:30:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kFSRcCt8po2OuKoAWsGSR2ULXOVtIcBGFxgqU7X+u+o=; b=SFuEJoZkPifOqLUh TOLXT6Mw0f82G4qAf58MFms2INup0bIPdOE5eR1gt1bMM1b+W42hVQkRkUXvlVGN pbTlQOzsUQy1In7UEvLcu88iALi0cq4GvBdyVnZU+jRFG1/azDPyd1ALEwJFP8ye gSz3GRipachh2jrKCvclRbdjt9y0sCrjhzpKTfwAs/HzZqvknjhiabPzOAY1oUhI 1UqMpdZkFpAFdpsyenGyZR7arBsse/89FYEYmjkmEMH1jd4Vn3VSAZt7WiZgqIU5 zcwqWknv9hKXuOYRtQezBx4gc5JSL2CJbmp4CeVBYzOrQbDVwiJsez78W9BXsULs 2TDgew== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj68m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:11 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5090e08dcfcso45198381cf.0 for ; Thu, 12 Mar 2026 06:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322211; x=1773927011; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kFSRcCt8po2OuKoAWsGSR2ULXOVtIcBGFxgqU7X+u+o=; b=hgCZopyVz86vrHFGFM92brCc79aMe/Jl/AdTpH6uEBhDVNaVzj7EsQ7P3XqjaPVvQn vt3zRZFtPrNEm0HMHO8jDKLuF3eOAoa0wQP++YlPv30aNxBgWnY8ViP6zkDuBzUOrtfn Jfgt2cJv1WUQwziPgKTssl6qhoWCMsx6HBuXDi7nmTgYNkbGBA9gho3p3z3g8DRM/S/9 IZdjoUdlRZjmVXjpDJ0KCxqkR6DXsAh+rY7v5Khjg0gmVhaGMjXynorLmjnJfYRBoZwn w2s7llP3fX+SIbaBXlJzCFpjnyhp/ChzIzzVRlx3Ylg5GQUMYwfUQPlEDeWTauEh5/OQ zG4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322211; x=1773927011; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kFSRcCt8po2OuKoAWsGSR2ULXOVtIcBGFxgqU7X+u+o=; b=EeT4vltzihI5gyTBtOcDI9HRLn/7MK61dY1iZ1xijzJ5j//Ib03qn4xDdqPe6pUWcy 2tKAvpli1wZ/uqpxAQQCC3ienBEW9mXG+5hJI9ugT7EaKYiJ/uUMprAMa59KepB94N/u 5oSdaEFAslwfeYKjBn/YOUk2QYHzEYoDFZcAwi3QY623ErzRIjtY3JN7H3ih6Ls24LKm FwuUHBjaRE5QvWO9kcr2dvM0NB2Z+OfSrGahS9w29iLpGJ3qlq+sZ8bwHL12+scMlsPF Qdl2eURQ00RSeFbYgK/WOqFYbEqzVbnOM2S6bs2R0bNRTJf/qb7KMewLSm556xgNtKMv IzmQ== X-Forwarded-Encrypted: i=1; AJvYcCUlWJjGDqwsg2kixSDRxnZWI3yXU2zIB++/cHpqqdmsA+7lUN+G/1/cEqwLUyGibnkdBnHpnrajNEML37s=@vger.kernel.org X-Gm-Message-State: AOJu0YyJD+7MdMWndix+NP65OqLWYh6YM8D85COaAjMX7afIYJiILsJJ ABzn82U1BmM8Nyc8XnnzyjtOtwqihtQDEqGeCRs8c96nHlDHgNk4l7JNltYhoM3f5z8faFPgJnm wNbUUK1bRBmtObZV1NS49xIgHiimOaSjmi6j43YQjKjUzKifRZD5DZD44Cii/zeQYM8s= X-Gm-Gg: ATEYQzyRHT6aFjt0BLcDQZYQ/mOat13uQ50EJ3/LOLtWqtUPYGGYqGPexDpZX47B+WO g9XQtkD24MS4HvyeFl4zimN5OLS5RJpNj5iJVtctaQh+gThLfZLYii3vu8RfrYJIZkHEfH97x35 n9G45b804hf4GF33SSYXbtuHsMuLFs7r3VxeyBJWcss3bVjfnKPf3ikxwimpX5XHTqdH4qv7l8Z NapKctvdFrDfNmCLpDg7D7CAa+183c7RuG82rKBU7hbsDgkJ/a+sQIfFR7Kpi79jA2TyUJ70gcv /pFiingxQPKcLx178e4gdkRy53nZf2Ui8IByyM9pd3/dIBpuV6pCdg8SDJiykSfBXxuOA/d2RPn WLhSA7M1vY7OCiXJU99RzwCguX6kIiNxBIGWgxNsVIjBzoUXJQ2MYMwDJ/f4F/vBGaB2ub/61PI wwevD2ACzMMkeeTBFhW/FwBbHJ3Kp7FpplFS4= X-Received: by 2002:a05:620a:bc5:b0:8cd:9365:f277 with SMTP id af79cd13be357-8cda1ac4ed9mr823286585a.62.1773322210555; Thu, 12 Mar 2026 06:30:10 -0700 (PDT) X-Received: by 2002:a05:620a:bc5:b0:8cd:9365:f277 with SMTP id af79cd13be357-8cda1ac4ed9mr823276085a.62.1773322209969; Thu, 12 Mar 2026 06:30:09 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:08 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:44 +0200 Subject: [PATCH v3 23/27] soc: qcom: ubwc: drop ubwc_bank_spread Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-23-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5290; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=KD/5YpHJHM0f6NYFyEdCILO6HpJWSM4YvU3pMSgxMM8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+42s6zRoRzNX4/u4arcGCvSNjTR7yJXr8II POClR06pQuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/uAAKCRCLPIo+Aiko 1XXuCACuVSv7Z14BzcGM57AF9mCB9V1GFPY8kEaGQzqdoc4CJV5YQomnGKDlR5SmoEuD17Pv197 w91pe2dD5CfVOeZ6/IDi20kfpAeEhbLVH8cZkLjar7IarFkkX4lWOrAg4hU5t3Yl8qtFmJNP09L QpVe424LpKLScJPJjzzbxhqCa4eN4YCp1O2n5IP8bw42XVTRxlDJEcVj27HHiY8FSutxpC4O8v8 kq83k6OepvT4fYWxm7/c+hcD/2bFL/URosgaI6RiZF51nZLk3PcV9Pw+O8FWSgBzs0kR1iccM0o uaU8DsN/HbOPKnYvgJdkHKn1kA5hq7P/OkxHRmFh8ybHi0Q+ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX5NZlw+lxHs0q chkLFb0M2KtOJvwFXBvA4CW4X/6E0wE2oXblBFUjXzaEhIVo9VJbirCP9KR5tTmkmU+GuLlmhaJ COF2zl1EPvtvUk7Ef193xBv0Rqw3P4cpKRD/wWlBroVHc6Xdha+qO4F1T0Rg5IzJFNY5BJ1WuXU e74VuZHyiazgQixJeMBmi4mXkLsteYCNMyQDocpXCKbrzJwm6zqt8oZcvIQfZ2dAH3GnA9TWv/H h7BcU3RyGw470aOc7WauYCdX2TPjZHNGe8VcYoP42aE8w+gWf61rzVA6eVoahlZKE9OSXLds8jP MUTt7dynJSLEiKFLtdnzoUuM6US3jSj35wEwUK6+pqqd4Yu1ja/92q3I5ZIL3M3WQLXT+nTcZYu 1ACbZCZ0KaXKCkCoBs/8xBkcMB4Bp4QQGMmDDPN5U7m+6o8jsZtmosjjWVRXHtD8HRjklSkAHwG vI9Ej2aF649VtAGl8jg== X-Proofpoint-ORIG-GUID: zzGBxVvXzP0Y2bcc--EpWc8eaDBJZ8lw X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfe3 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=j0qWcOM9GDCbVNQ44DEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: zzGBxVvXzP0Y2bcc--EpWc8eaDBJZ8lw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 According to the documentation, UBWC bank spreading should be enabled for all targets. It's just not all targets have separate bit to control it. Drop the bit from the database and make the helper always return true. If we need to change it later, the helper can be adjusted according to the programming guides. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 13 ------------- include/linux/soc/qcom/ubwc.h | 3 +-- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index c5c7fcb4d013..070bf97e134e 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -20,7 +20,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_enc_version =3D UBWC_6_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -49,7 +48,6 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -58,7 +56,6 @@ static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 13, .macrotile_mode =3D true, }; @@ -67,7 +64,6 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -75,7 +71,6 @@ static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, .macrotile_mode =3D true, }; @@ -92,7 +87,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 16, .macrotile_mode =3D true, }; @@ -116,7 +110,6 @@ static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -139,7 +132,6 @@ static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, .highest_bank_bit =3D 14, }; =20 @@ -161,7 +153,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -171,7 +162,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -181,7 +171,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -190,7 +179,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 6, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, @@ -199,7 +187,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, .ubwc_swizzle =3D 0, - .ubwc_bank_spread =3D true, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, .macrotile_mode =3D true, diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index c3f9efae5db8..254721f5ea3c 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,7 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - bool ubwc_bank_spread; =20 /** * @macrotile_mode: Macrotile Mode @@ -85,7 +84,7 @@ static inline bool qcom_ubwc_macrotile_mode(const struct = qcom_ubwc_cfg_data *cfg =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) { - return cfg->ubwc_bank_spread; + return true; } =20 static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD9393C9436 for ; Thu, 12 Mar 2026 13:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322217; cv=none; b=VdW3qx+MCArQGdEeiD7I1xWKj4sSX1X6SOj862+os71zlkLXzHM7qfw+/vWLxJzJmn17ZU/OWOokU+VN62yvtVTwrDMkkDdI5ssGbCGADNNlIDzMHknt5vG8t7pdB1cqT9USoEeEbMLN9q00zmNocDZq5cG8c9JvAstXVLe1z7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322217; c=relaxed/simple; bh=9xPFzWVLRFmfgeNqqZ9JTpL0iWalU/IUqVUpgLOYYOo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LVwJ4CrCkTqadOoMsoy0NrWxaztTXRgIqCokOVLpG1/sSnhQU465EVBLMBkW31n9WMOhP8/MeHNcfrQnjvsfTsUke+IaQ32lbOcr74pooMYBeqG+XaOohqfguKqqCZ9Qlox3H5VRTjFRhuN7gALF6qhvk4wKEgOUQFw/gnJ1B7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bGd+qWBb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OjTzLbc7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bGd+qWBb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OjTzLbc7" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7e1Sa509773 for ; Thu, 12 Mar 2026 13:30:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C/klMbCQgdLdWjO1751+IWBTzeQwDqi/QBK/fyMDd48=; b=bGd+qWBb3YxFjke3 zeDscYS/bkv6qFoDuRRvqFQ1QRKBABn8lmo2ULCw/os+bx7U/ZpllG8RXwU6EUum ZYvzB0dOKXUKDNZPoqU7nAGHdyfuYBMVmuJ3euSCgaJpa/SfNOLGDuP3JbIoMBsE 8Ad38gpignF/yg1imUF5+/dZvP7c/RdCVVxtE7/ztGBeVgOjibHt7MzsfIAgMtBF 7/OtwUxMQVQzVourN2Mlcog1gJUKNGWB+7lEDXV08MGriRfe6OTyNlBENbwc5w+N 0a5St7KGDau8xz0QKm1V5ml7Xd97SrFfUfhIFr8uYCvNZ+jhrJ6Vn78IEjT+Zium xhjOfQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0vfc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:14 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd81c571a5so631594185a.0 for ; Thu, 12 Mar 2026 06:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322214; x=1773927014; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C/klMbCQgdLdWjO1751+IWBTzeQwDqi/QBK/fyMDd48=; b=OjTzLbc70JYSQCZ8GHvf+IevOaN7Lx2cUnYVymGHfUT8tvq7PTYfyG6frCY9v3xS93 WgyRNIk7S35/kzGmYoIYsNoD+CGQg2Xh+Ww/27Vf7LYVG6CFQje6v3xFybGeOf/3kC/G gGZxhAingfFEBQVPuI5ahzfd1SaD8wmYVVgKr/qB/gZZYHJcy7aBvi9MWpQEwAx8fljt g0Cp6cMR2rry8Jpzj311v0YoOOhpWKZN38SobQwIQ9UyVZiBNXjlrMLKcZxKEiHp7WJT 1+2PxH3a5W3MVZa2VwsABMmB9AxoYNx9PqiLtUZyy3wbtu5xPvzdw6vqueSAVKfB+2fe Cw6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322214; x=1773927014; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=C/klMbCQgdLdWjO1751+IWBTzeQwDqi/QBK/fyMDd48=; b=dm2EOLuZ9ptG1pJVtYzq1VjWkRxwzeE/Rz81TymfE27EUc95wctBhoTvN0Z1PWjOE8 spodY67EVbvCSUhoG3dwVlcRSiTKuzTCDKHtzruyHGJ4V2J+SbKAxjUdNuA6eAC98Xk7 g7+lYly9X+WRxPWr6LDsKT9EgfhhlZWvqVWesVaf5Vazj6Am8GxIalv6AAiDMy7K1Kuy 41f+pjlbd7XBCw3NBEZL7QeI6bzIGwndeiSJsa6hy0etDHbTGtR3zMJYDbNYfFycmpiN yW6/Lj80lu2gca736EKhgaAAsDGRrepaCXehk2A0nYZF0H+MIY5wNx2KN9E3pw744bXI Ko4w== X-Forwarded-Encrypted: i=1; AJvYcCVg6xx8qtTk9+lFj82EP5jN0mvsHTNKduzNUFFMh+l3aRR8nHbYwFVuDh3hl/3kKevQhWEVZrU/a4v2VsM=@vger.kernel.org X-Gm-Message-State: AOJu0YwXADD5yct/5P1spklbfsGHjfc2Tnth553j8MyIRHUsEnjmXNZ+ vZK1Cqy9gQGcbSjk7BH9nEOOlKYq+pSgmaNWJ2iJdmNfO0kTVgfa4HWz4jyMoYysny1QiHEcLIu lP1959Uz5irOa0KxJIo4FaKY4Rmx2LilLEbOV0GAU64f2iqow1wFDJeZjlP9dLl3YBZ4= X-Gm-Gg: ATEYQzz81wsO2Pf05RysppDDcVEEcUQ0yVR2pCdT/nkCctyM5aoYp8zdPTjTNagZmvY YZlWfaCtSzHd8zAlz9IB2HnXluZOfMvoCnBp8vKgYZ6NNSvPTDuhYnMbDo/IfWzokMEBRjwmP8n rG/52XtpN2/IawZY5vYHff1oGGxexKv24sSihprR6tz7TfyVUg/W994piMaJoGGer5kpkiqKx0u zL+At42r5jjdqZJ0ZuxAwlF0JbC2O9tWfURHWuPG0vXCLTf7tKxuZq5gP6ooG9OHFZ0WGh33EeR a4nJyfk3KA4Lmnm2TAYEB0zz2oBW76v4J2UfAlVQlp0BS9py7jOWbM+gl2wcrvH2qk+GXqzgMdU AIKvFd/9i4T/topZFqYYYQriXfeZVWAe3zd7UVBxN+hD/vMKI3LhwDc7JI83iK7Qx4NLeSlQxb8 BuYk0QNF+ffhJO0gtyuZWadbMlSmmresGWo9I= X-Received: by 2002:a05:620a:2904:b0:8c7:1b3f:5eab with SMTP id af79cd13be357-8cda1a573a8mr745271385a.60.1773322212430; Thu, 12 Mar 2026 06:30:12 -0700 (PDT) X-Received: by 2002:a05:620a:2904:b0:8c7:1b3f:5eab with SMTP id af79cd13be357-8cda1a573a8mr745259885a.60.1773322211745; Thu, 12 Mar 2026 06:30:11 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:10 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:45 +0200 Subject: [PATCH v3 24/27] soc: qcom: ubwc: drop macrotile_mode from the database Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-24-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5167; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=9xPFzWVLRFmfgeNqqZ9JTpL0iWalU/IUqVUpgLOYYOo=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+4LUsSvH4sjenVhn7VrVZtIYrQuV2Gh0+9B FVI8HvG9M2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/uAAKCRCLPIo+Aiko 1RTxB/4i3hdCnEqI/ozB7uVVvC3euL7Lvvknpr2NZT+xxG6t+0Z4yxnDeFwBB8kqNY5rkTDQPAW p+lZshJAduE7VfDn05bJfRszX70+JAbB9Mj9L64/N0U7HW9C969jJPHqScg6P8GW2fPKCYEuk8g sBU2Gff72dQMVAcDpfgJ8CBA2XywwA/nsuWwZJk8leJZA5ZOP2MbSNoWNNbbBtkcHWEh//FWr/C uM/gWuz1DiQ279m+ABpt0+j4paFfIqtAZSS0/XqH1FFFuXAo9MZ+M+eHqOayMyvyYW4fzsajBcO 8sAJoZ3pBLRdCUXqGzpBUnqWHyP/hR2kAXkuUyo+tJZqYLjy X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: UmoR9wIqF_IJDkZmrWgBCeotcKm_LOTC X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2bfe6 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=lOjMx_-Oxa8n0LcNG1gA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfXxibFDh4A/3g3 O4AmuQ2GDJRt7i7S3cDV0uJhskajcmfaolj9hw5ti+yfFlz1XxvsxfAghFxIguZT4WoQz75QyOG UX1Q92SVEMLz4NJ7SH9wpGykpTiufsP7JHIhOhasjYMOmp1ppgAI8A5m+/dJeqmdZsFATQ5NS2Q XDxdhKQmhxlLxFWalRGxx7DiMAXzif7jmhWzLoDRWM+ic6frKYvNYX9Jpljz8gr/b4ckqvnQcMI tndfhuZygD7y5piG2Pr827OTjz1HQ7wzJpzfm7jWnZ4i67S8hBmKsN6LFBxhOqLUQkvDJZtmB6L qD8eorVFK8jrMtdwhaClZ9/lrEl9SCTBQYz+DbrJbnlNdH1pki8z17Rdv71TJwF58d71lDlmH+w Webx67XIYZWHtZ7W0SRzAVN58hJghCgM4DqZtVcuZ2p9OKxQg+A/Qiq7X5Y0wev/HNT3YhxzXzz E/yjXsY0h9l3ZSl6eRQ== X-Proofpoint-ORIG-GUID: UmoR9wIqF_IJDkZmrWgBCeotcKm_LOTC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 All the users have been migrated to using qcom_ubwc_macrotile_mode() instead of reading the raw value from the config structure. Drop the field from struct qcom_ubwc_cfg_data and replace it with the calculated value. Split single UBWC_3_0 into UBWC_3_0 (no macrotile mode) and UBWC_3_1 (with macrotile mode). Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/ubwc_config.c | 15 ++------------- include/linux/soc/qcom/ubwc.h | 18 ++++++++---------- 2 files changed, 10 insertions(+), 23 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 070bf97e134e..51de36f5f40b 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -21,7 +21,6 @@ static const struct qcom_ubwc_cfg_data kaanapali_data =3D= { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { @@ -49,15 +48,13 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D= { .ubwc_enc_version =3D UBWC_4_0, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { - .ubwc_enc_version =3D UBWC_3_0, /* 4.0.2 in hw */ + .ubwc_enc_version =3D UBWC_3_1, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { @@ -68,11 +65,10 @@ static const struct qcom_ubwc_cfg_data sc7180_data =3D { }; =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { - .ubwc_enc_version =3D UBWC_3_0, + .ubwc_enc_version =3D UBWC_3_1, .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { @@ -80,7 +76,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { @@ -88,7 +83,6 @@ static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { @@ -155,7 +149,6 @@ static const struct qcom_ubwc_cfg_data sm8250_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { @@ -164,7 +157,6 @@ static const struct qcom_ubwc_cfg_data sm8350_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { @@ -173,7 +165,6 @@ static const struct qcom_ubwc_cfg_data sm8550_data =3D { UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { @@ -181,7 +172,6 @@ static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_swizzle =3D 6, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { @@ -189,7 +179,6 @@ static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_swizzle =3D 0, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, - .macrotile_mode =3D true, }; =20 static const struct of_device_id qcom_ubwc_configs[] __maybe_unused =3D { diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 254721f5ea3c..fee778360ac2 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -33,15 +33,6 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; - - /** - * @macrotile_mode: Macrotile Mode - * - * Whether to use 4-channel macrotiling mode or the newer - * 8-channel macrotiling mode introduced in UBWC 3.1. 0 is - * 4-channel and 1 is 8-channel. - */ - bool macrotile_mode; }; =20 #define UBWC_1_0 0x10000000 @@ -77,9 +68,16 @@ static inline bool qcom_ubwc_min_acc_length_64b(const st= ruct qcom_ubwc_cfg_data return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 +/* + * @qcom_ubwc_macrotile_mode: whether to use 4-channel or 8-channel macrot= iling + * + * The 8-channel macrotiling mode was introduced in UBWC 3.1. + * + * Returns: false for the 4-channel and true for 8-channel. + */ static inline bool qcom_ubwc_macrotile_mode(const struct qcom_ubwc_cfg_dat= a *cfg) { - return cfg->macrotile_mode; + return cfg->ubwc_enc_version >=3D UBWC_3_1; } =20 static inline bool qcom_ubwc_bank_spread(const struct qcom_ubwc_cfg_data *= cfg) --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 581603CF02A for ; Thu, 12 Mar 2026 13:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322217; cv=none; b=ni5+frYoFncyYkGNJffzH2KBmnKtUdEG+06DVCtP3/X4C4L46iIJrk5WAbvPwRB39ws9hMEjzzOvOnldBNB+oIYS2rjDJvpKRhO2C6EVD39fnHeGjW5mI7/LxybmWbm751BfUD/+B2Tr+wT1JbNTabZ/Bp3slndpql+OJiBr4WQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322217; c=relaxed/simple; bh=Qu7SCbd08U0FxPNSARkgsOS6vFM+FAyy6vsMyoASvXA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HSy7BYKPlnj6wsPx70pLg214CKEQS9HU7Nre+IA9vq10TjgcnXGnyDMuxZbyEvMODA2a0hzXvCMQbETo3qhc1q0QWFIv8xqJNGw0PkXCddkRsLpBqqfn8MOCtbRi+jJ5bEtSJdwRHpZauvb1RbMxFkI/42futeCh0EPDuecWuqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vgzz65OX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D1+qtYYz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vgzz65OX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D1+qtYYz" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C9kgWp4132843 for ; Thu, 12 Mar 2026 13:30:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4kJnWK+0X3yWbB1kK40cUekEe/em44tg5c3VSKIz4Wo=; b=Vgzz65OX9KYFnj8M SWl4zaP6YGD4JgHFyi+ToE2EFY0Y4WCF2ZdlYH26WhN0hBb05ZIvWlIO7QzykSO5 I8gqaPb9MaPl2lwezKjVwd6C/83TsViCQX+vF9EcVAKiW4RnmWkBxsd16A4fbMyP MjTWh8/nRXDBAQccdrUltzsaug3XLomq/hStoaW5ejQ40Q7lGNNmNcZwFBaQn29D BwiBjk34oALQQAItvThGe3/Mnbny+oz4KwX+TLyEPpjSPluuD/HFTTyJzlndttia RxFH2hYmCbIuK8xZvWaaqqO1HVZ5X22MHuzkmsUzjeWZiIRXAI7Nq4RR1LmkJPw4 7/5Y3w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4w26kn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:15 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd77bc8186so994227585a.0 for ; Thu, 12 Mar 2026 06:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322214; x=1773927014; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4kJnWK+0X3yWbB1kK40cUekEe/em44tg5c3VSKIz4Wo=; b=D1+qtYYz5/VSw/vGBXLo2GjjNxKbjFQNi1G7MpbBvTOBSYdHUag0loxFjv+coUBQhT uf0eMSalNxHNoGqPa0fL+VCLsKo3MjfeuOEPNn5RcEHsoXK4Gw0VQlvER5n7TJ1wVY6o askmROd8Q6k3uNIlksbiH2QFLMSunSIHrhpue2Bkx5ZqvVL54hxfLUgPiJR7hYaF0YJV 9lOTRsBkGMyHu/UIf6+sfM0rAt+kfPKnfuRn8Cj1/njVfOKrTVn4nx6OrhQIZb9w2UKN 3Xh/FEyKLObiIyO+EIN9ILFyDXFnyPCQWrGz+p6odg/IKi3KSDW1aN32efTyuKvvVe1I ONKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322214; x=1773927014; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4kJnWK+0X3yWbB1kK40cUekEe/em44tg5c3VSKIz4Wo=; b=iECTD6uP46kwgQHn/4xZ7UNchbrDJkVIRAZ52L89A6M+A/s97UYNqLuDvLOFvd4obr Uqt04ptk4wvR1A2DjNgvqyqrGelRiBG9pqe0rtBgM34foBFKKAcUP3oPYPxGZAtOuKOd wPWWwo44GyFtBDy3nA9Hi9hVQnt1YK/ugl0T5q4yX889aA9OZDNJ2xkvzfmyEdbWC72x 7h3GYVFsrGMHgoxL41ojTWX6ODMkbbM+hHkcNFZg+oRrpHB1e4NJ3N9HBiCM1M67E1FF QadtYN1kngvYe7271A+c37bbaXwgljagb6erbK428pEySjT7sckll6r1whstA9eVWGAs icJw== X-Forwarded-Encrypted: i=1; AJvYcCWgjUuvLpfSyoouD1LJIA62W5j2E0spo5Jlbdhl/3O0YS/MQS9fv/+BJAq/nKmUZyZl4CIBrQv/m9aTk3s=@vger.kernel.org X-Gm-Message-State: AOJu0YypJVyfxq5olXREj73J0tfbkncDof0XKPZajBBH9KSkX6IuluCV M4zG2IdBnu5cUm+rv9rEhrCsKKUyoEccEAQ/w+fdS07FvQpU0pwANLMyl/bau+AL6Et/SBd/IYN wk4Vl4ImCAf2WgR+VuRcfxNaDYS6C4tKoFD8jT4+00Y5drTnitmJbk/2fjBT2QDWgZZs= X-Gm-Gg: ATEYQzwdR88RpkmricGnXTKO2/Kh5Sl6WM/ZLDClQRal55taVWaznyS+Dj4RNtc5+gL eWIur5wywp8K+b7HIyH80TLymuSvrGJpaXuQ7FpFweMmDZHWw3ojWRi2mxi9miqf3QCq1tCzERH 9lkxwkbTFuTaQllmduXnRCWbyApS56CEAJ7gUyuEy2bFLIyma5uoJHJxO67Rfl2TYFBpWfaTovr DSb76NSyknxpZh8oaoFT5dmAD3Drcy1BAYRlT/G+3r6sT+g4+0DRnokawnoB2+tNIiYnFVKkcOn R1rifXJo/09uGc2Go5ALf81gPos46f5MAct/BN3MXIYAiwKfpSZKK49oKpEX5nKCs1ubFoH1IhH PSEfCziLbOnSy2EM2mhEjda00Tt6VxC5aHvhndrdXYudwqCzrqjaCFA0GQLD9g5rcZH5xrz4fCH 6cT6fp8FBR5GJrXc1SiO9EoKkqe6QddEWMxNY= X-Received: by 2002:a05:620a:7112:b0:8cd:96e5:f7c8 with SMTP id af79cd13be357-8cda1a559cdmr766513185a.57.1773322214059; Thu, 12 Mar 2026 06:30:14 -0700 (PDT) X-Received: by 2002:a05:620a:7112:b0:8cd:96e5:f7c8 with SMTP id af79cd13be357-8cda1a559cdmr766502585a.57.1773322213412; Thu, 12 Mar 2026 06:30:13 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:12 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:46 +0200 Subject: [PATCH v3 25/27] soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-25-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=6082; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Qu7SCbd08U0FxPNSARkgsOS6vFM+FAyy6vsMyoASvXA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+4mKKhz4P253cyaZOGYWl46uL+Qn4OOtS8h lh2uw5D9NeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/uAAKCRCLPIo+Aiko 1RWRCACJ7gDjMdRfrJBykdoGT9vzRU982M9SLzPBR1PaPDZ0Jnn7Aoriafu7jdgUdgUPCD+XK3n XO5EdIDxSWiSGKwhTa/AawvYsjEAmAI/9ec7TOlTxOw4ODf/i/Ooh45lRmhGvCbQFJAbVb0XfLs 2mY2+s1c0N2SdFzQ5CzpsvjpnZu4EM/sMjKFtBoyzm7rcmffl2pceUMts4eDJyc/ab9ajJxO0Vq IgSsYPspLbX8RETu2YtsvzPJAm3OT2SwKvEtTxiovg6xi5CsB+2QdZyi9ijTGH6LNW96Bas3KQi 4BSkPXWJT31aI4PkObeGcM0q+3QEQQLbUQju9fzJAwCEik7Q X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: S4PzvpVu3roPoklFju0uQK3leIoK8TIh X-Authority-Analysis: v=2.4 cv=Cpays34D c=1 sm=1 tr=0 ts=69b2bfe7 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=8a_ODPMxA7UucN5sxwIA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: S4PzvpVu3roPoklFju0uQK3leIoK8TIh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX0wFVdufpUCvu +eMYvnOe8QG6tnaUs8HKtpq1nSMW6UjS4O64XL3GzYe7WhPoCLwymKtw1I1dHUeEicbHHzYURWI cBwQjwB1dHEVgChT6GjmlsCjN3ruQTBx3djiCFN74Hkg1Ozru6ryoDHsr0U1n7KfqGKMb0n5gn0 mlpuZ3GBh9sviRCoOIjvw+mwqcnYjU8HEjNhNNzpiGJFzyT+sphU0fuc7B7SFKcDw1Sr11k2gk5 zaH9OdU4KWzQe0wlKEyhRI0BRhdcW4BSdLSrVUEX8Xy0+Hwxc9Q5Gt3GcNYjHP1wWwPKuMEn+NJ hPR9FY6vvNSDpp8Ocwz/cBuTC3aDBYWpgSiclRL1Wl6lrKunq/0eQIl63KsjBZLl3lZRfUGSN4a ktWu318gj0Bpw32MEV0T13NO3mW8B8wr8DQvY9h7bFBVbJ0l7raH6gHJvnAopOLcA9MFRyV7+31 T0nJ4EidqMV1bEgXJLA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 UBWC devices before 4.0 use standard UBWC swizzle levels. As all the drivers now use the qcom_ubwc_swizzle() helper, move those values to the helper, leaving UBWC 4.0+ intact for now. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 34 ---------------------------------- include/linux/soc/qcom/ubwc.h | 33 ++++++++++++++++++++++++--------- 2 files changed, 24 insertions(+), 43 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 51de36f5f40b..49edfabb5e18 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -25,17 +25,11 @@ static const struct qcom_ubwc_cfg_data kaanapali_data = =3D { =20 static const struct qcom_ubwc_cfg_data msm8937_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data msm8998_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 @@ -52,94 +46,66 @@ static const struct qcom_ubwc_cfg_data sa8775p_data =3D= { =20 static const struct qcom_ubwc_cfg_data sar2130p_data =3D { .ubwc_enc_version =3D UBWC_3_1, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 13, }; =20 static const struct qcom_ubwc_cfg_data sc7180_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sc7280_data =3D { .ubwc_enc_version =3D UBWC_3_1, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sc8180x_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sdm670_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sdm845_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 static const struct qcom_ubwc_cfg_data sm6115_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6125_data =3D { .ubwc_enc_version =3D UBWC_1_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL1 | - UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm6350_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm7150_data =3D { .ubwc_enc_version =3D UBWC_2_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 14, }; =20 static const struct qcom_ubwc_cfg_data sm8150_data =3D { .ubwc_enc_version =3D UBWC_3_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 15, }; =20 diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index fee778360ac2..7c9506741001 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -22,9 +22,6 @@ struct qcom_ubwc_cfg_data { * UBWC 4.0 adds the optional ability to disable levels 2 & 3. */ u32 ubwc_swizzle; -#define UBWC_SWIZZLE_ENABLE_LVL1 BIT(0) -#define UBWC_SWIZZLE_ENABLE_LVL2 BIT(1) -#define UBWC_SWIZZLE_ENABLE_LVL3 BIT(2) =20 /** * @highest_bank_bit: Highest Bank Bit @@ -55,12 +52,7 @@ static inline const struct qcom_ubwc_cfg_data *qcom_ubwc= _config_get_data(void) =20 static inline bool qcom_ubwc_get_ubwc_mode(const struct qcom_ubwc_cfg_data= *cfg) { - bool ret =3D cfg->ubwc_enc_version =3D=3D UBWC_1_0; - - if (ret && !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL1)) - pr_err("UBWC config discrepancy - level 1 swizzling disabled on UBWC 1.0= \n"); - - return ret; + return cfg->ubwc_enc_version =3D=3D UBWC_1_0; } =20 static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg= _data *cfg) @@ -85,8 +77,31 @@ static inline bool qcom_ubwc_bank_spread(const struct qc= om_ubwc_cfg_data *cfg) return true; } =20 +#define UBWC_SWIZZLE_ENABLE_LVL1 BIT(0) +#define UBWC_SWIZZLE_ENABLE_LVL2 BIT(1) +#define UBWC_SWIZZLE_ENABLE_LVL3 BIT(2) + +/** + * @qcom_ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. + * + * UBWC 1.0 always enables all three levels. + * UBWC 2.0 removes level 1 bank swizzling, leaving levels 2 & 3. + * UBWC 4.0 adds the optional ability to disable levels 2 & 3. + */ static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) { + if (cfg->ubwc_enc_version =3D=3D 0) + return 0; + + if (cfg->ubwc_enc_version =3D=3D UBWC_1_0) + return UBWC_SWIZZLE_ENABLE_LVL1 | + UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + + if (cfg->ubwc_enc_version < UBWC_4_0) + return UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + return cfg->ubwc_swizzle; } =20 --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33F443CF67E for ; Thu, 12 Mar 2026 13:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322220; cv=none; b=T+HzKnw0uPl7EZaLf0zO7io+xjCqgY+OR+raWqErUSgL/onEXLCsrDxRCXJxmytv2A10kDmzZD5T/jzQsAKfkMufU2mTqWy6e8NK4sVnYbmYYDnHqQ+rLErt0xOQmAmEWUSGblSeu1ZUwCK3F4BXzx+139qiHi2jwI43TXTQkYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322220; c=relaxed/simple; bh=aZePfCHlihjZhkopGUN2RVAJWZ7XbjQf2cNHz8Ha1/A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GRsVuWpb5lyE+wCXe9m2OfncAJVUgavr9ZLcZus4Lp4su0p6uwjJKXm4oGuXEvC5iP3Y3dn7LDUzIn7BjbMPkyBZdHa/ATZivQM/9i/Dj8E0oeATKiNWTDR90FmUsv+ymd+9cqBt94T8/SIowMgOs/jTlg+sfuaZiDyBZC9vFVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z1UfmdRG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FpDxM30G; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z1UfmdRG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FpDxM30G" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CA4lWJ1756251 for ; Thu, 12 Mar 2026 13:30:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CHHWto9L3DJt77vFN3vZgjFHf3Lp2HIBccOsbhUwjkI=; b=Z1UfmdRGMMzqhXva WUVlTeJAXrF3kAkD8zQhGqymLE+LDJBwC2c4K5LmpCOzkF8z7ZMxmWyKJCqLZ4ON q4tQ7vNAHWhoasIdaDjtAFSIasYSuGh4EAKF2KYTJ9RYlVW5zkHoPwspwOcVB4+4 Iml6agVygHUUfpQn18LSboFlsFkJrq62pHIs0F78HzC7TFzyKjNo5RkVNZfOpqrH wxLld6VM2hrYCBlmLBEZnUUMvnq8ml36fWQ0Wex0VckX0ps9lwvDm1OGKtmDS6s4 Bny85nULhMFTkhUIKcDPGVLjkqqS5eqOwvG+jE0KaVNalz8zrzPpqgRIJGSVhnZ8 cb54Zw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53j6wx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:17 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd7c4ab845so451599385a.1 for ; Thu, 12 Mar 2026 06:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322217; x=1773927017; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CHHWto9L3DJt77vFN3vZgjFHf3Lp2HIBccOsbhUwjkI=; b=FpDxM30G7P+WlDoNI+vJ6odVGAjc28LtVodrmRMQyqxa7nkcvx3CvEZvo5Q85WOHxo IBsPr5PkJM/yEg3U/G54TYKZqrwBE496AJekUhiT4G1mRTfhMJ1Iy0Lxfnj8PX82PtD7 rO9AvO9RHq/aeENbLOLwciNZactFEuMFGf+4duYDM8Ev6NGfePxbZ6n7eNZciuhF91mN Vr4W7RVIQYfGvMWB7CzXckk3Dh6Irx41gAvq5fnKs4Zo/+Uil6y7aXh+XsDf+7iY5VZf yF86MmIQ7QhgdP8o2nkSFlJ7NtYcs1hzfJZ6qqFPgZUnomspTzbk9HJ5UK3He8f9X/jl Z+cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322217; x=1773927017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CHHWto9L3DJt77vFN3vZgjFHf3Lp2HIBccOsbhUwjkI=; b=SzBHXZjOsgP8JlghHkVBRfB0SMjC6N06xpGCsT24cn51keUlH1wNJotWfBgxQqmTFa zKmmC7VbtVWJYM2La/tzNlBysgPrz6TwstKBFeNjFBXrx90fYXZOVvGpUiM2iymZoH64 2bdtLx++6EZNnL4RPEnV9sZ+PSo2AjIyMvowq8giSCpfFfkt5R7YNTbw3mIGmJdx+h5D rifGCbSeC2c99bZA96s5YHrCeS/8RW10DIlD2OjdpkPKzdme6M9ylbsmRuf6kI2bfZgW 7xLef59WNYckKf9xun4dWndbVSBh1xVDooisKGVuJ2d6La8Rqnj1zCvNtCCLCG5bOviF uXPQ== X-Forwarded-Encrypted: i=1; AJvYcCVOIVIQGE5ygsxmcKXATR0+Tn4FaireQYfsp24hALHMPwEc9KpbZGtcs9koKvV3etz8gks3o6LxkHS2nvU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx9T+mMKQ2tQfoWPVSRDkl9wht1hytf8jD4unMQQtvHmRZL5hN cEa5R/WhGAmiSF55uP6Ll6u8rjyoDvIShglT4Sszgx/K5nofuB2Xl/U8IQxUNFYKYTX99Vs5QXl irbFxpLLfAVH+uKmi500brEnGxOJluHU8MPaKIACaWK6Le8WFGprGI/lJnoq2kYYJZiA= X-Gm-Gg: ATEYQzx1F8GZGKFK2Ht/eXLkYeQWwUzONIie6okIDln6GG/egKEHO+CgZT4IFB+72rH F31LEib5QeVumXZEoLkKil7C4vTGc/6SxmMitBc7CIa9QQ1LrpDx8shlsrAQ9EW99UhE9AxJdPR E6vf6/URApTidEerL2ga9EWarhYTRK2ReTeXtb6BNHhq/aNyItf9jiRL232yCViPtC7TgU0W2TO U58G36auUj6SP/Sakg6/SC0lYfc+DfcnME7JiWaT0lFffYO/+FSSXOds2mMykW6DXmybQDbeJni sxo1xWW9AQnZ6Mmg4D8hcWXBciq2AnGBJMTzB9CQxXTGvkrQSpjwjDTjg4xjRJ73++HdGZ4z4bW moXdP96EDSZThp/HXUod5c5bDzdD4Yq7LQ88IGCEuZNFA6p6pEMWzH7RvT8xFD2B2u4Tg2iluAu 43vKiOwLBaeWzE7kPCytt2WV5jFCFkD8lmlIU= X-Received: by 2002:a05:620a:40d0:b0:8cd:8785:eff4 with SMTP id af79cd13be357-8cda1930373mr778952885a.15.1773322215685; Thu, 12 Mar 2026 06:30:15 -0700 (PDT) X-Received: by 2002:a05:620a:40d0:b0:8cd:8785:eff4 with SMTP id af79cd13be357-8cda1930373mr778943785a.15.1773322214962; Thu, 12 Mar 2026 06:30:14 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:13 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:47 +0200 Subject: [PATCH v3 26/27] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-26-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4170; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=aZePfCHlihjZhkopGUN2RVAJWZ7XbjQf2cNHz8Ha1/A=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsr+4QsRN/zWuciV6Odv4RrrOuSOvS94vKiH4B itDI/Uu0EqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabK/uAAKCRCLPIo+Aiko 1VgRB/0W6lSJU7HgKg4riZddJ3HxFtJne7/DCfuauUegKe3lB2NlBQxcWy17xZMdkYFiBGeUVHD fXJVf8VKdPU2yzJJGs3eL3fUepzF+fxvvuCI23nYJCpXhUOj2SqWba9OvmAfFIimqqoA5FQZYbc 04s6Ph7rrcaHo3mKhawoSbbhdw9U5M4+3XzfdgMX8hXOH0ljaoO5na2i8s3vNek+ln9DuQdaf3X SRSWE1AD4Qvt1GCV7SroHBYT9mR86wxHAKG2ZYfPgbNifAga3wmYph9r2pQvmLKTvShntY0euk1 046NHQ9lmD6BC90Iwwa72lJEqZMvkgfUkQD8xJ5iGsrC0owG X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b2bfe9 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=3htL6sknLGLhwEng4zIA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX6zz1amLowjpx hl2j52vzwnh/0bnoJ6DgA5Nnc5T5Xa1YcQcBm6J6dPPu3aG4KS6MKE12yUU1ouRVVb3T1mqMBJH n+gG5LwnBfxMS9JszIo28eKhYyfmu0MnywSKZe+SrY3cw/I7eTKQTnY1sDH8x1JKmLHHSiWNWSJ vQBPGMLlWPr8YBycF7UJFgX4LGeiBjOj+8DMSeLS7XQdF5DgNLpUn5xgwc+P60icwyDwO7H+Q/S xijztp1ogRYpPqew48ZM5Y+uOOxJsMVjDsDC7mJ22ar6LiVQxbiG9muKHEc1TADCOVFuv87tiso 2sCXMBh2p2I3UMOT03UgvxdeysyjBtX8Dj8Qvn/8ucykACNfDbFX7OPzQ+24VRvg1wvV/tbjSoz /4vPfIftCWUv8GUXAs5mVMESqCTxpH563s+Vd9qGtSgUN560ad6hS9I4OtdBMNVi0qCm13toq+2 MIGMCdIrXXq9es/wRZw== X-Proofpoint-GUID: -8RFsApO-cR63TzpBl1FKGUeEJWFprJh X-Proofpoint-ORIG-GUID: -8RFsApO-cR63TzpBl1FKGUeEJWFprJh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 Sort out the remaining UBWC swizzle values, using flags to control whether level 2 and level 3 swizzling are enabled or not. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 14 +++----------- include/linux/soc/qcom/ubwc.h | 26 +++++++++++++------------- 2 files changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index 49edfabb5e18..ccee20913115 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -18,8 +18,6 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data =3D { =20 static const struct qcom_ubwc_cfg_data kaanapali_data =3D { .ubwc_enc_version =3D UBWC_6_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, .highest_bank_bit =3D 16, }; =20 @@ -40,7 +38,7 @@ static const struct qcom_ubwc_cfg_data qcm2290_data =3D { =20 static const struct qcom_ubwc_cfg_data sa8775p_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL3, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, .highest_bank_bit =3D 13, }; =20 @@ -111,38 +109,32 @@ static const struct qcom_ubwc_cfg_data sm8150_data = =3D { =20 static const struct qcom_ubwc_cfg_data sm8250_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8350_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8550_data =3D { .ubwc_enc_version =3D UBWC_4_0, - .ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data sm8750_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_swizzle =3D 6, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { .ubwc_enc_version =3D UBWC_5_0, - .ubwc_swizzle =3D 0, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2 | + UBWC_FLAG_DISABLE_SWIZZLE_LVL3, /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h index 7c9506741001..a7372d9c25fb 100644 --- a/include/linux/soc/qcom/ubwc.h +++ b/include/linux/soc/qcom/ubwc.h @@ -14,15 +14,6 @@ struct qcom_ubwc_cfg_data { u32 ubwc_enc_version; =20 - /** - * @ubwc_swizzle: Whether to enable level 1, 2 & 3 bank swizzling. - * - * UBWC 1.0 always enables all three levels. - * UBWC 2.0 removes level 1 bank swizzling, leaving levels 2 & 3. - * UBWC 4.0 adds the optional ability to disable levels 2 & 3. - */ - u32 ubwc_swizzle; - /** * @highest_bank_bit: Highest Bank Bit * @@ -30,6 +21,10 @@ struct qcom_ubwc_cfg_data { * DDR bank. This should ideally use DRAM type detection. */ int highest_bank_bit; + + unsigned int flags; +#define UBWC_FLAG_DISABLE_SWIZZLE_LVL2 BIT(0) +#define UBWC_FLAG_DISABLE_SWIZZLE_LVL3 BIT(1) }; =20 #define UBWC_1_0 0x10000000 @@ -98,11 +93,16 @@ static inline u32 qcom_ubwc_swizzle(const struct qcom_u= bwc_cfg_data *cfg) UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3; =20 - if (cfg->ubwc_enc_version < UBWC_4_0) - return UBWC_SWIZZLE_ENABLE_LVL2 | - UBWC_SWIZZLE_ENABLE_LVL3; + u32 ubwc_swizzle =3D UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL2) + ubwc_swizzle &=3D ~UBWC_SWIZZLE_ENABLE_LVL2; + + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL3) + ubwc_swizzle &=3D ~UBWC_SWIZZLE_ENABLE_LVL3; =20 - return cfg->ubwc_swizzle; + return ubwc_swizzle; } =20 static inline u32 qcom_ubwc_version_tag(const struct qcom_ubwc_cfg_data *c= fg) --=20 2.47.3 From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 551133CF687 for ; Thu, 12 Mar 2026 13:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322220; cv=none; b=nbC6uw+NACruv8ZSxHjQCGUrP2yPeBqtgLB2SQc5L5dUQsU21lBnJkMMqc7vpW8dBR4wMgDyNjI4Km5M5rL9r6tTe8FFj5Bgdh9AndATLzVuu16dfQoigawYB7fN7pzeKNM/TaW9fz1th8m0zdH5GfSqnYxQzK7l9OSZPf4Nxbo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773322220; c=relaxed/simple; bh=cuqO+m9BSceBUKXzD9bGuTtW3yUhyLay2fImgUonSHI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TdPh3IWflQK9Qfgwrz7QRqAKq4XJPv5AGjDGUDGvv2ek69FyRRbxGtbcZhUlIK1dfED3GItMuKqyZRuGlmdOJwR7DTzQrgbRn2bryF4nibmXfumNfLV+sO63z/IFYBdUZ/fySwhZAcrKWbGECeozeDp6p/x3KwSiV+m4YC/JB7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=otJ37acB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N23lfmjP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="otJ37acB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N23lfmjP" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CA6GDs263415 for ; Thu, 12 Mar 2026 13:30:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wCF7c3TBX6o+MiU7CsW3tf4ENTO+38tQp5kbxgZiMT4=; b=otJ37acB+zJ//GVQ pdTdQSdKrYSIWNaaQ4vjDgTGsK6BpKo4qCJ5bnZxV+rm0tUFa67+jU8jtD1ZTYlz v9hbATNIKx9VjIQS07O07+WUt0aYzY4nMmpFe14+bHY0cvHZBXI/Mod+WM62q/ui Mg18Uj1ljAkKKrbaz1Yx2moIJKPw7pO/UFwyH9r53Jf9KL/UV4JiCQ8SurB4Bszw xm9K4XTwIPEX0jVY/YqfZKTRrvPzXFRepPjqEYwYlix3+jK6fcaG1oL51/DhG0fZ 6RtcFbxMNmyMy8dVoi98YR0B1lz+sBPnDCwtMKolM8y11GBQP9TM6GWm/66CQTFp 9eTrbg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh4yj695-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:30:18 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd827a356aso677260885a.3 for ; Thu, 12 Mar 2026 06:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773322218; x=1773927018; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wCF7c3TBX6o+MiU7CsW3tf4ENTO+38tQp5kbxgZiMT4=; b=N23lfmjPyP2Tyab/NBtgGv82ujvBAehemBaP6lrL+4cJMcGkxZTsG/b/darL7TLtrA hMXNv5R6o5uvp6UKtRczIX5vprO2FvJXhYUa0e+eHlybAGu/F5Mp/4IqMrgCb98RnXVJ gcuo+W4SuBkHEIuUUhsnbivnvma0+8UN/82XlYFfkFyQurcplPRzt4+ZDhHafyF261UV 1L6jTOsxSJtjfBFpVi3VMvGtrowgy3WJdezJDYAZD0SC7aTeGDGGhpZ2/tWoyu+ozLwG FRef1k2UZwStYqSgC8rxxVNmiqJo9eZdycEOXj+pHiOWsvBuxgdsQ3pKp+P4ulae3bcR zQmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773322218; x=1773927018; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wCF7c3TBX6o+MiU7CsW3tf4ENTO+38tQp5kbxgZiMT4=; b=LybNHExCUpEUmAxdNzxpX/cnBUiARUtKGKQr/+RcHfZdqs7h0Jf8oEXiYboviPm1OJ VrfgkVwmwmcHZaxoSqRMvrcl3w9Nu0uRFhFQqxc996DMvPp69lZ1toU/tyySK96mrW5i xcr9JBQKp3GwpQl3W2WYyQmBl/fIlH59sBk0XRGBSj87Qj647QJ3zwg0nO/V3n/A4ta1 8e1Wa+vOS0ncw38A1geHUhmtgyMeLiPcHPemnDxl64G5IE8o/cPW7AXjBzkKzWFOEVIs 6Nfz4S63JmmxhqhwcYFtZAL130/CWJhQ5Z0v9RTXKcEUDFB58wSDX8aoPJqeUiAnSmOy wtlw== X-Forwarded-Encrypted: i=1; AJvYcCXVdW9wPPPi9bbAclv8vsC50fhVB1L59D6NplS5FETr8NKauw+h+Fuzji8sBo6jwMF3ZZhyYa7dc+wrhoI=@vger.kernel.org X-Gm-Message-State: AOJu0YzNUKbvRUaYpz4xGaFjI+uLPG0MFlVheed8/ivEtIW/QaGND3H7 z837Nbpu7JzhMd9iiH/Q7H7nHnb2RAk8ZhFukTEe7cMWPNd6CGbhIKfw4q1XZYuz7BY2X9XpGNY PLDm+kcfmEEJJJw8l2MW2wPQp9Wd/3kWqLpuFKy4QFw4BBZ2hqZ36l3aSkfJYOkt02zc= X-Gm-Gg: ATEYQzxgeOXIuSErRQRS4MKVyLdUP8Vda/uACy058cI5BDlvDfNRGmSLb7PjGX9uCVT VKxETluzw6wFe2gk/c2CzHkkJEfdo410XI9rQyh4G4QK2GPIOlchlteukcpxurdJFnwzBFciWm4 6scNpcT9stT9Zbusr3491wGtABtuJmdrtxqYaPhxuElmLIxi3/HJ5pr0CGScQbBqbJwbIx952t0 5ZIpGjrZ/IZ4QzwHQuXtyRaglKS1aAkWJz71W2T9tE267xdijQzm94fcMf2l+Rer9uy/Kvhx2yQ NjooEcmOQyNbpIQXDL6Iw2NVKCmX1kA7Wmsx0JsGAJ457oRVZreuyPa4beMog1KMeREHE1PFOYe +Fyb1RuFroWlHERl5cwLZ3yyrXAlmnS9PwwheQ4Yn8PGg6Fg7Ap4ryUzBAwR04lwVrCYuhWQPws qWYODgmAUpo3hG7F/L8Q1K8as4tAlDAWmm+oE= X-Received: by 2002:a05:620a:290a:b0:8cb:9975:cba8 with SMTP id af79cd13be357-8cda1ad6cfamr771382285a.62.1773322217356; Thu, 12 Mar 2026 06:30:17 -0700 (PDT) X-Received: by 2002:a05:620a:290a:b0:8cb:9975:cba8 with SMTP id af79cd13be357-8cda1ad6cfamr771371785a.62.1773322216630; Thu, 12 Mar 2026 06:30:16 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67d617e1sm8646671fa.9.2026.03.12.06.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:30:15 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 12 Mar 2026 15:29:48 +0200 Subject: [PATCH v3 27/27] soc: qcom: ubwc: deduplicate UBWC configuration data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-ubwc-rework-v3-27-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> In-Reply-To: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=11102; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=cuqO+m9BSceBUKXzD9bGuTtW3yUhyLay2fImgUonSHI=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+am/TsjbR6t9nc4PmNXiW/Xzk8umev8d8Va32yR0j3D4 7M7wK+rk9GYhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQATCXfgYOg/u7y7+MnRUn4G c8sIlc9tBTJbT2TY3DvmIBK/zetX+3UHme/vcw+cWHxE0fu8d+fTz+61epMumknN+KnHekHMSDL p/Ne0xvy14V+4S8PEVau0g33bf37VFV/Qy+raI/T4kSZ3SzPLhQcyEaaL72itPHrPeEei4XmXBW fLpzVFxTAHZOhcsWT49aFcubRNiOFbfDx/kzqLi+UXp//be56cjjmna7d01qbuOTqG0+QuMfn84 TJaPavvVn/ox1d+K980r57fUhkRn1X7XLG9ae8xoSmnCpZo8X8IaX1nz2j4Taf2hPjvRe/fvVrR WDnl/4oVF/PWc81sKP8iLPQz4Cxbir3VNasMq0cq7BzxAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwNyBTYWx0ZWRfX0XtsW1Ci6wRW 9e5PEkG5GV9fag6RpNCTyCAEVhIiWO9hO5TYwmT0lQ3HtMMIl7UGoPNNRgVuC+IbpbWniCBuEeF 3yPYgMuLRD3iXg1k5tiExVU7p89t332WEwrA/Xd5Hz9Ib1TC0C3ALlSjZ9lo+Alk4L+Bbja+vDk pEd+6EB/DXFW0ztE63iNro0Of0STx3dbcKc6oH3kkD8XVyAQ10C8dmNG2BWwz982rJSnGVFcVsj 25wW9y6oPkQzhPVv3UbdpdyIdkYWyEFXQKSV1NzCJY90SKNbRSEyErTm5K8Ie5fiW1ir2G2lIzC 2oOARYFuhoAe5XzlrP3OLe/H6j7PW9P1Q6ojHX5bOotc0n5CTVPoVY7zFa5kBQdsu8XRXRnulqW sk7Qfbe9U99rVmIlqVzLHjgZc1XFjrOcU4rN3sHqMgFPBbyu3ZrHoWgw4Vq4JSEbYUuDFdJQ+Pa xk7r8xd2bD6FI9iZU3w== X-Proofpoint-ORIG-GUID: USpUrqDrtOwFzTQR1bG44XNGu8l4Jsu2 X-Authority-Analysis: v=2.4 cv=C+7kCAP+ c=1 sm=1 tr=0 ts=69b2bfea cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=f57iFBScQPT45aafJKQA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: USpUrqDrtOwFzTQR1bG44XNGu8l4Jsu2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120107 After removing all extra entries from the UBWC database it is easy to define generic entries, common for all machine classes. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/ubwc_config.c | 189 +++++++++++++++----------------------= ---- 1 file changed, 70 insertions(+), 119 deletions(-) diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c index ccee20913115..2ee40a26ec68 100644 --- a/drivers/soc/qcom/ubwc_config.c +++ b/drivers/soc/qcom/ubwc_config.c @@ -16,119 +16,70 @@ static const struct qcom_ubwc_cfg_data no_ubwc_data = =3D { /* no UBWC, no HBB */ }; =20 -static const struct qcom_ubwc_cfg_data kaanapali_data =3D { - .ubwc_enc_version =3D UBWC_6_0, - .highest_bank_bit =3D 16, +static const struct qcom_ubwc_cfg_data ubwc_0_0_hbb15 =3D { + /* no UBWC */ + .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data msm8937_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_1_0_hbb14 =3D { .ubwc_enc_version =3D UBWC_1_0, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data msm8998_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_1_0_hbb15 =3D { .ubwc_enc_version =3D UBWC_1_0, .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data qcm2290_data =3D { - /* no UBWC */ - .highest_bank_bit =3D 15, -}; - -static const struct qcom_ubwc_cfg_data sa8775p_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, - .highest_bank_bit =3D 13, -}; - -static const struct qcom_ubwc_cfg_data sar2130p_data =3D { - .ubwc_enc_version =3D UBWC_3_1, - .highest_bank_bit =3D 13, -}; - -static const struct qcom_ubwc_cfg_data sc7180_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_2_0_hbb14 =3D { .ubwc_enc_version =3D UBWC_2_0, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data sc7280_data =3D { - .ubwc_enc_version =3D UBWC_3_1, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sc8180x_data =3D { - .ubwc_enc_version =3D UBWC_3_0, - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data sc8280xp_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - .highest_bank_bit =3D 16, -}; - -static const struct qcom_ubwc_cfg_data sdm670_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sdm845_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_2_0_hbb15 =3D { .ubwc_enc_version =3D UBWC_2_0, .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data sm6115_data =3D { - .ubwc_enc_version =3D UBWC_1_0, - .highest_bank_bit =3D 14, -}; - -static const struct qcom_ubwc_cfg_data sm6125_data =3D { - .ubwc_enc_version =3D UBWC_1_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_0_hbb15 =3D { + .ubwc_enc_version =3D UBWC_3_0, + .highest_bank_bit =3D 15, }; =20 -static const struct qcom_ubwc_cfg_data sm6150_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_3_0, + .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm6350_data =3D { - .ubwc_enc_version =3D UBWC_2_0, - .highest_bank_bit =3D 14, +static const struct qcom_ubwc_cfg_data ubwc_3_1_hbb13 =3D { + .ubwc_enc_version =3D UBWC_3_1, + .highest_bank_bit =3D 13, }; =20 -static const struct qcom_ubwc_cfg_data sm7150_data =3D { - .ubwc_enc_version =3D UBWC_2_0, +static const struct qcom_ubwc_cfg_data ubwc_3_1_hbb14 =3D { + .ubwc_enc_version =3D UBWC_3_1, .highest_bank_bit =3D 14, }; =20 -static const struct qcom_ubwc_cfg_data sm8150_data =3D { - .ubwc_enc_version =3D UBWC_3_0, - .highest_bank_bit =3D 15, -}; - -static const struct qcom_ubwc_cfg_data sm8250_data =3D { +static const struct qcom_ubwc_cfg_data ubwc_4_0_hbb16 =3D { .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8350_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ +static const struct qcom_ubwc_cfg_data ubwc_5_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_5_0, .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8550_data =3D { - .ubwc_enc_version =3D UBWC_4_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ +static const struct qcom_ubwc_cfg_data ubwc_6_0_hbb16 =3D { + .ubwc_enc_version =3D UBWC_6_0, .highest_bank_bit =3D 16, }; =20 -static const struct qcom_ubwc_cfg_data sm8750_data =3D { - .ubwc_enc_version =3D UBWC_5_0, - /* TODO: highest_bank_bit =3D 15 for LP_DDR4 */ - .highest_bank_bit =3D 16, +static const struct qcom_ubwc_cfg_data sa8775p_data =3D { + .ubwc_enc_version =3D UBWC_4_0, + .flags =3D UBWC_FLAG_DISABLE_SWIZZLE_LVL2, + .highest_bank_bit =3D 13, }; =20 static const struct qcom_ubwc_cfg_data glymur_data =3D { @@ -143,59 +94,59 @@ static const struct of_device_id qcom_ubwc_configs[] _= _maybe_unused =3D { { .compatible =3D "qcom,apq8016", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,apq8026", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,apq8074", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,apq8096", .data =3D &msm8998_data }, - { .compatible =3D "qcom,kaanapali", .data =3D &kaanapali_data, }, + { .compatible =3D "qcom,apq8096", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,kaanapali", .data =3D &ubwc_6_0_hbb16 }, { .compatible =3D "qcom,glymur", .data =3D &glymur_data}, { .compatible =3D "qcom,msm8226", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8916", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8917", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8937", .data =3D &msm8937_data }, + { .compatible =3D "qcom,msm8937", .data =3D &ubwc_1_0_hbb14 }, { .compatible =3D "qcom,msm8929", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8939", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8953", .data =3D &msm8937_data }, + { .compatible =3D "qcom,msm8953", .data =3D &ubwc_1_0_hbb14 }, { .compatible =3D "qcom,msm8956", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8974", .data =3D &no_ubwc_data }, { .compatible =3D "qcom,msm8976", .data =3D &no_ubwc_data }, - { .compatible =3D "qcom,msm8996", .data =3D &msm8998_data }, - { .compatible =3D "qcom,msm8998", .data =3D &msm8998_data }, - { .compatible =3D "qcom,qcm2290", .data =3D &qcm2290_data, }, - { .compatible =3D "qcom,qcm6490", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,qcs8300", .data =3D &sc8280xp_data, }, - { .compatible =3D "qcom,sa8155p", .data =3D &sm8150_data, }, - { .compatible =3D "qcom,sa8540p", .data =3D &sc8280xp_data, }, + { .compatible =3D "qcom,msm8996", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,msm8998", .data =3D &ubwc_1_0_hbb15 }, + { .compatible =3D "qcom,qcm2290", .data =3D &ubwc_0_0_hbb15, }, + { .compatible =3D "qcom,qcm6490", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,qcs8300", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sa8155p", .data =3D &ubwc_3_0_hbb15, }, + { .compatible =3D "qcom,sa8540p", .data =3D &ubwc_4_0_hbb16, }, { .compatible =3D "qcom,sa8775p", .data =3D &sa8775p_data, }, - { .compatible =3D "qcom,sar2130p", .data =3D &sar2130p_data }, - { .compatible =3D "qcom,sc7180", .data =3D &sc7180_data }, - { .compatible =3D "qcom,sc7280", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,sc8180x", .data =3D &sc8180x_data, }, - { .compatible =3D "qcom,sc8280xp", .data =3D &sc8280xp_data, }, - { .compatible =3D "qcom,sda660", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm450", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm630", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm632", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm636", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm660", .data =3D &msm8937_data }, - { .compatible =3D "qcom,sdm670", .data =3D &sdm670_data, }, - { .compatible =3D "qcom,sdm845", .data =3D &sdm845_data, }, - { .compatible =3D "qcom,sm4250", .data =3D &sm6115_data, }, - { .compatible =3D "qcom,sm6115", .data =3D &sm6115_data, }, - { .compatible =3D "qcom,sm6125", .data =3D &sm6125_data, }, - { .compatible =3D "qcom,sm6150", .data =3D &sm6150_data, }, - { .compatible =3D "qcom,sm6350", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm6375", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm7125", .data =3D &sc7180_data }, - { .compatible =3D "qcom,sm7150", .data =3D &sm7150_data, }, - { .compatible =3D "qcom,sm7225", .data =3D &sm6350_data, }, - { .compatible =3D "qcom,sm7325", .data =3D &sc7280_data, }, - { .compatible =3D "qcom,sm8150", .data =3D &sm8150_data, }, - { .compatible =3D "qcom,sm8250", .data =3D &sm8250_data, }, - { .compatible =3D "qcom,sm8350", .data =3D &sm8350_data, }, - { .compatible =3D "qcom,sm8450", .data =3D &sm8350_data, }, - { .compatible =3D "qcom,sm8550", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,sm8650", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,sm8750", .data =3D &sm8750_data, }, - { .compatible =3D "qcom,x1e80100", .data =3D &sm8550_data, }, - { .compatible =3D "qcom,x1p42100", .data =3D &sm8550_data, }, + { .compatible =3D "qcom,sar2130p", .data =3D &ubwc_3_1_hbb13 }, + { .compatible =3D "qcom,sc7180", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sc7280", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,sc8180x", .data =3D &ubwc_3_0_hbb16, }, + { .compatible =3D "qcom,sc8280xp", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sda660", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm450", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm630", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm632", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm636", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm660", .data =3D &ubwc_1_0_hbb14 }, + { .compatible =3D "qcom,sdm670", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sdm845", .data =3D &ubwc_2_0_hbb15, }, + { .compatible =3D "qcom,sm4250", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6115", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6125", .data =3D &ubwc_1_0_hbb14, }, + { .compatible =3D "qcom,sm6150", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm6350", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm6375", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7125", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7150", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7225", .data =3D &ubwc_2_0_hbb14, }, + { .compatible =3D "qcom,sm7325", .data =3D &ubwc_3_1_hbb14, }, + { .compatible =3D "qcom,sm8150", .data =3D &ubwc_3_0_hbb15, }, + { .compatible =3D "qcom,sm8250", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8350", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8450", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8550", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8650", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,sm8750", .data =3D &ubwc_5_0_hbb16, }, + { .compatible =3D "qcom,x1e80100", .data =3D &ubwc_4_0_hbb16, }, + { .compatible =3D "qcom,x1p42100", .data =3D &ubwc_4_0_hbb16, }, { } }; =20 --=20 2.47.3