From nobody Fri Apr 3 00:00:51 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 831F4338592 for ; Thu, 12 Mar 2026 08:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773304117; cv=none; b=YVqJzqkUVefYYVitOVKKj45EzjNeoEfrkeFt87z95q0FihtxTCfgwLgomd2xBOvC3+gATEicht4fc49wj9P8CAlBMHTAzGIYQOIbYEPL90A7n5ndCyo6zBIzgB7v7xIEz/76vCqR7oghu6+lmfnOiN1XsAeg2V3MbDSvAPb8+og= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773304117; c=relaxed/simple; bh=RE3qeIJFMCJw+TbGo280DpJf2sHQjKNb5z8KylWcMU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NS5lVLfPOBbcLBc2xN+ljXRUbKw+820goQrBn/mWnbLDOcBU1P2FKhh05Dk0VR7a+G/BhXPU2/yv9jSSF7dvG8nHdGVFq5qTWXcTnx6gHMyvb+6AWUXG7eV21yaT7l1ssE4msiupC7oRO+OCWO/vQKkGG8qfSPc8tyPpbh+fJt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=leNOSzPI; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="leNOSzPI" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-439d8dc4ae4so811139f8f.2 for ; Thu, 12 Mar 2026 01:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773304114; x=1773908914; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wPddzVJSVtkRrcRhnsRvT/Hf7HSSWz/56c2ZASviYjw=; b=leNOSzPIf0H9ZQFjqpm/++yDDjfz4Xvi0lp5KiO0cXXg2+kPoW74UT3oAPkPVtIeS2 MY6lIepqA5TAG/uq5IUWsPA2v4tjpeg6zw5pUqt9A/E4xN0f6XxWcii7G/Z27H9Um+aH l7lJ7Owc+++dFdKN3p1z5FjIUxLou/MZUWCVQ/XnbP2Mofw4PPuMlg2NFFmu3z+a8Urz y7MS4/5xCyXKnf7+HWABmqqtbKhGcl4udFKQO3lAmiRFfML3QGqXh3vMChHtP2L3JP3N aCiwG70i9aGamNpLtOd2hOgvB7v7EYTwnIJfzjliwbX333Yi27DiMGBic6sVIqfaADPS tHaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773304114; x=1773908914; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wPddzVJSVtkRrcRhnsRvT/Hf7HSSWz/56c2ZASviYjw=; b=GeN8CZR+547iO2yQyh6DzR2OIvQ+85M4k9ihl/EUc4oi6NIGqggf4tpBUJkFKKibV4 +kOLKLo+6mxaX2xea6875lDAYzBajKfNYBDR7QR/gur1BEL8p0Y819hDOXZxCJePAv+L 8htdy1yJvnBAzXDPh+MF1uTCPWGAAO8Rhahh5DanaiD44td2Aoafd1uXqJRKnMU7ahlB /7lO8dq/mKTqZEurPKv3IQ7s7JuzK6pYXK9fMA2KnO81seQEyHA8fYA+QE8N+QpRCcOt e6dwkn0RTMsXPXXbShbj/mV1ToCvYMmqNv5pdNN1vjzY0YIqBeIDCEnE0qdxQPDFyY+M E3IA== X-Forwarded-Encrypted: i=1; AJvYcCWaRHAXsgXd8kWhTeJ1b5LpDkykZk88LniaxwDde4/JSpt7Vt19SfwFFtQH5Xbbm3gKa8MieHbZzT5SFaY=@vger.kernel.org X-Gm-Message-State: AOJu0YySrK1tffPbgma0MUt2JTCn9jE4umVYlFr/OpqLuZVIYlE/z+UQ eN3GoNDL9cX7bL7IMkfPs410y71qlM69v57/wn3Hhwff0+4L+fXhVDZc0UZ/AvWumog= X-Gm-Gg: ATEYQzzXcrZjS+GcrIzA9oXQ6tF/xL8NoD0sFRPVhd20QfeFQznZwdDB+cKqFwWbrFi g/DHxN6RN80WfJoF6YHJEPtjnMwhqFMXH/Ww8eXIrdzUCA2djIHniX6ULvxBy0RQeyWbASIEnZ3 e2bMuPeVOfvZBo0LiWfiNmcj2OUtlxGY/42uYS0vpxiP7afbFcAeIdoonR3EAtmpVPeLfRwPgfc IbSzP6rmWif7FOQwrCYKGc2ag6VE5e1KNvTb54bSg6ChsAlsiv09pp/btWVftByz4q90ahJK8nX 8YvcsRBonyyhj2Wv7nxJhIs8YcimPrcoZFxAAuDhrxi/fjyAa5VipZogCUN+Y2lWpjvqRsA4mJ+ VZuzI7kLzqkxgW3+15sOXGVIsiGxeYdrNgU9y12dO+UGh/mpin7TCH6oLp9qTw0A5lJC4UReMmx uB54E= X-Received: by 2002:a5d:5f82:0:b0:439:b5f9:eeba with SMTP id ffacd0b85a97d-439f81f2288mr10505269f8f.3.1773304113877; Thu, 12 Mar 2026 01:28:33 -0700 (PDT) Received: from [127.0.1.1] ([2a04:6f00:1::ee:b:1015]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe219c41sm6273780f8f.29.2026.03.12.01.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 01:28:33 -0700 (PDT) From: Jun Nie Date: Thu, 12 Mar 2026 16:28:10 +0800 Subject: [PATCH v19 1/4] drm/msm/dpu: Extract plane splitting into a dedicated function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-msm-next-quad-pipe-split-v19-1-4ffa2b06c996@linaro.org> References: <20260312-msm-next-quad-pipe-split-v19-0-4ffa2b06c996@linaro.org> In-Reply-To: <20260312-msm-next-quad-pipe-split-v19-0-4ffa2b06c996@linaro.org> To: Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Rob Clark , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jun Nie , Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773304094; l=4057; i=jun.nie@linaro.org; s=20240403; h=from:subject:message-id; bh=RE3qeIJFMCJw+TbGo280DpJf2sHQjKNb5z8KylWcMU4=; b=M8/3vPKx/BLiXkMrb7SgSN2c/ye0Xo7pQ+VC1zKC3aDaybDQ5LizP8tMXUHdtiJ9hhKam2YbG BukVpt3O9A8Da7+yG3rBWBNQ+tM2Pd80pmWYCIOmnafEQ+B+vmf6LU3 X-Developer-Key: i=jun.nie@linaro.org; a=ed25519; pk=MNiBt/faLPvo+iJoP1hodyY2x6ozVXL8QMptmsKg3cc= dpu_plane_atomic_check_nosspp() currently handles both plane validation and plane splitting. For better simplicity and to facilitate future refactoring, move the splitting logic into its own dedicated function. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 48 +++++++++++++++++++++------= ---- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/ms= m/disp/dpu1/dpu_plane.c index 9b7a8b46bfa91..4ed14f203c315 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -821,13 +821,8 @@ static int dpu_plane_atomic_check_nosspp(struct drm_pl= ane *plane, { int i, ret =3D 0, min_scale, max_scale; struct dpu_plane *pdpu =3D to_dpu_plane(plane); - struct dpu_kms *kms =3D _dpu_plane_get_kms(&pdpu->base); - u64 max_mdp_clk_rate =3D kms->perf.max_core_clk_rate; struct dpu_plane_state *pstate =3D to_dpu_plane_state(new_plane_state); - struct dpu_sw_pipe_cfg *pipe_cfg; - struct dpu_sw_pipe_cfg *r_pipe_cfg; struct drm_rect fb_rect =3D { 0 }; - uint32_t max_linewidth; =20 min_scale =3D FRAC_16_16(1, MAX_UPSCALE_RATIO); max_scale =3D MAX_DOWNSCALE_RATIO << 16; @@ -850,14 +845,6 @@ static int dpu_plane_atomic_check_nosspp(struct drm_pl= ane *plane, return -EINVAL; } =20 - /* move the assignment here, to ease handling to another pairs later */ - pipe_cfg =3D &pstate->pipe_cfg[0]; - r_pipe_cfg =3D &pstate->pipe_cfg[1]; - /* state->src is 16.16, src_rect is not */ - drm_rect_fp_to_int(&pipe_cfg->src_rect, &new_plane_state->src); - - pipe_cfg->dst_rect =3D new_plane_state->dst; - fb_rect.x2 =3D new_plane_state->fb->width; fb_rect.y2 =3D new_plane_state->fb->height; =20 @@ -879,6 +866,31 @@ static int dpu_plane_atomic_check_nosspp(struct drm_pl= ane *plane, if (pstate->layout.plane_pitch[i] > DPU_SSPP_MAX_PITCH_SIZE) return -E2BIG; =20 + pstate->needs_qos_remap =3D drm_atomic_crtc_needs_modeset(crtc_state); + + return 0; +} + +static int dpu_plane_split(struct drm_plane *plane, + struct drm_plane_state *new_plane_state, + const struct drm_crtc_state *crtc_state) +{ + struct dpu_plane *pdpu =3D to_dpu_plane(plane); + struct dpu_kms *kms =3D _dpu_plane_get_kms(&pdpu->base); + u64 max_mdp_clk_rate =3D kms->perf.max_core_clk_rate; + struct dpu_plane_state *pstate =3D to_dpu_plane_state(new_plane_state); + struct dpu_sw_pipe_cfg *pipe_cfg; + struct dpu_sw_pipe_cfg *r_pipe_cfg; + uint32_t max_linewidth; + + /* move the assignment here, to ease handling to another pairs later */ + pipe_cfg =3D &pstate->pipe_cfg[0]; + r_pipe_cfg =3D &pstate->pipe_cfg[1]; + /* state->src is 16.16, src_rect is not */ + drm_rect_fp_to_int(&pipe_cfg->src_rect, &new_plane_state->src); + + pipe_cfg->dst_rect =3D new_plane_state->dst; + max_linewidth =3D pdpu->catalog->caps->max_linewidth; =20 drm_rect_rotate(&pipe_cfg->src_rect, @@ -910,8 +922,6 @@ static int dpu_plane_atomic_check_nosspp(struct drm_pla= ne *plane, new_plane_state->fb->width, new_plane_state->fb->height, new_plane_state->rotation); =20 - pstate->needs_qos_remap =3D drm_atomic_crtc_needs_modeset(crtc_state); - return 0; } =20 @@ -1132,6 +1142,10 @@ static int dpu_plane_atomic_check(struct drm_plane *= plane, if (!new_plane_state->visible) return 0; =20 + ret =3D dpu_plane_split(plane, new_plane_state, crtc_state); + if (ret) + return ret; + if (!dpu_plane_try_multirect_parallel(pipe, pipe_cfg, r_pipe, r_pipe_cfg, pipe->sspp, msm_framebuffer_format(new_plane_state->fb), @@ -1180,6 +1194,10 @@ static int dpu_plane_virtual_atomic_check(struct drm= _plane *plane, return 0; } =20 + ret =3D dpu_plane_split(plane, plane_state, crtc_state); + if (ret) + return ret; + /* * Force resource reallocation if the format of FB or src/dst have * changed. We might need to allocate different SSPP or SSPPs for this --=20 2.43.0