From nobody Tue Apr 7 18:04:51 2026 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646AD33A6F7; Thu, 12 Mar 2026 08:43:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773305009; cv=pass; b=pK2CoiE3zsc/K8Ao8Xe/pZYtbWUNFfeT6YU0aN4Beim+O+niauXVAOJvX43UwtGQ1EjHDoIomRAixQ88upsFbq8vzK20JHRNeOL93LQavQKaNACA+zkCOe4U5OLsLWBvCPeshHOhGQOPcArwOxzbMSzmEZW55l55vMkZMe/RDnI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773305009; c=relaxed/simple; bh=huf4sOli/OdrIpvyc62HdS32Qh7swj00LsrEz3KIWnA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q5O1kxv0iMK560EgRZ48em45e4qAa4x5AoD3HTK4VstVrBsR/Mgkm1BzvkfS3A/8BVyOE75RrpHxTbgMmTEkjeK7vnBb2NLUFikqufSQ913Hhkj/zlKichbKGj+F2G7pBeeTPvv90GZyguCRfEoyb+09ZHFZDlMtp6mT75pATsk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pigmoral.tech; spf=pass smtp.mailfrom=pigmoral.tech; dkim=pass (1024-bit key) header.d=pigmoral.tech header.i=junhui.liu@pigmoral.tech header.b=STRLuv8I; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pigmoral.tech Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pigmoral.tech Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pigmoral.tech header.i=junhui.liu@pigmoral.tech header.b="STRLuv8I" ARC-Seal: i=1; a=rsa-sha256; t=1773304995; cv=none; d=zohomail.com; s=zohoarc; b=QeMk9MU0ILTZCpd0gzBtuN0lJS/nAc72jRVK29cEKgT2vWxAqgeJZRdlMW7yGSUDiJwy722rwXOKVjeLkHO1wjPc2Ie5SfuWQcDCH/Cyus+E52fVSdd9iZgK3tMIOgJB3m2J1qv7akKI71864KYYoKfUgJh8FxgzUn98Otk+VgE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773304995; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=lLFFlC1eFZuQ+K5xs5pEbHt15H+wC35wY2TANwxBsOA=; b=Lz6re+TwBUzKyUq/9Px0Oye8BZhUPKElvZrPNQKV6OqnP7VqNyg6JBMlDkgUFHrkU+5mokDGc8q5z3fV8+M2a/YAm/y6vBahupsT3vvoS4XOpWPFCtN6QqK7qOJwfCc3W5S1hEgMvMvgNVcEunmh7r+lzS/7T3xHIqFvpctMhmg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=pigmoral.tech; spf=pass smtp.mailfrom=junhui.liu@pigmoral.tech; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1773304995; s=zmail; d=pigmoral.tech; i=junhui.liu@pigmoral.tech; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=lLFFlC1eFZuQ+K5xs5pEbHt15H+wC35wY2TANwxBsOA=; b=STRLuv8IF+HH5vxvnpJft8h1XKUbKuwze7E+Gb4nFV1rX3bDD4qhOhv8u2shi2Am 9bWmB84OPz1BTSq+QnnlPUMFVu0oVBngzzYqBZ7tM8jSZKJ+cKsKauNHaxZK3GgXoBB /7iPzd2HP1sG4WO1t65nre2gyoA9TtMFnoNC5M8k= Received: by mx.zohomail.com with SMTPS id 1773304994180870.4146837004669; Thu, 12 Mar 2026 01:43:14 -0700 (PDT) From: Junhui Liu Date: Thu, 12 Mar 2026 16:42:42 +0800 Subject: [PATCH 1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-k1-gpio-set-config-v1-1-8c3541da16b1@pigmoral.tech> References: <20260312-k1-gpio-set-config-v1-0-8c3541da16b1@pigmoral.tech> In-Reply-To: <20260312-k1-gpio-set-config-v1-0-8c3541da16b1@pigmoral.tech> To: Linus Walleij , Yixun Lan , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Junhui Liu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773304980; l=2486; i=junhui.liu@pigmoral.tech; s=20251228; h=from:subject:message-id; bh=huf4sOli/OdrIpvyc62HdS32Qh7swj00LsrEz3KIWnA=; b=B3MbVb4iVOeA0XP3NHfpH4p1KIgTU4BPfBNQ6hM1nRE+0L4walRbWHRavIXqIsDZnvnmncKDy yMmVWx5fDz/BMpuRpwjFuDW6yIZZ9VoH3ty6IdykLrHL6wdbniCEHKI X-Developer-Key: i=junhui.liu@pigmoral.tech; a=ed25519; pk=3vU0qIPJAH8blXmLyqBhKx+nLOjcLwwYhZXelEpw7h4= X-ZohoMailClient: External Return -ENOTSUPP instead of -EINVAL when encountering unsupported pin configuration parameters. This is more logical and allows the GPIO subsystem to gracefully handle unsupported parameters via functions like gpio_set_config_with_argument_optional(), which specifically ignores -ENOTSUPP but treats others as failure. Signed-off-by: Junhui Liu Reviewed-by: Anand Moon Reviewed-by: Bartosz Golaszewski Reviewed-by: Yixun Lan --- drivers/pinctrl/spacemit/pinctrl-k1.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacem= it/pinctrl-k1.c index 62cab6f6cd0a..b0be62b1c816 100644 --- a/drivers/pinctrl/spacemit/pinctrl-k1.c +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c @@ -674,7 +674,7 @@ static int spacemit_pinconf_get(struct pinctrl_dev *pct= ldev, arg =3D 0; break; default: - return -EINVAL; + return -ENOTSUPP; } =20 *config =3D pinconf_to_config_packed(param, arg); @@ -740,7 +740,7 @@ static int spacemit_pinconf_generate_config(struct spac= emit_pinctrl *pctrl, } break; default: - return -EINVAL; + return -ENOTSUPP; } } =20 @@ -814,10 +814,12 @@ static int spacemit_pinconf_set(struct pinctrl_dev *p= ctldev, struct spacemit_pinctrl *pctrl =3D pinctrl_dev_get_drvdata(pctldev); const struct spacemit_pin *spin =3D spacemit_get_pin(pctrl, pin); u32 value; + int ret; =20 - if (spacemit_pinconf_generate_config(pctrl, spin, pctrl->data->dconf, - configs, num_configs, &value)) - return -EINVAL; + ret =3D spacemit_pinconf_generate_config(pctrl, spin, pctrl->data->dconf, + configs, num_configs, &value); + if (ret) + return ret; =20 return spacemit_pin_set_config(pctrl, pin, value); } @@ -831,16 +833,17 @@ static int spacemit_pinconf_group_set(struct pinctrl_= dev *pctldev, const struct spacemit_pin *spin; const struct group_desc *group; u32 value; - int i; + int i, ret; =20 group =3D pinctrl_generic_get_group(pctldev, gsel); if (!group) return -EINVAL; =20 spin =3D spacemit_get_pin(pctrl, group->grp.pins[0]); - if (spacemit_pinconf_generate_config(pctrl, spin, pctrl->data->dconf, - configs, num_configs, &value)) - return -EINVAL; + ret =3D spacemit_pinconf_generate_config(pctrl, spin, pctrl->data->dconf, + configs, num_configs, &value); + if (ret) + return ret; =20 for (i =3D 0; i < group->grp.npins; i++) spacemit_pin_set_config(pctrl, group->grp.pins[i], value); --=20 2.53.0 From nobody Tue Apr 7 18:04:51 2026 Received: from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com [136.143.188.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA32383C75; Thu, 12 Mar 2026 08:43:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773305015; cv=pass; b=oHCNRLHRlUeNNgk+WTqW0UOCg83W30AkDVX10viRD2rRD1niPGIB0AgkVWAQG9wCGq9lfVkPooiryNqPZD3KinSdet0apfWE1t/1d0i6iyHzwuP5+5WAaLh1B3PhqbeLApzch0daiHA48v7e3iTT/G6KfxTuTlQRXaeEDUG71AA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773305015; c=relaxed/simple; bh=9MTfGDEAf9YZnyagaSAAFWByTP/OFXhtAXonoK5uZ0M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QfaRUJFEY0P1jgS4midOcQVRNPNSIuPp13uW+CXVzHpBZjUbxOYPae/EqIr+RMq7mhw9xH2ZJMvFi9R01W+QlU+OfMxUU1m9hPK/Xo35VSj03yeG/MHw7fl1EK3Q6ST3pGsLnZgaBvK6mzJmxo54d1rStKLZa2JIAaLgopFYb6k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pigmoral.tech; spf=pass smtp.mailfrom=pigmoral.tech; dkim=pass (1024-bit key) header.d=pigmoral.tech header.i=junhui.liu@pigmoral.tech header.b=ULc3fNhv; arc=pass smtp.client-ip=136.143.188.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pigmoral.tech Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pigmoral.tech Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pigmoral.tech header.i=junhui.liu@pigmoral.tech header.b="ULc3fNhv" ARC-Seal: i=1; a=rsa-sha256; t=1773305003; cv=none; d=zohomail.com; s=zohoarc; b=QH0Tdbja1Hfyq9EzNR6QnaIzusMndEOL7prvmnj79KYijmWuqObfY5fC8TLQ9KVKPfb+BxHZGtcFCqEgcVp8QmmpdcDrLlNUk7MKnxpyBU/ijOHrR1s8TlODnvQX7d25i1KAc5l+AwCdgoUJX5L4pmSFAkltS0kcK1z5t88xVy4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773305003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=v47EHelxEqjuraNQyB3mSutNBgUfD8I8NAMJB3eHXcA=; b=i9Ux6dtDUFTjb2xxn+MZpaUw76tCepjr1tq/W3HezILypcShCnXigde2VHHTwo6qHvoI6kXSNeEGnPrRUJ3rWLdR1YlosrjQws+tnHrL4QgngcsomQYB3oGPTTroUwe3VWGC7JZsSB4Ashoi9TBDxDWOKa56ewckuilkpIB18YI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=pigmoral.tech; spf=pass smtp.mailfrom=junhui.liu@pigmoral.tech; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1773305003; s=zmail; d=pigmoral.tech; i=junhui.liu@pigmoral.tech; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=v47EHelxEqjuraNQyB3mSutNBgUfD8I8NAMJB3eHXcA=; b=ULc3fNhvD8HwrjdbCZhVnPFiEf6ePL3OuXkP2qzv/WtCy4F1tlULMGR8D1aHhB8r +HVxQQ4ivY3Eb7eGVOUXKdzgy+wM0Q6a6TqfwFXTXChQN84jq0Zw4SJy0U9R4Rits0m qQyZCM94VzQ/czRbKea7/yacW9vMa9ZGr55J2UCo= Received: by mx.zohomail.com with SMTPS id 1773305000858359.97959519734354; Thu, 12 Mar 2026 01:43:20 -0700 (PDT) From: Junhui Liu Date: Thu, 12 Mar 2026 16:42:43 +0800 Subject: [PATCH 2/2] gpio: spacemit-k1: Add set_config callback support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-k1-gpio-set-config-v1-2-8c3541da16b1@pigmoral.tech> References: <20260312-k1-gpio-set-config-v1-0-8c3541da16b1@pigmoral.tech> In-Reply-To: <20260312-k1-gpio-set-config-v1-0-8c3541da16b1@pigmoral.tech> To: Linus Walleij , Yixun Lan , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Junhui Liu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773304980; l=921; i=junhui.liu@pigmoral.tech; s=20251228; h=from:subject:message-id; bh=9MTfGDEAf9YZnyagaSAAFWByTP/OFXhtAXonoK5uZ0M=; b=DA18ygHHkx+XZ8+b+pvbB3WE1hpWwMHQiwrwKhJ7Hk6Yc7YFAF0bqMqkIRFuIdhyiuMDEkL/E lG9i3nNvLUVAd13vZsihfmLz+cxFyRnCwTFnwneV812r1MvLYLuWqRR X-Developer-Key: i=junhui.liu@pigmoral.tech; a=ed25519; pk=3vU0qIPJAH8blXmLyqBhKx+nLOjcLwwYhZXelEpw7h4= X-ZohoMailClient: External Assign gpiochip_generic_config() to the set_config() callback to support pin configuration through the GPIO subsystem. This allows users to configure GPIO pin attributes like pull-up/down when specifying a GPIO line in the Device Tree. Signed-off-by: Junhui Liu Acked-by: Bartosz Golaszewski Reviewed-by: Anand Moon Reviewed-by: Yixun Lan --- drivers/gpio/gpio-spacemit-k1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k= 1.c index dbd2e81094b9..5fe813b7f9bb 100644 --- a/drivers/gpio/gpio-spacemit-k1.c +++ b/drivers/gpio/gpio-spacemit-k1.c @@ -228,6 +228,7 @@ static int spacemit_gpio_add_bank(struct spacemit_gpio = *sg, gc->label =3D dev_name(dev); gc->request =3D gpiochip_generic_request; gc->free =3D gpiochip_generic_free; + gc->set_config =3D gpiochip_generic_config; gc->ngpio =3D SPACEMIT_NR_GPIOS_PER_BANK; gc->base =3D -1; gc->of_gpio_n_cells =3D 3; --=20 2.53.0