From nobody Tue Apr 7 16:17:48 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03CF3C454C for ; Thu, 12 Mar 2026 13:01:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773320491; cv=none; b=OTRS6RycnQ4WT3V4b+mLWLDzjxiQlhQxrG82U+TQaqMDlCQzL7jyB+o0epL7XCFoIJ9mlf81gdVofbjlE7m4pphr64nugP71RcZhZQIGTrziMsEk0QrYMos/wNnjCK9o0N7O0jalZDX/7kTIvWo8bwLgBQlLOpXOsfjdO+GGYgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773320491; c=relaxed/simple; bh=c9qTGlM1mbtZADnyMUzaIZXw9eTKM1g457AGHgLifNw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=ZjAUNSOLQn7b38k1z5NE6J3/HjnOouPuDxCSp5fAoSBqyENlSg+JXuxDGrvplJwuH2ZtImvUcFBrp1gPzOWHv5XcuJ5JWI50HGGaMch3OepYAFKrSg53OOrB8WoELTRbre8ohNu235SwqAMKH4NJlrW7+otkmx69ILT8HZlQcJg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ib3b8G/Y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IQ89RUSM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ib3b8G/Y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IQ89RUSM" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C7e1Px509773 for ; Thu, 12 Mar 2026 13:01:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=Rg0LeG2M4qW3Fgz2/GI2ig 0YOI3YtmCwQIQGf5ultIc=; b=Ib3b8G/Y6tiAZbKNhDpxkKiAKDtcyy9aoWPVD7 x1sJKrLz1xdyBoWzyh70E6QNkZTsjqu/Jxgm9k/+xHRQnaG0TsTqJt599LWILhVm gOHyq23fElQaGfelC+tFTEuvKaJDgL1pBCUZTwxH8t1SqFJybA0dy1QZJVK2kipL DJBg+NQp62QTjASzavpbjPPvkdOu4ttv2iklTvaqPuV9zNNYgl9j7x8dcu34aGoa rwblLDJrFMBeYYneyXAzMGrqALXFlFgBILPO7txhMQubrzuNS7OMlLZnYJrl3Wuq k9vGTxB8z1wtJZ//gyIz6UPat7zQZPmgG1BH9qFE27132poQ== Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w0sw3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2026 13:01:27 +0000 (GMT) Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7d73e3cf94eso4015484a34.2 for ; Thu, 12 Mar 2026 06:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773320487; x=1773925287; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=Rg0LeG2M4qW3Fgz2/GI2ig0YOI3YtmCwQIQGf5ultIc=; b=IQ89RUSM0vkq8Lo1l6hsRx2ohbzXRa3EwyaKtTbcZVlajWcBH1n89AmyeL8E//uQ0r 5F76avax/6iSeF+TfYHhH/mD3PXtA9K+IrhOveXSTDJBs89sV7ZRlOIfIm/RBGz+pu2J sA/gjdSaqCZp3xyCRFzBxTcdMCeBr6RZvkBHreDoIm3dfoIUwIBK00IZwnyUyhWNPMRX dGFZpi7fGhuiKZktTUVHqSwiUjq90/HjIwFnu10dOOwA5PLya8K0HqMz3DryG6AzHPaD 5vpLVFMTjF4mQNUjmGcI4RyFke0B7m1N+8ksQeM06w1Ipv+o0FCsyV9JVlCPChD7LeKz Mt1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773320487; x=1773925287; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rg0LeG2M4qW3Fgz2/GI2ig0YOI3YtmCwQIQGf5ultIc=; b=MPq154xErOQAX+JRX6esF+Mt4YTjB6mCLU/2EEPwVhYFAWKgMUXWCMYYIMdpreSYrX xEv2Au9o085P3JuxQOODckSIdPDRBieBKd6EsHQvajNMmcugL/Loodh4/k7iNtUKMTTS RHnOfsMGBfiW+J0LArwSKaYX2HZQLN5lVuEw4M11AhnMM+IvITCNAO913XB5kv17kBRF zmUdwniRw8POgIBO7m+0/KHU8kYbz7CDX1TUMvHe7H8KrT0lB1IOj3ss7RBQEuv59oGJ H/tdYkE7DCZQaKM1IOd43UDYY83f8Io8Hg9l3zGhcOdGJbNkZAlaR98DOvT9Q8WQqXkJ klnA== X-Forwarded-Encrypted: i=1; AJvYcCWIl+HHlIsQnQPquDoE+ufGdCMnCjrW7mnZn1KVEoZZbzXtXn64oTY87nu59Gcbyg5eeegqfcG5PQ0+nEM=@vger.kernel.org X-Gm-Message-State: AOJu0YzEfiYQyQ8VP1ZEdBVqtsn/Xaziv/vFPVacxdEB8VSblCS/Gv2e 3iyTKSthjtpIDpdjrKBzn4lu8idx3VLrgjNTAXjdjBiMIGJuQwjydMWAM8UyRLYrldz0NLZciOi qn8TCkleC5HfL/yB9F+PXe95MKeknzU8cwXJaArx+iCOnZPsyfvYpIgL+foilNeTs98c= X-Gm-Gg: ATEYQzwPmsQd7YETe1FO8tPcDfSqgJrki/m1ig+PhCWXmmoRQO30hetSrnKQSEqSyoY GhiRlxtIEl+D9IdxoN/B2nAoJD0Q8lloSW7KwHVinmrvQ/mZm9SYWjvfDgmEN3M/oaXaf/q8HKZ WaRPZ1cSujCtX1iAUv7lxIpWJFb+779OX995LBTtkaynynsyS2EcwjBiNxA3CwVkDQtvIe1+k2A UZ0yDDoFhxYC3oL0zOZKfIzmHimXTpY6MYSlfj+KeN2uFqyGbYfrALz7F7pajxCmF5wKuBLOCDa 3/Uhjk1tYogXzWEHxWZScO+gfmHiRu+Ad4GNT8BUEL/0WZEpJT/Kgt7JRtO2WEQos836gE3fhQc kXp7q+Rk8ir8Kvbb4wlAiwccGJgw= X-Received: by 2002:a05:6830:81d7:b0:7ab:e111:1a57 with SMTP id 46e09a7af769-7d76a83dddcmr3388290a34.31.1773320486852; Thu, 12 Mar 2026 06:01:26 -0700 (PDT) X-Received: by 2002:a05:6830:81d7:b0:7ab:e111:1a57 with SMTP id 46e09a7af769-7d76a83dddcmr3388257a34.31.1773320486217; Thu, 12 Mar 2026 06:01:26 -0700 (PDT) Received: from hackbox.lan ([82.79.95.133]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b6756e4sm150083515e9.15.2026.03.12.06.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 06:01:07 -0700 (PDT) From: Abel Vesa Date: Thu, 12 Mar 2026 15:00:42 +0200 Subject: [PATCH v2] arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260312-glymur-dts-crd-enable-kbd-tp-ts-v2-1-2277bee4c564@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAPm4smkC/42PS27DMAxEr2JoXQayk0iRV7lHkYU+dKLWX0k2G gS+eygnBbrshuAQ5Mzjg0UMHiOriwcLuPjoh55E9VEwe9P9FcE70qzileB7ruDa3rs5gEsRbHC AvTYtwrdxkEbIwxO33Bp5UgfOyGUM2PifLeHz8tJxNl9oU7Z9bwScZopOrzVmdESwQ9f5VBeN4 lq7prRCWvYXiygzVElQmWaig1+6TKYd0bkR+L7h1KOSR14vB5Yhbj6mIdy3r5dyy/z3g0sJJRw Fkq8USktxHmLcTbNuM/GOCrus6/oER+Za+FoBAAA= X-Change-ID: 20260309-glymur-dts-crd-enable-kbd-tp-ts-c80c0cb78940 To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.15-dev-7ae85 X-Developer-Signature: v=1; a=openpgp-sha256; l=4897; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=c9qTGlM1mbtZADnyMUzaIZXw9eTKM1g457AGHgLifNw=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBpsrkDM66NgJaYlrzmTZV5v4J+bmZk9aKOvkaXp 0Un9mpGZu2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCabK5AwAKCRAbX0TJAJUV VinOEACgMnFN7MaeRj+ZE89VPRn0vIJElIveUCzBy7e7aKqO3pFxdPgvV1pvoOWrwSDLuGev5KS tyEKOj0Vpj2n4Bh06KdXDBIakZgn1OQsr6Cd7tmWt+MuE71vwcMnkvTE60pKVI4kFY0jDUScBDC cJWlkew/pWWw6PUO4usKieW4OSXue6XVlzY0OX26A7WFN+oUpAqjVhL5x5YBdJOQ8nFGYxTW4+2 94DnvwhQqshfuFvg0M6OKldrGPlXqUwxeEN0oIjgGq1JixkAi6D0zcV/hgtLQqEidzz7nGdKR2H 3PlDDHOhm8iOPoJ0AzqmBdd61XbssGBd7dmZ31tVHF9Hw3b0zE+GRAeClaoCOlwFscWuq0uCd0v TkSBUImD0GwetSG9zaG2YHoPfgxFwqubSYaN+fmwTV5ZFBWDuK07YwpPdsRaLUbgNKWziY/8eZL t2L/JpwBX2ODl47BMtaQ9qG5Iu3O9LLJbJ+DCa/0XG9JVHydbIJDY0mGAByWUmxzXRGa/6YuWDo 3zkh60N79AttrdXkBA36tuQhsLmY5kHCy19iY0Ns5Jer5PfyLfr1jD/H27j1geVCJojjpC256Id 0dmRGJDRgW5qQ1NXHeZmzZwqdfzzmNrRHW1tTFIHZosy67ek/SmXn0ijXrE0HtRJMXpeLW+CESM u4PqTeXtWIFC5ng== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: 2YteOEqLDqZg0hTV7FUgmv5h9fOHDz1Y X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b2b927 cx=c_pps a=OI0sxtj7PyCX9F1bxD/puw==:117 a=iKs3dpp2RB4k51ZqCjcyjQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=PmoVyoobU9LGoXBsNIIA:9 a=QEXdDO2ut3YA:10 a=Z1Yy7GAxqfX1iEi80vsk:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEwMyBTYWx0ZWRfX7E4QWyRzKZbU gwTx/ZDyxpk4bJGM1BdK2GcmJHrNJmOXByNNOefQqqkeAtaekS7jVM9Wrbixk41nckVEgMYLmfF +yTkm/IZU69XosViTKL8uN4A6Ha4t+tvBfBp+UZUmXDGT1oHDD+JRhHlJT/2vWtkrkucm4xiGwF b1h2INV3+SNn21nQpZpNVJO+MkbI2dDp2bf7eUgXutrpZdinANSVDY6hKdiPGRNnpA/6TqxAKgY HfuWKmM/0rGooDoeyCEMKqh6f2NIvrDdJ5/aZmWdyRSJcN9gV8p/3vAU3nXMDteHBfKIgWzMmGD kGbQjEx4lCG59gD4m7PgCElS7o7TEiljenKHoBcZsiM7unZflVNmr5kSVKPRNwUg5PUpZiEz6X/ TwIj+A8KujyUPZvQPvNd+kgFpAzT7aZOamX7vYlr1mehoxtn9smv3cqsJPZhD9CRubfWmrfBwZe hGF12js6V0IASXXFdvQ== X-Proofpoint-ORIG-GUID: 2YteOEqLDqZg0hTV7FUgmv5h9fOHDz1Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120103 On CRD, the keyboard, trackpad and touchscreen are connected over I2C and all share a 3.3V regulator. So describe the regulator and each input device along with their pinctrl states. Signed-off-by: Abel Vesa Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- Changes in v2: - Rebased on next-20260311 - Re-ordered pinctrl properties in vreg_misc_3p3, as Konrad suggested. - Dropped next level dependency patchset. - Link to v1: https://patch.msgid.link/20260309-glymur-dts-crd-enable-kbd-t= p-ts-v1-1-56e03f769a76@oss.qualcomm.com --- arch/arm64/boot/dts/qcom/glymur-crd.dts | 117 ++++++++++++++++++++++++++++= ++++ 1 file changed, 117 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/= qcom/glymur-crd.dts index 38cdcf662ba7..55bdad46eba9 100644 --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts @@ -13,6 +13,8 @@ #include "pmk8850.dtsi" /* SPMI0: SID-0 */ #include "smb2370.dtsi" /* SPMI2: SID-9/10/11 */ =20 +#include + / { model =3D "Qualcomm Technologies, Inc. Glymur CRD"; compatible =3D "qcom,glymur-crd", "qcom,glymur"; @@ -139,6 +141,23 @@ vreg_edp_3p3: regulator-edp-3p3 { regulator-boot-on; }; =20 + vreg_misc_3p3: regulator-misc-3p3 { + compatible =3D "regulator-fixed"; + + regulator-name =3D "VREG_MISC_3P3"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + + gpio =3D <&pmh0110_f_e0_gpios 6 GPIO_ACTIVE_HIGH>; + enable-active-high; + + pinctrl-0 =3D <&misc_3p3_reg_en>; + pinctrl-names =3D "default"; + + regulator-boot-on; + regulator-always-on; + }; + vreg_nvme: regulator-nvme { compatible =3D "regulator-fixed"; =20 @@ -446,6 +465,64 @@ vreg_l4h_e0_1p2: ldo4 { }; }; =20 +&i2c0 { + clock-frequency =3D <400000>; + + status =3D "okay"; + + touchpad@2c { + compatible =3D "hid-over-i2c"; + reg =3D <0x2c>; + + hid-descr-addr =3D <0x20>; + interrupts-extended =3D <&tlmm 3 IRQ_TYPE_LEVEL_LOW>; + + vdd-supply =3D <&vreg_misc_3p3>; + vddl-supply =3D <&vreg_l15b_e0_1p8>; + + pinctrl-0 =3D <&tpad_default>; + pinctrl-names =3D "default"; + + wakeup-source; + }; + + keyboard@3a { + compatible =3D "hid-over-i2c"; + reg =3D <0x3a>; + + hid-descr-addr =3D <0x1>; + interrupts-extended =3D <&tlmm 67 IRQ_TYPE_LEVEL_LOW>; + + vdd-supply =3D <&vreg_misc_3p3>; + vddl-supply =3D <&vreg_l15b_e0_1p8>; + + pinctrl-0 =3D <&kybd_default>; + pinctrl-names =3D "default"; + + wakeup-source; + }; +}; + +&i2c8 { + clock-frequency =3D <400000>; + + status =3D "okay"; + + touchscreen@38 { + compatible =3D "hid-over-i2c"; + reg =3D <0x38>; + + hid-descr-addr =3D <0x1>; + interrupts-extended =3D <&tlmm 51 IRQ_TYPE_LEVEL_LOW>; + + vdd-supply =3D <&vreg_misc_3p3>; + vddl-supply =3D <&vreg_l15b_e0_1p8>; + + pinctrl-0 =3D <&ts0_default>; + pinctrl-names =3D "default"; + }; +}; + &i2c5 { clock-frequency =3D <400000>; =20 @@ -626,6 +703,19 @@ key_vol_up_default: key-vol-up-default-state { }; }; =20 +&pmh0110_f_e0_gpios { + misc_3p3_reg_en: misc-3p3-reg-en-state { + pins =3D "gpio6"; + function =3D "normal"; + bias-disable; + input-disable; + output-enable; + drive-push-pull; + power-source =3D <1>; /* 1.8 V */ + qcom,drive-strength =3D ; + }; +}; + &pmk8850_rtc { qcom,no-alarm; }; @@ -664,6 +754,33 @@ edp_reg_en: edp-reg-en-state { bias-disable; }; =20 + kybd_default: kybd-default-state { + pins =3D "gpio67"; + function =3D "gpio"; + bias-disable; + }; + + tpad_default: tpad-default-state { + pins =3D "gpio3"; + function =3D "gpio"; + bias-disable; + }; + + ts0_default: ts0-default-state { + int-n-pins { + pins =3D "gpio51"; + function =3D "gpio"; + bias-disable; + }; + + reset-n-pins { + pins =3D "gpio48"; + function =3D "gpio"; + output-high; + drive-strength =3D <16>; + }; + }; + pcie4_default: pcie4-default-state { clkreq-n-pins { pins =3D "gpio147"; --- base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7 change-id: 20260309-glymur-dts-crd-enable-kbd-tp-ts-c80c0cb78940 prerequisite-change-id: 20260109-dts-qcom-glymur-crd-add-edp-03f0adde9750:v4 prerequisite-patch-id: df42484b224c01014637ec5a8f56bab459890557 prerequisite-patch-id: d986d8d948eaf7b80028b2244750dc7aff7de307 prerequisite-patch-id: 7ec5f802a334d96421d8f95d4d9e9773655cc947 prerequisite-patch-id: 8d9e016b49979fa817cf9eab70b809fdb9d4656f prerequisite-patch-id: 6a291fd702870ca28d64439313d498593996b741 prerequisite-patch-id: c96958ab5c5605fb9577645ac5bfe5912cdfebfe prerequisite-patch-id: bfa283218723a48e54fcd842484b004c877339b7 prerequisite-patch-id: 346f2db0933c551a039f63b945f989a5c8320657 prerequisite-patch-id: 919020405b70d588fa4356a5cbfb44e67006102e Best regards, -- =20 Abel Vesa