From nobody Tue Apr 7 16:16:38 2026 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD14A3AE6ED for ; Thu, 12 Mar 2026 11:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773315691; cv=none; b=mTQAj7yFeR4RzcW7C3bnYp7Cc51YvxnD/AYGf6PwZnIPWiSYe7NlA+zunwFeW3e3/FQf40nWV3PU4eEBeDf1RA9Pe4KcOm+AaFfWhnTh/+jsv3r/Iuv3ed+nyC0YQI6JGC7r9PjOp3Za5jgQ5LJEn+9BFtQlNntp5FWlyUIluVY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773315691; c=relaxed/simple; bh=3EOAVMx1J493idd6LYRl0KO+vebw0d9HHob6XgQPPPg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=NHbPU8/bI/tatLpbrdIkVc1VMVRMLxX1Hpqp0Kmw/UR+Y7wLMQ8l3Ocvbwem+kZ0pvZZe95ximBYHz/j8wuIHGi4wNLPc2yhF3Lsmd2TciFjv5dlO+7vfVqTO+CqPnav/ukaBK0ijQ6KBB5bGvm9J0EpECotWwT2Ia48E9A9Zek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=kvGsYv4e; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="kvGsYv4e" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C6C6213984755; Thu, 12 Mar 2026 11:41:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=8 9rwUP4iU2VY5/7GrNdJqamxljJu9ZnTMFqvHj5hnho=; b=kvGsYv4eIp4k1wVHz t5W21w8nrf4snBeL91RRGX+InskwCBMc2TyDfDtJ6zWbWvhOZC2BGwqb8IIm/U51 nSnoU6rn2vHx3xbmployhdVsCrMWRy+CCLO+vEJIvMQ74pRf21v+ba94udrpMkTt aPcnvaJQUDyDNRlcmz+9vzBbk5vCHJ5KKZRebPyPE8iLKcxPZpgYvbuTT4iKo4YX LBYNsf+1t+bLqaGfYag7N8jwJ7FM+GM6q9R+b2BHDFzAGVVhjOxMToz3s6uSVkZs scNVG/PPuBFclaSJBK8xSXgHsiI8o2QbPSaV6nQmkemC+RlVdAiQ/OlNft/bRkaV rcqpw== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4ctxyghfsc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2026 11:41:14 +0000 (GMT) Received: from [127.0.1.1] (172.25.10.37) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 12 Mar 2026 11:41:13 +0000 From: Alexandru Dadu Date: Thu, 12 Mar 2026 13:40:53 +0200 Subject: [PATCH v2 1/3] drm/imagination: Add missing rogue context reset reasons Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260312-b4-firmware-context-reset-notification-handling-v2-1-aec5a64cb06f@imgtec.com> References: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> In-Reply-To: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> To: Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , "Alessio Belle" , Brajesh Gupta , Alexandru Dadu , Sarah Walker X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773315672; l=1690; i=alexandru.dadu@imgtec.com; s=20260304; h=from:subject:message-id; bh=3EOAVMx1J493idd6LYRl0KO+vebw0d9HHob6XgQPPPg=; b=wfh81hQn7qvNSRMvIOOzHSN6+GWQygSkwktXQ3qfNXY1W8vsyOLasj3vM29IIzYlll/0VxVM3 m709cUxJmp6AIUbr62KmMUyTvq0Qx99wppQ6W2OujYOFs0aB77Obz2z X-Developer-Key: i=alexandru.dadu@imgtec.com; a=ed25519; pk=FU07SyNrYGwhahqSxbWEuzyXlUh47xBXvLvOR7UA6+U= X-Proofpoint-ORIG-GUID: 8TTtFAbdqBYc5Gyr4Irz1gD1M2FxVc-- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDA5MiBTYWx0ZWRfX/x6QRhFmG+Nw 8svJ0ZjB8LSyfDA78N+OnZZNQHNEuO5ed8AphSvuTvdc7ypd3Ze2vNkUnfj4X4iTj2nfHy0Q0d3 0tvOkScIRCCdS9EhRB8hnXgi6eOE0gzPgPYRcUvH3vP5SXh39m+eTYiZNmMOM6K9IsCNBezpVdg R6Lt5ZVOoeoe+ipfO711khSflQeBThNBb6l4rgxqV6+Vi6FtrK0DIB9O+QrWmcT+xVN2+wcHbuJ EzYCQRmqiFAhqIChHJrZiemIEtQt134zs7hDa8Cv/xLMpisF8w1tonB9GvdhrKwGpg7ZFqo+/H7 E/iBYVhoIn0egRNji5cFzfXs19r1wNBorSrMNwQPbDIfNImQKm4zLsIT/JxSLQuuznHQSjPmoUJ QRQogtecYzjy2ckaAodyzzhSqAYsBUSv3m0c2YHOGl52pMwwMlrTlAwxMdw2qiWKrMwQm9MX5gK 3pMaIguQHVAvN81RmBQ== X-Proofpoint-GUID: 8TTtFAbdqBYc5Gyr4Irz1gD1M2FxVc-- X-Authority-Analysis: v=2.4 cv=NevrFmD4 c=1 sm=1 tr=0 ts=69b2a65a cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=7IANbbwssFwA:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=r_1tXGB3AAAA:8 a=lDk76OInDpq-OS2Ox4QA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 Update the context reset reason enum with the missing reset reasons in the 6-11 value gap: - CDM Mission/safety checksum mismatch; - TRP checksum mismatch; - GPU ECC error (corrected, OK); - GPU ECC error (uncorrected, HWR); - FW ECC error (corrected, OK); - FW ECC error (uncorrected, ERR); Co-authored-by: Sarah Walker Signed-off-by: Alexandru Dadu --- drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h b/drivers/= gpu/drm/imagination/pvr_rogue_fwif_shared.h index 6c09c15bf9bd..f622553cdc11 100644 --- a/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h +++ b/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h @@ -236,6 +236,18 @@ enum rogue_context_reset_reason { ROGUE_CONTEXT_RESET_REASON_INNOCENT_OVERRUNING =3D 4, /* Forced reset to ensure scheduling requirements */ ROGUE_CONTEXT_RESET_REASON_HARD_CONTEXT_SWITCH =3D 5, + /* CDM Mission/safety checksum mismatch */ + ROGUE_CONTEXT_RESET_REASON_WGP_CHECKSUM =3D 6, + /* TRP checksum mismatch */ + ROGUE_CONTEXT_RESET_REASON_TRP_CHECKSUM =3D 7, + /* GPU ECC error (corrected, OK) */ + ROGUE_CONTEXT_RESET_REASON_GPU_ECC_OK =3D 8, + /* GPU ECC error (uncorrected, HWR) */ + ROGUE_CONTEXT_RESET_REASON_GPU_ECC_HWR =3D 9, + /* FW ECC error (corrected, OK) */ + ROGUE_CONTEXT_RESET_REASON_FW_ECC_OK =3D 10, + /* FW ECC error (uncorrected, ERR) */ + ROGUE_CONTEXT_RESET_REASON_FW_ECC_ERR =3D 11, /* FW Safety watchdog triggered */ ROGUE_CONTEXT_RESET_REASON_FW_WATCHDOG =3D 12, /* FW page fault (no HWR) */ --=20 2.43.0 From nobody Tue Apr 7 16:16:38 2026 Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A0D13AE6ED for ; Thu, 12 Mar 2026 11:41:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.86 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773315699; cv=none; b=Otygw9DDba3I3/nferKC22pQ2TZD12GZML66YuPEUr0lL8uPLINNRF+77ZrpbwoWTrVeGsKglAizR4J+jjtZU3Gle/JEIWjcKBK7L7bV9sY81ehxSEas8zS1k7WhSLNrOI/jm/oeVtViUrfNBxqj3xCk51/AdRJM486uLHUrGAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773315699; c=relaxed/simple; bh=GEhtv8jPF6IZFz2Yv8qIUQ036AidYPCRjdm2hvybvEY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=fgBshUcLbsWq+um9wlOXQVDYmEjMZt8SXs1T+A04J00zec6NmuIS6NUb6zv6COaOOWrg14vz65xQB9SWeBz2MzRBODU1jKNBw4COcsKJoRRo79UyHL2eaeN/UauCF0eJgCF0Awc5CeSdEsFLk95VVkHUshKbUNcyDnCpNRE8p6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=LSsIXVke; arc=none smtp.client-ip=91.207.212.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="LSsIXVke" Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C6DfHu3792160; Thu, 12 Mar 2026 11:41:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=4 WMYA4KVqA3O8lxjZCn1coG6Ben4j1tWFldvlrq6psc=; b=LSsIXVke5+gWQ92bZ P9Rhc+U+wIJciIxLS3hRBrjWI3lmbaQ9geP70Wu+m76DMhiVTJAC3l/OfvhXPhDm zCoXyvo6dS2lf/xcncDnhZLZRi975sooDlwYcdiohPzknStF1NqVo4/8PnJaawe+ gcARxTVPU0QVhMSHk0s+JMh47lvTQnVttEmgS1T+e882DLIku/LbSGouU5pO72WH MHR5aXB8f+faH+GfVGtLFUiLXdjfwnRS/aGrWgT+atW36FN7mCbWotw+vv9cPiDt T6lDWt+MKVQSfmLucCKWVi7RjVssBpFT2MreLDi+uDPdC1XaORJzYiSoeQ8Fxn1K saXVQ== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4ctxvy1c16-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2026 11:41:15 +0000 (GMT) Received: from [127.0.1.1] (172.25.10.37) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 12 Mar 2026 11:41:14 +0000 From: Alexandru Dadu Date: Thu, 12 Mar 2026 13:40:54 +0200 Subject: [PATCH v2 2/3] drm/imagination: Switch reset_reason fields from enum to u32 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260312-b4-firmware-context-reset-notification-handling-v2-2-aec5a64cb06f@imgtec.com> References: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> In-Reply-To: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> To: Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , "Alessio Belle" , Brajesh Gupta , Alexandru Dadu X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773315672; l=1898; i=alexandru.dadu@imgtec.com; s=20260304; h=from:subject:message-id; bh=GEhtv8jPF6IZFz2Yv8qIUQ036AidYPCRjdm2hvybvEY=; b=hhzHF365gbZIAueIMtD95L0c7L7DJSghhRWLWcmiSjNi1NxLURopGN+5ylyDxrZK4K452cVwt EUNPHRvEDM0CeUVuUPkBaQAxLqv+ns/JPUeJP/OoqMR2zqQEgc02w3V X-Developer-Key: i=alexandru.dadu@imgtec.com; a=ed25519; pk=FU07SyNrYGwhahqSxbWEuzyXlUh47xBXvLvOR7UA6+U= X-Proofpoint-GUID: Il79FvllxOV95FuEur7wzu5VBqBm9TyP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDA5MiBTYWx0ZWRfX2uBFfyRH+Heb ZXqyPpomhq8NMCKykj2qk9K1k1mC3JTZfnXhe0VHrIeAXp+tpQEe1uiIEefK4mEqAbTdgsaXB31 Tm3/eVPCPT/nWNEVm33CzboIagszM1AncDc6scm1tyXgjBj3s4XFVT2rclBmAGsuQavVoQVFN/a FZA73cVKdRACm98iqTgPL8+p4bTw8OOEXI3vDPlvKEObC8gAZoWZ59kfWUWO9mtQXjlnNFsvKrB ALGaCG5wmHmsl4dAScFn/KMWIx+Lm/gNKeBeJ8R8JKB/zGlVQgWFUK9g2OgtHC8DHQ3n+3IZAi9 gVf5Sp5ZYnb20sH7i73jh+LPAqdmTtwXxMGvzRBTdYaSwMb/bQ7JkU40t6z4Ihme7hcmUQ0c+NQ /uBXAVTiyhevkzBnBrvY1zHdN/9SAiOKIW1cdsGNA2qOoPCnAsRfSh38JHLTjR14PB0m+zxEg5s 8TyJWKXMFSOZcAg+OZQ== X-Authority-Analysis: v=2.4 cv=NuzcssdJ c=1 sm=1 tr=0 ts=69b2a65b cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=7IANbbwssFwA:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=qZQ2PDNLMSdLoqI-hfl9:22 a=r_1tXGB3AAAA:8 a=1QHZ_anrujvv2WxOvQkA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-ORIG-GUID: Il79FvllxOV95FuEur7wzu5VBqBm9TyP Update the reset_reason fwif structure fields from enum to u32 to remove any ambiguity from the interface (enum is not a fixed size thus is unfit for the purpose of the data type). Fixes: a26f067feac1f ("drm/imagination: Add FWIF headers") Signed-off-by: Alexandru Dadu --- drivers/gpu/drm/imagination/pvr_rogue_fwif.h | 8 ++++++-- drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h | 6 +++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_rogue_fwif.h b/drivers/gpu/drm= /imagination/pvr_rogue_fwif.h index 172886be4c82..5d590c4c2566 100644 --- a/drivers/gpu/drm/imagination/pvr_rogue_fwif.h +++ b/drivers/gpu/drm/imagination/pvr_rogue_fwif.h @@ -1347,8 +1347,12 @@ struct rogue_fwif_fwccb_cmd_freelists_reconstruction= _data { struct rogue_fwif_fwccb_cmd_context_reset_data { /* Context affected by the reset */ u32 server_common_context_id; - /* Reason for reset */ - enum rogue_context_reset_reason reset_reason; + /* + * Reason for reset + * The valid values for reset_reason are the ones from + * enum rogue_context_reset_reason + */ + u32 reset_reason; /* Data Master affected by the reset */ u32 dm; /* Job ref running at the time of reset */ diff --git a/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h b/drivers/= gpu/drm/imagination/pvr_rogue_fwif_shared.h index f622553cdc11..869d904e3649 100644 --- a/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h +++ b/drivers/gpu/drm/imagination/pvr_rogue_fwif_shared.h @@ -261,7 +261,11 @@ enum rogue_context_reset_reason { }; =20 struct rogue_context_reset_reason_data { - enum rogue_context_reset_reason reset_reason; + /* + * The valid values for reset_reason are the ones from + * enum rogue_context_reset_reason + */ + u32 reset_reason; u32 reset_ext_job_ref; }; =20 --=20 2.43.0 From nobody Tue Apr 7 16:16:38 2026 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B6AB3B6C04 for ; Thu, 12 Mar 2026 11:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773315691; cv=none; b=bKX/gtCQJeB5vE93ZXCfUASLV2wRsWYD2RzSw2xlAcSTk7NhR49eQB5PpyT3g7oXG3EsKf0AWvk/K6KH+Z0P1LvikIBd0tm/uv7Mq6MA5GFGRhlcChCPDm7KXHcGGoef+oC032QGpsy7DoieUXfhULbK13eWxfe098LItatxjuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773315691; c=relaxed/simple; bh=NUkPOE62tQDngv6++5PK77LscQsM3GAUk4T9SkUMLlg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=AQghtsReYKKjClp0TZwm7mHqjeomTVHB3kbSQsopMWR+HjOI7stbsz5NqjrjeWkuhPfOtHI8Gzd77jtRh4OnFFQ8w3WEdpnqx2PLkhFMBCAILTSvwQmFatlokDN5HUnIe0i3LOLzz/NcVZpQw0fbQ5/n67OTg8Hz42gfdqrOkE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=OPDi/Avg; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="OPDi/Avg" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62C5iMTe3935955; Thu, 12 Mar 2026 11:41:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=y olkeaz3VGLMVGezxGWPaLcQC3PibB5bexw8q6oL2/Q=; b=OPDi/Avg3BO44FV2N iV9LvyiL7qbknFClsS0+mYaC3bPSZa1YT0afzIfxorfTPtm9el7swfQwEQu5+kWN f9gR5/e/Lx+W1wwblBg8lzHo9s+z9T+OcFp9ekPMMkmqEcUUtb+f/8ut1AyjpgeU NSlTkolu2kVjMeDfwCsWP/Y9jtwWYod/3cw/7XWIny3NET1qaguI5qTzOQb4/J2r UStwiVQnfC7Q+pJIbbJ4TTaO7h2ST6ZTp3i933K399lB3eMlw6UVrxhXroVQxvhW HEk+lTa0rJq+xvhYvWmvP676g7g3Eye+JQ5LiObAIgtorvxjpQPJJYiuy9QCCXpg TqYzw== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4ctxyghfsd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2026 11:41:16 +0000 (GMT) Received: from [127.0.1.1] (172.25.10.37) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 12 Mar 2026 11:41:15 +0000 From: Alexandru Dadu Date: Thu, 12 Mar 2026 13:40:55 +0200 Subject: [PATCH v2 3/3] drm/imagination: Implement handling of context reset notification Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260312-b4-firmware-context-reset-notification-handling-v2-3-aec5a64cb06f@imgtec.com> References: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> In-Reply-To: <20260312-b4-firmware-context-reset-notification-handling-v2-0-aec5a64cb06f@imgtec.com> To: Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: , , "Alessio Belle" , Brajesh Gupta , Alexandru Dadu , Sarah Walker X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773315672; l=6596; i=alexandru.dadu@imgtec.com; s=20260304; h=from:subject:message-id; bh=NUkPOE62tQDngv6++5PK77LscQsM3GAUk4T9SkUMLlg=; b=SqmGeN6V/kFXSCEw1SVSrMErvvRE3bDFAfPK5j5TXhmcGk7p6ntvDY19ZlVPR0ScKoknGrJFu ZSaM9cv0ag9A8QSnUJGJGIGNYKwPR441OJtnbe9cpZ+rbVA8yrU5paK X-Developer-Key: i=alexandru.dadu@imgtec.com; a=ed25519; pk=FU07SyNrYGwhahqSxbWEuzyXlUh47xBXvLvOR7UA6+U= X-Proofpoint-ORIG-GUID: 4t9pZv8du5ZpyDWTXUDxrzWJYx8721pp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDA5MiBTYWx0ZWRfXzzCJ4I2ZJiEa kgZ/xin497nVGCpnPN+nleH4bl6mQMsxdCdYvLUlT/3p9LWnjbQhgOFYt8lTSNqe0AzgJJCL1XF EfNr4SRWS9ZF8AW+OSoD359tBMlnwVsDvkgnOXX4K6KPH4qQ0jWR2jhiFm6HeB9QbMIuFXdPW4f YK+A5QjSFhXKOhzHl6YHIjzepOWVihiCobINAZCYWVG/PdpH8GVvxCeTU2++Rw/jqVfed/bQG/y PWZuJ7H0EwyAkmlPEilFvD3wTWCmtJvwoaRSmnSgqz+bNOGIqTk2uXn+bMvF+C4uDHVbuWXuxiC hN9aZS3c2JHriKgTFo2AhMu5BkkqwPkpyMXBIhf140o4bS4u/ea6LhgnBhAyUKWWLoquc/cv6Y8 68Km6RXGELrfpr/lPJI7HccKgld1iSz6vHCvwYN9FqB5lo/YwpqYVkqFGmWhBgYUJ14EaQCZoFC 2rz1fkLbGCNSLZI768g== X-Proofpoint-GUID: 4t9pZv8du5ZpyDWTXUDxrzWJYx8721pp X-Authority-Analysis: v=2.4 cv=NevrFmD4 c=1 sm=1 tr=0 ts=69b2a65c cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=7IANbbwssFwA:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=7RYWX5rxfSByPNLylY2M:22 a=r_1tXGB3AAAA:8 a=eoAnicgNG9KoMJQc0cgA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 The firmware will send the context reset notification message as part of handling hardware recovery (HWR) events deecoding the message and printing via drm_info(). This eliminates the "Unknown FWCCB command" message that was previously printed. Co-authored-by: Sarah Walker Signed-off-by: Alexandru Dadu --- drivers/gpu/drm/imagination/Makefile | 1 + drivers/gpu/drm/imagination/pvr_ccb.c | 5 ++ drivers/gpu/drm/imagination/pvr_dump.c | 113 +++++++++++++++++++++++++++++= ++++ drivers/gpu/drm/imagination/pvr_dump.h | 17 +++++ 4 files changed, 136 insertions(+) diff --git a/drivers/gpu/drm/imagination/Makefile b/drivers/gpu/drm/imagina= tion/Makefile index f5072f06b4c4..1222a14262e4 100644 --- a/drivers/gpu/drm/imagination/Makefile +++ b/drivers/gpu/drm/imagination/Makefile @@ -8,6 +8,7 @@ powervr-y :=3D \ pvr_device.o \ pvr_device_info.o \ pvr_drv.o \ + pvr_dump.o \ pvr_free_list.o \ pvr_fw.o \ pvr_fw_meta.o \ diff --git a/drivers/gpu/drm/imagination/pvr_ccb.c b/drivers/gpu/drm/imagin= ation/pvr_ccb.c index f89db5e3baa2..a04520e7efc0 100644 --- a/drivers/gpu/drm/imagination/pvr_ccb.c +++ b/drivers/gpu/drm/imagination/pvr_ccb.c @@ -4,6 +4,7 @@ #include "pvr_ccb.h" #include "pvr_device.h" #include "pvr_drv.h" +#include "pvr_dump.h" #include "pvr_free_list.h" #include "pvr_fw.h" #include "pvr_gem.h" @@ -165,6 +166,10 @@ process_fwccb_command(struct pvr_device *pvr_dev, stru= ct rogue_fwif_fwccb_cmd *c * suppress the "unknown" warning when receiving this command. */ break; + case ROGUE_FWIF_FWCCB_CMD_CONTEXT_RESET_NOTIFICATION: + pvr_dump_context_reset_notification(pvr_dev, + &cmd->cmd_data.cmd_context_reset_notification); + break; =20 default: drm_info(drm_dev, "Received unknown FWCCB command (type=3D%d)\n", diff --git a/drivers/gpu/drm/imagination/pvr_dump.c b/drivers/gpu/drm/imagi= nation/pvr_dump.c new file mode 100644 index 000000000000..bb52eea8b63a --- /dev/null +++ b/drivers/gpu/drm/imagination/pvr_dump.c @@ -0,0 +1,113 @@ +// SPDX-License-Identifier: GPL-2.0 OR MIT +/* Copyright (c) 2026 Imagination Technologies Ltd. */ + +#include "pvr_device.h" +#include "pvr_dump.h" +#include "pvr_rogue_fwif.h" + +#include +#include + +static const char * +get_reset_reason_desc(enum rogue_context_reset_reason reason) +{ + switch (reason) { + case ROGUE_CONTEXT_RESET_REASON_NONE: + return "None"; + case ROGUE_CONTEXT_RESET_REASON_GUILTY_LOCKUP: + return "Guilty lockup"; + case ROGUE_CONTEXT_RESET_REASON_INNOCENT_LOCKUP: + return "Innocent lockup"; + case ROGUE_CONTEXT_RESET_REASON_GUILTY_OVERRUNING: + return "Guilty overrunning"; + case ROGUE_CONTEXT_RESET_REASON_INNOCENT_OVERRUNING: + return "Innocent overrunning"; + case ROGUE_CONTEXT_RESET_REASON_HARD_CONTEXT_SWITCH: + return "Hard context switch"; + case ROGUE_CONTEXT_RESET_REASON_WGP_CHECKSUM: + return "CDM Mission/safety checksum mismatch"; + case ROGUE_CONTEXT_RESET_REASON_TRP_CHECKSUM: + return "TRP checksum mismatch"; + case ROGUE_CONTEXT_RESET_REASON_GPU_ECC_OK: + return "GPU ECC error (corrected, OK)"; + case ROGUE_CONTEXT_RESET_REASON_GPU_ECC_HWR: + return "GPU ECC error (uncorrected, HWR)"; + case ROGUE_CONTEXT_RESET_REASON_FW_ECC_OK: + return "Firmware ECC error (corrected, OK)"; + case ROGUE_CONTEXT_RESET_REASON_FW_ECC_ERR: + return "Firmware ECC error (uncorrected, ERR)"; + case ROGUE_CONTEXT_RESET_REASON_FW_WATCHDOG: + return "Firmware watchdog"; + case ROGUE_CONTEXT_RESET_REASON_FW_PAGEFAULT: + return "Firmware pagefault"; + case ROGUE_CONTEXT_RESET_REASON_FW_EXEC_ERR: + return "Firmware execution error"; + case ROGUE_CONTEXT_RESET_REASON_HOST_WDG_FW_ERR: + return "Host watchdog"; + case ROGUE_CONTEXT_GEOM_OOM_DISABLED: + return "Geometry OOM disabled"; + + default: + return "Unknown"; + } +} + +static const char * +get_dm_name(u32 dm) +{ + switch (dm) { + case PVR_FWIF_DM_GP: + return "General purpose"; + /* PVR_FWIF_DM_TDM has the same index, but is discriminated by a device f= eature */ + case PVR_FWIF_DM_2D: + return "2D or TDM"; + case PVR_FWIF_DM_GEOM: + return "Geometry"; + case PVR_FWIF_DM_FRAG: + return "Fragment"; + case PVR_FWIF_DM_CDM: + return "Compute"; + case PVR_FWIF_DM_RAY: + return "Raytracing"; + case PVR_FWIF_DM_GEOM2: + return "Geometry 2"; + case PVR_FWIF_DM_GEOM3: + return "Geometry 3"; + case PVR_FWIF_DM_GEOM4: + return "Geometry 4"; + + default: + return "Unknown"; + } +} + +/** + * pvr_dump_context_reset_notification() - Handle context reset notificati= on from FW + * @pvr_dev: Device pointer. + * @data: Data provided by FW. + * + * This will decode the data structure provided by FW and print the result= s via drm_info(). + */ +void +pvr_dump_context_reset_notification(struct pvr_device *pvr_dev, + struct rogue_fwif_fwccb_cmd_context_reset_data *data) +{ + struct drm_device *drm_dev =3D from_pvr_device(pvr_dev); + + if (data->flags & ROGUE_FWIF_FWCCB_CMD_CONTEXT_RESET_FLAG_ALL_CTXS) { + drm_info(drm_dev, "Received context reset notification for all contexts\= n"); + } else { + drm_info(drm_dev, "Received context reset notification on context %u\n", + data->server_common_context_id); + } + + drm_info(drm_dev, " Reset reason=3D%u (%s)\n", data->reset_reason, + get_reset_reason_desc((enum rogue_context_reset_reason)data->reset_reas= on)); + drm_info(drm_dev, " Data Master=3D%u (%s)\n", data->dm, get_dm_name(data= ->dm)); + drm_info(drm_dev, " Job ref=3D%u\n", data->reset_job_ref); + + if (data->flags & ROGUE_FWIF_FWCCB_CMD_CONTEXT_RESET_FLAG_PF) { + drm_info(drm_dev, " Page fault occurred, fault address=3D%llx\n", + data->fault_address); + } +} diff --git a/drivers/gpu/drm/imagination/pvr_dump.h b/drivers/gpu/drm/imagi= nation/pvr_dump.h new file mode 100644 index 000000000000..1e3e68694f5f --- /dev/null +++ b/drivers/gpu/drm/imagination/pvr_dump.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0 OR MIT */ +/* Copyright (c) 2026 Imagination Technologies Ltd. */ + +#ifndef PVR_DUMP_H +#define PVR_DUMP_H + +/* Forward declaration from pvr_device.h. */ +struct pvr_device; + +/* Forward declaration from pvr_rogue_fwif.h. */ +struct rogue_fwif_fwccb_cmd_context_reset_data; + +void +pvr_dump_context_reset_notification(struct pvr_device *pvr_dev, + struct rogue_fwif_fwccb_cmd_context_reset_data *data); + +#endif /* PVR_DUMP_H */ --=20 2.43.0