From nobody Tue Apr 7 16:16:22 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EB183FB06D for ; Thu, 12 Mar 2026 16:38:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773333530; cv=none; b=BWmzHfTa+rZspy9g1+LgmJfvcPj8XNLquCIt/MEUaaQkzg2+SKNQs9iCmB8vj/Z4JUh/rRyLEuNovTgHfqkeB8CoPhsFKrAftddpIeqMOuQHMIGG8H+zGW0Rj9fdpa6zet/Wnrukpfg9a3JsunkpSQy0t2XQWo+DJZKA4IX836Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773333530; c=relaxed/simple; bh=qEFyTt1s5nJZMUCvr3Lag+e/OgjP4gX0IckUJ4wTtR0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=mjQUUN5etvQgt2kfrVy0BZDq6+G4Xiv1pzl4SaGm/5aP/h+dpp7Y/gHw7K160Y7xQsF2J3yydn0gINLUiMzXME8YImhMGiK4NBCCGYFW1KJQirWjHArmWqTvooUtlrV6qyNWK9LFz5XTaBEhgthtc12BnyudadHrD1km93FG4oY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=qmnzVjtF; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="qmnzVjtF" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62CGUQNm3650902; Thu, 12 Mar 2026 12:38:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=9BAzV jlyOIht2AO3dGsg7xUVnZURb2lN/HKsxfjg3cY=; b=qmnzVjtFVkD50KLt61K+i OT+PwzaXlL4LhXDftUlNhcx/PekpvnUPCXMo3afUt2qWYvCmwOnbQllrjyzUgy20 Pgywg3Z+34y7HJ8s/zWPJvshVNP34322dG9duzk3LhAxbMQQk/EBcADHrEHekAKL XdlR5c//vOW3RZY9MqhM/i2ofP1z45mfK4UX3NONQ2ZTKNOPTPFE5QWmvdcjjPjx ayLrARDKFMD+lGzkmsJwaa08YgMrh405TQ8aVeO3gA1QEYt8Nzi4e9eLFvjBGX4W Mcrpq50ZCoQNbsSeyOjjKZeOWtTpAYTqhw4ZXIBR8GSD2kXBm775/LHNQZpzStSj A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4cuh6bbhtp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2026 12:38:29 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62CGcSGf009200 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 Mar 2026 12:38:28 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Thu, 12 Mar 2026 12:38:27 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Thu, 12 Mar 2026 12:38:27 -0400 Received: from HYB-DlYm71t3hSl.ad.analog.com (HYB-DlYm71t3hSl.ad.analog.com [10.44.3.82] (may be forged)) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62CGc8Gc021063; Thu, 12 Mar 2026 12:38:22 -0400 From: Jorge Marques Date: Thu, 12 Mar 2026 17:38:08 +0100 Subject: [PATCH v2 5/5] i3c: master: adi: Fix error propagation for CCCs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260312-ad4062-positive-error-fix-v2-5-1c933b5c7ed8@analog.com> References: <20260312-ad4062-positive-error-fix-v2-0-1c933b5c7ed8@analog.com> In-Reply-To: <20260312-ad4062-positive-error-fix-v2-0-1c933b5c7ed8@analog.com> To: Alexandre Belloni , Frank Li , =?utf-8?q?Przemys=C5=82aw_Gaj?= CC: , , Dan Carpenter , Jonathan Cameron , Jorge Marques X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773333488; l=1096; i=jorge.marques@analog.com; s=20250303; h=from:subject:message-id; bh=qEFyTt1s5nJZMUCvr3Lag+e/OgjP4gX0IckUJ4wTtR0=; b=8+oDOltklseTgRmNd/iTQ53Wp/iKwe9BINooYOg0NAIhPyPOk6Yc1SsReo+npBL/E5cdTTzp6 58jyMJFml4rDzHXwnDQgvXPRdwBtDYHgoFCm0Jpldsyzp0uToQ2UD73 X-Developer-Key: i=jorge.marques@analog.com; a=ed25519; pk=NUR1IZZMH0Da3QbJ2tBSznSPVfRpuoWdhBzKGSpAdbg= X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: upVA2Nl15sm7Dr9DFm547bemW83Ul9GC X-Authority-Analysis: v=2.4 cv=c6amgB9l c=1 sm=1 tr=0 ts=69b2ec05 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=xdR8xYJEzGsg0H7vZJUA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: upVA2Nl15sm7Dr9DFm547bemW83Ul9GC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEyMDEzNCBTYWx0ZWRfX96NXpV8U8M/6 F+eWJT+Q7TdH4KNghUmWdNq9WXdVh03WkfY7o6h8moQYHkp9Nz5aT0Rh2/r3W1IiTIIIeCoOpQX DelQtl01ciaIgmP+x/Zdc6E5v/Iw4zQE9AzeUU867rveeXRRMOWJIkuu2gyBMpsDpsWWM12Es8V 1bmaCHGYg1IUXwl9BML57V7WMDxi3zZsSCCfiExav+WubX+FJXex2yKCVMeb6M4HhppiL52VoqC 4oMz91cTiKPrME2QIt7ihYBBNki8kcGKW/vTM5GrvlkuumUWWUyR5IVmGdWUwC7bZfpn1anHhyd b6bk6DQjeZCs/PUiOnB1e6V5Y+LaCxNwzIIpU4a/giOBBNnlL0O+m6yukSrpMb2DfSlC/eIma9B 9FhdH1sSi7OMRT0kGumt+fjnFR3wiCRykPUqs62Cq3PR/p2zsuX0hw796wOtdHlxkmjUn1fiUfo fayRfZ1HDLWxPyguMKw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-12_02,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603120134 adi_i3c_master_send_ccc_cmd() always returned 0, ignoring the transfer result populated in the completion path. As a consequence, CCC command errors were silently dropped, including the default -ETIMEDOUT and later overwritten by adi_i3c_master_end_xfer_locked(). Fix this by returning xfer->ret so that callers correctly receive any transfer error codes. Fixes: a79ac2cdc91d ("i3c: master: Add driver for Analog Devices I3C Contro= ller IP") Signed-off-by: Jorge Marques Reviewed-by: Adrian Hunter Reviewed-by: Frank Li --- drivers/i3c/master/adi-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/adi-i3c-master.c b/drivers/i3c/master/adi-i= 3c-master.c index fb9a488304469..047081c9f0643 100644 --- a/drivers/i3c/master/adi-i3c-master.c +++ b/drivers/i3c/master/adi-i3c-master.c @@ -361,7 +361,7 @@ static int adi_i3c_master_send_ccc_cmd(struct i3c_maste= r_controller *m, =20 cmd->err =3D adi_i3c_cmd_get_err(&xfer->cmds[0]); =20 - return 0; + return xfer->ret; } =20 static int adi_i3c_master_i3c_xfers(struct i3c_dev_desc *dev, --=20 2.51.1