From nobody Tue Apr 7 19:49:31 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 401673A4F35 for ; Wed, 11 Mar 2026 23:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773271264; cv=none; b=qUZHk6KgExAe/ZC1dbND4p1rVR59RxHCDC8zSJXcwuXadmB1vCGCl5hCMxrNriAegY87vzUUl9np+2pq5BcVp/2BfgvmHQHNitE/ppecj5idM5lrzEXRZUnH5mZ574XxOh+qTJazMRLq1OMMTTeJFRDjp7zIhRSI67mg7iWejJc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773271264; c=relaxed/simple; bh=Tw+2EyKUb9agQ6zKe0hRUqwC5xleuQDNBz4yJ156L+I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DduQrIs+v7drWorQkDdAVCCY3LueD1boUnFYD1TrEbnOJnZa8QzXj+m3e8FEW+82Ups+9qGPMcTaArjynUYgwyrg0iJxirG2eJPT/BWVDurrYPXSBE8/0xza8NKJBNczmCzynwQMVdz30xlysjuWkXDqHceuKpPuql4UN9PYdRA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HU46iou7; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HU46iou7" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-359fea895b5so213207a91.0 for ; Wed, 11 Mar 2026 16:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773271261; x=1773876061; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DkMgiVq7K2oqvd5LIg0pWuilh6oqSCCM4UC7aP9hpy0=; b=HU46iou7qqulew9Q1YNo/BcYfAGpODphqmgtC5t/K0mmMKgTjEJoGpWpt0v6t9Nxy4 TtuBwT4Mkkp1MNoEL+JiKgMaOL/tL94B/G1NIAPxw1xeFfFul2XJCmki2RlCR9qYbxqn 51kP1Qig+NqiJ17E2eqe7x9xarT1WF2FALLVepJN80zAi+vDA0NVkB42T8HdNX+gId0+ enmI/LVl50M1T7wY/fozGxGq8a2/0NPBEFIcRAu9f9cmWRnUUvymtAloy6hPkUT9b3eV avYiw2b/Ezbpl0h2W9S32WbBKJDJWQ/qotJzFqn5QpH13pRrPFxUNQVchToGvCg9jEDU 8oHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773271261; x=1773876061; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DkMgiVq7K2oqvd5LIg0pWuilh6oqSCCM4UC7aP9hpy0=; b=JhvvxpRRjRM9HvoFvcXKT3/0AawJ5rE8JlgJvad7hGSrPIh4SGs5MnF8v2erOrVVri SjULToOwtFU237lWm8nYvP1De73Qym+8tg2zeYr2+dddzLRacJsZc1og1YLAJDq+rjYK 9+W2WgTndqEKqNBHZuP3GuiIo5d2VNBKxi6CI2lYRuepllHUNlhpDOSX3GNZKavB6DWz CNEvFbpC7dV+0rC3gwiXOAE/rLMScIMQ5dMoVSDyjXudBvRmqRm5bQLMuRgJW4FC7Vlk j2W1GeF3b/H8FCt4AiPJ6FRcoUi7Hth7eadlQeu8Zk+JE97NiT7M9zmZ8RkM/vvS2ENF CIsQ== X-Forwarded-Encrypted: i=1; AJvYcCXBX6MU83OpK0Gq8gL3bDupJfbtjtR7gmL7ZDHsqs00YtRBatFeHrgemHK7TiWi4sA19V0kcqkpCfK5KT0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8rwgt7KioFtNWdesrn6FpSF0rslZlhNktmtDmvK4ODqGyWcSI aG1R+7aOfumGZkvBSzUsF/9bJLjkdB88WCL1Hx31I+s3Yv5yXbqzx48d X-Gm-Gg: ATEYQzwjQCXTLP2uhvEkbIElFm7tx/54W2Nt4L93tZIUktJrKxtx1ifjh9CVhRF6/ab Vm27e8FR2X/ayOtYB242MEXNMo5gex9Aad+R4RtaeyZNFVv46N2aKbv+8Pml4ODYV+2NHjXgRyl MIjNjAm1NyGeK8OycaBFGmz1S/oNcaRawbHDJ/53Y/SN8MYJxEJjMcHX0Yz9Ivv3unKiY1vmyGm Fd4TR6brmjkp1OmxyFyD+Ch54PLRo3CzsCcqmOM/qEr+FMk8Mr9xuGuqYuXI63Dv1LO2/qq3Tqm EE0pdALSDRK1zMCRFwX9L4t/ao5TEmQ3vPv48Yg/FXwbtniLdOHDztNsIdGlaQGCeto0H8Qq9fD 3W+3pauEl42nWhpnsQ/nlFsRIen97GYJRyOY4vq7PRXAv2sNSSIeIOQCBBxS6w8RHtIXz/BUmeS X38eqUmQj6sxtDBJRjdBTl8i21aSHmscvd7eZ7n1GR6ZAQoTYfxZ9yL6WeRNFIQN9na8+GAkXbM j4+IhOyPFUvFZA2hdTuP2yynfWyNFMaKPjY X-Received: by 2002:a17:902:f651:b0:2aa:e6fa:2f6c with SMTP id d9443c01a7336-2aeae7d8961mr41552345ad.24.1773271261277; Wed, 11 Mar 2026 16:21:01 -0700 (PDT) Received: from ryzen (c-76-21-102-177.hsd1.ca.comcast.net. [76.21.102.177]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae261082sm46883805ad.41.2026.03.11.16.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 16:21:00 -0700 (PDT) From: Rosen Penev To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman , Kees Cook , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org (open list), linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not covered by other areas):Keyword:\b__counted_by(_le|_be)?\b) Subject: [PATCH] usb: renesas_usbhs: use kzalloc_flex Date: Wed, 11 Mar 2026 16:20:43 -0700 Message-ID: <20260311232043.18025-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removes one allocation and one free by using a flexible array member. Also added __counted_by for extra runtime analysis. Signed-off-by: Rosen Penev --- drivers/usb/renesas_usbhs/mod_gadget.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_u= sbhs/mod_gadget.c index 1539e8e6901d..0c7fe109d5c7 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -40,7 +40,6 @@ struct usbhsg_gpriv { struct usb_gadget gadget; struct usbhs_mod mod; =20 - struct usbhsg_uep *uep; int uep_size; =20 struct usb_gadget_driver *driver; @@ -53,6 +52,7 @@ struct usbhsg_gpriv { #define USBHSG_STATUS_WEDGE (1 << 2) #define USBHSG_STATUS_SELF_POWERED (1 << 3) #define USBHSG_STATUS_SOFT_CONNECT (1 << 4) + struct usbhsg_uep uep[] __counted_by(uep_size); }; =20 struct usbhsg_recip_handle { @@ -1084,15 +1084,11 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) int i; int ret; =20 - gpriv =3D kzalloc_obj(struct usbhsg_gpriv); + gpriv =3D kzalloc_flex(*gpriv, uep, pipe_size); if (!gpriv) return -ENOMEM; =20 - uep =3D kzalloc_objs(struct usbhsg_uep, pipe_size); - if (!uep) { - ret =3D -ENOMEM; - goto usbhs_mod_gadget_probe_err_gpriv; - } + gpriv->uep_size =3D pipe_size; =20 gpriv->transceiver =3D devm_usb_get_phy(dev, USB_PHY_TYPE_UNDEFINED); dev_info(dev, "%stransceiver found\n", @@ -1115,8 +1111,6 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) gpriv->mod.name =3D "gadget"; gpriv->mod.start =3D usbhsg_start; gpriv->mod.stop =3D usbhsg_stop; - gpriv->uep =3D uep; - gpriv->uep_size =3D pipe_size; usbhsg_status_init(gpriv); =20 /* @@ -1175,9 +1169,6 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) return 0; =20 err_add_udc: - kfree(gpriv->uep); - -usbhs_mod_gadget_probe_err_gpriv: kfree(gpriv); =20 return ret; @@ -1189,6 +1180,5 @@ void usbhs_mod_gadget_remove(struct usbhs_priv *priv) =20 usb_del_gadget_udc(&gpriv->gadget); =20 - kfree(gpriv->uep); kfree(gpriv); } --=20 2.53.0