From nobody Tue Apr 7 19:49:31 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8BCC358378 for ; Wed, 11 Mar 2026 23:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773271145; cv=none; b=oE5TUwciNG7MoyvTmplEsHdgU4U0ZhHqdcNKXE6771X98LqLHYyS6wH4xTCEE13qwUMO/4qDfn3SqnsT8MrhRWy8FzG3T4eH05n2Qt8OrY38PjghbKMtj81Ke6MPMCNbf5/xnOfLmEdmuLDRzYfXTOop8mF7dT+y9LvyFfKMBaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773271145; c=relaxed/simple; bh=O6jBhetHYK3YjI5od6XbzRv137I+sjU3j7bdXLcMVIk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bGyglzVxhhSuTZsBKeOhO3K6Rghwxodr9hWS4UDkNLvySQ7/7/UHdkvHuADUaE7/jNKmBSdudACc0jL1i6go4nKk+MklEjEu7SDZdhClW6USh84EElHSTXfWfPoWdzTt0Ei1DTTWfUN5uRKxmcBQMfJPQuHylkq3hn6xoQZVVR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KnCxiJqX; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KnCxiJqX" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ad21f437eeso3791195ad.0 for ; Wed, 11 Mar 2026 16:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773271142; x=1773875942; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nGQa5TPg+fy6f75658KrdxaLTfVS/9M1At/7AR8OAo8=; b=KnCxiJqXXM1lmVUKn97NqqpXhZdLhCN9uXHz5DTW8sEfQGTmXykuLB6tBB/xnnjag/ KnSYQA0Y5YPXwLLSp8qwQKN1QdI0nkbIHLAo82yUUO5HN0aDTKrjy1rGlVKhIXR/++38 h6vvkA2FwNuqDFp1eMQm2dYzud4ttgv7diRWElfz9ikFEwf3Dfum4aNMuDNv36DPE7Py 8hCfsx73HDkCA8hlhce1xJErqj86xlzWrBqasQqGNrUd0AsxtGgypHtoUYdqlvpQqDJC oSObC9B1lZXrLnFpOf0YtjhC5FXdsPoivT0iyNb4SmoPeXIJekxF7656Le43sQMW9s3T R1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773271142; x=1773875942; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nGQa5TPg+fy6f75658KrdxaLTfVS/9M1At/7AR8OAo8=; b=ZFmx0pVEvzZrq/+D3OP4jl2IDUP7Gy1cALDq68gdZOxzqIcqqLo6+r9L7jMv30kGUj scyQVH9/JWhnUHIaxJRkTwZmNcfXKlWVJOmSlIEgiwA0t7PKUJuGh2aSDxcnRIujkloR KSJ27ekyd75+au4FwBtt+d5y7XqIpT/Ydt7vGWTsyf5JLh4+0NWFfYKtUzRA7y7ANZUB /kGazsD5i0aBGQ2UlDu1TeiMhtaU6wvcu4CE/+bxx8zfqxbW4aNlEJDC6NPOypiQB96n d0zE25UM0Un+IoLXE+31EQsfcIqvGkMG6thrJmGXseyDdssjAlbZaV9A5Uya7rZAGOya CQeA== X-Forwarded-Encrypted: i=1; AJvYcCWGrV6wt3YfqbUue0Zl7ohOn/cgqIc4sjyAO6+Y9+nS3SiplmaTXtiTxhNbxRTPhsIenTY3H/LSdJ49FWA=@vger.kernel.org X-Gm-Message-State: AOJu0YwIzEMpqLNix714yDG6yiIIdWdi+gmn4BNBsM/3CB9mYBNxTtms aCOF1IVcROm2uVpCKhxN4XJ3HFLYwQYkiu9XcYdwLq+fPx5pdfaFv0Y6 X-Gm-Gg: ATEYQzyP+Nfdrj2xgBKgphHhhC7ENzHE0LfZeLsbFK5ALSfBFDnA3ah0/XiQrQFKS2i rULoNQ3S3WCVvPWfmS3rOm4vbt9lP+dh85IjaDpf5krZ+a/WfZxSrxWe3tSLtkZGn2QSTBwVUok 81KqMUGVkUO7JazgsZ74XYwY61Lg7OSIfrmbuVDzi1SayGNi+q8kU4f1cYyx2sOsxiSDe0qyCnK m53dkrwUVdJQ9rOvJUZeqltFTlzfrE6lCgIgesgv5gzVvxjBhQv1Z6CMPzWf4bNA3qauhmqf0Mz 5pqzYR8i6iM77JD9nIoFYA9mr/AtV8tfHxuCm2N6mVMvotlYkMmaYgnAeLH+GwwAGTlPUxVgIgB YKeqdLHMT1M2Yt8aVNKuiWHSLi218ngpt1/O9ez1QequOsoeW8L3EMGCKX5jp1Y5D++CC50xT8J wWZQWhfpoB0gk/XTRilHDTY9VD+GpDVfpP1lDAKkn8K9gs2ybcxV7p5g== X-Received: by 2002:a17:903:32cc:b0:2ad:b213:feba with SMTP id d9443c01a7336-2aeba4416d2mr10894095ad.5.1773271142123; Wed, 11 Mar 2026 16:19:02 -0700 (PDT) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae222e3asm43921815ad.15.2026.03.11.16.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 16:19:01 -0700 (PDT) From: Rosen Penev To: linux-gpio@vger.kernel.org Cc: Lixu Zhang , Sakari Ailus , Linus Walleij , Bartosz Golaszewski , Kees Cook , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org (open list), linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not covered by other areas):Keyword:\b__counted_by(_le|_be)?\b) Subject: [PATCHv3] gpio: ljca: reduce struct allocation Date: Wed, 11 Mar 2026 16:18:44 -0700 Message-ID: <20260311231844.17891-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert connect_mode to a flexible array member to avoid calling kcalloc and to combine the allocations. Add __counted_by for extra runtime analysis. Signed-off-by: Rosen Penev --- v3: make unsigned int to match original. v2: add counting variable drivers/gpio/gpio-ljca.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-ljca.c b/drivers/gpio/gpio-ljca.c index f32d1d237795..93a0fd4ac507 100644 --- a/drivers/gpio/gpio-ljca.c +++ b/drivers/gpio/gpio-ljca.c @@ -63,7 +63,6 @@ struct ljca_gpio_dev { DECLARE_BITMAP(enabled_irqs, LJCA_MAX_GPIO_NUM); DECLARE_BITMAP(reenable_irqs, LJCA_MAX_GPIO_NUM); DECLARE_BITMAP(output_enabled, LJCA_MAX_GPIO_NUM); - u8 *connect_mode; /* protect irq bus */ struct mutex irq_lock; struct work_struct work; @@ -72,6 +71,9 @@ struct ljca_gpio_dev { u8 obuf[LJCA_GPIO_BUF_SIZE]; u8 ibuf[LJCA_GPIO_BUF_SIZE]; + + unsigned int num; + u8 connect_mode[] __counted_by(num); }; static int ljca_gpio_config(struct ljca_gpio_dev *ljca_gpio, u8 gpio_id, @@ -400,22 +402,20 @@ static int ljca_gpio_probe(struct auxiliary_device *a= uxdev, const struct auxiliary_device_id *aux_dev_id) { struct ljca_client *ljca =3D auxiliary_dev_to_ljca_client(auxdev); + struct ljca_gpio_info *gpio_info =3D dev_get_platdata(&auxdev->dev); struct ljca_gpio_dev *ljca_gpio; struct gpio_irq_chip *girq; int ret; - ljca_gpio =3D devm_kzalloc(&auxdev->dev, sizeof(*ljca_gpio), GFP_KERNEL); + ljca_gpio =3D devm_kzalloc(&auxdev->dev, + struct_size(ljca_gpio, connect_mode, gpio_info->num), + GFP_KERNEL); if (!ljca_gpio) return -ENOMEM; + ljca_gpio->num =3D gpio_info->num; ljca_gpio->ljca =3D ljca; - ljca_gpio->gpio_info =3D dev_get_platdata(&auxdev->dev); - ljca_gpio->connect_mode =3D devm_kcalloc(&auxdev->dev, - ljca_gpio->gpio_info->num, - sizeof(*ljca_gpio->connect_mode), - GFP_KERNEL); - if (!ljca_gpio->connect_mode) - return -ENOMEM; + ljca_gpio->gpio_info =3D gpio_info; ret =3D devm_mutex_init(&auxdev->dev, &ljca_gpio->irq_lock); if (ret) -- 2.53.0