From nobody Tue Apr 7 21:26:12 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13EF83C9441 for ; Wed, 11 Mar 2026 19:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257110; cv=none; b=EE6wOqBxYf7hg10bPj4Hwgtb7M3YeOz9Oz0K7M1PQyKJ5+CcGxDCyhaQy57/9KAiQkRGdslmTt7oYKQXPP39gM7SXUEXcURrI5SJiUBa0k503ORGS0w2ByzEHpZR6wnmyIeW7ig2gDgLd3VQgLcBJJzpioJB7xdrS+6KUGbaSuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257110; c=relaxed/simple; bh=3dPZmfuxSa9+StYu9kHGBvda1YP5z0QRhThE+L/eG8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D7Pey85mBiP0qdMgCkHrD5KnNWT+8rYRaZcX27X35vgNikxc8pASvTihWzeMIXpvy9B/VmmRDCiP4x8Kpz8NI0h4RayT1MirEQMvqRA4XYusWW3ddbqwKJNEzta35DFv51Sf1xX10N2Y+daD7hGhNS4V1lw61SiZ3+E2S1sXf9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m978MJcL; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m978MJcL" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439b7a87fb5so167405f8f.3 for ; Wed, 11 Mar 2026 12:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773257107; x=1773861907; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wCEZNOhYzSxA1k0R7KF6Up+P27mNNlK+gHFgw3PPzoA=; b=m978MJcLH4QOyc3gh8jUJsOolLDNCi1GwzUvoJq7+eIdqZxWAeW7yfZCYsgb4s1B7L HhIoBMTN+ZKNkeiofbzd8+FH1UQmPMaq6upy9BquuAPTgTi8lF3HF3pghZwNaFRv+MSJ 71rUst472m6kCj5YIqsdDiXhECYfoMF9KddlbOFM+GuCjoe2ZQ6zL5mu8Wvkdv1v29U3 E0vJW2dC0bwb6tVtZuVjiVggKDrCrUHd8wuiyAmFVBUn3HBos9rRpn3q8bdq6Edo1BYp KnqB1BKEPYFvt3i/MZRU+TXsKVdb/3r4bb+N1ZtLoEGaxDYAvxVwRaTDKl7m4BadSswW amZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773257107; x=1773861907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wCEZNOhYzSxA1k0R7KF6Up+P27mNNlK+gHFgw3PPzoA=; b=ERYVS5azBoy1luWPUGPKpEa1iEA7wgwMHazV70MCa8gb03JQFhpye4u6M3qMMrcey+ fvKtchpfzRx1E8j7O4hbT3+LGaQ/9mQBYiGR0EthHo0hgDcygJmBMbt0Dt/2bl5TV2o2 agtXmg+3kk0oXEIC0mxPhZMJx9B79QCaaQhJhjpBFj5sKWeVxEKzuEJE1pKclo6kC27v 15nd8RoeP4rc/whz9EnBBAuquSf5qTMIfY8kTo5BbqLYm8UiVE7S2YcAxD2S7daJUVED tpE/m6meHJrE58AXKAxYCnF64iDdVLu7s4J9PJhrLyo+FHP8cvOVkXo0a0T+8siCrKCY hoZg== X-Forwarded-Encrypted: i=1; AJvYcCXGUkaVfR9uz4qG6zzxrts+Jl930ozUR7nmuGzo3eF+oKpOho2bGbEDCHRBo+kioTS0NskCBC256pDJHNU=@vger.kernel.org X-Gm-Message-State: AOJu0YxCDvBaD+GpNVVddyyViP+vQ2sl7/a07sfGRoK7CnPj6ygtRwZ2 mOLq/xHdWzLMFoxNENqB65cmwKUHI8mruXiwnQKOesiCzpI3uv2UNM0f X-Gm-Gg: ATEYQzw7sbCpNbRn07S1BP7WmkFOoNE2TgrvhG52XhZ1tVkQnJyhGWLmSxHBrIO4RwV LQg4pdOVNmgOCsEiR88zjJosKWCJkq/ua5pPLOOoByRM4plB+UDuy2Sq+QuZvV3W8WEX7OgqPjp fI0fKlvaLvpFG74MUIzFhPbMSCzn907X6VacsLu7fGBUpkq77NTudVIb2jrkXt1sowvGB+ULoL0 qdIKEf98rZCQ6kqwXGJZC9hs3WHN8XYaOZ1F797TEI8e9dcEyXMsMnc+3sv7+eKl7Yhr8WJo5z8 KV99bKAYEOK+oh5Zw5DepKiSZwXvkqM4fOJLsPi6r3Gr08eW6i5m1tB88b8PUMoSPGdY0s+d5ro xhraJafQ//BsP0tH9c0pqiLDEcNSLqoCyQky3FSq/pJhdJdt4JU/VvHK9ikQRvGuyX5iosleUGl PyeNoIeFX94DIdZvDEsoSDXvdxyyibjEO074fO4mFxIlos8j3G X-Received: by 2002:a5d:588b:0:b0:439:be4b:6868 with SMTP id ffacd0b85a97d-439f84358fbmr7575669f8f.47.1773257107398; Wed, 11 Mar 2026 12:25:07 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:38b7:8ca3:cb55:d344]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20bd9csm1323210f8f.21.2026.03.11.12.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 12:25:07 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v5 07/15] irqchip/renesas-rzg2l: Replace rzg2l_irqc_irq_{enable,disable} with TINT-specific handlers Date: Wed, 11 Mar 2026 19:24:38 +0000 Message-ID: <20260311192459.609064-8-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> References: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das rzg2l_irqc_irq_disable() and rzg2l_irqc_irq_enable() were used by both the IRQ and TINT chips, but only performed TINT-specific work via rzg2l_tint_irq_endisable(), guarded by a hw_irq range check. Since the IRQ chip does not require this extra enable/disable handling, replace its callbacks with the generic irq_chip_disable_parent() and irq_chip_enable_parent() directly. Signed-off-by: Biju Das --- v5: * New patch. --- drivers/irqchip/irq-renesas-rzg2l.c | 41 +++++++++++++---------------- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index c779bcc4028d..0d6b72e1bc02 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -259,33 +259,30 @@ static void rzfive_irqc_irq_enable(struct irq_data *d) =20 static void rzg2l_tint_irq_endisable(struct irq_data *d, bool enable) { + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); unsigned int hw_irq =3D irqd_to_hwirq(d); + u32 offset =3D hw_irq - IRQC_TINT_START; + u32 tssr_offset =3D TSSR_OFFSET(offset); + u8 tssr_index =3D TSSR_INDEX(offset); + u32 reg; =20 - if (hw_irq >=3D IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) { - struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); - u32 offset =3D hw_irq - IRQC_TINT_START; - u32 tssr_offset =3D TSSR_OFFSET(offset); - u8 tssr_index =3D TSSR_INDEX(offset); - u32 reg; - - raw_spin_lock(&priv->lock); - reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); - if (enable) - reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); - else - reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); - writel_relaxed(reg, priv->base + TSSR(tssr_index)); - raw_spin_unlock(&priv->lock); - } + raw_spin_lock(&priv->lock); + reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); + if (enable) + reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); + else + reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); + writel_relaxed(reg, priv->base + TSSR(tssr_index)); + raw_spin_unlock(&priv->lock); } =20 -static void rzg2l_irqc_irq_disable(struct irq_data *d) +static void rzg2l_irqc_tint_disable(struct irq_data *d) { irq_chip_disable_parent(d); rzg2l_tint_irq_endisable(d, false); } =20 -static void rzg2l_irqc_irq_enable(struct irq_data *d) +static void rzg2l_irqc_tint_enable(struct irq_data *d) { rzg2l_tint_irq_endisable(d, true); irq_chip_enable_parent(d); @@ -456,8 +453,8 @@ static const struct irq_chip rzg2l_irqc_irq_chip =3D { .irq_eoi =3D rzg2l_irqc_irq_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, - .irq_disable =3D rzg2l_irqc_irq_disable, - .irq_enable =3D rzg2l_irqc_irq_enable, + .irq_disable =3D irq_chip_disable_parent, + .irq_enable =3D irq_chip_enable_parent, .irq_get_irqchip_state =3D irq_chip_get_parent_state, .irq_set_irqchip_state =3D irq_chip_set_parent_state, .irq_retrigger =3D irq_chip_retrigger_hierarchy, @@ -473,8 +470,8 @@ static const struct irq_chip rzg2l_irqc_tint_chip =3D { .irq_eoi =3D rzg2l_irqc_tint_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, - .irq_disable =3D rzg2l_irqc_irq_disable, - .irq_enable =3D rzg2l_irqc_irq_enable, + .irq_disable =3D rzg2l_irqc_tint_disable, + .irq_enable =3D rzg2l_irqc_tint_enable, .irq_get_irqchip_state =3D irq_chip_get_parent_state, .irq_set_irqchip_state =3D irq_chip_set_parent_state, .irq_retrigger =3D irq_chip_retrigger_hierarchy, --=20 2.43.0