From nobody Tue Apr 7 21:26:11 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9B2B375ADB for ; Wed, 11 Mar 2026 19:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257109; cv=none; b=jjaWedKkPpDDbfYCZGnKraWEwF7u1wBT9CUx68agtydLJAjA/iyVe+kaNToj8rCa2093wgURivEdTNEs9ITWUbQatJCn4/FQoS7A4Yb4jWjYqzN1LSuWV4XDastnnjktkiuy52fT4QrscC/RyHzysbXRBTFxjN3T4HTFCEtVyXw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257109; c=relaxed/simple; bh=lyZczvy+fbbjpuhJdriWY4Xm3ChQADyZfKOTYccb1GA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lzzcB7EtSLFkTCdTm9LQ8dgYiM3tjsfk31Ti71iA+/bboJ3/UGJPhz4Ue2YibgLA1/+SmBG1GtTDOKwv26cIHeE2zyeK6NKoEDsUh0YEadNxFVCgDBf6qUD+kcTM3ArDyoTXBuWX2OhrhzclqT1QwFXiciyDxwd+bYEYJEQ7TRs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AkJ+HgAw; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AkJ+HgAw" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so1929105e9.2 for ; Wed, 11 Mar 2026 12:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773257106; x=1773861906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iGXUvkvzSy+dtJfFo2G7AhUAuLk8jdwln0iV68qBoI0=; b=AkJ+HgAwmkPMRZwg+EbtgMmTGWyOYMKacNi1mUc5e1UQHeqO6pUnno5YRcxkLkXFTg oQMYNcfyCaGBZopJUa1nr6GfOh12AWU9oRNbGEPimBUhGYgwgnNh68DQlRsrIniVL6N5 YAwpD6WWkVeGb/dR+F58Wy/XbNar5hJI8zmxfT+VRXpnBUWms0xbH0OEmh6XmYwVt1E6 y9SpX9jsGBHLrMCOyfHlzxQh1DtrQPXSNIvDfYzTPfkE17mB9GrtoIlqZefynkROfET+ mYACurB5+yaMgjXf9YzB8VSmvdEDXNQ1SLuhEJf4pHbQ1KcbD2K2DvzPf7FQtr8b2/hC Isiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773257106; x=1773861906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iGXUvkvzSy+dtJfFo2G7AhUAuLk8jdwln0iV68qBoI0=; b=Rs7CwxMTDDaKBYsBQH2bQIz5/EKV3wtTeUFtJHU+4sBlbaztFq5jHAUo5FPtHPiSL/ Z9qnDCdJGBqQVAz7K2cuF85Y9B+KsCKzYm1QejsKAJ5sC6Yvjl/zwzr/fChRV4hLqwJe yH57gNUKHyyjlDYRbR+7JE3ZdcNnCoF6sjLTNHLKfxPySFugkFYNtzYzz4M6gD12YzcT OtzAmI5jzvk468JHGKBVRG/OPdYi/ttqzts89m1X+wPLV/9LgMdeulZ76aLIPnBBY2J3 alTVdixk1sUnrumhMRkk0vQyydSGfo4rbBOilnr+mnvhs/L8fOMd6bpyUJ4Al3mLVDQQ Ijpg== X-Forwarded-Encrypted: i=1; AJvYcCW9lFlYj7pdhTmtlvcxEwZaTLWJB1znJlIfTNi7tHsIAnT/uN9uujzcRh9PIUTPn6q7HSwEGJYj2GNZer0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf/L6ara6LGANkIBaGKIiJ4yLVMdlDIUX642wc6fn3UY3WopiD yfSHv2/EbFNKfIDboR8jRPlrBa7VT56SxpOCxz9znthtHlZ9T6mPqhAR X-Gm-Gg: ATEYQzz+k3iD/dCbop0cJMlmLgVC0ix0l/neAYjd5EbfrZXMkfyV2X9j+VBn+Sb9cj+ Ecw6s5alDlAFdNhEOP6usgTRONBtqN4mj/zxesZgtShmpAnFzU0Yw5tX90ck5PBqvOM9SuDv/3F /Pjukx8XrIUwaYR09QTpbCdbFU+/unwVl+3Cd4tl7QG8Sp0CgK8MmPS/29CNBNhenGFzXz+7UfB kdvwffOJ16PmiKJH+7T7k8YAZKmpqF40wG45E9GHvf4cCIO2rhQ3tqJpicKDfPqCHi8AbArb04R Q30oO+r/CSgrRas0xNDMsnk20jYs1UPjL20nJ9YJEHLwaRTZqfwh/ub2hunszyWzKw/GNwe4D8r n1TQDXP0dpd2g0wl8HiCkie47fjLHXCY0i2bFPY5C4Kn6eR0o52ML5DjA7smWbHOD5NN2xuLePI mrC7bvIYdvp2LOd1luTPWWjA6DiNc9lZLxSY+qwcd9kJVRSdTZHBU6zJRTuzI= X-Received: by 2002:a05:600c:4e56:b0:485:4136:99a8 with SMTP id 5b1f17b1804b1-4854b0fafb9mr58370445e9.22.1773257105975; Wed, 11 Mar 2026 12:25:05 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:38b7:8ca3:cb55:d344]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20bd9csm1323210f8f.21.2026.03.11.12.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 12:25:05 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v5 05/15] irqchip/renesas-rzg2l: Split EOI handler into separate IRQ and TINT functions Date: Wed, 11 Mar 2026 19:24:36 +0000 Message-ID: <20260311192459.609064-6-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> References: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The single rzg2l_irqc_eoi() handler used a conditional to determine whether to clear an IRQ or TINT interrupt. Split this into two dedicated handlers, rzg2l_irqc_irq_eoi() and rzg2l_irqc_tint_eoi(), each handling only their respective interrupt type without the need for range checks. Signed-off-by: Biju Das --- v5: * New patch. --- drivers/irqchip/irq-renesas-rzg2l.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index a0f03f81d5ef..1c5083a48561 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -130,16 +130,24 @@ static void rzg2l_clear_tint_int(struct rzg2l_irqc_pr= iv *priv, unsigned int hwir } } =20 -static void rzg2l_irqc_eoi(struct irq_data *d) +static void rzg2l_irqc_irq_eoi(struct irq_data *d) { struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); unsigned int hw_irq =3D irqd_to_hwirq(d); =20 raw_spin_lock(&priv->lock); - if (hw_irq >=3D IRQC_IRQ_START && hw_irq <=3D IRQC_IRQ_COUNT) - rzg2l_clear_irq_int(priv, hw_irq); - else if (hw_irq >=3D IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) - rzg2l_clear_tint_int(priv, hw_irq); + rzg2l_clear_irq_int(priv, hw_irq); + raw_spin_unlock(&priv->lock); + irq_chip_eoi_parent(d); +} + +static void rzg2l_irqc_tint_eoi(struct irq_data *d) +{ + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); + unsigned int hw_irq =3D irqd_to_hwirq(d); + + raw_spin_lock(&priv->lock); + rzg2l_clear_tint_int(priv, hw_irq); raw_spin_unlock(&priv->lock); irq_chip_eoi_parent(d); } @@ -438,7 +446,7 @@ static struct syscore rzg2l_irqc_syscore =3D { =20 static const struct irq_chip rzg2l_irqc_irq_chip =3D { .name =3D "rzg2l-irqc", - .irq_eoi =3D rzg2l_irqc_eoi, + .irq_eoi =3D rzg2l_irqc_irq_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, .irq_disable =3D rzg2l_irqc_irq_disable, @@ -455,7 +463,7 @@ static const struct irq_chip rzg2l_irqc_irq_chip =3D { =20 static const struct irq_chip rzg2l_irqc_tint_chip =3D { .name =3D "rzg2l-irqc", - .irq_eoi =3D rzg2l_irqc_eoi, + .irq_eoi =3D rzg2l_irqc_tint_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, .irq_disable =3D rzg2l_irqc_irq_disable, @@ -472,7 +480,7 @@ static const struct irq_chip rzg2l_irqc_tint_chip =3D { =20 static const struct irq_chip rzfive_irqc_irq_chip =3D { .name =3D "rzfive-irqc", - .irq_eoi =3D rzg2l_irqc_eoi, + .irq_eoi =3D rzg2l_irqc_irq_eoi, .irq_mask =3D rzfive_irqc_mask, .irq_unmask =3D rzfive_irqc_unmask, .irq_disable =3D rzfive_irqc_irq_disable, @@ -489,7 +497,7 @@ static const struct irq_chip rzfive_irqc_irq_chip =3D { =20 static const struct irq_chip rzfive_irqc_tint_chip =3D { .name =3D "rzfive-irqc", - .irq_eoi =3D rzg2l_irqc_eoi, + .irq_eoi =3D rzg2l_irqc_tint_eoi, .irq_mask =3D rzfive_irqc_mask, .irq_unmask =3D rzfive_irqc_unmask, .irq_disable =3D rzfive_irqc_irq_disable, --=20 2.43.0