From nobody Tue Apr 7 21:26:12 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BED6632C316 for ; Wed, 11 Mar 2026 19:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257108; cv=none; b=RT+yJDA2pSpzmB15pJSx2e5xECyI/+a7+UK9phapUg93ynEuOBYmx/avHat3Z2defvvj33fK5FR6p/LJhL293KZ0XIEFDLidvtHJep9EsIuv0JGu5LCrgW4/4gwSj+hlkAKRJn05261McZJDX4QHCY0QdxE0KdCp3sJENZYkgi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257108; c=relaxed/simple; bh=2E6jMa7ABsxErVDYefKJecluauKc2OSpEoG3VqKGCm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RkZe5wDr0T7JyRBaiMmYa/KaGToCpfdXN0B++68U2BnBMwc9xtIHaPJ+vbydqKTXySDN2tR6JR52TtqNG5gs0cFBUzo7gTYP0GN0TA94boJ8VNQDCmXnHt4tVmq0TbNDKDrccS2+MSgNCTLBOz72qB/O02u+b/tzPNVuoiHOMQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ag6Dy0Wv; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ag6Dy0Wv" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439c4bde55cso168932f8f.1 for ; Wed, 11 Mar 2026 12:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773257105; x=1773861905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=43m+t9jWY/9aRGNctYAYIHzG3/TvbD02Kz/mm0ecsjM=; b=ag6Dy0WvDAofOFfNDWgnvGt1StzRKBLc+FBmFDkx5RwB+HywLy3GemogQdKuyKyFpI 4ORGJ7nuL/w4NVpZwY1ua5LL16GlBz0M6Ut+YNok+mBgziGk4N1poBTsvPT6uluI8AHh 8++I20Bs/9SZCIQMlnE9AM31dX0ZX/aKHUljZjAjzUs6DnUcrGXzdqx+nolrNolc21Gm HHXXTizfQAq1+ff/WdLkZeKZZ6rBbep0bJljZcmL1YTA+KGxCaXJGxtURrW6IxiyNSnw PBRI6ZT3mH6Z0r3hiJWMdQGuGdoKxlMfJUaAXrH32ea1Tl7Hlu4IYPZGB7Ny2lgOxQrY wN4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773257105; x=1773861905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=43m+t9jWY/9aRGNctYAYIHzG3/TvbD02Kz/mm0ecsjM=; b=gOmOoReKJlk7MSVZYyLtvTq5l7Z1UO46QsvhkfLD1ncI4uGI7nTuABXlBblCAW13Wt atOLp7ZuZyur/rnZG9y+4eTeAmy+W+13VdZiAJXHJJUDVyUqiapMGWH8jONMyluY/QbC J0PC9p6cGjwZwiLXX1OR8NOlauNnvICdDusOaUsSoR0KO6W1np+wf7BC+SF2QuWY9cZG co6A+nf61nHRPT+juO+cwTNIaE5ZRpIUV6y3FBfZ7ml0BMHIJBxEkhLIu7COTQa1cDeM dc3x/a8F11dmcZWQ7gidZd5fdF3Oj5JJw1pTgojcLM+LZbPXwuhk5crjS1D9pZ23SzPI TDcw== X-Forwarded-Encrypted: i=1; AJvYcCULlVhK1RAa8OyWaggVznM12j4e+bCiXxFmjhdU7sJ4C90M/uOjB/JLecIHVVYGwP6bc2kd0o5vZuxONg4=@vger.kernel.org X-Gm-Message-State: AOJu0YzvFtwU7O64rZnk90sKJy2HmeljHP7Skuwxx3mf76xWL5h7u42+ I51wrpzhaLgRKKt6LpVdNo3AmvvwHWqhgwd28MhoxUho5DK1uyDENSEf X-Gm-Gg: ATEYQzyQsygekm9eg0JxAjndnyd1d7s3gaOkHy623Ik+b6O2R7AhenE+N/2jLZSwBKO OwDUgIyQuHrJcOIovayqIvVIl62oDuf14UDF5UyiKsGiECQiFi7SN0IAKYtW9/GjnzHfgceJ23c fVvtv5HlXSPy6w5MILyJssfxSA6r8aRtmTxrisDU1N8aEIpDk6vNe1e3g8HJyisd0av6hmouhPb o7e2z3quQvKDvgL64salGrHjHs1sqjWYEfwEzt2BIezsLwlQskezcIE4HN4ra0ZXsdUa7XrcAVY xokc90P5zVHB4RkbiDRAYeH0BcZxnygzPR8qDBtH9vGf/HQOofZEojh6NOM6Jcc8ZVpUAhFV9Ox /aU01oj31cCV2UvwFXqm6hVNMbybu611X6qo9DC72CHfqalrBNsJGC4uQvGmyDwQIEu53nqrrpb 6hGdXYLfJJ2bANzzTWPS08SN/IOvECr8aQuuV44mZGLtm3DHFq4boAHC80vHs= X-Received: by 2002:a05:6000:1863:b0:439:c510:f97a with SMTP id ffacd0b85a97d-439f8439cafmr7103472f8f.48.1773257105096; Wed, 11 Mar 2026 12:25:05 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:38b7:8ca3:cb55:d344]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20bd9csm1323210f8f.21.2026.03.11.12.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 12:25:04 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v5 04/15] irqchip/renesas-rzg2l: Replace single irq_chip with per-region irq_chip instances Date: Wed, 11 Mar 2026 19:24:35 +0000 Message-ID: <20260311192459.609064-5-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> References: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The driver previously used a single irq_chip instance shared across all interrupt types, relying on dispatcher callbacks to differentiate between IRQ and TINT regions at runtime. Replace the per-SoC irq_chip and its dispatcher callbacks with dedicated irq_chip instances for each interrupt region: IRQ and TINT. Subsequent patches will add per-region callbacks for IRQ and TINT from the common code. Signed-off-by: Biju Das --- v5: * New patch. --- drivers/irqchip/irq-renesas-rzg2l.c | 61 ++++++++++++++++++++++++----- 1 file changed, 51 insertions(+), 10 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index ed8044b0a339..a0f03f81d5ef 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -71,14 +71,16 @@ struct rzg2l_irqc_reg_cache { /** * struct rzg2l_irqc_priv - IRQ controller private data structure * @base: Controller's base address - * @irqchip: Pointer to struct irq_chip + * @irq_chip: Pointer to struct irq_chip for irq + * @tint_chip: Pointer to struct irq_chip for tint * @fwspec: IRQ firmware specific data * @lock: Lock to serialize access to hardware registers * @cache: Registers cache for suspend/resume */ static struct rzg2l_irqc_priv { void __iomem *base; - const struct irq_chip *irqchip; + const struct irq_chip *irq_chip; + const struct irq_chip *tint_chip; struct irq_fwspec fwspec[IRQC_NUM_IRQ]; raw_spinlock_t lock; struct rzg2l_irqc_reg_cache cache; @@ -434,7 +436,7 @@ static struct syscore rzg2l_irqc_syscore =3D { .ops =3D &rzg2l_irqc_syscore_ops, }; =20 -static const struct irq_chip rzg2l_irqc_chip =3D { +static const struct irq_chip rzg2l_irqc_irq_chip =3D { .name =3D "rzg2l-irqc", .irq_eoi =3D rzg2l_irqc_eoi, .irq_mask =3D irq_chip_mask_parent, @@ -451,7 +453,41 @@ static const struct irq_chip rzg2l_irqc_chip =3D { IRQCHIP_SKIP_SET_WAKE, }; =20 -static const struct irq_chip rzfive_irqc_chip =3D { +static const struct irq_chip rzg2l_irqc_tint_chip =3D { + .name =3D "rzg2l-irqc", + .irq_eoi =3D rzg2l_irqc_eoi, + .irq_mask =3D irq_chip_mask_parent, + .irq_unmask =3D irq_chip_unmask_parent, + .irq_disable =3D rzg2l_irqc_irq_disable, + .irq_enable =3D rzg2l_irqc_irq_enable, + .irq_get_irqchip_state =3D irq_chip_get_parent_state, + .irq_set_irqchip_state =3D irq_chip_set_parent_state, + .irq_retrigger =3D irq_chip_retrigger_hierarchy, + .irq_set_type =3D rzg2l_irqc_set_type, + .irq_set_affinity =3D irq_chip_set_affinity_parent, + .flags =3D IRQCHIP_MASK_ON_SUSPEND | + IRQCHIP_SET_TYPE_MASKED | + IRQCHIP_SKIP_SET_WAKE, +}; + +static const struct irq_chip rzfive_irqc_irq_chip =3D { + .name =3D "rzfive-irqc", + .irq_eoi =3D rzg2l_irqc_eoi, + .irq_mask =3D rzfive_irqc_mask, + .irq_unmask =3D rzfive_irqc_unmask, + .irq_disable =3D rzfive_irqc_irq_disable, + .irq_enable =3D rzfive_irqc_irq_enable, + .irq_get_irqchip_state =3D irq_chip_get_parent_state, + .irq_set_irqchip_state =3D irq_chip_set_parent_state, + .irq_retrigger =3D irq_chip_retrigger_hierarchy, + .irq_set_type =3D rzg2l_irqc_set_type, + .irq_set_affinity =3D irq_chip_set_affinity_parent, + .flags =3D IRQCHIP_MASK_ON_SUSPEND | + IRQCHIP_SET_TYPE_MASKED | + IRQCHIP_SKIP_SET_WAKE, +}; + +static const struct irq_chip rzfive_irqc_tint_chip =3D { .name =3D "rzfive-irqc", .irq_eoi =3D rzg2l_irqc_eoi, .irq_mask =3D rzfive_irqc_mask, @@ -472,6 +508,7 @@ static int rzg2l_irqc_alloc(struct irq_domain *domain, = unsigned int virq, unsigned int nr_irqs, void *arg) { struct rzg2l_irqc_priv *priv =3D domain->host_data; + const struct irq_chip *chip; unsigned long tint =3D 0; irq_hw_number_t hwirq; unsigned int type; @@ -491,13 +528,15 @@ static int rzg2l_irqc_alloc(struct irq_domain *domain= , unsigned int virq, if (hwirq > IRQC_IRQ_COUNT) { tint =3D TINT_EXTRACT_GPIOINT(hwirq); hwirq =3D TINT_EXTRACT_HWIRQ(hwirq); + chip =3D priv->tint_chip; + } else { + chip =3D priv->irq_chip; } =20 if (hwirq > (IRQC_NUM_IRQ - 1)) return -EINVAL; =20 - ret =3D irq_domain_set_hwirq_and_chip(domain, virq, hwirq, priv->irqchip, - (void *)(uintptr_t)tint); + ret =3D irq_domain_set_hwirq_and_chip(domain, virq, hwirq, chip, (void *)= (uintptr_t)tint); if (ret) return ret; =20 @@ -529,7 +568,8 @@ static int rzg2l_irqc_parse_interrupts(struct rzg2l_irq= c_priv *priv, } =20 static int rzg2l_irqc_common_probe(struct platform_device *pdev, struct de= vice_node *parent, - const struct irq_chip *irq_chip) + const struct irq_chip *irq_chip, + const struct irq_chip *tint_chip) { struct irq_domain *irq_domain, *parent_domain; struct device_node *node =3D pdev->dev.of_node; @@ -545,7 +585,8 @@ static int rzg2l_irqc_common_probe(struct platform_devi= ce *pdev, struct device_n if (!rzg2l_irqc_data) return -ENOMEM; =20 - rzg2l_irqc_data->irqchip =3D irq_chip; + rzg2l_irqc_data->irq_chip =3D irq_chip; + rzg2l_irqc_data->tint_chip =3D tint_chip; =20 rzg2l_irqc_data->base =3D devm_of_iomap(dev, dev->of_node, 0, NULL); if (IS_ERR(rzg2l_irqc_data->base)) @@ -585,12 +626,12 @@ static int rzg2l_irqc_common_probe(struct platform_de= vice *pdev, struct device_n =20 static int rzg2l_irqc_probe(struct platform_device *pdev, struct device_no= de *parent) { - return rzg2l_irqc_common_probe(pdev, parent, &rzg2l_irqc_chip); + return rzg2l_irqc_common_probe(pdev, parent, &rzg2l_irqc_irq_chip, &rzg2l= _irqc_tint_chip); } =20 static int rzfive_irqc_probe(struct platform_device *pdev, struct device_n= ode *parent) { - return rzg2l_irqc_common_probe(pdev, parent, &rzfive_irqc_chip); + return rzg2l_irqc_common_probe(pdev, parent, &rzfive_irqc_irq_chip, &rzfi= ve_irqc_tint_chip); } =20 IRQCHIP_PLATFORM_DRIVER_BEGIN(rzg2l_irqc) --=20 2.43.0