From nobody Tue Apr 7 21:26:11 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CAA73E5590 for ; Wed, 11 Mar 2026 19:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257113; cv=none; b=qgvNNF1cILAjNZ0YOiN2Q23nNzFlXnMXzGuLJv3KRjY7SfheKNuVclodB2m5XPTPt+TH8ZPKsNmoR622m3kH3Lgg78TFkj0/RZUNzmRE9zIKwxmUNg0dl0cc3cDTJgX24YVnpBM5LM5mwIntEaYaSdfoc+UAhpHgXYc93mtp+GE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257113; c=relaxed/simple; bh=9oiAbcWjEfgaBgpmhpb898gNxNOJat+jQs9qnUiLUgk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DkkZkoaCPvpPCSRfqTKnP8nw8yrIF29sTeHwrGi2PEAvtWckFS0JLJwPfI6McrhHouXeQm7imydqvMNdAynptqIv8bM9Jw9B1f1h0FkIZu4X/+/vt1D5YJE+p+MOtVboyNBqTDxEEv8scisfqS3J4WUAeOejkStlYuQTIhFbBfU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UCpY++ph; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UCpY++ph" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4852c9b4158so1789095e9.0 for ; Wed, 11 Mar 2026 12:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773257109; x=1773861909; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2v2QrzPKN7jBP6V4KIFwuXhzoPzNwKJfv37TL6swzDA=; b=UCpY++phy8/1W61EnHKybYqqCQum/XQdx4sitxLpujHr5aJ8PFOH4mh/0Knj4zAUHt ty4HDBvE910KP/CuawLxkfubhcYnpvCK+vDd4cvFL2iV8pKMb2LfzVrKDZIrAi91Zq/j BC4cUHTYdRTxaKSbAdMHQ/f8mydUo5ENvzvDy3gmbq2BWL1/xu+yl7nyLfdFQO2Mv9kV aTpRulGa4YcxRLL/vazTB3ODsgtCEh4ei1iJIDbLJUC1E2ODPBegukrov3RntGCD4+Cb Vl5ccqmnauvSKkqItnSD6lGj+7Wlt/lUR0p0j1p7GBcTuvB1B4C94XOYyjLfO2/ATOZP n1yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773257109; x=1773861909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2v2QrzPKN7jBP6V4KIFwuXhzoPzNwKJfv37TL6swzDA=; b=n92IeLYmmSFRMUqLIUMFLuqXbW/qY13wAek0+JJrsG/bYGvZcGI1zMpvMsrOuAmDjp /oBOKSVwuFA6A3ZLkz0GRAj09azfhUaVDpTuKI7MYCUdcgjbhlq2EHomRnh1PwER9Bl2 hyzKkyta3zwB+4kXRijIl3s+x0RKTdIYCKFhTx1LbuZXIb29xvkOgsgfy/0XgYfSkFIf bVM6rA9yRvLab4J0Jd1vEeSea87xlaXxgZP0XlmZCNVAo1ZzIp88laRDs91Vapi4R/Ty q7KUk8Ask6fV4Ywmwhh82t3G5BA96g4O9XyLajHlImprLo2d8pHvrMzEH74s4q5gE8bO /YZg== X-Forwarded-Encrypted: i=1; AJvYcCWxLWYSq+ZBdS1i0LGtoTc9R+lUEoCLUF5Bf2Lu5nP2SZ3FwjLxOuA7/Mqf6BCcGFMHiTil+54YwcGrVtA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7ebHap8ZYJt3NSrbUzfc12aD5p5HicDy1OZYTLEU7IXPyKJgi 4E3D8KNH9auyXMCopZbKq10tK0Ffrq8BOtSjdeVz0skoopYNWxbw9Crd X-Gm-Gg: ATEYQzzN4JqKE3wLZNHjX/7UAUvqiVAtHo4Za2oRr5QjlSYLosiyUR3JXj6IVjVCnGq AN5N/CbAt9iRb5G9Ua4eBcoWUqn9tk/TJnRz4GylhIot3PWionI1k5F3n3YiuUhQuhpdUOR2F7x hIsJinjkPMywFGBdWtiVe4TvgvUARkESZT4WSi9bh/jEoqqiukmXYgvNCNzSJgV7EtKFdiVeGPX 0irtP1K8RhqszgSLA0q9WcsuIdtpR1BdOC5/Bc/wb9rtYqwPy4AvVlkCRFog0tmnvNQKLS9XF0I J64QTme3ex/WCAHAP2aMKu8vaYgo+OE46dlOj/1Hmy+GWq9B6hyj7UWrDb54/nZciNTpJGHE0w2 knYq/qZBWGx0mFcAPY0EzIxCkrciFKWSvP7wDxfG33aF7RmQgUtwcoL1cZ+9zl44Pub9/dg/DwA fdtBOFEU/1W9DBuAj8sWCOUexFYzQwel2NZMxrRfPSjvAJKyFOX/sKmyXLv+Q= X-Received: by 2002:a05:6000:240e:b0:439:df02:1d70 with SMTP id ffacd0b85a97d-439f842a97emr7261683f8f.29.1773257109303; Wed, 11 Mar 2026 12:25:09 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:38b7:8ca3:cb55:d344]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20bd9csm1323210f8f.21.2026.03.11.12.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 12:25:08 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v5 09/15] irqchip/renesas-rzg2l: Split rzfive_irqc_{mask,unmask} into separate IRQ and TINT handlers Date: Wed, 11 Mar 2026 19:24:40 +0000 Message-ID: <20260311192459.609064-10-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> References: <20260311192459.609064-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Biju Das rzfive_irqc_mask() and rzfive_irqc_unmask() used hw_irq range checks to dispatch between IRQ and TINT masking operations. Split each into two dedicated handlers =E2=80=94 rzfive_irqc_irq_mask(), rzfive_irqc_tint_mask(= ), rzfive_irqc_irq_unmask(), and rzfive_irqc_tint_unmask() =E2=80=94 each operating unconditionally on their respective interrupt type, removing the runtime conditionals. Assign the IRQ-specific handlers to rzfive_irqc_irq_chip and the TINT-specific handlers to rzfive_irqc_tint_chip, consistent with the separation applied to the EOI, set_type, and enable/disable callbacks in previous patches. Signed-off-by: Biju Das --- v5: * New patch. --- drivers/irqchip/irq-renesas-rzg2l.c | 44 ++++++++++++++++++++--------- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index 9e0080c5ec95..fd017c73dfc5 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -184,30 +184,46 @@ static void rzfive_irqc_unmask_tint_interrupt(struct = rzg2l_irqc_priv *priv, writel_relaxed(readl_relaxed(priv->base + TMSK) & ~bit, priv->base + TMSK= ); } =20 -static void rzfive_irqc_mask(struct irq_data *d) +static void rzfive_irqc_irq_mask(struct irq_data *d) { struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); unsigned int hwirq =3D irqd_to_hwirq(d); =20 raw_spin_lock(&priv->lock); - if (hwirq >=3D IRQC_IRQ_START && hwirq <=3D IRQC_IRQ_COUNT) - rzfive_irqc_mask_irq_interrupt(priv, hwirq); - else if (hwirq >=3D IRQC_TINT_START && hwirq < IRQC_NUM_IRQ) - rzfive_irqc_mask_tint_interrupt(priv, hwirq); + rzfive_irqc_mask_irq_interrupt(priv, hwirq); raw_spin_unlock(&priv->lock); irq_chip_mask_parent(d); } =20 -static void rzfive_irqc_unmask(struct irq_data *d) +static void rzfive_irqc_tint_mask(struct irq_data *d) { struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); unsigned int hwirq =3D irqd_to_hwirq(d); =20 raw_spin_lock(&priv->lock); - if (hwirq >=3D IRQC_IRQ_START && hwirq <=3D IRQC_IRQ_COUNT) - rzfive_irqc_unmask_irq_interrupt(priv, hwirq); - else if (hwirq >=3D IRQC_TINT_START && hwirq < IRQC_NUM_IRQ) - rzfive_irqc_unmask_tint_interrupt(priv, hwirq); + rzfive_irqc_mask_tint_interrupt(priv, hwirq); + raw_spin_unlock(&priv->lock); + irq_chip_mask_parent(d); +} + +static void rzfive_irqc_irq_unmask(struct irq_data *d) +{ + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); + unsigned int hwirq =3D irqd_to_hwirq(d); + + raw_spin_lock(&priv->lock); + rzfive_irqc_unmask_irq_interrupt(priv, hwirq); + raw_spin_unlock(&priv->lock); + irq_chip_unmask_parent(d); +} + +static void rzfive_irqc_tint_unmask(struct irq_data *d) +{ + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); + unsigned int hwirq =3D irqd_to_hwirq(d); + + raw_spin_lock(&priv->lock); + rzfive_irqc_unmask_tint_interrupt(priv, hwirq); raw_spin_unlock(&priv->lock); irq_chip_unmask_parent(d); } @@ -501,8 +517,8 @@ static const struct irq_chip rzg2l_irqc_tint_chip =3D { static const struct irq_chip rzfive_irqc_irq_chip =3D { .name =3D "rzfive-irqc", .irq_eoi =3D rzg2l_irqc_irq_eoi, - .irq_mask =3D rzfive_irqc_mask, - .irq_unmask =3D rzfive_irqc_unmask, + .irq_mask =3D rzfive_irqc_irq_mask, + .irq_unmask =3D rzfive_irqc_irq_unmask, .irq_disable =3D rzfive_irqc_irq_disable, .irq_enable =3D rzfive_irqc_irq_enable, .irq_get_irqchip_state =3D irq_chip_get_parent_state, @@ -518,8 +534,8 @@ static const struct irq_chip rzfive_irqc_irq_chip =3D { static const struct irq_chip rzfive_irqc_tint_chip =3D { .name =3D "rzfive-irqc", .irq_eoi =3D rzg2l_irqc_tint_eoi, - .irq_mask =3D rzfive_irqc_mask, - .irq_unmask =3D rzfive_irqc_unmask, + .irq_mask =3D rzfive_irqc_tint_mask, + .irq_unmask =3D rzfive_irqc_tint_unmask, .irq_disable =3D rzfive_irqc_tint_disable, .irq_enable =3D rzfive_irqc_tint_enable, .irq_get_irqchip_state =3D irq_chip_get_parent_state, --=20 2.43.0