From nobody Tue Apr 7 19:50:52 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB5292F4A16 for ; Wed, 11 Mar 2026 19:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773256591; cv=none; b=d9Hp3l3Qu+rlEgTYe9QAu3h1HKgEMVPO3QZ+oMi6dIKiEVbVoEuBVYwWFJilcW4stHQyGyyVsAfasGdE+sOmilTCpwPli3s0K5s4hkn2iWl2cLLVjDx9yb6cDe+b/RKGSvv3B2eVmDaeC7yeU2ZhTMmWHmwvo70+EyCRS7WFm8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773256591; c=relaxed/simple; bh=0Qnr7VxidfvU+xsDleNOZhfJsVXxieNl3yqIIH0Y+3o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BxaKTgeD6vBSr31mVwTCjYF4w5NyUJZNZd7TXFoOnjhQkH9mtOKodgW1FN+H3EwLC4BlfYSv05HTvR04e8dpyNpnqtT6lT+IAYGOmq/Wsur4HX2+bSjFLYnsvn5duRkf4x7MLp0fvOxD4DnUDPkY3L9r3NnCgfE9ST9OXHoOiWo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Bm3ScU91; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FOU+cQr2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bm3ScU91"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FOU+cQr2" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BD7vGM4032630 for ; Wed, 11 Mar 2026 19:16:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=M6F2sM+eNOI6ryH461JlMbp6jSOf87pDbVN oVk+OREo=; b=Bm3ScU91/1gbgUtg12dKKtbeLcwP1WzLf0fRvYobQ0tC+dxzV1D jixSoZTKlD1QdTfs0T4W3noLyFrRFX6t4rJUMDnfkhrhoWHPErAfgCAuMNFbWMCy R4L+2SE2RtA0I4EVoAqhQrL8OYz/lzE49gOBWPVU65tf0NwV5sw68dswOrogesbp K+u3exXivYalvIhh833iyxuKG9LgtqTzen0ltSyOqORH9etjF5HYeEIpDVhReBhw +fMFdFuON1HDs47xngINu09G793baXoGWmF99ZfS3ObgLxL73Oiz96lqn+Tfhcb0 hrrBzlqxH4pbszJ3emsLYIpwrPxLPO/q9VA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu90t9cry-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 19:16:28 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd7774be64so109517585a.0 for ; Wed, 11 Mar 2026 12:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773256588; x=1773861388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M6F2sM+eNOI6ryH461JlMbp6jSOf87pDbVNoVk+OREo=; b=FOU+cQr2APXfXaGSt+v6YZZuW7wIrgo/EVkWK8AUOvRKHmwRJUm5cwqAaswy5RimoI BFnN1YhStu6g0EZplVYwUMZkVeJO8MuEk7lyZZ1V85fuBHmOg07K58Kr1IEH1Dhx6vj4 6uzQbJnprS4jrusmXNWA5DhNny6fKQnyb3kUrVwA4U3R5Wro0AGHJCrK0mVdJZLioON8 I7SFcvym9w4PMboM6hKK5WjBSZZjFHB55tCKOZGH1LbSsr5fJFuNhY0Yv4U+1vvJgaAg KI1KXtftOSKnWfFqku9RM+8tXEU5QYNqzoQ+LStdmxPD+wDoTwFxzTfGwKD4bt1cSFXH KLkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773256588; x=1773861388; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M6F2sM+eNOI6ryH461JlMbp6jSOf87pDbVNoVk+OREo=; b=M36RRejS/cPhgnuFd+ZTsBzGlKIDVl+PDf+0UyDPXBfVpflzc9I3POlgzK/cSkLeUz AtrXOnP8gBzMBOjQNeW5FiEN9T9SPc75xJECEefPMHe1lV1TaLVpUuwg0RmAMl9Yienn uQ29qBed4mD6eH7msuSy6Wrymhp3KIBO9KzI6vVEEu3lYFnj+d07EWcTsPFNZqkSF4BC kfbZqVjBLfalTMAH4Bib65rJ8YLBasvfKhW3o4drIoI0Yf/Xzg6FWwS92RfvrnAocCTD 13Ez65Ei5pKH7+DPt4egCmKn76d4VFRC87vYS53JWu3KjB57ysaiBfK3t2JIXcD0Zja1 +oLw== X-Forwarded-Encrypted: i=1; AJvYcCV5IT+rMgbNkL3nC/oCznMjrYdnh2q9RYFbs0UEQWNVAKjttgeOypgFxAvFBf2951Xu2rob2CtW/etJM/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyZWSV7wcVAQbFKEnwKwQZksGIiJIqthZyYbwL7lbvT1SfK4r7y DwvqX3j5xd0423tnA1Sv4/fkmhE+gHTX5EWLCbRplYvwxTaVI8SxEW92ArqxRWieMXglpHMnV1e HYMf0pjEXAuqyR0VNnfq09+kHNciVhGYPxNvb21YO2dJuM/98UMoAz/j2HNb8teB9l5k= X-Gm-Gg: ATEYQzz1VTutYF9lnZr1z9atILI8Vr7PLXsNirNksLyQ62kDBhb6EXrqeifg17H8LK6 s/iyko1udHpF4mxsMMdqxUvy0VXlNRvFTx++pN6kEf5w9aBpQA/NK6nfNVC6SUoSYCXwEDPUR+3 GQz5FMA9wNsjyWEu0eQ6SQ5tExCBoeZM7/2IEAkcZqVIy9aTSuAj69VYYFWNGrP6mK5gv5SHDeq MRQVZHNs/Dv93KyX9+l2dnZoTJ6xAE/auKd9b6XNJODJMLApKL7lGubtDEE6T4d3t69g8HgobVE nf00tQkSGTOMvVf0BlNr07/6Dne8u6I22wZubxd/Se8DPEalML4gxNPNVvDfMGYG/T3eaVjInf0 jWIw7WVaZV+V+fB3m0QCvEwDXDYDReOBYi9Qs X-Received: by 2002:a05:620a:46ab:b0:8cd:97a7:a343 with SMTP id af79cd13be357-8cda1a29234mr498554185a.36.1773256588023; Wed, 11 Mar 2026 12:16:28 -0700 (PDT) X-Received: by 2002:a05:620a:46ab:b0:8cd:97a7:a343 with SMTP id af79cd13be357-8cda1a29234mr498548885a.36.1773256587514; Wed, 11 Mar 2026 12:16:27 -0700 (PDT) Received: from quoll ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe2273d9sm1475806f8f.34.2026.03.11.12.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 12:16:26 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH] drm/msm/hdmi: Fix wrong CTRL1 register used in writing info frames Date: Wed, 11 Mar 2026 20:16:21 +0100 Message-ID: <20260311191620.245394-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1818; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=0Qnr7VxidfvU+xsDleNOZhfJsVXxieNl3yqIIH0Y+3o=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpsb+EltUEMM5EjdIEq/s76SBmQyTVDzV2KeOFC RL/nWWEX0GJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCabG/hAAKCRDBN2bmhouD 1/YxD/wOPr0o16gKuvZcH1lDYB5OKlGeVB6cFFqVE0WRcXlUXwBj1qbsymgbYZllOE8iIAnx+xc l+XGmhJIL3Ytxv9JujjEucIdn2I0Y1U/GI9/dBXNonw/AqRMYOjb6l60LqNme2qDQS9N9AYEPaB 63o7mVsB0hLaTvRdXMa+yzfRQcyakznFByatyE6IKSwxGgW/NiM+bF+z5YmxoxLW7KtgS9gvyib ZxG61HkdyDqj4+mN4qNWU7JMVtrcMI8XZPriotu+YJor1W0d6EH8VRbo+pndWpXfrvHQ0eVRO3i E+CjV6H/MjwwTwHYKd9ErpFuExModykTudNq93r/ymIgJFsHyCF1ariJ6BO3SH9e683E0ooxw2O 1/QOnPZQMKOo5ZEJ6o5k6uTGjJni3lK+hIPNA0milUC5znVlboHUWgVY2ML04TWG2BworNw5398 n3P6N3tmTdr5LJQoxo8dcXkG4nYUz5gNC8tvaGj/bFa/HcHYYlcuY58qQQAqCgviTHEIl9v9a/p DDD5Ug7wrg7bYaAv7QSDKoIf2B/NGRDWjJoSZD79tci6kfjO8gtgBXqGQ3eLlpspgMkyvx1F/8Q BMT1/xjh3EcM+d4982bUiGZH4UNxzE3k4wOVsa3fidiOalcuzqfZIsDYbcau13HbhQUY1zS8tHj 0fKIP+gfkmkiMaQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: rXuYSem1viWXZeaGSFmGS6Cqrw5JcKOk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDE2MyBTYWx0ZWRfX0k6iRMTfrcTp uJumGoGUTskEQQUCxRnC/XpTJ8rEKsRfQoEn+RkxXmjmNfDQXv9yGmybjbY6amHB8fNuIVC9Nc5 3FOOVkCKNHZ6tFiG1iZuJQaGPtn4Ky8H+gW1GCSWmj+Ik/EymBKBVjnE4ElmCGMtZQfUfViokKx 06mEeCLctGTW+xD/oCErZH8Kaw9zDRTl0gnvBQb6CMzdcyEMJb7CsEcFnLpcbw81TCsn9/NVwny 5UbcoZwg8kYZzN8OFwqEzpkVCqb+xrBEok/Zvj2HhdAb15H/nfY0KTDv/zDdWU0zoA33YZ5wX1m GGz5QsywlE82NocNxEVVtHVG79izsaZi1Tc6K/TNq8qpraOaqCp7LI1U3VnxlLz0cni4U5LG3Wl DUDROGV/taakWlopeEPdzESnwLWif84a6WjjfKhWoYKEp+PZs6/gDeXF/9j4MBozs/+EPOvcjtY sQjEKSn6Jlni3bBwvtg== X-Authority-Analysis: v=2.4 cv=DfEaa/tW c=1 sm=1 tr=0 ts=69b1bf8d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ksbDLleXNvo7xJVorFEA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: rXuYSem1viWXZeaGSFmGS6Cqrw5JcKOk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110163 Content-Type: text/plain; charset="utf-8" Commit 384d2b03d0a1 ("drm/msm/hdmi: make use of the drm_connector_hdmi framework") changed the unconditional register writes in few places to updates: read, apply mask, write. The new code reads REG_HDMI_INFOFRAME_CTRL1 register, applies fields/mask for HDMI_INFOFRAME_CTRL0 register and finally writes to HDMI_INFOFRAME_CTRL0. This difference between CTRL1 and CTRL0 looks unintended and may result in wrong data being written to HDMI bridge registers. Cc: Fixes: 384d2b03d0a1 ("drm/msm/hdmi: make use of the drm_connector_hdmi fram= ework") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index 3c407e275ce5..a9eb6489c520 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -153,7 +153,7 @@ static int msm_hdmi_bridge_write_avi_infoframe(struct d= rm_bridge *bridge, for (i =3D 0; i < ARRAY_SIZE(buf); i++) hdmi_write(hdmi, REG_HDMI_AVI_INFO(i), buf[i]); =20 - val =3D hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL1); + val =3D hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL0); val |=3D HDMI_INFOFRAME_CTRL0_AVI_SEND | HDMI_INFOFRAME_CTRL0_AVI_CONT; hdmi_write(hdmi, REG_HDMI_INFOFRAME_CTRL0, val); @@ -193,7 +193,7 @@ static int msm_hdmi_bridge_write_audio_infoframe(struct= drm_bridge *bridge, buffer[9] << 16 | buffer[10] << 24); =20 - val =3D hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL1); + val =3D hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL0); val |=3D HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SEND | HDMI_INFOFRAME_CTRL0_AUDIO_INFO_CONT | HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SOURCE | --=20 2.51.0