From nobody Tue Apr 7 19:55:53 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8814C340DA6 for ; Wed, 11 Mar 2026 18:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773254495; cv=none; b=JUv2CdzyQvSmd3Ufktz6N9tLZwLb9xBavv2DKdjW4SUz34xBQfvVIWDwkRgbImmpZYlEjkibehNaOh5Yv2vUcnkLG53nVeSry+nl6DfvhuzwXMCCVcTMqO18WblRnoDfh/v3gkJ+59/HqFxLdQ0B8IooqlmdENuYqplE0ELeIeY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773254495; c=relaxed/simple; bh=WaRlK6ADyJGwKPeOq+zbAjbnJ8368wyLZLmBoXeDw2U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BINrlYN55b6HOHXQCpxqP/baX2HW01FEdz2kzQ/kJjF6Kd/mWNKjPr5rqXgU/ZiMFu6AFUyw6fFRnjWY+ejaFT54ZXL+wiq/rtzXWPt3+8wtLJ0GCb52JHj5La4nuV1F1+umOkjzXFWWvGSTpcnv37qpTyCiELSq42UAd82NVYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TIAD3pDl; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TIAD3pDl" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2aae4816912so1828155ad.2 for ; Wed, 11 Mar 2026 11:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773254492; x=1773859292; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Jm6aBQFmhV5MNb69YAxeMe+wLv1vCAxTIamZijo4ixo=; b=TIAD3pDlIeZohwSLvtm8O/nh9AjPXLyTD4sv8EUvGYq69UxHxcy1/5K4NohILBremJ gVrwizfFnoYrLYUj5AkygbCd58Y46qDcbALsRPhHtFsuUFwWuu0SNwz55cYUMCieiaIF wmDyujHKhWhVLBrJ8MIPDVjpqHUIw+4b+Q99peRzEJFm0UK7BRH8ZCqRb4AEkJuLDF2v GYBlM9qhEyLFjFTOOj4CEp7HVGtGrBQYeG7hBLKiUzRTgBfj2x38dLkGqEi7M8TivfgP yq1wycsCH/6qJOBxy+aZMQeBIV1gX0wJNQqYubRzRvMQ9Z1qgIupOco2w9RHNvCuJp8d XDjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773254492; x=1773859292; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jm6aBQFmhV5MNb69YAxeMe+wLv1vCAxTIamZijo4ixo=; b=euoBRJq5DcmQBagzp54VAavvYKwz1XASJaNj3bmk0ag6+UAWcmFrUGjItwLNl+ibwR R7nXESRhGrUWRyYsgF1TQH+H6LQM3F3ydluem6l7zRVV1cIrlDBAozJ9nLRRH3LEHmwe nD9AiG8nKV0m+8GBsnACzU+hoctB51ytJgpiONmek3/rUxe5/VBUHQZleQum8Uvo5LoB m5lEPQSQfBnfNNL+WOs2pTXGPIGBI3btriPSpFWhs/YFjIVepflP4i7C0zn/8SfgA5M8 FXZWdvgrLYJ80ii/CFcPXH9QJPRUFozDGv5Q18rHGKe9ZQwyb//JlVoadpUl5vO7OHri YVbA== X-Forwarded-Encrypted: i=1; AJvYcCWJaHAnkBoESzU4b+Ojf8zt78rN4sCqKUTM0XEUz75m7Tfdd2fGrZQWI81Qv6s7SBAfE+2je4i+bGFlP88=@vger.kernel.org X-Gm-Message-State: AOJu0Yzuwl0edZjuQhSBSeD9TXyg0yBDFtyaQ6OpsCvRuCKJTW6l9lZI e3b8Wf2fuwLjyXgA1hg6iWXXYknfgNjoQ7roOxQF59cmKB6j7Wo5qIEq X-Gm-Gg: ATEYQzzu/Q1mMubmZjAGC16n4XkilC/LK8JwARzBNb0v9LLyu9N2F81DKv7Qe1CrpIy F/LM2nbuittVI0izmR87X+hANUnxi8Ui80/YEs6mibnXjlwDRSIac3/joiGJvUC9Qf4OTr4R/WV SiJPGzv7vJeQBs/hZJPBUI9X0rMyYxmk2bplUd9lTDPp8HLtIehHPg9Ye5RloZvkQSMHMDGiJIK uNfhA/W2EDzCRf5yNCfgiDXoBBw+P4evzzEPm4IvN+K+lcaocwbZMbV4jQ22zf88IlQ415UX4/R 4WNY32hXA/BIAYpysQXm7ilzCqMKV/fAGUsTAlV/Gb7fkiOBpazfgZZLitwAGm70yVyz8kZYRIZ jrOtG9i9k4JQv4+PGoSlWassIn0g2ALvx2Cpwr8yCuKcLzW6eAaKlbuR1hzJI6fdzA1geeDMgb7 y1I6I0qZWJv7EwiCdeZEwlgZGGQ36ZirjGZgLmbb/TikTp X-Received: by 2002:a17:902:ef4c:b0:2ae:aba2:f915 with SMTP id d9443c01a7336-2aeae7ba3b6mr37880165ad.21.1773254491602; Wed, 11 Mar 2026 11:41:31 -0700 (PDT) Received: from hyd-e160-a08-1-06.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae35f0dbsm30211155ad.69.2026.03.11.11.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 11:41:31 -0700 (PDT) From: Rahul Joshi To: dtwlin@gmail.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rahul Joshi Subject: [PATCH] staging: greybus: uart: add comments to locks and fix alignment Date: Thu, 12 Mar 2026 00:11:04 +0530 Message-Id: <20260311184104.499201-1-rj5547884@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The spinlock_t and struct mutex members in struct gb_tty lack comments describing what they protect, which is required by the kernel coding style. Also fix the alignment of the wait_for_completion_timeout() call in gb_uart_wait_for_all_credits() to match the open parenthesis. Signed-off-by: Rahul Joshi --- drivers/staging/greybus/uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..52a84a68049c 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -50,12 +50,12 @@ struct gb_tty { unsigned int minor; unsigned char clocal; bool disconnected; - spinlock_t read_lock; - spinlock_t write_lock; + spinlock_t read_lock; /* protects iocount and oldcount */ + spinlock_t write_lock; /* protects write_fifo and credits */ struct async_icount iocount; struct async_icount oldcount; wait_queue_head_t wioctl; - struct mutex mutex; + struct mutex mutex; /* protects disconnected flag and device state */ u8 ctrlin; /* input control lines */ u8 ctrlout; /* output control lines */ struct gb_uart_set_line_coding_request line_coding; @@ -318,7 +318,7 @@ static int gb_uart_wait_for_all_credits(struct gb_tty *= gb_tty) return 0; =20 ret =3D wait_for_completion_timeout(&gb_tty->credits_complete, - msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); + msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); if (!ret) { dev_err(&gb_tty->gbphy_dev->dev, "time out waiting for credits\n"); --=20 2.34.1