From nobody Tue Apr 7 19:54:45 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55AE93E6DC7 for ; Wed, 11 Mar 2026 18:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773253318; cv=none; b=oAf8RqnOglFjXfHdmVGE0io70TM5buayULKFmvj/3fudUR/irBVYnSn2Lp+VPJp7wZVzUwHPpLMXhZGRDUFpCLYM77GBAfAjoewk8xdszy4QJzysXCFJgY3P0t16OPSC4iovvfmZ04wjlrdvTzayWPQUrA2/jxPcs/twYXr3OJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773253318; c=relaxed/simple; bh=MFgYY7643GUWuqoTdmop0Qb/gEDZtoEx/qcVezAWPvc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CJLanG/Nrg6AK6pidvsvmIo6alxtSdyLG6kpidtUBRu8BMjJFHpLxuTk+fI/FMCMFIgyBBLU3noPi2FPllhuPWX6HAfR+rMBAUc5LLoTx7AA7rkJYq/y3w/Uq5ONdqtSSagZ0kKZacsfQJ2r7DV1RCLnfng+Jgrttnj7H5KSD3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ERezV393; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ERezV393" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso1279675e9.3 for ; Wed, 11 Mar 2026 11:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773253316; x=1773858116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/8pjK+lITqFvqVmVlowmWtOmjb1H8Ha6m3w9r5dFPrI=; b=ERezV393wWn0KJLxNOjLJsU5JlexAeu+RgemxuJ9W7BEBlGxTKLcM7Z2JTy8/i56G3 5t1Kn8KTZs4p+T5V9rSxJlMRmDb6BTOgexNNlWCrR4RhElOD+HBaNbTpD0rFg3PRQtHz enmSGqOnbuLMpd8BcJS67H5bOaj8X/yR4SuBftiYv+xsgNAiD95JzNhnXRJCPfgzx5E6 nAFdutA1dG5uUTo782l1IqoADJTVv7sXr1RmvqtUCTkF7vy+6YHOCp922vO7mAO8J2CY uOYknfu++Vf/fPFp8DN+u+QVornNttzQ3FpgtPsT2f6Tj2p4/SHftA0O9G8FSDmXTMDv vk7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773253316; x=1773858116; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/8pjK+lITqFvqVmVlowmWtOmjb1H8Ha6m3w9r5dFPrI=; b=i3ajP2S/u0zKuiF6YmPLiSB6tVmr38LF0nJfRTPbGg5k7i0u96xHInIwSsZxa1Y4sZ Q+3voD0qD1hCQCEDL1JOm/QOOD7i1DGCsNOQtA0K6I/MLaRGfCwIyWmkrNkmwuDKxtQp /WpFigUb7h3kuBtLzwWPKIqyI7g+qNCuUPKIJwIgNmOrBIjulhJhs8tmD79JDCTbetQq Ha+7aoHGQKEFdeAmqyBJFZtPb2s8hSBUVRTrNURUJNsSFF11YXDqbrULBgnlpNYgppEl 9TnWMii1L43uQyyY6aY/lGVHLIsHalS7xEPqHd7dAFzQBBnLdQfhFOUKFZmz40fHkvqJ Ixlw== X-Forwarded-Encrypted: i=1; AJvYcCVzN1R50D1BjOSJJTpbV63vFzUNQ6GIKdM2Fp8k5uqqkKcq1jdQ9/4cOBDO2gRCs/92u1csygpT34zd2r0=@vger.kernel.org X-Gm-Message-State: AOJu0YztEi4ooG8LJdKWmjshYhj0qBJY4LfPpxOWKIU7Ux1PLMjpWsvp 8RYRmhrATdUnvErJx39PFDAv6z/4q5jSBfbFDIs5hrnmybmvlCwyuv3c X-Gm-Gg: ATEYQzz0keUS3u9Wqxlrw2HO4N3QmKnoCs0gbFy9IE0xtwy2tqjG7i+Fu7ViP/0gZR4 5lzTn4iNc+D6wKAJmN0bIc8u7wvxqucGeMn4YSBZuRWCYcW90pEMpQUkbWc8Px09Ku4Nk6exfwS aladHfQR/jLczum7qHQ/TG2B4bRDvBSFmxcVQzKVprqzAdujyzMSBL0NbJo4x2xyv1VKSfvCdyH tTp9oOQM2n5NVteA6QF8fWemDJZiU9ce42C35Lh6r/7zk0fZn/MeeSPmBjyHjKwjodCFDX5XAP1 KBU0i0rZef+8bSqnXCRH6ZsTyQsU0ej4o63AbY7U9W7EURj0jq/LrE0xXsDK/mP+hBVQBSrDJwJ ruUWIZGd60MYX0oweovkIieDwZsNz4h/GlaSfG2doPqbylJ7dbwZzolypZa1nmCRkC7LEdgoWAp 14XZfpb7an0TyswfZrErthLFAJXNlNDsthIBL01O6lep2XzKErKyqBWfM= X-Received: by 2002:a05:600c:8b38:b0:485:3fc8:de9c with SMTP id 5b1f17b1804b1-4854b0be1b5mr63417565e9.12.1773253315564; Wed, 11 Mar 2026 11:21:55 -0700 (PDT) Received: from Ansuel-XPS24 (93-34-88-122.ip49.fastwebnet.it. [93.34.88.122]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4854b0b95f4sm39063925e9.5.2026.03.11.11.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 11:21:55 -0700 (PDT) From: Christian Marangi To: Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: John Crispin , Christian Marangi Subject: [PATCH] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical Date: Wed, 11 Mar 2026 19:21:42 +0100 Message-ID: <20260311182147.30266-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: John Crispin The XO clock source is always-on in hardware and cannot be gated. Without CLK_IS_CRITICAL, runtime PM of downstream consumers (such as the CMN PLL driver) cascades a disable up to gcc_xo_clk_src, causing a branch status timeout warning. The IPQ8074 GCC driver already marks this clock as CLK_IS_CRITICAL. Apply the same fix to IPQ6018. Signed-off-by: John Crispin Signed-off-by: Christian Marangi Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-ipq6018.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c index d4fc491a18b2..6943dc511534 100644 --- a/drivers/clk/qcom/gcc-ipq6018.c +++ b/drivers/clk/qcom/gcc-ipq6018.c @@ -400,7 +400,7 @@ static struct clk_branch gcc_xo_clk_src =3D { .fw_name =3D "xo", }, .num_parents =3D 1, - .flags =3D CLK_SET_RATE_PARENT, + .flags =3D CLK_SET_RATE_PARENT | CLK_IS_CRITICAL, .ops =3D &clk_branch2_ops, }, }, --=20 2.53.0