From nobody Tue Apr 7 22:04:29 2026 Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61481A6831 for ; Wed, 11 Mar 2026 13:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.92 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773235953; cv=none; b=hJ6ziNJDkflafyiuoRFWYu2U3CrwL/EI7E9yHSc/qnHvr4q2o4qXFTkPbzXhuO0QKisM2AM4m2ZzcW7RQy3wCKVg4BNc4vywFR0uIHxxxTa2mC5H9ROcXngVbITKS/rFFtz/CXcjtkGMUGDKF4W7FJ0oen3Fy07rKUNKPuMUF1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773235953; c=relaxed/simple; bh=2gIvixmJ3QB5o+6kZyDlNWB5Y19C6XyVkSUKmBYXnOY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=fYIhBU0T9xVoUJl3TIq8THQF6bZPFHLSeS2TOwEsyjYBrxTN7yGV/YluxEXC+F++Sa8aYwsRUAYuokd+ZoPCNCmBQ1jaWnLf5j4GzLQfDkjV7+nn4pxBEbYVtx5358TMWV2y+pcD7+JPrTAoQyvwh6iU/SmW4UrScXPDgSeSsec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn; spf=pass smtp.mailfrom=smail.nju.edu.cn; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b=WvIiHY+m; arc=none smtp.client-ip=54.254.200.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=smail.nju.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=smail.nju.edu.cn header.i=@smail.nju.edu.cn header.b="WvIiHY+m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smail.nju.edu.cn; s=iohv2404; t=1773235930; bh=nue+qzPo4qG7NNzBxMSw/JyTNDP379Ume26FJRqcLIA=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=WvIiHY+mctGbw/YFOfXdRE328D3HMbb03ZGGlHM3hATap4jpPWZl2swdk1FFA14lJ r8AIj8/09gXXEMDyxWi8X5iwj0yo14Faab3oXaCfNZb7/c5jezeK2NwxQ1OZ892Qsl d5ySuVVlqIXCH3yAzgkTnHr8/Z04geQPaqlHv12A= X-QQ-mid: esmtpgz14t1773235918td265877b X-QQ-Originating-IP: Sjg5GRpehjMhjW7R+H5sozHhXDewFonGnwPMgAtMDRY= Received: from localhost.localdomain ( [116.172.93.199]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 11 Mar 2026 21:31:55 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 18182196931313005747 EX-QQ-RecipientCnt: 14 From: Kexin Sun To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: airlied@gmail.com, simona@ffwll.ch, linux-kernel@vger.kernel.org, julia.lawall@inria.fr, xutong.ma@inria.fr, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg, Kexin Sun Subject: [PATCH] drm/i915/gem: update outdated comment Date: Wed, 11 Mar 2026 21:31:53 +0800 Message-Id: <20260311133153.576-1-kexinsun@smail.nju.edu.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: esmtpgz:smail.nju.edu.cn:qybglogicsvrgz:qybglogicsvrgz5b-0 X-QQ-XMAILINFO: N7PSPozZml7Xh0smo3THWb3Mb1xlD5g9momizmSzjcZ864mOL/z7509x BC9ZAhgkiSN0xnUQVMyyzNj2VGBIMirKpS8LYNTOGjL40WI7d45pGqbW9zyCEJSh5vCbWOB 1SCBebopDP0LXJWu6Xa6FFPe+SyudyGnhb7GC9ta+43FT7YbzvQ7DrFqgfN/4uSxlOLJZOe vKOn18/+pOxX5lOAAKsOR8MvaVMA/XFTy5Q8QxSbMhfmBZOJQ+kKOynxLl7OkAXd/ge2lWq BappKlpndNdhGlFHmRObFYnZpRWgIA4u6H+58fieD4dIR+yYlG0r6F40iZs3hs7u+tFslTy MU7xv2ritKHQTOBBUHzTtJUcIb0Q8XEw2uhdNr3GhfVEBMaYMwv/a/JgzQG5msWaPWsonjA yxYd396oDRskgSExeKIR/3eLrI4FNqeWd9z/DoGBIGBpjFlZEakySCrqo5sWvJTmWKNoudp 168KyuSBoi7kYKKb0OynNZcFBCdvLSH4ADIyRwwRw1h1eHau5LO5WIuSrcpQMmSlrNyvPzC g+IryuBCeqmWQhE4ERCznReJAmZ8QFVVLNrjV4jD7XnHNXTVFsRwezEOrMAwfAnezykN4XR N3QGXJ7rm2KBUiq4sEY4YYd/f5RqLgU0UnF7GdmUiw/6gsSBqi2v9ZL6OvlwwxiCthOfjMr 1GtWwgQTKr96mM9KJv5zz+G9vTg1rwjHQ6bLsaHymrMmIQMjnQ7hu4eIvz7uhWrlIQKk0Oh RH4BCak0W+sV3BfBQBcStcUtIUtuZ6DuMEFUwX7E2pIc2uYNwzD1qC2VSrHdjSAwvfSLCm/ xdj4o6fBNOqp7CNRKHdYsAJgIHQKdd0E8YdW9gZJxMUnHsTyaFhN6Cp9nIigx13rw7NT2Z3 gCB26sKl+8r7aptWGasmGwQbA6ku1UNUJV413deF/DgwGS8e9p8eUiIdGcQ0dQbWZh7PU+e RG7RGsbt7o851vEosjIqvc4SehikDL8kny/R2gEAnGgUDBfE6bbFzs2/rc/1/MpcQ6+0rSh 45sVfmRcjx5T1CHKgVsB8hrbDya9aYnCUo1qAggL4C4+WXIo7426oIkzWoq+qjn3y1VjX5a iqhEJ6zfUt3pz1W/HDk142BA8WeNPHaYpCfiFboBRtYGos8GINtkIM= X-QQ-XMRINFO: M/715EihBoGS47X28/vv4NpnfpeBLnr4Qg== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" The function set_engines() was removed in commit d9d29c747df8 ("drm/i915/gem: Don't allow changing the engine set on running contexts (v3)"). However, concurrent code paths such as i915_gem_context_lock_engines() still access ctx->engines under engines_mutex (e.g. from execbuf throttle), so the lock in context_close() remains necessary to serialize the engine teardown against these concurrent readers. So, remove the outdated reference to set_engines(), but preserve the serialization reminder. Assisted-by: unnamed:deepseek-v3.2 coccinelle Signed-off-by: Kexin Sun --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/= i915/gem/i915_gem_context.c index 6ac0f23570f3..958e3c822948 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -1516,7 +1516,7 @@ static void context_close(struct i915_gem_context *ct= x) { struct i915_drm_client *client; =20 - /* Flush any concurrent set_engines() */ + /* Serialize against concurrent access to the context's engines */ mutex_lock(&ctx->engines_mutex); unpin_engines(__context_engines_static(ctx)); engines_idle_release(ctx, rcu_replace_pointer(ctx->engines, NULL, 1)); --=20 2.25.1