From nobody Thu Apr 9 05:47:46 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 339D33B19BD for ; Wed, 11 Mar 2026 07:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773215565; cv=none; b=SAYNS7tZUgg7zczHkZvO/IwCy+t7NWvKXQvnZJgtz47aNe4fxFujQZOsgHl5cxqbr6Fv9KDS4/yX52THqUYxHdZaR+Wb1a+87f0vxMXQ45x3Ss8ABW1arvKWjacRrw8hZ6CBJiH9kyJ4wfAXxtMzQmMCNUCmhETABrqiMAUi3ZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773215565; c=relaxed/simple; bh=sPilm9ruKuGewnbtA2jeOf/ucQBHTQeO8HOZykuVTW4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B3Tbas0wR2zTeT9BqvU2bKzKkKt4WDLfE8svARi1Y1CSzmw4TKlSuNfOVEPvNsoHfDAtDuTFQzIxiZUFix1XWLjtu1OY2JCMY8ah8O5Yzs3CTMRiAUwraODf8HUEQ2Cm/QC8yskKZ7pTQfvr8IV0dT5h7bIKB9yMcY7EW7kMNB8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=KUTXKifN; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KUTXKifN" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3598e065d8dso4931883a91.2 for ; Wed, 11 Mar 2026 00:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773215561; x=1773820361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J+k9XHKdzt+xrme3N3sFqf/9kOYEeHBPbN54N+TXv9c=; b=KUTXKifN0EN4MXdtqWurTjBT3qZYN7KpokOCYyjSsToUDlodCiVGllrKATvm/s2CDd ZKTisK0kZVpZ7NEkdP5dPH3+Fe7eSOWyOgcXdaTyKXcKCsydokZXk0i3aUg16bSQcC+m Ib+zben4FB/frmvJqDa+83ULX6H+h5m4j5y2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773215561; x=1773820361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J+k9XHKdzt+xrme3N3sFqf/9kOYEeHBPbN54N+TXv9c=; b=fnXM0sY+7skQcw2Jj75VSLJourBQKR6vnMETcsXPoxNS2N/v9+J3t1I5OcrGIR9Cse QEtipKRbfxv7QatLNZUIVZq3SclgO6+4iy5tdPBb4BNiNTcqkZv4Wfmnp6gK88zOBnaw EJ8Hf5Zs/n3EBYqGxn84LFlHghz+7PHmCIOK4yPOZAzIOymk2Ut/jzvujycRIlHgSJ02 o8Iy0Uk8lt1/vJ1v9tJ9u92RwJ2xosJeRjM+7oeX9hNt7JPExK2KUdJAiqRO2cAQxF4I 5et4BBCM6bAQu1dH3rDfd0iWJjWnL9GHIBUjMVYRxl8eGyrANk8Zy5jfPxcyL0gW6ghv 3LVg== X-Forwarded-Encrypted: i=1; AJvYcCWbKu37/OYC2Bd1qs9TIa3jET+jCQY1fNi7yaE/Nc3Jm7aT4T6hTDF0MoIwmx0ImixSkRP9zReO89+7Pgg=@vger.kernel.org X-Gm-Message-State: AOJu0YxCN0mrKqLUHV+AEIHp9/OEucbTDzJFbwQzjSOVmN7tXGBnKOdE ema5+IkZnpQcKDcOsvdNqULBnU/2NSXvp79Z8zlu5p1vefQ45A8b4ZYLm5hBGV9ZiQ== X-Gm-Gg: ATEYQzyQxV1CASDR+HjquG2xUDefdH0lSmSnCSF+xB+vvl5UvjCi5pknpBtGkurS2dg e4eKrQxG9JO5blVZKlA0ZI8y9RYPGTjwexAB6nlwsLitBev4WxjHJtuEQy18cXf8p7EVX+iuwDy KV+zKDLCvQNxz0MJHpQz4hBj997gODxLCq67d4yjpPi+gbcpYw0OA3wlQ1bU0HGpraoE+fzwoaj z/Ey6dwaglZ+tHVTlboU6Dz7zPCqHGY0WpjqUaPkWVrGW5L8CoU4ViZTZ31YcqjmORprgZLwjZY O/rSm8+hWNWCp7C6pWiarOkboTx2nqYNR7mJgpIwepoJYa6eiB1HaT1DV8PKxyDy9bidQC2Vohk ZEOFnjc1tTjD2ENhJhlV6YcIf2k7j0GtmTRqYiAd1RBHHFzLbbqWlzaenzMqimTflNLKRnK21t/ SbHrXxTNpJHyLSQbrv2EDW13Bsz2oREC2r/LfFeVBpM95KQpgRDTPH4ULv3qSJT643vtmS8xoOY oKCLma9 X-Received: by 2002:a17:90b:3d01:b0:340:66f9:381 with SMTP id 98e67ed59e1d1-35a0121613emr1654777a91.10.1773215561374; Wed, 11 Mar 2026 00:52:41 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:805b:14e9:f783:bcae]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35a0236f79asm727816a91.6.2026.03.11.00.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 00:52:40 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas Cc: Chen-Yu Tsai , Bartosz Golaszewski , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v5 1/7] PCI: mediatek-gen3: Clean up mtk_pcie_parse_port() with dev_err_probe() Date: Wed, 11 Mar 2026 15:52:16 +0800 Message-ID: <20260311075223.3303497-2-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog In-Reply-To: <20260311075223.3303497-1-wenst@chromium.org> References: <20260311075223.3303497-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mtk_pcie_parse_port() in the pcie-mediatek-gen driver has a bunch of if (err) { dev_err(dev, "error message\n"); return err; # or goto } patterns. Simplify these with dev_err_probe(). The system also gains proper deferred probe messages that can be seen in /sys/kernel/debug/devices_deferred Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam Signed-off-by: Chen-Yu Tsai --- Changes in v5: - expanded tabs in commit message into spaces for better formatting in git log view (Bjorn) --- drivers/pci/controller/pcie-mediatek-gen3.c | 36 ++++++--------------- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/cont= roller/pcie-mediatek-gen3.c index 75ddb8bee168..1939cac995b5 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -876,10 +876,8 @@ static int mtk_pcie_parse_port(struct mtk_gen3_pcie *p= cie) if (!regs) return -EINVAL; pcie->base =3D devm_ioremap_resource(dev, regs); - if (IS_ERR(pcie->base)) { - dev_err(dev, "failed to map register base\n"); - return PTR_ERR(pcie->base); - } + if (IS_ERR(pcie->base)) + return dev_err_probe(dev, PTR_ERR(pcie->base), "failed to map register b= ase\n"); =20 pcie->reg_base =3D regs->start; =20 @@ -888,34 +886,20 @@ static int mtk_pcie_parse_port(struct mtk_gen3_pcie *= pcie) =20 ret =3D devm_reset_control_bulk_get_optional_shared(dev, num_resets, pcie->phy_resets); - if (ret) { - dev_err(dev, "failed to get PHY bulk reset\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to get PHY bulk reset\n"); =20 pcie->mac_reset =3D devm_reset_control_get_optional_exclusive(dev, "mac"); - if (IS_ERR(pcie->mac_reset)) { - ret =3D PTR_ERR(pcie->mac_reset); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get MAC reset\n"); - - return ret; - } + if (IS_ERR(pcie->mac_reset)) + return dev_err_probe(dev, PTR_ERR(pcie->mac_reset), "failed to get MAC r= eset\n"); =20 pcie->phy =3D devm_phy_optional_get(dev, "pcie-phy"); - if (IS_ERR(pcie->phy)) { - ret =3D PTR_ERR(pcie->phy); - if (ret !=3D -EPROBE_DEFER) - dev_err(dev, "failed to get PHY\n"); - - return ret; - } + if (IS_ERR(pcie->phy)) + return dev_err_probe(dev, PTR_ERR(pcie->phy), "failed to get PHY\n"); =20 pcie->num_clks =3D devm_clk_bulk_get_all(dev, &pcie->clks); - if (pcie->num_clks < 0) { - dev_err(dev, "failed to get clocks\n"); - return pcie->num_clks; - } + if (pcie->num_clks < 0) + return dev_err_probe(dev, pcie->num_clks, "failed to get clocks\n"); =20 ret =3D of_property_read_u32(dev->of_node, "num-lanes", &num_lanes); if (ret =3D=3D 0) { --=20 2.53.0.473.g4a7958ca14-goog