From nobody Wed Apr 8 02:51:51 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C2E134D390 for ; Wed, 11 Mar 2026 03:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773198182; cv=none; b=j1jFsE70jCHdlNl+1XWuL/3/auM98Yx1SU0spDBN4mW3k3AGgUkvJDVGvJ/ltZz+sRBOS1V0cejobGbPZfWb/DnCes5Fh3/Q/2ADDzQ0ArGcnPzj92Lo93QsxEJfQdb1Sdn+FbBeT6lz8K941nPCs8Hmn1xxUXK0icS7akFsNes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773198182; c=relaxed/simple; bh=bCr3faLzA5fDRoom0L80CxJO5ve40rsLpjNa5vvSbCc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cXJKibj3dzNMgBtXgaukovKNVPggX1+L6QPWEL+ffudFBjmuVbvrB7+lBF3/+BcgLiqwJs48thWXr3VxFZH6smCwp2Co0biw9JYCsqRKltNuf78hBC+vOi3iBQZ+BOYxKug+Eehr4x3ctFh3QFvwZk+aeiC4RkPXBsstHOrIBgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com; spf=pass smtp.mailfrom=shopee.com; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b=EItdXMFr; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=shopee.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shopee.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shopee.com header.i=@shopee.com header.b="EItdXMFr" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2aea68839a5so3918065ad.1 for ; Tue, 10 Mar 2026 20:03:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1773198181; x=1773802981; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ly1IRsMskN9R+65s2IxLzpzlj0ryymd9c9VwDaOci84=; b=EItdXMFrUuwYvrvppxEZDj0kPZnLfMEXmTvkPScaKTvCjmooW8WzYHHWEb671y0k8O APwhCf8aXw/IjDlBzm9bDMhwM3DG3MSKfHlgnnqoU3Un1bznjyDkRpheaRgqz+qSWjYx IOxyjBquL+SC3eyXm5B+42in7xHgsGBwixfkLo3l+8KQcuV2+NW0SsBOjiVIOC6U8Ie5 MIJ/FIasG+FFX0XaYB/B04fBBnf4pbjfrtNm/iozO0f8E0C2gw5KXkxB2x0H8+yHFnjD jRecv8dXQLf1GkpARC8E2N1lZ+G1QN4AolidJpkudTqhcSZ+L9VeL2ur+sEdD5R8WGzR QTyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773198181; x=1773802981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ly1IRsMskN9R+65s2IxLzpzlj0ryymd9c9VwDaOci84=; b=a7er3Pv+ZwfxgUQFMNtgF7H1fbegh4HIlBAxH+IdIq7+8p+nEQUustnliF3WVE9X1U trmmdH09FW2BeTCrZP5fJkxhm3xbNIMheB24oGKRX19OWo6E0DQOEvV3qsfSBjTzqKWj TSl1CDASS9AX6+BObCZzk9vfRp/y2vXvaDXC8/R0MihJYvumm+Q9obhfzKEzdJe3wXvk 3Wil4Iru61aAr7qhySxvHEYf6LIidFVSNzWUcgKdG1N5YIFEbxXdMHs/9a8aR7ddYFZq zGyZY2D9Ui6Lf0+7GkTmgQVTIOn4zYOWEIdRKGw5cq4k6AZXhkOXmPaiR9TVZGxFH/rb vspQ== X-Forwarded-Encrypted: i=1; AJvYcCWHQknZCTBAWzhVHDAPt8nVY7fAMhaGwbpYSQr2u1cS8Mn/zDNEpBtv9Ems+jP3raAS5uQVBTJxVFvZhfg=@vger.kernel.org X-Gm-Message-State: AOJu0YydjhgQd37DboP+hVH7IWpcmxqKPlPFnUmZtXre6UCtfkgeQKCO mepKrcD94qW+SlbmWzvDBs8Jk0/JDBWgGf+z4qEX+rjRgM5Z4XzrX5OV7NEkAijedbE= X-Gm-Gg: ATEYQzwQ8mqWx+aueFUESdD4Uk6dBbHRHFsdi48ZUab8yWMkQMfrfCGwgURy0V5cFs0 OT7rtNMTJj/yMpWGryRuDV/5zRiT3pYICVWQYud/BSThQA738I8pmrlhFE/xDdMgurhRKZV2sfM ph6L0DLRz8389VsfxzHQ21thYt0P6CkmBBPo69ADeKy+rLnldhSt64X9Ocnafzgjyrk7+pyqwGw 8FuoJBORXQ1+Ux7nNg2dWepc67R6Fk4Xafj+br2xHt++jvI2nRzWfT9emb+kP8KZBdEIKSF50gA WvhlyuLFio1VTLxN5pXS6tkI564RNoB5xK91rFcmi3exVkPfuowCbajVXBMX6bgtOA58TvbQQo0 ahMxAk0BuE8jMF4UPPHxbbkL7dhbroYvou1hM3HVTZf7b4n8u/qsBSnocwzkGnxdkNFVwCbGXWR WtucmVJzYbcA++i9uEeZeZzHg67XGaQfpVIRxkbA== X-Received: by 2002:a17:903:41cb:b0:2aa:dad4:dfa2 with SMTP id d9443c01a7336-2aea1de84ccmr61348405ad.18.1773198180714; Tue, 10 Mar 2026 20:03:00 -0700 (PDT) Received: from localhost.localdomain ([147.136.157.1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae378974sm6251555ad.82.2026.03.10.20.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:03:00 -0700 (PDT) From: Haifeng Xu To: akpm@linux-foundation.org, david@fromorbit.com, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev Cc: zhengqi.arch@bytedance.com, muchun.song@linux.dev, usama.arif@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH V3 4/4] mm: shrinker: remove unnecessary check in shrink_slab_memcg() Date: Wed, 11 Mar 2026 11:02:35 +0800 Message-ID: <20260311030235.240953-5-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260311030235.240953-1-haifeng.xu@shopee.com> References: <20260311030235.240953-1-haifeng.xu@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If memcg_kmem_online() is false, only non-slab shrinkers are recorded in the map, so remove the check. Signed-off-by: Haifeng Xu --- mm/shrinker.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/shrinker.c b/mm/shrinker.c index 3137518bc746..98307a9bd00e 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -639,11 +639,6 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask,= int nid, } rcu_read_unlock(); =20 - /* Call non-slab shrinkers even though kmem is disabled */ - if (!memcg_kmem_online() && - !(shrinker->flags & SHRINKER_NONSLAB)) - continue; - ret =3D do_shrink_slab(&sc, shrinker, priority); if (ret =3D=3D SHRINK_EMPTY) { clear_bit(offset, unit->map); --=20 2.43.0