From nobody Wed Apr 8 02:51:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 912EC36EAB7 for ; Wed, 11 Mar 2026 03:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199416; cv=none; b=U3DJwmhh0khmZOMbsvmOD+sd8wx1yDGATdznE/eGNP0paOLIhIi8mUmcv8pzp0v+97put6UIt/nyRoWTvnjbRmqDdMF0B/fXQA1v8ApT3U+4VqRemyNes99ffvGK67bcjg+levan59wsj8p2WYJUY19E0CUjsrZKSTjeh9hOfcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199416; c=relaxed/simple; bh=wXJJ0dAZpKF1rU+9v2j++kD4vXhMZtkbkrtjqNCMm+I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HonPE+UajK/WfFU07sj9F53XbR9cVCZt8T0YLdiwTiAACRM/9h/lOm1LzunWExXh0SbeHvDoSObyHfQ01jrbmLf2j2dLlVT4sjhFrOFIjx9PExSpAaGICIkpnWJ2DfDWWKLhcmgjBTCur883bQFKs93J4m5TcAZj1k0QWAtXWas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NiwBQHBf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hajwiR7T; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NiwBQHBf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hajwiR7T" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62AJODID3417778 for ; Wed, 11 Mar 2026 03:23:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nJxnxNjXEHAomyQpf6dxP3G900o6a7htory/+Plg2ys=; b=NiwBQHBfujfdlSs+ 2wk2SyMCW2OhIC02hPtaCwJHPhXgsFV1FeWWkSfTZyA91PhOoHiEG8Ut8LB3VemR qzfYACJT5sXdkaQ+kngHMAF8aBa3/aMHHIqKudoDiL7xVnsVzxGsziwEjzNzBfUI Wg+ehUMzaJZCkVCXJRN8eTyynCGcsxhTGNLBJSUuvaP0o1GUihAZZKdOzOFcdR8f wjJAp0Rt76aaNXcemM9a+MjbTDLXEDhhpjfDpRyETzFFp30GjpU1sVZ/3WlB4M3Q 3sb2KhYQv6dg363V3YBdZHZMqTjZgQiAELUq6NBag+rFXwBv+0JcC7tNuM9J/3JM OiWtGA== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctja2b61d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 03:23:34 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-94e99ef0150so5047426241.1 for ; Tue, 10 Mar 2026 20:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773199414; x=1773804214; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nJxnxNjXEHAomyQpf6dxP3G900o6a7htory/+Plg2ys=; b=hajwiR7TvdfKqhmLvQOfhN0anweM9AelUOkzTvcBh5CNwZQirvVh2kny7+aAxQPcL1 1XG6JFLAReFhNN/kSlLrc7IIuiCMivfoYe7UIqNk/aZBpqqSD/Ub1fFYe3aq1DDkBD/F OvQIgCBAIw4gsnh4v96mcFHpo50beUp50SnPUsRhxFQ8LPzum92XnQHK6UTDxc7L9JpN iVSahrPz9ykZHxj7rwfk1p5zLYEhJaEAbhsx3s5TwPojd7IHbw9O6eoi6eNRpG4H++qV MqzsuOrQv8tXWL58jAMGq05otrMXjEeYXLuIxy+/Flq+eyZ5Noaol/sflhU7JLdMpgqu xttA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199414; x=1773804214; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nJxnxNjXEHAomyQpf6dxP3G900o6a7htory/+Plg2ys=; b=qfWjXEv/D6kYr16GrYE4JG91JNGLaOP5lJmEtNMPiZeBHSyD0c1fgODHRbTBSpePsI 934HiVbMcHuXvwLNs+e4vXxqM6PqJJ/330lNg5yhJunzFAkXAlHWg0FtP1Z4vl4mLdyz Vqrxq/HJJ1kdzilBT4v/mK5Y8yt2TbxEHKMfu/x62Mrnf4udeSXtIOuToaqBN60wmZHO 79oU6pU2fvU8HvPDUQhK3/N3Pg6GDoRDj7cydjuw7QNZzsymGe5pq7E5w92p8biRY74d JEDigipq+sYoD6kVKJQlKDobhjet0biZi7HyDzb3QF4iiwsroP5uBA5AyfTST6lVoiUZ AmmA== X-Forwarded-Encrypted: i=1; AJvYcCUrqq4aybYooiFNDONA5NAbw/UE9weZCrGjG1jrQW+j33flqwBKY5FQoRqaWNsjlEQTklLwA7F+oVsl/8M=@vger.kernel.org X-Gm-Message-State: AOJu0YxV5Q19EvzeCHMp4cagLuH2YeDa9GrkSTinEIm8CT4dF2jMU/l5 0qY/7hQ4W1bBx7NPFXEFzHET/wuGcAd1BE1q212minD7x+2nY/Vp/e0FagG/XjNfQDGDjYjBd69 E7XQNbzrl3gm2ShnoHVFK9q8gQpAJ6BqQDxzRpYP2RZXV5P7zrjlBuCSr4gQ+TUR7ACg= X-Gm-Gg: ATEYQzwf0gDRJfWyNXoPSWg0MSpP4w7/+cebytpGlpJ69CTszCb9rvu6hKoh5MNL6jZ RwiUWXmF3p2oDRkoS4J/XuBw+kbEDDftoYVcQjYDQFs5OSm3dKDBejhuKcLx/QBV8eKrjzzyVS0 3e4S8X7h0XjIuEsL6Mt8Oo4hzFLxgyYi2S8uUoXKg8VvZEEgoJRjoESzy+9onWoziIrYI82vi++ 5wRxKgYX0FpM4UY80InwAVACUPbKdJf+KnKEoOEEfoTfLPnWfz1xZfHEow9gyon9frrEWvLKSWU mqVX9gqDhVH/KRSWSodKZAQc6fDM3SPj07pGsGWUwy1fXW8jyRwWGG+gCXooc2w0IxYU/bsIMBx 5RB4coKJrRCWTqLatzMm7o2iv0bL5hRIUff/UOvfe3+KUYZrSZCqP5IFoJQBPtWMAThmuA1swYH YK52XOh6Gbyccm67Z6eygfBkt3nMzeLTu1PwI= X-Received: by 2002:a05:6102:50a4:b0:5fa:603:1d62 with SMTP id ada2fe7eead31-601deb9bf32mr368668137.14.1773199413764; Tue, 10 Mar 2026 20:23:33 -0700 (PDT) X-Received: by 2002:a05:6102:50a4:b0:5fa:603:1d62 with SMTP id ada2fe7eead31-601deb9bf32mr368656137.14.1773199413354; Tue, 10 Mar 2026 20:23:33 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e5ed41sm1422721fa.25.2026.03.10.20.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:23:32 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 05:23:00 +0200 Subject: [PATCH v2 06/25] drm/msm/mdss: use qcom_ubwc_version_tag() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-ubwc-rework-v2-6-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> In-Reply-To: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1601; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=wXJJ0dAZpKF1rU+9v2j++kD4vXhMZtkbkrtjqNCMm+I=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsOAdAoshTUBFF7gu/dmTFUGS5vZ+v78q9e178 17nAHXN1qiJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabDgHQAKCRCLPIo+Aiko 1ch8B/99JWkX0Pkso2rCvaimmcGAFzKsPXaNaGGs1r3r44m4kho81YF8axNq+ATyYyXAcyPIKUV 60g5lTgSj8etZVXDaiot2Fq05qtkw7JnBF9X+lk/zdQptaB/HkB4fS3td+GgvXtB0ydeQ72vgmy hO85TykY/KIN3NRH5ABVsOvP4Q0Ry/DvAZNQqDwo8+9EBftixeirl7x8ox5HXAMIy8hv7kzHSQB fB5yquJCe3/vJ4GzTczBHtWoGkZT3J+uMKBh3+TSDGqxSxXlNNP08SjuGQUQMcDXcY6sAJhwj5D pGDKhyj0bRFUO9qAcHkaBQQJLwtdUtfR8NuQGaqYo88Tcm/c X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=c9WmgB9l c=1 sm=1 tr=0 ts=69b0e036 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Xd8vOn4_dRUKSRNknbIA:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-ORIG-GUID: tynO4Fz1icWMSu17szBztXnX5r73hesL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAyNiBTYWx0ZWRfXxgamIx5ElMt6 tzx02R5ZfHBpOcIvnPfVIDkcF+pWg6jvA56EEeCBp7owHDDUYior5DdF8RLfwnxJFrRpNfP0Hvl lrndVpas9XXGYReiP+O1cWMqT72S0KGKCotuK6Tveattqk3cv8XHBpPWBRIFcsOyNRUyWk3gkr2 1mKlHUiRhpGKp2G+oSj//subQpxTmtAOiRsNhgCYaczc/4qRnEsDlWDvWa+yYkvK1g41hgtcCrR 67O2PrXgkUdSaJWYqEV3s8K8fd2NMAWJ88aBeog/Ff+Kr6ixHL15jt40gWcshu3YvAdySW88nw3 LPkLMTAGbEF/iYwMM1Du/JE+kDeInMNVjIckx7109wg/aDp02nbP8I3YCsO949gJZHX2bYEgQcq m0cCKSpLB8KS46lnXYKyntbIK0SUxFwbrEoAvY++Z7VJU973MGte+g0lcS1/EoU/HPKD1uyJoMW 8VuFbWgpVRaNy5VIPyg== X-Proofpoint-GUID: tynO4Fz1icWMSu17szBztXnX5r73hesL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110026 Use new helper defined to program UBWC version to the hardware. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index d8b0288f0040..497db0ce28bd 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -204,7 +204,7 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *msm= _mdss) const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - u32 ver, prediction_mode; + u32 prediction_mode; =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; @@ -222,20 +222,8 @@ static void msm_mdss_6x_setup_ubwc(struct msm_mdss *ms= m_mdss) else prediction_mode =3D 1; =20 - if (data->ubwc_enc_version >=3D UBWC_6_0) - ver =3D 5; - else if (data->ubwc_enc_version >=3D UBWC_5_0) - ver =3D 4; - else if (data->ubwc_enc_version >=3D UBWC_4_3) - ver =3D 3; - else if (data->ubwc_enc_version >=3D UBWC_4_0) - ver =3D 2; - else if (data->ubwc_enc_version >=3D UBWC_3_0) - ver =3D 1; - else /* UBWC 1.0 and 2.0 */ - ver =3D 0; - - writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); + writel_relaxed(qcom_ubwc_version_tag(data), + msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION= _MODE); } =20 --=20 2.47.3