From nobody Wed Apr 8 02:51:48 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA20B363095 for ; Wed, 11 Mar 2026 03:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199433; cv=none; b=UexdmvaSi2z+d/N/j8DYGfDFkQfa+l2F+L8UxnlXrg5CMwPXASKoSvzppMdzSsRR9IYOSSs03B3BV+GmQehnSENS8z56G8Sct02lux6mDdUxHbzKbnKGzdlxR6+lnl1CN75naMeh2bb3FbmUs3g+aYKJHfl8Wm4p+ZGtO/DWLEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199433; c=relaxed/simple; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NFyWnsp5+ZqiBhw6Cpt2zN0Hmon3yFoXwzrqWuy5mSWudi72IYomlMix7piNgusnnGzoJQLdcR/pNhglcqgSRdSh+zIDyaA9w48n5fHwwecO8yDdI3mOl3Z1JlZME+KyP4RLdq2ITQjU/2ar3PcYmo6nUQ+escg4enSP4F+SZ8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=apZPe43U; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JuEbkW8b; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="apZPe43U"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JuEbkW8b" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62AInSJV3760444 for ; Wed, 11 Mar 2026 03:23:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=apZPe43U8Pl8U+mL ydHIqqJCFMN8yvkO/KJ6xKxDyqHqu2tSIqLZWzg4u337h/0mZIu9Ln0/7X0csQJy 6c7cCPUVd5lGX8pNCGwe0SccSjGFIHMUa2eGeXkv7SQLRlgKo8PgyGMgi+Zluvz3 rO/1Xj8umhM5QPFkc1AjwtosG2I2NxPu/sIlP4pm6T3YUdwXwt0xLgTlfYyzVytF Qa0C2CiTFb4VWSTv+8dttX/aLmfNqvyJANkTQPTugLP4yEAr7Jotkn4rRBvXZyAC 8INrGUgs2W7KHh7+2Tv3TToZWjUPBuoTYMsMf3P7GegmpFmRc1mV2OCMA7/ZLY3+ 5lJ+qA== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctk8uk0f5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 03:23:49 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-94de7380eeeso10323675241.2 for ; Tue, 10 Mar 2026 20:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773199429; x=1773804229; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=JuEbkW8bQsjI/ZCG3D8dSGcI6ff+aviN8s1Eu4LbXTKiqxH1WIH6lkb5odUHY0sUzz 4EhfeWEFxl4eqHOJPRV4bhZfcvYbDOf1JxdYpjwKven6oPe7Gn+l+S+enmj33EbSHIn3 6STIaAkQ4DK+729w1zhS9SzbNp/pD4v9NkQH2zIXMXDEigQTwOEhawY+mm50/3xEptNa 6KlYyuveez7wI4x1lQPXnPGDsDuFttRuI24aeB+NUwHt0IrubszgYFEpsCuhNVqbp/p8 vmFmi7+0MQAA7n7ptnd75wKjZLeQ5GOsrGcuIjAkc9OE+BoMRuaHN0kD6AXBM/yjqs/y qObQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199429; x=1773804229; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jqyKT4W/cNuaTzUqSFqRUV1yQx0wbYgJqqv8//555T4=; b=PKHt5gYklkRfiUNDVExCgUnxJnnM5EqpCA4QSbAngCgJwTc6Pc+JGMQfDMdOBwrlIJ XsUOQKrTMAVznYN0L4tbGzzk/3/rUXlYUMtDm0E+qOryBPTRVfHuZ14SP0gBEBquYX7N oUpgg1KWzq+/irrgitLV0SH4tOJyvSUZV+4/C4eiNxujDwH0S71vFKDFSNAdFCn7TxCP KDuMr73+SSJ0Ax4+hk+OTFJrj68vl8xZNq4T8opAHzkx/ImT4Tzpg4KRxJTS2LYu+v50 QiR99IXJcO1uCPwrouI3Wg52DlyzKDc6aDQC5NvVNU70+gTNI9k/89Hm3imxgLGSImfG agtA== X-Forwarded-Encrypted: i=1; AJvYcCWLyrq90QHRLTrQGZYD81fyb2oXbUiwHfKdIRW1iQhyfGgM1oqqXismN+oABS4uBDAbDsxP6pnLYak19sY=@vger.kernel.org X-Gm-Message-State: AOJu0YwEH76r3+5FlV/CVImY9q8MA0PyW/fEIm/2Rpr4MIgUeUcYc6KN vFYX4PUq0L9uZSBTOHhFew6ayPIOx8/gD9DRqIra5I7OBxawOKNmcWUG99L+9OLI5ELJ2usgZVC smzNg8sLcc7SDUJnmy+nrbcM7lFa9w/0FqxuZhqGVRzgkKKivv9YeRM59Po10rzKE9Bs= X-Gm-Gg: ATEYQzzzW3ZM9IgI/KyuzNgMCmj01UbDQp/gxks2/Blz6Ze/+G4Yj224l0z/g8rERzj O6UrGuTWPAdEz1C8relP+9L9RZcbLPW8nVRzsn41nVEzO36ox6iR1ZZQfs3KE5AhqVI3u+tB93b aSe0V7q6OnxV98BB/QkZ+PRs8EOQsOX2hahmjr9Jx4XEKMIEEFx8d4tn+R75wE1GsFd5YA9qTAK tmSZuzmyvsqhAjQ01MSi0CQxZcfHTJJab7dG8VcccdA6qMNZfuJVXvtZfNPyYrL5017OFo/s4yM l/WJ+Z2Rq7DUICb3dYI7/IQOSKQEUbSOFWKxXdQvKKpr2cueT7CswarEwnFSbQI0TsoOU2DQkvJ CTJAxL4YskL5MjeHDYVdFI5uHmCW9MR4j+LTpSPdebfL9dTK94ErXbkudnqE0BRyNm/CQzYcwaQ dVxdF7XAaDnwo2NntByurxuWijljRTljqEiAU= X-Received: by 2002:a05:6102:510e:b0:5ff:dcb9:9222 with SMTP id ada2fe7eead31-601deb2b6a8mr492828137.7.1773199428948; Tue, 10 Mar 2026 20:23:48 -0700 (PDT) X-Received: by 2002:a05:6102:510e:b0:5ff:dcb9:9222 with SMTP id ada2fe7eead31-601deb2b6a8mr492816137.7.1773199428587; Tue, 10 Mar 2026 20:23:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e5ed41sm1422721fa.25.2026.03.10.20.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 20:23:47 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 05:23:06 +0200 Subject: [PATCH v2 12/25] drm/msm/adreno: use new helper to set ubwc_swizzle Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-ubwc-rework-v2-12-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> In-Reply-To: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2707; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Dp+N+Bk8UMYAX+OsWFRzXnJ6xbH9DAMBa3dOlN5rF0s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsOAeub//VZeYzLSiRPsy3mVca9T9Lf20GUVzD fwQSSSdEbmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabDgHgAKCRCLPIo+Aiko 1dkPCACrAf1IYYTZl95PYbR0Onc4NkkXHJfcQjbyO47fcf5qTMXdzfZwaRwV5yHQ1sprgXpISkm lWmS7W32c3ibD5JaHltliQFkt0eukwfZSBku0+DRfkGRjLiv/L3D2Qllo4FvYzVoe5Wr4c0TqPY 61Bu+tSP/Pgzbvpivu4Cojejo2nRqgiv7h28/yzvoo8Z0zKNOhSf9d+tn8OsgVpjNjEi2dSzZ0F S3TT436BdQFY4fBVhUJyqCVfMYL3gJcvkPIuoNqViNikfVggmMau9g4DC+nsDw3DTAL5P3EoJxH LnidAB5JalxfOl6WwpZmBJUC/O95iPLOQKkoCvrUBUTtm0Bg X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: t3fD9h9ua-eKUueKDr52I817kC2ueBwl X-Proofpoint-GUID: t3fD9h9ua-eKUueKDr52I817kC2ueBwl X-Authority-Analysis: v=2.4 cv=YcmwJgRf c=1 sm=1 tr=0 ts=69b0e045 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=0JjmiBfSQHijSEXDZO0A:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDAyNiBTYWx0ZWRfX6mvutr5McvcO 1Nle+uBgAY2g2AFG5luIOCcdVunu8XFgXkxj+xrobOhQO+8ElC/xVIIBuqqyMi5snDYskcRqhBR dH7MJFKOAruygU2cefKMVj3xfoaLWfqdmRwzEFFTNw5xpZnQF220cJbaChETrxfBhtL+h4kqeO7 NAAVXvDb2Xpf/wpwe345MU8lJrYac2KHxy+Wlzk7M7tKQTgI2SQgNuKPdaXPAm3wPrspBQlfnum qBx6XilGdd1z4PDTIHzJZ0ih/17vM+syW80jyOrcQx6MX1b0N7Pnbm2GQqOZgymS7yLktwGGavB PJJK/M/rhHfuElfMQiWKWP7iYmmT4h68zGfyQWn9oNppteVWzakYBWvwx0i8odH10O/xcfpvjMN NcD6UnZpqgmosA/nF6zdpoI/ngIIISS/gxWKZGd6/Kd9G7YqLcqYVrK2YKxLUtR2JyVYBo/5QpW PXkEt5vh7DnJLgMLOKw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110026 Use freshly defined helper instead of using the raw value from the database. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 56a820ffa613..7be31de3b525 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -741,7 +741,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) BUG_ON(cfg->highest_bank_bit < 13); u32 hbb =3D cfg->highest_bank_bit - 13; bool rgb565_predicator =3D cfg->ubwc_enc_version >=3D UBWC_4_0; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); bool ubwc_mode =3D qcom_ubwc_get_ubwc_mode(cfg); bool amsbc =3D cfg->ubwc_enc_version >=3D UBWC_3_0; bool min_acc_len_64b; diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 6dc1d81fcaeb..680f0b1803a1 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -265,8 +265,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) { struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); const struct qcom_ubwc_cfg_data *cfg =3D adreno_gpu->ubwc_config; - u32 level2_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L2); - u32 level3_swizzling_dis =3D !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LV= L3); + u32 level2_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL2); + u32 level3_swizzling_dis =3D !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENAB= LE_LVL3); bool rgba8888_lossless =3D false, fp16compoptdis =3D false; bool yuvnotcomptofc =3D false, min_acc_len_64b =3D false; bool rgb565_predicator =3D false, amsbc =3D false; diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 4814233d8dba..cc21b41cae26 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -432,7 +432,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_co= ntext *ctx, *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: - *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; + *value =3D qcom_ubwc_swizzle(adreno_gpu->ubwc_config); return 0; case MSM_PARAM_MACROTILE_MODE: *value =3D qcom_ubwc_macrotile_mode(adreno_gpu->ubwc_config); --=20 2.47.3