From nobody Thu Apr 9 03:30:24 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58AFA1C2AA for ; Wed, 11 Mar 2026 09:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773220539; cv=none; b=V8svQLfD6og4vpBFjxQ9sHhj/zB2TvKFG62Y2sxkBkGnuHgzwaGDQKFxd20YFWgVyFKfr6eHaJGwRb3W+dKXhV1KF6NTeou7cXnOed65nUQDz5MH5cGdSbgVqpzcE4dsmgKgxvkmuK+QRUlDCzwcwJyx84fEnn0oxPPL6oIaBME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773220539; c=relaxed/simple; bh=ptqbIaZ+Sw/Y72FyBa0Z6lHZzYa1jDTMvBtaBmzxJro=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rww/kKnaeZc3B67D8kLdne3EFvcF2giR4h2unwHSk/ACxtHvHy4oEeI2DDs0iZUVlo+EFTAwE9ZxN4dBVyM82mJIj16eqHaGCnX3hI2NyxFdegbWqhOYBh1MLgLRTPYaeNcJFBz8E4lZz20YiOS04tZQIvhAp/QOOMg6oaHWUa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=qx2CB+3R; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qx2CB+3R" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 09AF082A; Wed, 11 Mar 2026 10:14:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773220460; bh=ptqbIaZ+Sw/Y72FyBa0Z6lHZzYa1jDTMvBtaBmzxJro=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=qx2CB+3RgyF7kpg4MrRMW5FJO7stVJCyEXulm954cFDt+Z7SDgZPTn0OvaH0EjD5n mr4poTANP/0kzgzOWmv7b7PfFh/z0c6FQbXz65xa1DeOzbbaULZFrEbbhlyV3mimqJ rVspesGa8UbW94nFKfXtnl3A1dmhZUywRXAqutFM= From: Tomi Valkeinen Date: Wed, 11 Mar 2026 11:14:43 +0200 Subject: [PATCH v2 1/2] drm/tidss: Drop extra drm_mode_config_reset() call Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-tidss-minor-fixes-v2-1-cb4479784458@ideasonboard.com> References: <20260311-tidss-minor-fixes-v2-0-cb4479784458@ideasonboard.com> In-Reply-To: <20260311-tidss-minor-fixes-v2-0-cb4479784458@ideasonboard.com> To: Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Javier Martinez Canillas , Aradhya Bhatia Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Devarsh Thakkar , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=873; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=ptqbIaZ+Sw/Y72FyBa0Z6lHZzYa1jDTMvBtaBmzxJro=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpsTKtbk/66GG42b1kL2CfmiiFASah42GNjQgDC 5FS9o/ArtaJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCabEyrQAKCRD6PaqMvJYe 9QZWEACccVWvnVtwz9/8mtzb+nbqx2KLJaP1bHMaQszafsgwkqGh9/ZLJS8LAXYr7yAE38bZ9rG Cy4bEufgqfsWk5APvHDsRWHtL9kiUwQcO2zC7h2IZ2XyNrTaczmDsC6tdm0QBEzbqoaVeH1oCMI 1qItskdk/OTxQsjPPEDBmSpF8szAinxVDkwyyx7Y45Nntkn8RzGBDv76/Qvk+bF7LJyK7O3csD5 0IxfPSYqd57R4Ws5MbPW4PuicY5IgUVDzq9gqbpXN77AS1mLvNwcDvh/dvX4TdDSms3GZ9jLLi/ Li91YGniKelB7D2du8XK4zf+6AUlnggDFQNpsbJJHpjQ23d8iLzoZ7/pcxVeVrCjHmS9yuVa2Gf ESA9rzEaXey6nuvGNqxp5oDcFQJwC/BGiRomjH0YL3iSpWNTZcKIwLC2ZSxhamHbSGBud9tVrUI O+pZIXBqhuI8zD82HCTEA2WgFVkafxglHY1MWU3GZNuIB1LfwKzIjPdZ8gwgH5/GbwOFvGme8FQ hSergLfqtshZG5kGf4mN5cJCfysqcP1L9QtYu8dX+91U5tYQSOrxTW63wVQxlE9VOQAjDHt9zU4 m9YfwcfKSSJ/qH4C53Tumic/vYq9uFbl7Qd0AHEMYNjB2hUCitA7dnp2mS0MyX2JPpJZtQwkjrU AlUTQa0iiJEpL/A== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 We are calling drm_mode_config_reset() twice at probe time. There's no reason for this and the second call can be removed, reducing work at probe time slightly. Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Displa= y SubSystem") Acked-by: Maxime Ripard Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/tidss/tidss_kms.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tids= s_kms.c index 8bb93194e5ac..b4779c09a1bf 100644 --- a/drivers/gpu/drm/tidss/tidss_kms.c +++ b/drivers/gpu/drm/tidss/tidss_kms.c @@ -287,8 +287,6 @@ int tidss_modeset_init(struct tidss_device *tidss) if (ret) return ret; =20 - drm_mode_config_reset(ddev); - dev_dbg(tidss->dev, "%s done\n", __func__); =20 return 0; --=20 2.43.0 From nobody Thu Apr 9 03:30:24 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4198F3C5529; Wed, 11 Mar 2026 09:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773220546; cv=none; b=lNcx4lXm7Fr9MFyz/fat1btfrsLTj0rYNCkmmujVksq13jjKZzTqFXYRaXH4+f3vTI+f/8tf0vC56Ywj88HNxBf2h5xtsx+n1AECEKsdPrKuUjBxlM5cRrSaDg27+Mce7+aKLNLvtJPXconx5dU3i8OeItgGnLE7mxm4eXvdJho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773220546; c=relaxed/simple; bh=FK89pOaFAMnCdx1USHLPGPqlFLXxs2xhiM3WFS+Geic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c2y3xBfKvYYui3sW6UkUIQVuhXiJlm9z0hkGMop1EGYNJ45C49peqr7DmN8B3oWI+j6mB6KlZlnjIAwGRfEBbygUlWgvdn4yB1g1v0V7RkqmbA9HZmONQhVG4PUPeiW0lfsjzezTn/xfrq2hUpHp7gPyxosY9186W26lzCVQ0/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=PyljCFGB; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="PyljCFGB" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CFD1F981; Wed, 11 Mar 2026 10:14:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773220461; bh=FK89pOaFAMnCdx1USHLPGPqlFLXxs2xhiM3WFS+Geic=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=PyljCFGBEfaoDHTntkIC8krem8ZFFkY7kCs/7sYkE+8ai7+C+gEUYvP7UOdh6FL3p cfX4O48KY2UcFV/4fAWlArpMbYFezryOD/umf6JhyH5FI3n1X5t/shhUUKdA6KGYqH FS3FYSYRIJ0eP7cjilwkNsX5dDnv51wtAhXmrZqs= From: Tomi Valkeinen Date: Wed, 11 Mar 2026 11:14:44 +0200 Subject: [PATCH v2 2/2] drm/tidss: Fix missing drm_bridge_add() call Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-tidss-minor-fixes-v2-2-cb4479784458@ideasonboard.com> References: <20260311-tidss-minor-fixes-v2-0-cb4479784458@ideasonboard.com> In-Reply-To: <20260311-tidss-minor-fixes-v2-0-cb4479784458@ideasonboard.com> To: Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Javier Martinez Canillas , Aradhya Bhatia Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Devarsh Thakkar , Tomi Valkeinen , stable@vger.kernel.org X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2518; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=FK89pOaFAMnCdx1USHLPGPqlFLXxs2xhiM3WFS+Geic=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpsTKta2KS2BnqNS/cahxVcpraq+OxMhz0502r0 FQOP/KL1jWJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCabEyrQAKCRD6PaqMvJYe 9QlCD/9cijyL+ssoamfzXYS8YPdeEEX+jeJ+RV7Zgpkrkey4UPXWXUXTYHb/zBFsaD9hcpINoMI IB0viFjIf8kC6sXwcWjUqtdl9tAsCgU4DZi4R5wWW28SiIDAEcZxXMHeY1/LAc12dq2CsOGNowA 1Sq7VZxJ43LqSZaAm5wPg5/jIwJoIFwP07ey/AUXlOzPEoYViT2F2Osl8F/E+PSd2xEDfqE435A DUz58MwKVjaF6jGvl69Kf15qghUgR1O9CxAXgxRVfSWpoDKjSC6Xo9312q5n/vzHcKlymA61zzp pfhS7k2BrDhcsj0vPyf21z20IRJ/MlGSvdNAf/IhX/eUuHjftlEfEE80Hx/Z7dVIGJ67iYsbTg4 pt0KfRqBs+CYDDMCpF7Gm2718HzTHeC1Q2ZA4l5qSaTeIv4k7DwAyOxUYr0RJMPsSBL9+eVAVDV aipG2v6gCfvvU8WXv7Rh7eT6U3d9rylIoJ+2BZKMPeALTBakUJpw+5/AYG+dAR06HGq3n0p1d2e bBCwCvZnZhcO9x2p91GBL1aRT/Jtg6+UnD8hZ6iObFwOocURDn+/maIpsxcEI4quxT3+YM1l+Mu mOs25y7hgMbKMm1LIDEBy6DXGIezNpMzAu4F+wimsJV0wIngU0z9nN0Lzz7cHER+Rf+Vwhr34HU 6TCj34AyH0ZPbSw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 tidss encoder-bridge is not added with drm_bridge_add() call, which leads to: [drm] Missing drm_bridge_add() before attach Add the missing call, using devm_drm_bridge_add() variant to get the drm_bridge_remove() handled automatically. The commit marked with the Fixes tag (from v6.6) is the commit that added the encoder bridge without drm_bridge_add(). However, this fix is not directly applicable there as devm_drm_bridge_alloc() was not used to alloc the bridge, so using devm version for drm_bridge_add() wouldn't be safe. Instead, drm_bridge_add() and drm_bridge_remove() would be needed there, but that would require new plumbing code as we don't have a separate cleanup function in the tidss_encoder.c, not in the tidss_kms.c from which the encoder is created. Also, there has been no reported bugs caused by the missing drm_bridge_add(). The drm_bridge_add() initializes the bridge's hpd_mutex, but HPD is not used for the encoder bridge. drm_bridge_add() also adds the bridge to the global bridge_list, which is only used in of_drm_find_bridge(), and again that is not used for the encoder bridge. Thus, while the original commit is not right, there should be no bugs caused by it, and for the time being I'm not sending a patch for the stable kernels for the original commit. This fix applies on top of commit 66cdf05f8548 ("drm/tidss: encoder: convert to devm_drm_bridge_alloc()"), which changes the tidss_encoder.c to use the devm variant (added in v6.17). The warning print was added in v6.19, so applying this fix to v6.17+ gets rid of the warning for all kernel versions. Cc: stable@vger.kernel.org # v6.17+ Fixes: c932ced6b585 ("drm/tidss: Update encoder/bridge chain connect model") Acked-by: Maxime Ripard Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/tidss/tidss_encoder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/= tidss_encoder.c index 81a04f767770..db467bbcdb77 100644 --- a/drivers/gpu/drm/tidss/tidss_encoder.c +++ b/drivers/gpu/drm/tidss/tidss_encoder.c @@ -106,6 +106,8 @@ int tidss_encoder_create(struct tidss_device *tidss, enc =3D &t_enc->encoder; enc->possible_crtcs =3D possible_crtcs; =20 + devm_drm_bridge_add(tidss->dev, &t_enc->bridge); + /* Attaching first bridge to the encoder */ ret =3D drm_bridge_attach(enc, &t_enc->bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); --=20 2.43.0