From nobody Tue Apr 7 22:03:14 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838A33C73D7 for ; Wed, 11 Mar 2026 10:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224386; cv=none; b=unMbL8n/LNMFgKZ4GaiIKqx0GIgtfvQPyRkP2vcZop7ubTNb5GiBn4XDfIj3EyJ8lv3KUbYNBGw71Nljh4KZmcddyfcDeAVL+LX3SfF1I87M99xBJK+2aK/c0u+gIc7+Wavrb5ngEwSltplTs3Ky+YtgNA/SGt51uQFRyDCnVes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224386; c=relaxed/simple; bh=lZahW99RTlxb5nSjc6Dzfk6SVjr8wXe8geyfqZrys/g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hNgy7CF+7JUe/yen+QzVRjghM2ilp6Rpw4d6rr9hiAcbrpgT9/Y4PrdCWfAbJXtSpC6taFXdhfn2Gs3+JkL+YHf39G+2ZhnuSZ7wvqH0IfrjHFozd3jVMR2k0TTbZrVB87rR/S/TyADJ3ObaS3dc3MwFhsTdtrNW0uUNGRByflU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=Ct00CbYK; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="Ct00CbYK" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=iXIH1tXdZIJ5fkYaX4jFP9QBJPuyNx5b18M8eLitWko=; b=Ct00CbYKQ4ArbbYHoJFb8srJY6 8uJg9eW8MaHNoZQGgyfvKTr/hxqtJ/MxcLk0/PhLqpS9kmIIcy7DCC4sfKbOtZqmCY+7EkaAeObJt eVrrOBb0DOhVhksSXK4XF7oPQJtpxoG9i6WL19X4oyK9Voz/hauRsuQGJuAcVkaiu96fzSRJncGFw RcLA73jaAMf5WcYYRqY5f+TfMyzCaRRs254uzTZ0AtOrdH6YuymdCP48C/YsAgfk/Pj1m0RSVTOYv LzKYkXpyeZt0CW5ViHic3zV3SuvvzSI9k5DxhqAHX0Hhxj6ZffxvjQW/bcEihYd1vUHTewH6JbwRl T+vS749A==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w0Ger-003hKV-Gw; Wed, 11 Mar 2026 10:19:17 +0000 From: Breno Leitao Date: Wed, 11 Mar 2026 03:17:47 -0700 Subject: [PATCH v6 1/4] mm: khugepaged: export set_recommended_min_free_kbytes() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-thp_logs-v6-1-421e30d881e0@debian.org> References: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> In-Reply-To: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=1398; i=leitao@debian.org; h=from:subject:message-id; bh=lZahW99RTlxb5nSjc6Dzfk6SVjr8wXe8geyfqZrys/g=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsUGYdXYLlTfdS24x4Ijnmy1lzO7mh4g8bO913 JPJ20/U5aaJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabFBmAAKCRA1o5Of/Hh3 beMxEACJHeqxWGPfoHsKTtYydXn+xUc2IzPH9U0E7Coj9mxC1hXG0bAsEqptbp7IlygxSMfBZs5 cguRNroZvDK2zbBxYlxUmqkzX/dy8AKf1d6WGHB4OnXcam8+AS+TaQu2OfoF4SQuIOrtf9GGFvV 974GdlxU0PhmTTJP/g0ZtxGpq8Fp1Gn+UjVpeEMBT8JOsmh2Ib0uLSstDextCYqMJ28XV/z4Jfr za0Q4IiqGVo/RtiWcmOjJWwViSuFaMreQWTnRUDTUFwGhKfg20x0z4z0kbk0mdJoIdyd7peoUez guRmThRVtWGi6EV0MyufH3/gzObG5/cgbCkUMwpG/gXAnkOy3aScRzxRVFH5Ux8On0Y5fY/M3ns +0CVZtyKZaV4JSFxurxFdEBaG1kih2lSkmFm9td2o0R6iJwZ9Jd7dWve7AaMk2MhY6WUGos2zFW NzxNH0jP4tm7R9rk70/qKfaGuZo7Bj95aVIb3C6o42OEc4Z4PRPaxCwYstlM+52nvL4b6PjuYQV JGDNQIVoL0YBYLQnSRjUfE52VnbRveYlD89Zqm//G0eyS+1Hopj5t9YfLLdGF9vtfj0koR50xqW fngb8dJmcJF0evXumurpgMt4A7yDR2QoJ//AHD8G9CKzAPIFl2F9H4S1dM7tW77d6tmYnHiNDzd xQcXTu8CpjIDwSA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Make set_recommended_min_free_kbytes() callable from outside khugepaged.c by removing the static qualifier and adding a declaration in mm/internal.h. This allows callers that change THP settings to recalculate watermarks without going through start_stop_khugepaged(). Suggested-by: Lorenzo Stoakes (Oracle) Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) Reviewed-by: Zi Yan Signed-off-by: Breno Leitao --- mm/internal.h | 5 +++++ mm/khugepaged.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/internal.h b/mm/internal.h index cb0af847d7d99..7bd768e367793 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -623,6 +623,11 @@ int user_proactive_reclaim(char *buf, */ pmd_t *mm_find_pmd(struct mm_struct *mm, unsigned long address); =20 +/* + * in mm/khugepaged.c + */ +void set_recommended_min_free_kbytes(void); + /* * in mm/page_alloc.c */ diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 1dd3cfca610db..56a41c21b44c9 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2630,7 +2630,7 @@ static int khugepaged(void *none) return 0; } =20 -static void set_recommended_min_free_kbytes(void) +void set_recommended_min_free_kbytes(void) { struct zone *zone; int nr_zones =3D 0; --=20 2.52.0 From nobody Tue Apr 7 22:03:14 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 674DF3C9ECC for ; Wed, 11 Mar 2026 10:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224389; cv=none; b=sG+VaEEph/RLzRwD0hvd4OywU4HiI2fajUdSwOQ/wzep6P7l7Fl4UV/6irp6Ohj/7Qvozn2rLBwe+tNC67v8MsK+8twO6AmmGh/EAfzA42SdAK4nd7WEu+ddNbqOt/kBLfzI5k4HRjgQo/THILUc8wQu+yjM9Z5ggKvmSQfQUn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224389; c=relaxed/simple; bh=t2LGZ41pcWRU3yvwZ5U6d39fdwdrml2WrYQvffEHhZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nhj5acqr2uzojPqRQL5eNvWBx8oZ2nDEehGUvs5LVq+nFWD0e66WfVKoKd8iFGe98mJ/ND+luweGQ3+tncth4Q9DBkKYQUPwfjAQrXSuB7ku2/3qe5a3FrH8PJm1YGGuTcIdY6QN7PxDdYRcmA9WSLeM3g+xxePjpXKht9V4Nhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=LMh+0ell; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="LMh+0ell" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=5yreLjK2erbVMXiW7KuM89LaFb1/wtMtolE8GC0kxjU=; b=LMh+0elltPbfwMimFH88WYC0r+ fah3mKQfMhkJHQoysEZ/5O5eMzzfV/Er9Wkt4vnwL3zRxwsEu9kCOVXckWPxRIowK3Z9ZAClA/B4X beUvhxI6BfCG3Wb/XAwuynIQbos1Al2XzZrj8TnewjRaz79yTwObeYx3rf0cfV+RGPnkdxrMd+UuZ RCCBfB5UoAZs+Q39+ssD4aMmZeEMg57X1mBau4RNBk4m13QrWp/r+GcXJ/qsRH0TNgRe/3frZdqRm mFzw7Q9SNUFG/4Z6wCTn0VBUNieHYMDbBh06hA0iV548mVtqHcQ9BkQ3Tu35dG21xqLu51g6YZqim jfQJxckQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w0Gex-003hKa-9G; Wed, 11 Mar 2026 10:19:23 +0000 From: Breno Leitao Date: Wed, 11 Mar 2026 03:17:48 -0700 Subject: [PATCH v6 2/4] mm: huge_memory: refactor anon_enabled_store() with change_anon_orders() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-thp_logs-v6-2-421e30d881e0@debian.org> References: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> In-Reply-To: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, Breno Leitao , "Lorenzo Stoakes (Oracle)" X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=4470; i=leitao@debian.org; h=from:subject:message-id; bh=t2LGZ41pcWRU3yvwZ5U6d39fdwdrml2WrYQvffEHhZc=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsUGZitv6aRdp3z+vgNYyxni53MMg3FfbFI4Qi HH5hHhgdcqJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabFBmQAKCRA1o5Of/Hh3 bbVTD/9JwPnc8xhW6wjSWEGZW9FPCmHYyKOIkyhmrooZSH9MOcwFws8CJ1ZYvpGQh8Q4cxfgJSB gI/cMYFoMOOBR8UJR9L4DE7ZPKMCMhhbdgkXohP5Jo1XgNBAKII0ApXyiWjcsu1YU++XTQqgCKy kAnDxnr5keYydPqw0N7HVOWbcKX0WA5hWXhvyxsMa/T+fRWqH1yAnQ6AbatOkifzY3yumabdFpV 3HHZ5usiH9n5CO0z1mWbSIekpHh3xguim1k5t5J1xWuQ+qm0ZWLAZVH9SJVqD+d5Jccp17sSGUO Bbm0kBi4HakJmoGrM9QgCe7XEos/urbQYez7cDlaNql6WKgTK4C3EimXNiSAlSA57eymaMf9iRk J6l2f/vKBxWIUqwzoP5ej+X4MvvL8cUup6jt3fnzc/HpkvjWTaFuuUpzD5tuvwcrDfoB6It0AH2 JgEGZtq4pTK8W4aL4j70pOillgHv8v7efzJQVakhbi2wi99A7eseGm31PpV/JYZUqiiB7pM2/zs DyslufFzXDkGEHJpBDlOr8ON68u5IcBDmIE20r+svoSwPggFluhaFAiXHAnqxrN0IdhvMF5IG6U bX/pg/Xyoz3DdzN3KP//Ewk5GvZf/8NI6TiFM73E60Iy6W/yqtBL0llF5NqsfPFnbkmZxNzboIr C7OaZzEobKJ+oxg== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Consolidate the repeated spin_lock/set_bit/clear_bit pattern in anon_enabled_store() into a new change_anon_orders() helper that loops over an orders[] array, setting the bit for the selected mode and clearing the others. Introduce enum anon_enabled_mode and anon_enabled_mode_strings[] for the per-order anon THP setting. Use sysfs_match_string() with the anon_enabled_mode_strings[] table to replace the if/else chain of sysfs_streq() calls. The helper uses test_and_set_bit()/test_and_clear_bit() to track whether the state actually changed, so start_stop_khugepaged() is only called when needed. When the mode is unchanged, set_recommended_min_free_kbytes() is called directly to preserve the watermark recalculation behavior of the original code. Signed-off-by: Breno Leitao Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) Tested-by: Lance Yang --- mm/huge_memory.c | 84 +++++++++++++++++++++++++++++++++++-----------------= ---- 1 file changed, 52 insertions(+), 32 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 8e2746ea74adf..f6af90e6cf05d 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -316,6 +316,20 @@ static ssize_t enabled_show(struct kobject *kobj, return sysfs_emit(buf, "%s\n", output); } =20 +enum anon_enabled_mode { + ANON_ENABLED_ALWAYS =3D 0, + ANON_ENABLED_INHERIT =3D 1, + ANON_ENABLED_MADVISE =3D 2, + ANON_ENABLED_NEVER =3D 3, +}; + +static const char * const anon_enabled_mode_strings[] =3D { + [ANON_ENABLED_ALWAYS] =3D "always", + [ANON_ENABLED_INHERIT] =3D "inherit", + [ANON_ENABLED_MADVISE] =3D "madvise", + [ANON_ENABLED_NEVER] =3D "never", +}; + static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) @@ -515,48 +529,54 @@ static ssize_t anon_enabled_show(struct kobject *kobj, return sysfs_emit(buf, "%s\n", output); } =20 +static bool set_anon_enabled_mode(int order, enum anon_enabled_mode mode) +{ + static unsigned long *enabled_orders[] =3D { + &huge_anon_orders_always, + &huge_anon_orders_inherit, + &huge_anon_orders_madvise, + }; + enum anon_enabled_mode m; + bool changed =3D false; + + spin_lock(&huge_anon_orders_lock); + for (m =3D 0; m < ARRAY_SIZE(enabled_orders); m++) { + if (m =3D=3D mode) + changed |=3D !__test_and_set_bit(order, enabled_orders[m]); + else + changed |=3D __test_and_clear_bit(order, enabled_orders[m]); + } + spin_unlock(&huge_anon_orders_lock); + + return changed; +} + static ssize_t anon_enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { int order =3D to_thpsize(kobj)->order; - ssize_t ret =3D count; + int mode; =20 - if (sysfs_streq(buf, "always")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_inherit); - clear_bit(order, &huge_anon_orders_madvise); - set_bit(order, &huge_anon_orders_always); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "inherit")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_madvise); - set_bit(order, &huge_anon_orders_inherit); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "madvise")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_inherit); - set_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "never")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_inherit); - clear_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); - } else - ret =3D -EINVAL; + mode =3D sysfs_match_string(anon_enabled_mode_strings, buf); + if (mode < 0) + return -EINVAL; =20 - if (ret > 0) { - int err; + if (set_anon_enabled_mode(order, mode)) { + int err =3D start_stop_khugepaged(); =20 - err =3D start_stop_khugepaged(); if (err) - ret =3D err; + return err; + } else { + /* + * Recalculate watermarks even when the mode didn't + * change, as the previous code always called + * start_stop_khugepaged() which does this internally. + */ + set_recommended_min_free_kbytes(); } - return ret; + + return count; } =20 static struct kobj_attribute anon_enabled_attr =3D --=20 2.52.0 From nobody Tue Apr 7 22:03:14 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675983C9ED3 for ; Wed, 11 Mar 2026 10:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224388; cv=none; b=pxitO5C0xLfEDWg2WLAr+SXcRwN5mxcDFTIGx8ML8VeTn3feqbAvHDn5ckDn8Y13uRd7SViM/MQXquxa8koHKdLvVWfZ+0ukwpckWSvtL/MehaVQPpF0y0EIuOKy3ixw1YnhE+KAAStFiMmCu3PocdCQOQNAgkN8KtGHlLyyn4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224388; c=relaxed/simple; bh=EdbjNIc4MU4kE7FF3eW32wB/WCGu/OZa4I2oST0exss=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eZ9SsA0LSPwpHHoqykA3qpfkqCZfkSVufzbwGC2lWVPxOxaB2+6uywGTg3XQh9TSM11LaBDr+iW21VldhIguCh73aEZu0kfnfH4PNxgfS25oFwVVG9K0ROIL4Wo+uokAaE02F5GvwzGo7kdtsBjwBek7GOl91/YdqNNPkjbtBtw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=gbdGfQ72; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="gbdGfQ72" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=MFthAOwBMbfcPyydbWyKKsxIBB7Wpv1CRiBxp3jBdA8=; b=gbdGfQ72Pbj/yEZ+HcSy0He0BU THMv8H8sgx5QLH5+QNvjCwQ7O1bwTSV/Y/VtxS3fX29hK4Qd7jOdQwH1pP5p70wxrpvF/hBp++PVn uE/eSHxFSqxODC0Zjmx+e3pr+CVMWYiqw76MY0pMF5pUSJdC5hkX4NWfWLzNx+JILAntUY9LIfVBF mSPEHcEkz1NXVD4Z4mpmK5zeGr6qTXcfbUFPJB7tibAhEwV1ubTGdFenkKkAvLU7wf9VtovKdlj8O TyT7bfMtarLTr2qGC99g8v2xEK8od+ql8WRDTYxK7LvxmtPiREsS2BY2/bL4pFWw9r2NG2SrAocSQ uxcPo9Ow==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w0Gf3-003hKl-6U; Wed, 11 Mar 2026 10:19:29 +0000 From: Breno Leitao Date: Wed, 11 Mar 2026 03:17:49 -0700 Subject: [PATCH v6 3/4] mm: huge_memory: refactor enabled_store() with change_enabled() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-thp_logs-v6-3-421e30d881e0@debian.org> References: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> In-Reply-To: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Wei Yang , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=3631; i=leitao@debian.org; h=from:subject:message-id; bh=EdbjNIc4MU4kE7FF3eW32wB/WCGu/OZa4I2oST0exss=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsUGZAPQLhkqPGTMyt0/1aIWw63IFWqb8fSKPJ 0SODewov9iJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabFBmQAKCRA1o5Of/Hh3 bXU+D/9e57RxcBJQU/pf0opwkVMFvv5vy3sgdffVbMJgRkBmPaYK/7UJawozT2FS8nu+qdYqydL iFEPCb67wviiCZF5c0KPF0yxBNC/VugLcW7wXIgKOaAx/cv9EOS7M1sOwAp3VvLESblVIC/4xyO vdQqkQotDbrkA0VjaR+4Pd7b8M+OQquusCVPYCYbBCQfG8SK9zkkv36Rjw5fqNXMY6febQKijDD b1VN9k7rTxpP3yr9QZ4sGix6f4txLiDdSbJEhYLupIC3xMEsurgPHJo7GQq3dBeiO+VopPP3V3Q ios1pY9I6EmNkdhF7sGYbZbmDuiG6UPyCTnWvBA8ZLOvhjQmi0nfep3lvGa/Z+O3qGXGzqGAN/q i3KchWhMtTR5y0TA/Fm5ihINJZNeZzVLezfsBRdCKucit7o0Et8FUqc2PdkDqwL9SioSDIDziK8 4g3ikHY3emF3En81FczhKlbY5KYkmKJFqP9SPJjrCaBUqUM3vSqv7PnW9mG9fEWsHjvoYZPlEqv NjutbbaEKmkfztuvnTcpnyaRRFDPGZDWlmfcIJAO4utF3iC5fX4nGPtQgwtUQb28gqadOjLc5fA 5fWnpEUMP8zuq5HulJbyBvu4Lxpo0DMLuMWhyde7oxPcm5a+x89nmhCNkIzB+eG3VoySlzSkXhC o2gzwAQCYVRUs+g== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Refactor enabled_store() to use a new change_enabled() helper. Introduce a separate enum global_enabled_mode and global_enabled_mode_strings[], mirroring the anon_enabled_mode pattern from the previous commit. A separate enum is necessary because the global THP setting does not support "inherit", only "always", "madvise", and "never". Reusing anon_enabled_mode would leave a NULL gap in the string array, causing sysfs_match_string() to stop early and fail to match entries after the gap. The helper uses the same loop pattern as set_anon_enabled_mode(), iterating over an array of flag bit positions and using __test_and_set_bit()/__test_and_clear_bit() to track whether the state actually changed. Reviewed-by: Lorenzo Stoakes (Oracle) Reviewed-by: Zi Yan Reviewed-by: Baolin Wang Reviewed-by: Wei Yang Signed-off-by: Breno Leitao Tested-by: Lance Yang --- mm/huge_memory.c | 63 ++++++++++++++++++++++++++++++++++++++++++----------= ---- 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f6af90e6cf05d..8949393de7a51 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -330,30 +330,63 @@ static const char * const anon_enabled_mode_strings[]= =3D { [ANON_ENABLED_NEVER] =3D "never", }; =20 +enum global_enabled_mode { + GLOBAL_ENABLED_ALWAYS =3D 0, + GLOBAL_ENABLED_MADVISE =3D 1, + GLOBAL_ENABLED_NEVER =3D 2, +}; + +static const char * const global_enabled_mode_strings[] =3D { + [GLOBAL_ENABLED_ALWAYS] =3D "always", + [GLOBAL_ENABLED_MADVISE] =3D "madvise", + [GLOBAL_ENABLED_NEVER] =3D "never", +}; + +static bool set_global_enabled_mode(enum global_enabled_mode mode) +{ + static const unsigned long thp_flags[] =3D { + TRANSPARENT_HUGEPAGE_FLAG, + TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, + }; + enum global_enabled_mode m; + bool changed =3D false; + + for (m =3D 0; m < ARRAY_SIZE(thp_flags); m++) { + if (m =3D=3D mode) + changed |=3D !__test_and_set_bit(thp_flags[m], + &transparent_hugepage_flags); + else + changed |=3D __test_and_clear_bit(thp_flags[m], + &transparent_hugepage_flags); + } + + return changed; +} + static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { - ssize_t ret =3D count; + int mode; =20 - if (sysfs_streq(buf, "always")) { - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - set_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "madvise")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - set_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "never")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - } else - ret =3D -EINVAL; + mode =3D sysfs_match_string(global_enabled_mode_strings, buf); + if (mode < 0) + return -EINVAL; =20 - if (ret > 0) { + if (set_global_enabled_mode(mode)) { int err =3D start_stop_khugepaged(); + if (err) - ret =3D err; + return err; + } else { + /* + * Recalculate watermarks even when the mode didn't + * change, as the previous code always called + * start_stop_khugepaged() which does this internally. + */ + set_recommended_min_free_kbytes(); } - return ret; + return count; } =20 static struct kobj_attribute enabled_attr =3D __ATTR_RW(enabled); --=20 2.52.0 From nobody Tue Apr 7 22:03:14 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 196F23CAE85 for ; Wed, 11 Mar 2026 10:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224391; cv=none; b=o5vJuKQ0MLhU8Exd3i2SXuPUx1I5UClwLwwo9cw6N2qaLlVUUIQXbPS5XbuVw4iSaEuUgy9gRBHTJyQLx3Pv4YZvETctknakfbmQMDeaYJRiC7YmhwMNG8JEP0zQrwQe5ayxt/whMTKuU0oENjeNDhBTYlc0Ox9JieSFar2EXqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224391; c=relaxed/simple; bh=ve+lNwoqDQSYspSHS5OWSYYUOfQw+Gl9hm3vxR11Gs4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gi1q4RAzPCWZ2NGACliZwIROexKk4kZ2iDzXsc9fefbP59UR1cIWHA3IbzJCRojuEf4pVKZh3VxLDP9A0gV3/ik6B1DxRT5zqYpBOH6EnlqCt8OKb1geuLGAA5xQ/R/Le/NpBoyIKPBfEGWH3P9wtJm2x6sELATao9qQ3+9huoY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=nLqrnyWI; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="nLqrnyWI" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=Nzuz22HJlpi5hM3GMMNGDuF/FPshFhM/ibIt8PNUdHM=; b=nLqrnyWIY5Gt6JYWgBUsYihjFY hdw0cy8bACMvdua+Tql1P+JXMhjamBK/aK3XFYH0byntLap0XWuz1jffXbzyRihdcGDtbNtJUsNTe lDVeTwAjbToRt7JqZCMNYWVrA468Cf5SRcyeqggASKhXpf7aifctdclJr+b5gHWmBmy/wnkRoUXsM 1vjxDbG4TwpAS56tgzteOULaP0JPSmIn2Yu1WY1eQSdtBAZhWimUJa5mfJT/85lGIuZVNOFoe3IKI NUjlZn+xIzuHX4EHq33htHk6qwRSgWHLIzMO3/F7SAxz4EBBqhNzk59ngFGVWcv+ksSH5xG14cglo xsyDuoMA==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w0Gf8-003hL0-Kk; Wed, 11 Mar 2026 10:19:34 +0000 From: Breno Leitao Date: Wed, 11 Mar 2026 03:17:50 -0700 Subject: [PATCH v6 4/4] mm: ratelimit min_free_kbytes adjustment messages Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-thp_logs-v6-4-421e30d881e0@debian.org> References: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> In-Reply-To: <20260311-thp_logs-v6-0-421e30d881e0@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=2046; i=leitao@debian.org; h=from:subject:message-id; bh=ve+lNwoqDQSYspSHS5OWSYYUOfQw+Gl9hm3vxR11Gs4=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpsUGZ9Y4BNiKt+ejJ6EMTJmA/lbLn4yECsyMFI LTlvTztlpaJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabFBmQAKCRA1o5Of/Hh3 bYzMD/0akGeFFa5euLxXr0SCDjKxo8ulEvSsFBx2OMOnL6EQo2KXe5BgztyMFjVLE8HjzwDUGTj dp9feCbl0fs+3m5ZEkzje96BhZi7PT3qiPM7HUgd8vPXPUQLk0TD4q+RBW1XWBsaMBmsliMkOlP xISpP3b4fczP318KfRxlAjMDelhLNrZogrVL5xpepce4tFRoD+XOpOH5hCdL7gm0muNqH+riHdX OTjW9kaM62YDgGttxZKYuXs20ejLt/0Xg54LndX2j8ZGQnZ3zSaE7bAziO4v3KN1ulWDwj2Wi/z qZAVXm9kRrK7iu0LI4GUXK5YxdwI4P36HtZ2410v9YBcM/jUsOMjcYwXiIDHykjA49odpJ/v61m j7TC7VPeMkYjA0k+4e/QAJ5RlBUcifKoXIAyTTTRcymsjYRgDr7Uuuj9hQSwAtdcN25ULfl2WQY 82CLgV0aWtfIfU+HSghYt0Mp8uO5YOyyaiOXUT1/pSG24r8atmuaSDqeRQwSFE+3F5E3t7hOuOd qfFRzmzMug6pDB1cejHUOa95cjWl8K8JvQqC4Lxm9eg/SYSwciQB1DMg2vzBk5WUb29c7MzDZ7o yYLOGBySG8m4qu3QjBrdeEKT0HUOGwRZRiFtZsq0wXXUnPYIqQ6UDF8E1CbKceERo3s98bV6O/B nBp0pW3oRj5sMTQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao The "raising min_free_kbytes" pr_info message in set_recommended_min_free_kbytes() and the "min_free_kbytes is not updated to" pr_warn in calculate_min_free_kbytes() can spam the kernel log when called repeatedly. Switch the pr_info in set_recommended_min_free_kbytes() and the pr_warn in calculate_min_free_kbytes() to their _ratelimited variants to prevent the log spam for this message. Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) Reviewed-by: Baolin Wang Acked-by: Zi Yan Signed-off-by: Breno Leitao --- mm/khugepaged.c | 4 ++-- mm/page_alloc.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 56a41c21b44c9..d44d463ccfd3e 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2671,8 +2671,8 @@ void set_recommended_min_free_kbytes(void) =20 if (recommended_min > min_free_kbytes) { if (user_min_free_kbytes >=3D 0) - pr_info("raising min_free_kbytes from %d to %lu to help transparent hug= epage allocations\n", - min_free_kbytes, recommended_min); + pr_info_ratelimited("raising min_free_kbytes from %d to %lu to help tra= nsparent hugepage allocations\n", + min_free_kbytes, recommended_min); =20 min_free_kbytes =3D recommended_min; } diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 2d4b6f1a554ed..c840c886807bf 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6553,8 +6553,8 @@ void calculate_min_free_kbytes(void) if (new_min_free_kbytes > user_min_free_kbytes) min_free_kbytes =3D clamp(new_min_free_kbytes, 128, 262144); else - pr_warn("min_free_kbytes is not updated to %d because user defined value= %d is preferred\n", - new_min_free_kbytes, user_min_free_kbytes); + pr_warn_ratelimited("min_free_kbytes is not updated to %d because user d= efined value %d is preferred\n", + new_min_free_kbytes, user_min_free_kbytes); =20 } =20 --=20 2.52.0