From nobody Tue Apr 7 22:05:30 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E981382F27 for ; Wed, 11 Mar 2026 12:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232853; cv=none; b=fUF3OkBbv4W/8XB2aMZf47kZQrdg9IEzOYgGM5FwpkHpFFFKh7MuuAxmNgZkw01UqAPPgKowk8AJlm3lSg2TYnBbnDH4+n3wFfHIpKfkri8XBt0a0UPWDj27l28/XX2jm6emHea/hsW97EdIKmMpHrHXggqQ7Vg7M+Iw8vkxecM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232853; c=relaxed/simple; bh=Pt9eBf3q+rpnIa6pxHeLVY+V7c9hYTChfRhtMtFrFEg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HORUKO2PHD1naEN64rx0huONDwhb5TuckH6EbmZwh2uGTmgSXNAxAZCIdaGLPS+oA7UXyLZzACnHuOqz0kSvltZKeOt07HcrQRFmAXVfKn+78OxJO4OoF6cQuWqiuPvj4zv1oOkfXj63zhFyIkLOxeu9sxczznm6JiXsVDJt7Ps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OJ32Qw32; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e+9+ivS1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OJ32Qw32"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e+9+ivS1" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B9U9Hi613997 for ; Wed, 11 Mar 2026 12:40:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B9kf1xOyGVR0LAsUb0gr+ewuAw5uTpNXsIwgYg+g+ZE=; b=OJ32Qw32ctj0+/nS LGe0nGO7eL4P6V3LWjYIz3bQzZau5OWQR3O5s+BdVwVcxjBOgcTgBFlCxYVMszVP cpoWuDsiAH9/wc/FxtT8duiS8/l4d+forxE5mHuPL4IgvyVUbutlUxgVKgyikYT2 ogkCznQtwCw6LeqYSiC8y9N9XPKtUenBVc7OPVFLvVCPDpWyJ3FoxaRzoK+C6FHY JQ0+BVtI7E85/WXNJuyVnZVClPbJKUAB7dw3/dHzWGOnZm4+IfkvukPhZpocnHx5 RePK2QifTvx7hNcnktLfEI83UE75FdcDJ2jcSpYMdrkA9k50v6GHA8s+rOFscRHq sBo1GA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu0jf1wfm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 12:40:50 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae669a8ff1so435423565ad.3 for ; Wed, 11 Mar 2026 05:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773232850; x=1773837650; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B9kf1xOyGVR0LAsUb0gr+ewuAw5uTpNXsIwgYg+g+ZE=; b=e+9+ivS1rFaSFnAFs/wYTWgTzGPopcaGKbRF23VgZLwdjF4UQB9OxhPThBOUuEzkZc RzNucE9+XEpRx+4RFBRkP++oT12yxFItzJjNJUFmkI7NflS4ur5HgA1f0bk3OPyClYvm H0jcpmPIx71kNBj9UhBLVhfuRphryqDNrJ0MtfpUEhpYy5jU3g9otazboWOl9vUYzl1e rb1P2/PZu3HFKqkD3BhCjqYe/pPI3HTylxlG6CvpIiujHUP84Kc1i5Ka1FJVxj2Zerv1 VXXobIay4wqvkQzNn4pwA8HD+i0A+5e9YmTlon8xbmF14P6FOYGOKCuDLMsO6mvaWLyg LmQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773232850; x=1773837650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=B9kf1xOyGVR0LAsUb0gr+ewuAw5uTpNXsIwgYg+g+ZE=; b=Vkruq/6OYpDTQaN2FN8gCdUEX7G/APYxZWRmPO7POqtCALzU27CeqSsQrk08reCyub JHnwaUzlAUwaAvgTy9qHsd59pMU9WSaf87CzvTuL8p7NykxsftFlZQHXI2jXYyRfOmG8 rW1nA8bTuujYQy8P5f7DdMx/c9AlEh03q30aWkh9q+skAql+E392Kp808So4a94V6qw1 h/5VjzZ2+D6LqhZdrauJfTDStzmsqxpckUU5/xBGfLvM55YRBfbUk6ykvDP83wUPXE7l ttsQ7ix6+1aCMaeFRUiZXO93jL1qv0JYH5NpMGOWuf2Dp2FUjRdx5cjeWEDk6Z0YX0IJ cOcQ== X-Forwarded-Encrypted: i=1; AJvYcCURp89vjTpjHlhzwjqCQBXx0sQdk3UIl/GJrtWs6B5XeEDWqxRfjHEOkkNzFTvRw3s2uqyFM+qslgauDNE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj2KYPNTMgSgPyn09Ee8Ksg6yKirxZmV07kJgH4jNV//AOLt0f J5f/k3N2Avx+ToVunMCevhEJEHx60N4i+EI8ty4L8dpD236h0oQ0Epl2HyIWBHNVstkJmjaDqp0 yy/kilFmL5b5L2OA6GH14F6Ev8pY2WiwWmSBu3XZLHEM2mvqh5pbjxBDOFKmd6EY5rao= X-Gm-Gg: ATEYQzyEuBtc9nOaxx1Mg9BJVu2EkX9lK6RG3Ez0EsnZmxDoofAK/5XbeuGi/Nh8mtw PT5XzVwbaIsre5FlJEp7eogX3AUympqlSO06IQ/S4fWaa/Kgnn/GbBIXOAXsj+Oyp3IulyDCPp2 EsikrLy1eGfeEPiLNMUcByEI+RqURkMiJxWBIo5/82BrUDwHe33Ai0WfCpT5bsiXf7UuFMTyfq/ RH3doD3I/bvEV04iEsyaT3Qb1qL5NefwssrTNkAMwWaFiW9c8LjIZgnK/0Mn7XkaY8efjeuLZFE KOLH4dYmksNdwDcEhPt/Wa4jJya+1JaBG2P8cJMNA2ADIgzB0LzQDCrWzyX7aVQNIbC11ETLXuc B91M6IDtdy7fMQTyYiFmr8oH6zt7LTKggBlVs05L0zxIJmALp2N4oi62K X-Received: by 2002:a17:903:2349:b0:2ae:7f49:dba6 with SMTP id d9443c01a7336-2aeae7b9c7amr25539355ad.17.1773232849670; Wed, 11 Mar 2026 05:40:49 -0700 (PDT) X-Received: by 2002:a17:903:2349:b0:2ae:7f49:dba6 with SMTP id d9443c01a7336-2aeae7b9c7amr25539125ad.17.1773232849154; Wed, 11 Mar 2026 05:40:49 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae2466a7sm23304385ad.20.2026.03.11.05.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 05:40:48 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Wed, 11 Mar 2026 18:10:38 +0530 Subject: [PATCH v3 1/3] PCI/ASPM: Add helper to encode L1SS T_POWER_ON fields Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-t_power_on_fux-v3-1-9b1f1d09c6f3@oss.qualcomm.com> References: <20260311-t_power_on_fux-v3-0-9b1f1d09c6f3@oss.qualcomm.com> In-Reply-To: <20260311-t_power_on_fux-v3-0-9b1f1d09c6f3@oss.qualcomm.com> To: Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Jingoo Han Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mayank.rana@oss.qualcomm.com, quic_vbadigan@quicinc.com, Krishna Chaitanya Chundru X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773232841; l=3724; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=Pt9eBf3q+rpnIa6pxHeLVY+V7c9hYTChfRhtMtFrFEg=; b=KHFAs89LsMBYL5fHydYgDFo5VhcbamTST8VkKk6b6M5RUp5TA02BRoJOjr6mcp2jkNH/UfEUM TQ1Ze34FsL5AWnmVpEQtv+Mk28RFPYk+oK2Mjtv34ACfbkFvMGqs3VK X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-GUID: Gt0HwHIpnnAZrHLLQN0-qUo7arm6YN87 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDEwNyBTYWx0ZWRfX+qPy2+sO8gfs BeqOz60/IBLtHCgZIqbqoDFeZzfcecKGuocVSZZ1tfAOSTzgvUvrwaJij8cMJ6k9ZVUPkPRlMmt U2HPzwmXV0Bc3wx4kgm7bE+067yK9J5aTpsFdFWnRPN/08H7EomEggQzVlOz+SnjV//yGK0qrhi mIHmgM7ileGBXIjDE6r5jg16XrhLu+7EYc2/6osm8LTUQnwfISNJLXG7ETTap1LvSaoMFM8AByY rJnncNq6r0Hfepfr5ZX+kdZwzYoAQbyL0oNqKdjkwl8dhLu0SZqC08hc2owaVvVWo1jgt7hcytm N+y1Yvu4J50ck2GTwKJXDlWy++nRj2vzQcueJXzmZBVXDh65xDqvfZNaQ4+PkEIPQDvNVGw7fCD hrTXGJub8NGICa+NZOs/25ghre7DyxizNKQQWQnJj3oJK3oUDtEH/tczGGkoKBiBLOVNg5akfYm 56v9KcsNW2IybUCEa+g== X-Authority-Analysis: v=2.4 cv=FMMWBuos c=1 sm=1 tr=0 ts=69b162d2 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=j3416i00YO8nPnzCGbIA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: Gt0HwHIpnnAZrHLLQN0-qUo7arm6YN87 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110107 Add a shared helper to encode the PCIe L1 PM Substates T_POWER_ON parameter into the T_POWER_ON_Scale and T_POWER_ON_Value fields. This helper can be used by the controller drivers to change the default/wrong value of T_POWER_ON in L1ss capability register to avoid incorrect calculation of LTR_L1.2_THRESHOLD value. The helper converts a T_POWER_ON time specified in microseconds into the appropriate scale/value encoding defined by the PCIe spec r7.0, sec 7.8.3.2. Values that exceed the maximum encodable range are clamped to the largest representable encoding. Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Shawn Lin Tested-by: Shawn Lin --- drivers/pci/pci.h | 2 ++ drivers/pci/pcie/aspm.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 13d998fbacce6698514d92500dfea03cc562cdc2..48964602d802e114a6a2481df3f= b75d9e178a31b 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -1105,6 +1105,7 @@ void pcie_aspm_pm_state_change(struct pci_dev *pdev, = bool locked); void pcie_aspm_powersave_config_link(struct pci_dev *pdev); void pci_configure_ltr(struct pci_dev *pdev); void pci_bridge_reconfigure_ltr(struct pci_dev *pdev); +void pcie_encode_t_power_on(u16 t_power_on_us, u8 *scale, u8 *value); #else static inline void pcie_aspm_remove_cap(struct pci_dev *pdev, u32 lnkcap) = { } static inline void pcie_aspm_init_link_state(struct pci_dev *pdev) { } @@ -1113,6 +1114,7 @@ static inline void pcie_aspm_pm_state_change(struct p= ci_dev *pdev, bool locked) static inline void pcie_aspm_powersave_config_link(struct pci_dev *pdev) {= } static inline void pci_configure_ltr(struct pci_dev *pdev) { } static inline void pci_bridge_reconfigure_ltr(struct pci_dev *pdev) { } +static inline void pcie_encode_t_power_on(u16 t_power_on_us, u8 *scale, u8= *value) { } #endif =20 #ifdef CONFIG_PCIE_ECRC diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index 21f5d23e0b61bd7e1163cc869fe9356d1ab87b34..d7f9ae9e48c25dbc2d9b4887e2f= 74623688098e0 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -525,6 +525,49 @@ static u32 calc_l12_pwron(struct pci_dev *pdev, u32 sc= ale, u32 val) return 0; } =20 +/** + * pcie_encode_t_power_on - Encode T_POWER_ON into scale and value fields + * @t_power_on_us: T_POWER_ON time in microseconds + * @scale: Encoded T_POWER_ON_Scale (0..2) + * @value: Encoded T_POWER_ON_Value + * + * T_POWER_ON is encoded as: + * T_POWER_ON(us) =3D scale_unit(us) * value + * + * where scale_unit is selected by @scale: + * 0: 2us + * 1: 10us + * 2: 100us + * + * If @t_power_on_us exceeds the maximum representable value, the result + * is clamped to the largest encodable T_POWER_ON. + * + * See PCIe r7.0, sec 7.8.3.2. + */ +void pcie_encode_t_power_on(u16 t_power_on_us, u8 *scale, u8 *value) +{ + u8 maxv =3D FIELD_MAX(PCI_L1SS_CTL2_T_PWR_ON_VALUE); + + /* + * T_POWER_ON_Value ("value") is a 5-bit field with max + * value of 31. + */ + if (t_power_on_us <=3D 2 * maxv) { + *scale =3D 0; /* Value times 2us */ + *value =3D DIV_ROUND_UP(t_power_on_us, 2); + } else if (t_power_on_us <=3D 10 * maxv) { + *scale =3D 1; /* Value times 10us */ + *value =3D DIV_ROUND_UP(t_power_on_us, 10); + } else if (t_power_on_us <=3D 100 * maxv) { + *scale =3D 2; /* value times 100us */ + *value =3D DIV_ROUND_UP(t_power_on_us, 100); + } else { + *scale =3D 2; + *value =3D maxv; + } +} +EXPORT_SYMBOL(pcie_encode_t_power_on); + /* * Encode an LTR_L1.2_THRESHOLD value for the L1 PM Substates Control 1 * register. Ports enter L1.2 when the most recent LTR value is greater --=20 2.34.1 From nobody Tue Apr 7 22:05:30 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6818E373BEC for ; Wed, 11 Mar 2026 12:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232856; cv=none; b=TX+ucIeEpWadUzfoATLYp3GF+Kwbj3NExAgBCSgwx3z67QgwF+JSLrzEujoWfMHJK+8PtVlQyM17eWTk+WqnbVW8EXI5y9TgvQpPUhHa5BCv9MnLpaVN1uxEheZI62/6Q/ioQY4XLASjBcXEQCSJZUPgcWkQAPgcrxMGYyvmjPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232856; c=relaxed/simple; bh=P7eBKgOTVNbd2AU6d6k1MmcyBnI7wcKu6MKbMkU3hvg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QXoD7xdKGBXQ9NxUrIziELdn1MNSqsXVAumaqfQdY5OVhxyWbffxo19amPn65f7IftwgcxIWmQOXEuVY1cD5uDdiQLvkQw2aJd/YxW7stpZsco9bSTA34f8UbylW0Rqpyyd8lHFnqpXyRH4wS3u5zY28Rpmd3b0Pu6D2aA4sNNE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XZv3SF96; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=avgmS9sp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XZv3SF96"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="avgmS9sp" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B9R2pv613996 for ; Wed, 11 Mar 2026 12:40:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3Z15d13ybfQqYpQ5QfjD8B6GQqnkhmB5ANu1YfYyMoY=; b=XZv3SF96eK/jNY6Y SnaGOuiUVK6hri5FnzU2HIRhv3JMwyc0EDby1gpOiyvm1t3lMhU2uLi2oQ2r54YZ kdCjVHSx1B/64iXTXo7U9ITZjZix8Jj1NVzD1+g3GrXhS8awkLL5GR1c2zWz5FTs xA2w+MvaU0WnKl0gmn/rIXrWamIZHPxh72Lx/lvSrK/MfouCRSiW+EBhyB444O7h uneIDFEuWDqxwNBz5FpbvEMlntNGf2/cG+ba6WteyXtA6C8F8xq7Cy+yvfrbR5aS wasS2I8z5S1aAZNtkMRAIoI+NWREuKjPC+Zq0ZhBVz4Q8zvNAhQ8dhhK1OyOt2gs 7Sspxw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu0jf1wg7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 12:40:54 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae50386da7so6578675ad.0 for ; Wed, 11 Mar 2026 05:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773232854; x=1773837654; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3Z15d13ybfQqYpQ5QfjD8B6GQqnkhmB5ANu1YfYyMoY=; b=avgmS9sptaORT6JKa42ynj4o91HJEgVz+BtrfeYvxKOm5Oxe1a93BG1rGR0dC64lig QUsVf3ntSLn8/EWGCCNczugbs+hHVdS2drWQ8m4LBdfwj8XjzFeTLnrrOt+z1pzl9vmU nEN7/ykjAylJbsQrpU9g+Lu/WPigBcCyqT1zsHxHqrC2riQ1iT32IXpteL3+AjjbE2L1 9cvzM5YqxXhkU3eijN0BsWGRjjv5HCHrLqV2ngIYtpxo/OIEYrCdmBGZNBaCG0nf13ak oLY2imK7BY5TR9D/j298esBIra+TYF2rtgF7L9Q7VvF7KRY+3M+URrAQdxfnt9CIqR17 WRUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773232854; x=1773837654; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3Z15d13ybfQqYpQ5QfjD8B6GQqnkhmB5ANu1YfYyMoY=; b=dxINi+rR3BZOCuRmn94Px073YrE5q9S7Bx5s6M36pPdvNcDDOqAL4LFIEDhd2xPiR5 xM5tMAv9fU+SQAnRQRtAXPCtkQbMhzxDfBolWrLYZMFqQoR9+Ci9dVL3aljmfznJSR5b YCjxL610kO8nj7hO7Die5l1xm3wijJw/r6C++OfxNOYXEiouIKxnvj1vlEIsEMR6VMuk LSOb6KvytCiOsCJTjLuEAn0uG51t9ExEQ+F9KSnoNGyHSt9MrYeEWKngzSIuwcLf+Wyy mjbYh4hNWt3ZeB3/ib0viDpFL3aMlpu9QfwuHx2yFhpnDruj0kQodVaN1ywl1vf5CrIt lbXw== X-Forwarded-Encrypted: i=1; AJvYcCW4BjJvC8iNJZNjsj5WJExW0fL1wNTsTN4C35Zo0JBnpTGB7slKzfgoXtYk77kp6QEZiOlg5EE+Rk7udUE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3tg2owiWiBM8gJDVaWFlquUtmini9yfMVkNhgOTvgA1uyyd1f A7r9iIwGtFZabH9D+l/Xc+gsTWAYnRTJTVjLvF8qKz10UX5Bw3IIGWaf4JeXz77Sf28VLUzAV+X HcnqE8yI+jyBveZuMqMwlK+P8hTsMWjb4jm3Vn0ii7FMPEZBN50bOU7F2m12BtbWuXCA= X-Gm-Gg: ATEYQzxexXVhtjTTCcVpgnRDcVueG2QZki/kW+6drYdzI1xM3gbXxWgxcySWgoeHXII 8XL4XrOkbk4H1kmcEYj7NaSeRU79USYTjmuqL3t90+2tpXsn3O6FNS3sKN6hD/7cM7PTLd91y0x al/7aHNyxyI/Dug3txV95Sy8M3erbuKlXwy+O4GN9AZor3ULFoXy4JVsWnwq/VS3WEC9u66ZjFZ x5FM9DIDYZibsig77ZYmgoI0wGb4tL1oHTFJbIl5RaVraYmd/bIpzqBKfFdviukLo5n0a6qVZ7n Y9/uJls1os3eDbKuJdQUD1Jh38IVQauPtQLSW8irScePgdXCkLZrQbr216Nb2UgQBuw9CnxhhNw 5xf3rUOCA6HBA7KWnXpvxSY0S70ZXpOaygPM8K76rYQ8kpGhsvKCcfaqS X-Received: by 2002:a17:903:4b43:b0:2ae:47b0:dc80 with SMTP id d9443c01a7336-2aea1ba9876mr80596045ad.11.1773232853895; Wed, 11 Mar 2026 05:40:53 -0700 (PDT) X-Received: by 2002:a17:903:4b43:b0:2ae:47b0:dc80 with SMTP id d9443c01a7336-2aea1ba9876mr80595765ad.11.1773232853351; Wed, 11 Mar 2026 05:40:53 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae2466a7sm23304385ad.20.2026.03.11.05.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 05:40:53 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Wed, 11 Mar 2026 18:10:39 +0530 Subject: [PATCH v3 2/3] PCI: dwc: Add helper to Program T_POWER_ON Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-t_power_on_fux-v3-2-9b1f1d09c6f3@oss.qualcomm.com> References: <20260311-t_power_on_fux-v3-0-9b1f1d09c6f3@oss.qualcomm.com> In-Reply-To: <20260311-t_power_on_fux-v3-0-9b1f1d09c6f3@oss.qualcomm.com> To: Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Jingoo Han Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mayank.rana@oss.qualcomm.com, quic_vbadigan@quicinc.com, Krishna Chaitanya Chundru X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773232841; l=2929; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=P7eBKgOTVNbd2AU6d6k1MmcyBnI7wcKu6MKbMkU3hvg=; b=xleuH3VgOgn7EvYNWW7rJTRN8DE5mC8MXKORI5WGxi1kXF0jqeOcM5ZZke1xLsKJx0QiVPNoS 82R2YqaDOxzBhjMSwkW6qCY8XlghwT7d/CGXh/35fvYga4o9rKoOkx9 X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-GUID: o6s5CaD3bCqwn9lmaqJP-bUiHVQqYWQI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDEwNyBTYWx0ZWRfXx9fIgwaiUoir 359G1lZgooaLzxS3vt6xfQoC64bBYOHj94WydI3zT75Hi077moWK6KEnSfli4e51by+iF3f3Xd9 E4K4G1a4yXdOBO69gIyw2zhGyoZgNgSXrxwnprYNTWYeHlJi2r+khnbowSw2xqrs3VImnWlU8OJ QwOl3aWYKYyRcr+NqHCeeOpa1Psn2JirTUBDpnsNWogTm5uhWeyGYYJ2fHaEef38r3zmOXyMNkW LjVnUsbdT+o15RPlZ+IC/foCqCgWuIRwS9s0AdPnqrnnF3z2QGPBrWmkz8HXeDcij4m2Ooc6jtS sP1lG0PHqfRRmGcIu55duGsYflolrwbfADONeNZ9MhlQ1yTqMJh8u9TlLOJfQ/7TvpmHFLHY/qO RA8YRfc/KtobOPNui2qRdQxRMlUgZUHzdw6KBUWssLDycUyftfE6doTcHyTpomaeRNlHYKWEgaB iFkn12NrNsRryfnaQtw== X-Authority-Analysis: v=2.4 cv=FMMWBuos c=1 sm=1 tr=0 ts=69b162d6 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=kXhGf0cxdCgfIYue-YsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: o6s5CaD3bCqwn9lmaqJP-bUiHVQqYWQI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110107 The T_POWER_ON indicates the time (in =CE=BCs) that a Port requires the port on the opposite side of Link to wait in L1.2.Exit after sampling CLKREQ# asserted before actively driving the interface. This value is used by the ASPM driver to compute the LTR_L1.2_THRESHOLD. Currently, some controllers exposes T_POWER_ON value of zero in the L1SS capability registers, leading to incorrect LTR_L1.2_THRESHOLD calculations, which can result in improper L1.2 exit behavior and if AER happens to be supported and enabled, the error may be *reported* via AER. Add a helper to override T_POWER_ON value by the DWC controller drivers. Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Shawn Lin Tested-by: Shawn Lin --- drivers/pci/controller/dwc/pcie-designware.c | 28 ++++++++++++++++++++++++= ++++ drivers/pci/controller/dwc/pcie-designware.h | 1 + 2 files changed, 29 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/con= troller/dwc/pcie-designware.c index 5741c09dde7f40487c6da6dfd66f7c8d96a74259..6289329ef2b2a4ac9264d1c6cb5= ea4e88c261634 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -1249,6 +1249,34 @@ void dw_pcie_hide_unsupported_l1ss(struct dw_pcie *p= ci) dw_pcie_writel_dbi(pci, l1ss + PCI_L1SS_CAP, l1ss_cap); } =20 +/* TODO: Need to handle multi root ports */ +void dw_pcie_program_t_power_on(struct dw_pcie *pci, u16 t_power_on) +{ + u8 scale, value; + u16 offset; + u32 val; + + if (!t_power_on) + return; + + offset =3D dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_L1SS); + if (!offset) + return; + + pcie_encode_t_power_on(t_power_on, &scale, &value); + + dw_pcie_dbi_ro_wr_en(pci); + + val =3D readl(pci->dbi_base + offset + PCI_L1SS_CAP); + val &=3D ~(PCI_L1SS_CAP_P_PWR_ON_SCALE | PCI_L1SS_CAP_P_PWR_ON_VALUE); + FIELD_MODIFY(PCI_L1SS_CAP_P_PWR_ON_SCALE, &val, scale); + FIELD_MODIFY(PCI_L1SS_CAP_P_PWR_ON_VALUE, &val, value); + + writel(val, pci->dbi_base + offset + PCI_L1SS_CAP); + + dw_pcie_dbi_ro_wr_dis(pci); +} + void dw_pcie_setup(struct dw_pcie *pci) { u32 val; diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/con= troller/dwc/pcie-designware.h index ae6389dd9caa5c27690f998d58729130ea863984..da67beece3f11e33d9a1937fa23= d443feea3bbc7 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -602,6 +602,7 @@ int dw_pcie_prog_ep_inbound_atu(struct dw_pcie *pci, u8= func_no, int index, u8 bar, size_t size); void dw_pcie_disable_atu(struct dw_pcie *pci, u32 dir, int index); void dw_pcie_hide_unsupported_l1ss(struct dw_pcie *pci); +void dw_pcie_program_t_power_on(struct dw_pcie *pci, u16 t_power_on); void dw_pcie_setup(struct dw_pcie *pci); void dw_pcie_iatu_detect(struct dw_pcie *pci); int dw_pcie_edma_detect(struct dw_pcie *pci); --=20 2.34.1 From nobody Tue Apr 7 22:05:30 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62ED638F232 for ; Wed, 11 Mar 2026 12:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232860; cv=none; b=UEKKh/f6Q13oJ4DqrErHxuK3Vc7w/g/xTJe5MLCvKAbr9vVos5L4ebPxLhAzuAMsPKsMYCkYiGBvXYlmz2di+aB9xgdc6wKgqiiUXrWrOAoheVjFb70d+cW6cmYTEecLaQXdCDsv9Wx/t+7VDrpRy7ZCUzi81G/NWnJFwmxTu4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773232860; c=relaxed/simple; bh=fCZai0Br+UV9JtDbXVN+nJASmxIaMenuxY5Mhb3FJSY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U2FhAQ8uOeA3wtQaSBC9dUgNT+pV3GQDQhvTobND/TQ1FqJHoX2iJueBLo2XcVqgjgar62CPxq7qhEwIFNiMOe+r3VHKsT7Nc/RzesF23M/9zl2ZPg9a4kw1VxLDVgJyXT0NsXHIURxhDuiWLmd5QOzp44ImU3z8MKySL4HBXFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cOmD61+Y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HkorusCn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cOmD61+Y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HkorusCn" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BA5b57294256 for ; Wed, 11 Mar 2026 12:40:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= or2aWxGkNMHGpvSv6Gz69lZrZZtJUX0pU0QL6U2L0WQ=; b=cOmD61+YGR8Nmkhy 3gqXhNVJKdElLtLiGdZOUDayYRU1UPZRaD62K1oHns6x7ursX+5+icVC69GIhgwS 2MXT20y+KGMAf/HflVZusLoeGd61Y/hA1yKBlALUDQ7xJJWm6S4UE7nmkCl9Z3Bw k9ivVfVxRgiqxtadsSNI+vi2Nwj8HyJxT8kooNGEFq+kJ1U08SYe10rUiWUrLjRY QkmDH9St54EGhUElyZuiydZhttYSNgly6ZERoj3gnWGKUgl+MCGJ5mNfyU5nEcKJ U5pcvN91YBo9j50J4J1lbmu6J74mlTwIwSqU/ePYW1VfjPAcDXSa0ks6ZjQGfMZy 5gslqw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu6bb8gh4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 12:40:58 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae4cdfc468so103599405ad.2 for ; Wed, 11 Mar 2026 05:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773232858; x=1773837658; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=or2aWxGkNMHGpvSv6Gz69lZrZZtJUX0pU0QL6U2L0WQ=; b=HkorusCnyfhICJQNTaKT2RUU7RHVHJ3rM1mlNZArNdTWmxc+uMZXpgju6D8p8i2dW0 u4+AqBqIEEEcuHRxQY5ruf5LjbYd3BZ37bSpB/Cn8bdXMjjj5t76hdUNC1Rv41CwHiak f6DMzhdl4Mjbt6RSIcZxpnItynCnDYUy2UosB1k2vt2NHmyvL9fJvA++OA/I03chVkwq 4l9f9Y42+nhOS9orJ4RUAcw4UCBVaI39VCx6m7lG+Mbupnu0KuEi3OlAG2WVW/oDBknP gtlPxUUTvShA2e4MSVSQJaiw9hpLUhs4hFL4tvZsBK6MtjOQGj+pXJuFY88NraNT15uC 21LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773232858; x=1773837658; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=or2aWxGkNMHGpvSv6Gz69lZrZZtJUX0pU0QL6U2L0WQ=; b=bVHzRY1TDALy6xcUprjv0jBKEzp5FMSmRItiERZ+GPLwcnZ6jRfGxsNykB8Dox0bo4 Bu8ZXXHn0qDnLsR1ZamuP5ua3wA4knT0FOieZaR9C7gZ1YkJEwh6NKpD+BFzxN6lZraF HhAlEdrvG6yaXQOm32YWDVvIOrNWRYlzEu+Co4rFwdc7TZ8v+axxGijMC5IYoaO1A0RT WXai8UNZPNQjJngmLHF1N/qhaGIi8vsi++hQbfyY1gHqJfyLo2BbefCvcAIYIp3d0HNo Mito7eiapCbom2nKuSWMR8vlUrKaqM0kLzrugxqDri0PmSCA/CbIwb/TmHoOHPluTfFK FU6w== X-Forwarded-Encrypted: i=1; AJvYcCXNqKO4sZLss1xzpPHE5/DUIEn/QsOKi82JLIsMImbh+GnvmyVyfqAZyCdmn9osmGmcBxhaLWTvakSh6Qg=@vger.kernel.org X-Gm-Message-State: AOJu0YxZAGau2yCVDvrki86vkyMLmq29HxknCeqYcU+tY/FCsUlvwfnB ennYs51NbkthWLibujHXile2ZMBmVT5kGIXEcgnm2DlcySlH1qm4U5pj+HHFtuT5V5dGYUsU8Zc Gw/uw6SiVWwibrIJF2PoOH+LFTfOMrWE3F7HOtf7iXdBxBaDIo9Jp0cWeIyB8Kn/03jc= X-Gm-Gg: ATEYQzwSTORkICbOU+5GCmx/SAr5bxV9s5X5IgIncRAoyPUKRJIdU8mDkybd+wViBv3 DppFBF3lEHx73lipxyw7jG+y1xquDdJss+X/AHLm2dNtvlu/S3ToUlHbrFgpyAL1lB3qkghJMxD aCUIo8jPBnYa6D7zZ60nKLANeOJXsD0vG/Y3wwuwBUixbgWloo4t66CF8gTSoA3IHq9R/naQlXv RCRJYhSJvVkpX45HbR4JCXNs2uTkhWghKfjE7jBhSftL/h/UsuVU9bFexucMw9dke2Qi/yTA9xJ 6mUM8zVyFWGk9pTDnL0VGsdgv7evC+NW+uJJmschqnYJLvcrYmcnrpEJnOMRrjnonmR2FcvQaiG /+lqfnPvsy1ypSnLz6heI8h30e6441H7Qs3nVliSJXSK+PbBh0R02tArD X-Received: by 2002:a17:902:f70a:b0:2ae:a577:55b4 with SMTP id d9443c01a7336-2aeae8dd2b2mr24993775ad.40.1773232858088; Wed, 11 Mar 2026 05:40:58 -0700 (PDT) X-Received: by 2002:a17:902:f70a:b0:2ae:a577:55b4 with SMTP id d9443c01a7336-2aeae8dd2b2mr24993425ad.40.1773232857570; Wed, 11 Mar 2026 05:40:57 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae2466a7sm23304385ad.20.2026.03.11.05.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 05:40:57 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Wed, 11 Mar 2026 18:10:40 +0530 Subject: [PATCH v3 3/3] PCI: qcom: Program T_POWER_ON Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-t_power_on_fux-v3-3-9b1f1d09c6f3@oss.qualcomm.com> References: <20260311-t_power_on_fux-v3-0-9b1f1d09c6f3@oss.qualcomm.com> In-Reply-To: <20260311-t_power_on_fux-v3-0-9b1f1d09c6f3@oss.qualcomm.com> To: Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Jingoo Han Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mayank.rana@oss.qualcomm.com, quic_vbadigan@quicinc.com, Krishna Chaitanya Chundru X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773232841; l=2432; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=fCZai0Br+UV9JtDbXVN+nJASmxIaMenuxY5Mhb3FJSY=; b=Q4gJKXQ9XWkdvcloTyy0OjYGuDQaSF43IWeaLQVPmMM1GCZviMKmSu7O8NOFAscE78vI2fQM/ hdaFH1/lNCIBaw+ez88sFt9ZfeVhrD16b2XYpbl5LlpIudxmRYbrE3I X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-ORIG-GUID: vTdzYVB9w2Hfdsc4ef0xNcLz6sGUYPBB X-Proofpoint-GUID: vTdzYVB9w2Hfdsc4ef0xNcLz6sGUYPBB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDEwNyBTYWx0ZWRfX+DdyCG/KCzCm Y3cdBx5+N4N4Qsrvmj4QHsQuQHabmPTJXHIavWI2+bVBPREYvLJ3I1k7cNqkkVmX2BZ6+Eif837 M2/jSa9XUgkteY9YxBjvLKPnzkd/c+UnQn2hHkzumIHkG9mMJ+HN8qfkqAPXsMGv9KHURhFFAeF xuTsocEsaYxN9HEhdawYZMUFC8/WB0M1Oa/nrUkTza20G3ryFICTb7FxOsH2BdaU4Kcf7S3+0ne oMb6umRQw0FuRyPQyk5/UiDCQ5QC6PfhlT+7qNaGJZlfD9KVMW6WJ9+R5NqIQmJF8yx9RIUNBIT gX60RQOmdbpXZMtomCq5HKNOMrLp2081De7CvZEaHFVDmbxm0tSi8XL79qIVxIbzLIezvL7xJPS EDueuQZItn2snG8xA4VkFcHAgd1ODmeuvHXQ3jpsyG9r+mhvKoF4mhtX9zM/aod3PSnjPWLNi+Y yP77aPrJammhkh4ORSQ== X-Authority-Analysis: v=2.4 cv=CKwnnBrD c=1 sm=1 tr=0 ts=69b162da cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=wXczfBY3881IDOTkNB0A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110107 Some platforms have incorrect T_POWER_ON value programmed in hardware. Generally these will be corrected by bootloaders, but not all targets support bootloaders to program correct values due to that LTR_L1.2_THRESHOLD value calculated by aspm driver can be wrong, which can result in improper L1.2 exit behavior and if AER happens to be supported and enabled, the error may be *reported* via AER. Parse "t-power-on-us" property from each root port node and program them as part of host initialization using dw_pcie_program_t_power_on() before link training. This property in added to the dtschema here[1]. Signed-off-by: Krishna Chaitanya Chundru Link[1]: https://lore.kernel.org/all/20260205093346.667898-1-krishna.chundr= u@oss.qualcomm.com/ --- drivers/pci/controller/dwc/pcie-qcom.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index 67a16af69ddc75fca1b123e70715e692a91a9135..63d5628e988d3c07f42099c0d86= e6b80fd54ce32 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -269,6 +269,7 @@ struct qcom_pcie_perst { struct qcom_pcie_port { struct list_head list; struct phy *phy; + u32 l1ss_t_power_on; struct list_head perst; }; =20 @@ -1283,6 +1284,14 @@ static int qcom_pcie_phy_power_on(struct qcom_pcie *= pcie) return 0; } =20 +static void qcom_pcie_configure_ports(struct qcom_pcie *pcie) +{ + struct qcom_pcie_port *port; + + list_for_each_entry(port, &pcie->ports, list) + dw_pcie_program_t_power_on(pcie->pci, port->l1ss_t_power_on); +} + static int qcom_pcie_host_init(struct dw_pcie_rp *pp) { struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); @@ -1317,6 +1326,8 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) dw_pcie_remove_capability(pcie->pci, PCI_CAP_ID_MSIX); dw_pcie_remove_ext_capability(pcie->pci, PCI_EXT_CAP_ID_DPC); =20 + qcom_pcie_configure_ports(pcie); + qcom_pcie_perst_deassert(pcie); =20 if (pcie->cfg->ops->config_sid) { @@ -1759,6 +1770,8 @@ static int qcom_pcie_parse_port(struct qcom_pcie *pci= e, struct device_node *node if (ret) return ret; =20 + of_property_read_u32(node, "t-power-on-us", &port->l1ss_t_power_on); + port->phy =3D phy; INIT_LIST_HEAD(&port->list); list_add_tail(&port->list, &pcie->ports); --=20 2.34.1