From nobody Wed Apr 8 02:48:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2739327C08 for ; Wed, 11 Mar 2026 05:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205517; cv=none; b=LC0Wj4LVksLj2gzy+KmxBxdpd3XAsGTqISirpWbf39ZOdU66eUZYsMyEXK/18RvsKLZYqlDez1AxuYyW1+t7Y5nXVeOdumlK7FJGjaERWFHBneUOt80YWbS9ooH706ZdmmHhfaS8i37n3zWK6+hlmSXN6v0k/XtVYDdMgpeuzk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205517; c=relaxed/simple; bh=dKd+e7VXpOLrs33EkmmfTfblgiU21vmALyxPTYH2etM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y0skGSiIeo0Ik/JEjhE1c2zVzNPDSJ3yRQsNxrZ1OYCfFQhD3AWBoH/X6Hf3IOa/O0+8Oba74iCwQM0nbbUen5LosFr71Q42urY/uguNxNVv7v8YGtrrfkOLDUVfVtVvhqPOUGm5Pb0Kghw/u0YOituoNYNjCH4cMxB5JEvIZuo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LGMYShwe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HLuWY+al; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LGMYShwe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HLuWY+al" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B2KjM1248813 for ; Wed, 11 Mar 2026 05:05:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cDxcjhAqOb/kGi+fNZPYkRZoZ7JQxWwf0K5Qbx1wh5o=; b=LGMYShwexMrfSBBz +0dssBkMZ5q7QvbhDtMJxP/Uy/jhiF2marUV+9+AiQduM5jyHHzjaJLyiWnWanPo XFtnHOHtG5bAhXAMpV0f7c0rWz4I15WUAn7vr6+LjECwq7TpnveFp3cUBpY8J8Gt u3wWijC6aQGP49eroIpyMz7JxrFjv55c9VwRXoCTlDWaAr5H7+5yRoh9jfIQ63CZ 72CPXhTjuN6qIMXDKtF7xSmRfejfgP/3iz/InXaZnj1ML9qJ32XT/ehk/Sssv1js HXZVGgQbckGBzgQS2OwXLwxnbCTRZ3I+EJf7b3EVT2v7HuuVUtadUw9Ylh0QWc8F pgMU2Q== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctqv11xgg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 05:05:14 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb52a9c0eeso11068455885a.2 for ; Tue, 10 Mar 2026 22:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773205514; x=1773810314; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cDxcjhAqOb/kGi+fNZPYkRZoZ7JQxWwf0K5Qbx1wh5o=; b=HLuWY+alFl1T7hiawZPnhv/cxNeCDv15JcGkXG5AZJzYTnwNdKlJ+hWkD3HVJ1ibwq uKaVIVkkUjbSSl7zbhwIvcgm/nXpQ4pKhPCVS6Kb7rzkg1F0HrjnBlj15gxfBmhBZFo9 jOwONxGfA3Sc+RvUlPBUE58z6MEH2K6LVE4iSRXz9AEK4XMy2FiTP1WctLD4jUM12oXw dDVOezOYmZZ2fGLDls/Z2Icz4b6bLGX1QtWu5VqcZZgXVTpPbhRKDGRwve6VquYKXpsH mJf+QXoSmpoqTcUbuU9Zjj3jOyJekcNc+LuEt5SFHnRf9B3p8v02TpVBqgtIftf7B74q mwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773205514; x=1773810314; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cDxcjhAqOb/kGi+fNZPYkRZoZ7JQxWwf0K5Qbx1wh5o=; b=sO0p4W6xPeM2sliu91B93IcU9wqolipVxQsYO8QTzgpuk/dBT2+GWrgjg+KVchfXR6 enf/b/vrk0ddlApFliDSwi5qJctlceWqwKeCVAlXF62JWhrP+lM5Ffuv7lLmAHLx0Qlv 7b9chZfFZ0o10eUx61J0Xnv4JrUv2aOAsKz75q8OKcP7ziDpcXwWQ4CZlWgn6JPeDle9 EFZc3gkTF+z1z8790IHBD8qvTCrPfByrc0kqh77XYjqP8S9kD3KXdoLkYcbzWPWDyH+d jdZBBASeG1mn3Y1u/VHntMxh94EkVOcbcZq0WI7so9WX6bLYgmogD2brQVvDTI1opHPN hPUA== X-Forwarded-Encrypted: i=1; AJvYcCW9WtRncdbdCAAg8pkoK/c6H/NNo5yvGw6ln58u5GOeoa7ucCceLyeefWl+5yZROcDCctkV/6pPDxMkAho=@vger.kernel.org X-Gm-Message-State: AOJu0YyfAg3kJwPm3oc9EUzQkjvQW1h+HvFq7JRCM19VLy+eUj5JZpI2 ltqn2It/vPxIarYpm/b6Sj8wKVBoL06umW5JpupUFTlvYLPQhkSJs4TDh7FlW65mUiOEdBrm/jr m0LCg8K8bmVyXHL/+mJyljTJ2vRzNWRD6EL2bpi6VCvnFFnqECb6lhkr6EJYDWk6hEkk= X-Gm-Gg: ATEYQzxNbisiz1+MFjzwfoq25arF0g+lrcSUVQAGU45k1bXAUQyPkVz+n2dTNOTlkdN BTr/+S0FWGSjP1HkJQXEB27NL9LwS0IEx3vKsm3Ws+NEG4O8G1OR2dCi5AkwR5ALK4Xh5d6IK5n ygru/gYpMbdpTzUz9u4f4JMFpiG7au9TTW2xRF/a4J5uaJrUyo5cSdyjlbLk8+DZrkTHhHAZ0ZU GtD1O6OkSipADTG0EIRHkzwC+xWtM0diAWGClQ/2+yHL1mqbEHxArpJ0RZpHuaQ1XVM/rwrEh3Z y2jwqWqnfobKnXtF2ujcoV0HUr0Hslrocv9GFKM2pBVDhjN0j6YQPH2eCNjfgWr1SJnV3yY5Oj1 SYmYoQf2O3iEnNFs+XmTnUCOcfAnKDEXmyvs0INtkoNeT+J/E7yuiw35d4A1ZAfxqLcIXzCoeHW OgzVept5EHkWHtUL3BFNyZIEgvvNm+doFNyco= X-Received: by 2002:a05:620a:1a08:b0:8cd:911e:2c28 with SMTP id af79cd13be357-8cda1936b3cmr171659885a.7.1773205513885; Tue, 10 Mar 2026 22:05:13 -0700 (PDT) X-Received: by 2002:a05:620a:1a08:b0:8cd:911e:2c28 with SMTP id af79cd13be357-8cda1936b3cmr171657185a.7.1773205513469; Tue, 10 Mar 2026 22:05:13 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a15635805bsm199240e87.65.2026.03.10.22.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 22:05:11 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 07:05:03 +0200 Subject: [PATCH v3 2/8] media: qcom: iris: use common set_preset_registers function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-iris-platform-data-v3-2-f02258c4d4ed@oss.qualcomm.com> References: <20260311-iris-platform-data-v3-0-f02258c4d4ed@oss.qualcomm.com> In-Reply-To: <20260311-iris-platform-data-v3-0-f02258c4d4ed@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=6432; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=dKd+e7VXpOLrs33EkmmfTfblgiU21vmALyxPTYH2etM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsPgAXv2pf7kX2wiaYi5akWFnHVf3XWbCsFzEF C8jBMi7RQKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabD4AAAKCRCLPIo+Aiko 1chCB/4obfNBTcjckosdatnmMiNrIZfs2KniMO5fgqDXKQwAfuZS5pVpjFUhl5Sh5ntkqMoO06d pSTXIr6jmDwP1Atga7n4qF6lbl2dMzegYgW84yjNgFEZOkoi3oim0j3CuHAPgsmnfOAPIyZKb0X tBfiAVe/5gg3VUabphByrpJVkA+XbcSt5YE+xFGRkYJmYaTDToNd7FY53Mxrcf2/JqQMKKhUDVf eMBP35CTEYKbXxGPFyQ7nCFmoY2iiou/Gf+leSrXvwY59UYiaM0bzqz/eQWLk/MjkFGkBbPszBP h6j6a/Y6+kup61AT0q4k0rQocggoRSMKJmJtE8lxV6ui6i7e X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDA0MCBTYWx0ZWRfX2ewoFk0yqEFH +xV5umk6GzBuhkoGpohkBfLkEZMAF7qU9KxA6vorbZKu4trTVXE6z1+ya4KPzrZ9TUtquzYNIJr ZJwL2Zn2VWBylNrx3+YPsnt1wsy0yAW9M+CcsH0KiV+GrTehS79QV8ZzXpGAyePcK8KAOWOQZUz 87hbqvuFrpN1dbLLuCibh5uA/KidI5DM4c5q9QA4cEAHO5jfaT9Ywy2lgoOLbIdVZSeEvpwy6qj 6RbL7ScLm78uieeVlr8icEIsszRBB40UZkzEk/MicgSg924Xh4B/AQ4Jirdi3COgRgqCswrFJ86 Q4eDwAAl0bP6oCdU6EwMJQT2zbS1uZtNPJ7E15MhUQnrE9YA+Ucvqx4jG2JL2hr/bJXpCVGCTqw nTMdO6hCXIafnjYw5n5sWiTmLVvpT2tWr7Y3SAZDT5t4MV9DGGhWpKA7XLJEm8+Bzowg3TNYm7x Znk11eRXCcLRxJVqtIA== X-Proofpoint-GUID: FSktkdnA3qVmiVg2qStrpi41M0NMfRkY X-Authority-Analysis: v=2.4 cv=S5vUAYsP c=1 sm=1 tr=0 ts=69b0f80a cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=LmgrmXmU8fDMlo1BKrQA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: FSktkdnA3qVmiVg2qStrpi41M0NMfRkY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110040 The set_preset_registers is (currently) common to all supported devices. Extract it to a iris_vpu_common.c and call it directly from iris_vpu_power_on(). Later, if any of the devices requires special handling, it can be sorted out separately. Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - drivers/media/platform/qcom/iris/iris_platform_gen1.c | 7 ------- drivers/media/platform/qcom/iris/iris_platform_gen2.c | 9 --------- drivers/media/platform/qcom/iris/iris_vpu_common.c | 7 ++++++- drivers/media/platform/qcom/iris/iris_vpu_common.h | 2 ++ 5 files changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/driv= ers/media/platform/qcom/iris/iris_platform_common.h index e4eefc646c7f..d7106902698c 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -207,7 +207,6 @@ struct iris_platform_data { struct iris_inst *(*get_instance)(void); u32 (*get_vpu_buffer_size)(struct iris_inst *inst, enum iris_buffer_type = buffer_type); const struct vpu_ops *vpu_ops; - void (*set_preset_registers)(struct iris_core *core); const struct icc_info *icc_tbl; unsigned int icc_tbl_size; const struct bw_info *bw_tbl_dec; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/driver= s/media/platform/qcom/iris/iris_platform_gen1.c index 07ed572e895b..ed07d1b00e43 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c @@ -260,11 +260,6 @@ static struct platform_inst_caps platform_inst_cap_sm8= 250 =3D { .max_operating_rate =3D MAXIMUM_FPS, }; =20 -static void iris_set_sm8250_preset_registers(struct iris_core *core) -{ - writel(0x0, core->reg_base + 0xB0088); -} - static const struct icc_info sm8250_icc_table[] =3D { { "cpu-cfg", 1000, 1000 }, { "video-mem", 1000, 15000000 }, @@ -343,7 +338,6 @@ const struct iris_platform_data sm8250_data =3D { .init_hfi_response_ops =3D iris_hfi_gen1_response_ops_init, .get_vpu_buffer_size =3D iris_vpu_buf_size, .vpu_ops =3D &iris_vpu2_ops, - .set_preset_registers =3D iris_set_sm8250_preset_registers, .icc_tbl =3D sm8250_icc_table, .icc_tbl_size =3D ARRAY_SIZE(sm8250_icc_table), .clk_rst_tbl =3D sm8250_clk_reset_table, @@ -397,7 +391,6 @@ const struct iris_platform_data sc7280_data =3D { .init_hfi_response_ops =3D iris_hfi_gen1_response_ops_init, .get_vpu_buffer_size =3D iris_vpu_buf_size, .vpu_ops =3D &iris_vpu2_ops, - .set_preset_registers =3D iris_set_sm8250_preset_registers, .icc_tbl =3D sm8250_icc_table, .icc_tbl_size =3D ARRAY_SIZE(sm8250_icc_table), .bw_tbl_dec =3D sc7280_bw_table_dec, diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/driver= s/media/platform/qcom/iris/iris_platform_gen2.c index 1f23ddb972f0..c84d4399f84d 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -756,11 +756,6 @@ static struct platform_inst_caps platform_inst_cap_sm8= 550 =3D { .max_operating_rate =3D MAXIMUM_FPS, }; =20 -static void iris_set_sm8550_preset_registers(struct iris_core *core) -{ - writel(0x0, core->reg_base + 0xB0088); -} - static const struct icc_info sm8550_icc_table[] =3D { { "cpu-cfg", 1000, 1000 }, { "video-mem", 1000, 15000000 }, @@ -917,7 +912,6 @@ const struct iris_platform_data sm8550_data =3D { .init_hfi_response_ops =3D iris_hfi_gen2_response_ops_init, .get_vpu_buffer_size =3D iris_vpu_buf_size, .vpu_ops =3D &iris_vpu3_ops, - .set_preset_registers =3D iris_set_sm8550_preset_registers, .icc_tbl =3D sm8550_icc_table, .icc_tbl_size =3D ARRAY_SIZE(sm8550_icc_table), .clk_rst_tbl =3D sm8550_clk_reset_table, @@ -1018,7 +1012,6 @@ const struct iris_platform_data sm8650_data =3D { .init_hfi_response_ops =3D iris_hfi_gen2_response_ops_init, .get_vpu_buffer_size =3D iris_vpu33_buf_size, .vpu_ops =3D &iris_vpu33_ops, - .set_preset_registers =3D iris_set_sm8550_preset_registers, .icc_tbl =3D sm8550_icc_table, .icc_tbl_size =3D ARRAY_SIZE(sm8550_icc_table), .clk_rst_tbl =3D sm8650_clk_reset_table, @@ -1114,7 +1107,6 @@ const struct iris_platform_data sm8750_data =3D { .init_hfi_response_ops =3D iris_hfi_gen2_response_ops_init, .get_vpu_buffer_size =3D iris_vpu33_buf_size, .vpu_ops =3D &iris_vpu35_ops, - .set_preset_registers =3D iris_set_sm8550_preset_registers, .icc_tbl =3D sm8550_icc_table, .icc_tbl_size =3D ARRAY_SIZE(sm8550_icc_table), .clk_rst_tbl =3D sm8750_clk_reset_table, @@ -1212,7 +1204,6 @@ const struct iris_platform_data qcs8300_data =3D { .init_hfi_response_ops =3D iris_hfi_gen2_response_ops_init, .get_vpu_buffer_size =3D iris_vpu_buf_size, .vpu_ops =3D &iris_vpu3_ops, - .set_preset_registers =3D iris_set_sm8550_preset_registers, .icc_tbl =3D sm8550_icc_table, .icc_tbl_size =3D ARRAY_SIZE(sm8550_icc_table), .clk_rst_tbl =3D sm8550_clk_reset_table, diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c b/drivers/m= edia/platform/qcom/iris/iris_vpu_common.c index 548e5f1727fd..faabf53126f3 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c @@ -468,7 +468,7 @@ int iris_vpu_power_on(struct iris_core *core) =20 iris_opp_set_rate(core->dev, freq); =20 - core->iris_platform_data->set_preset_registers(core); + iris_vpu_set_preset_registers(core); =20 iris_vpu_interrupt_init(core); core->intr_status =3D 0; @@ -485,3 +485,8 @@ int iris_vpu_power_on(struct iris_core *core) =20 return ret; } + +void iris_vpu_set_preset_registers(struct iris_core *core) +{ + writel(0x0, core->reg_base + 0xb0088); +} diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.h b/drivers/m= edia/platform/qcom/iris/iris_vpu_common.h index f6dffc613b82..07728c4c72b6 100644 --- a/drivers/media/platform/qcom/iris/iris_vpu_common.h +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.h @@ -39,4 +39,6 @@ int iris_vpu35_vpu4x_power_on_controller(struct iris_core= *core); void iris_vpu35_vpu4x_program_bootup_registers(struct iris_core *core); u64 iris_vpu3x_vpu4x_calculate_frequency(struct iris_inst *inst, size_t da= ta_size); =20 +void iris_vpu_set_preset_registers(struct iris_core *core); + #endif --=20 2.47.3