From nobody Wed Apr 8 02:48:27 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE74324B23 for ; Wed, 11 Mar 2026 05:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205513; cv=none; b=F99FrC5QW3h5kQKDETwKbI7nw5tAxgylMiT3QgZ22UcFRDQAA0oGkbDECVXcLhlEIvk0nYQWKmoWrjZXprkbh6SNEfqgOyIcvWqvZe765Yyd3DJfFd21Rik+CbgMCHwtpyW+/xPukKhRsR2kg5PJKG2zmz9z8eDgrBT8VKiOPzc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773205513; c=relaxed/simple; bh=upK6uBmdFj3L01J2+uso9YhOoCCeQIlN/0kiddAlHQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KIq8+uDK8ksfvXYmQuw2S+875r/xn1n7cv/mzhsqBCpKmtbuSc7TABFS5/tJY7GNVD0qBDvznwc7ONX+gbdvnYt4cBy7Z6wdmfHm3pfM/P1oxFW7Qv4ET6ameYmmBMi1dhNlnW8j+8dgkP/1Z4+4Y5ZEyaQK+JcQecjSIX/o3aQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S0uHjVP/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VpZANF50; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S0uHjVP/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VpZANF50" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B3VANc614004 for ; Wed, 11 Mar 2026 05:05:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z4EIReUVZDLLFKrNuhEc4keZuSe+ZzG9lS8i32XVEH8=; b=S0uHjVP/AnAiRjiN JFlaibyCbMlTt7nrBx9YSmHSfyDLpKORcUxRoWa4/ugbl4qTjNfNeaeZhVAxT83y kdF78mBH06pFGvQ1FOLoz41r55abDUYOcc7/Jm/aUHsj1hLLoWGAr1cUY7so4URA mCALXe+ttum3Gz2HKbi/SuzRL/Nb5fsu7GatO3pARhpfmRTRMR/S1rjgl5bTxNrY e3j43VLzNvwNTp9fqlS+24K0g8KqbU/Ci2zbWR89fmiHpEQ6UWXFbXRlWmis0fHg nOF22paV4Tvus0SCksgCsJrgbx1gLvZ5cb+vvmqG+5vgXR80ZUCazyoCT1Qs/92t AetBcQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu0jf085u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 05:05:11 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd81ce6fdcso3147318885a.3 for ; Tue, 10 Mar 2026 22:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773205510; x=1773810310; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z4EIReUVZDLLFKrNuhEc4keZuSe+ZzG9lS8i32XVEH8=; b=VpZANF50mbEJPbJl9fClkQk+OWqpGEiNRe+XBv4XTeiEaGsgH7BxkQ5gH6EPx4GRho AsZwpJMZ8fykIDABERdJSgPNkq09NNOQlTaznPKrftcqo1gbyeEXsKNCCo9ze+P8PIyH ihgb9xrj4uujQj6JWHmeB5hlMBOVlUR1EW7qGl09XHhdsHC4OEdNIeOMcTm56EgKzQLv CJ6IJnuWKGf2Vc1WA9qaTpThgJNfJFFCRiyY0y/3myyjsCjfbK/Q8CnsVzCf1n4H0/gW EsLM5vQjhCM4z28AFYT8RS+b2ODaJg5DkjxidJqm9w5hESuGFPwpo7babLoGOqdQRxX+ 5CLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773205510; x=1773810310; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z4EIReUVZDLLFKrNuhEc4keZuSe+ZzG9lS8i32XVEH8=; b=HepToIFt01ZuSMGbFFM81s4aSYlOsMdmpKS1NJ0cjMndV/PdY6MGwoOSR3CygeBx0r ycjo+hL2jDD1bKzdPO3z+e1YUjbSX4m64nKlPrbqnSaXErM1grBqnejZy9lxAIUZKvCZ RvOmq3o/pU0RVs6wJmRqnKA6brKC7/w20Rl4uWebiN/rpeX5QAoGuJXyeyPWaiy+x2u8 mdG/lSsYBCJlwpsVf1iL9cHVJx+LLNdbrwNuOPG1ZQZ8S4GoF8pWl/hwnIlzcRxdYtYK HDGUJWFHz/NrmZGHMy1Duf2JP/pXLCxzFp7rCkNcCAkxjtv6Okuu0jbOTJx03F0JspKl eZnA== X-Forwarded-Encrypted: i=1; AJvYcCX95Yu9ff8T0PpnPqoazNgus2cW0kqWttUxTMSA28XLf3D0in5yNJesAS8HL7Xh1hknu3T6CK0T4L3kCHk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5FBfGY+TBKJ0pVjbYkorL+VHR52llde4MyLQJgEUs0Ok7aGjv wwvnSO79xTj51zVU2S3UlitIs5pO+Nkm6vc7SQecxI3EGDZ1i5z9AYdMwYvtyh2zKBfmXcHRghe cKajniR5nCdZbl8kbdEbsXQDUfodqr+7j119U9YU7GdsraP0I9ZCfTW9Id9xp7NNa2MY= X-Gm-Gg: ATEYQzyiHRa4ODUmNs3DuYAWACuxfE8bl2iEZ3ReJZ2Pw9mdci5F9S3+x2Bb/QqjIxs N1C+XfyYTrIX2NMWkyP1tlVHkyrx25bQe09gemFDbIV89U8J0r6s3J4x4/EV9EdFwCJjIWqhRWW b7faoXS8vJfvm3Ve96hKjaN/a+UGeTi5Ou892x6gghhuYGMyDzNKNn5ZwPgWkcULOPeuca5tpLY FVoOltiPu4B1RwhQOJxnICWf1tyRoBTuuJh5scQb2/G19epbaynPhBjtHTEkbwX29LWdiI96z6G Uep4B7oM6h41oqL1Xk+m6kALGW9XOIq14RG7jgkbKSZ3UUpp2LFAi8kYlFILd0AtDPV6yga7+UL 3sU8CufjN8Ji+YEbzMN7Mg+LOstOT2OYVNi1QZdUD53aVnvSgnZMxa+uWL+NIuPOg+6wcrCCAUn TX5xxqJfvO6GqfQzF1YvyfvIsb2XB6jjHDSPU= X-Received: by 2002:a05:620a:4485:b0:8cd:98c1:762e with SMTP id af79cd13be357-8cda1a56dd6mr173832485a.63.1773205510023; Tue, 10 Mar 2026 22:05:10 -0700 (PDT) X-Received: by 2002:a05:620a:4485:b0:8cd:98c1:762e with SMTP id af79cd13be357-8cda1a56dd6mr173829485a.63.1773205509578; Tue, 10 Mar 2026 22:05:09 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a15635805bsm199240e87.65.2026.03.10.22.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 22:05:07 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 11 Mar 2026 07:05:02 +0200 Subject: [PATCH v3 1/8] media: qcom: iris: drop pas_id from the iris_platform_data struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-iris-platform-data-v3-1-f02258c4d4ed@oss.qualcomm.com> References: <20260311-iris-platform-data-v3-0-f02258c4d4ed@oss.qualcomm.com> In-Reply-To: <20260311-iris-platform-data-v3-0-f02258c4d4ed@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=6161; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=upK6uBmdFj3L01J2+uso9YhOoCCeQIlN/0kiddAlHQU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpsPgAFqDolu63ZYTEYBbJ+rNqr1zfdMJDfIxS7 Ef/YsmriI6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabD4AAAKCRCLPIo+Aiko 1fc3B/9j2jNlSMK7bUjKfGmV/cmenjJYbbq3NwiS8mcYCJaYmRQFaBqUWrYGMnFvVhTMkkeBNo9 MAdwYSw9NS9JP2rNeBBARQt0nkrltk6/Clr4IjUT+xFErKPJTC2c+1guv6cianZXFflw0FZV89q 4LiBX39bKfBZrBYzm0VtLhzlMgdGJxfvNwtifUNkSE8ui6rT5MWfrzutM4vPyLaXcg9dq1TsbIb EoSLNwMJu47YXSLQGrV39BQ930LTiE6rlqIIQq2XvtrZMKFBLwNpSC/tJkU6gzCu5eq/G9bhOYr ljQ4pr0XurxEd8POM5MOBfNwnnO194i7K++YiO14uy+44PgQ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: i73r9gwlIngg_kj0CYl5q2OXuKS3e88O X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDA0MCBTYWx0ZWRfX30s8xAxf21QO bH2dsFYH4tLpEgHRxRZ/kwdNverSO2BosjnSWMCDjMEbjfy3x3+DkMw9wGhIB+nRA8yjZLSO4Y9 4tncZuUWylqk+SgjDAGwFAaInOPJRmjF0VdlsqubsPuM0mlpYSa80U9ADXtxcC+gr2iyty3Gksq OcJoc7sIGABWnSC2C/tBAFZTubvkDPfMRDnBvz8+xFWnuj+LudZtFQVL6tROX9OmlocNZfjzpFN /rk6Jzde50aPHhQSdhdExZ3NWO3d/X4xcEO1TxWbG7o94RPXGXqxzaQqwRVKXlKfS5SYtOlYQY0 c94VXae4Tf2JiaRkJjW/DKap3fg/h3HqhdX1Jq7cXL8x39BljUdRp1YxnN8j0m4/URZzy1QRLak faInvU0IvIckrUDMVhetVKMFN8CXcs5laSSpS5JYfeqw9CrJ41lnTgBRHkFdVzPPOLZrjH5zZz0 tgbfLMv20ZSPk/F42yw== X-Authority-Analysis: v=2.4 cv=FMMWBuos c=1 sm=1 tr=0 ts=69b0f807 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=hYMYe-gnznq9qBW6PAEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: i73r9gwlIngg_kj0CYl5q2OXuKS3e88O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_05,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110040 The PAS ID, the authentication service ID, used by the Iris is a constant and it is not expected to change anytime. Drop it from the platform data and use the constant instead. Reviewed-by: Dikshita Agarwal Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_firmware.c | 11 ++++++----- drivers/media/platform/qcom/iris/iris_platform_common.h | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen2.c | 4 ---- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/med= ia/platform/qcom/iris/iris_firmware.c index 5f408024e967..bc6c5c3e00c3 100644 --- a/drivers/media/platform/qcom/iris/iris_firmware.c +++ b/drivers/media/platform/qcom/iris/iris_firmware.c @@ -12,11 +12,12 @@ #include "iris_core.h" #include "iris_firmware.h" =20 +#define IRIS_PAS_ID 9 + #define MAX_FIRMWARE_NAME_SIZE 128 =20 static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_n= ame) { - u32 pas_id =3D core->iris_platform_data->pas_id; const struct firmware *firmware =3D NULL; struct device *dev =3D core->dev; struct resource res; @@ -53,7 +54,7 @@ static int iris_load_fw_to_memory(struct iris_core *core,= const char *fw_name) } =20 ret =3D qcom_mdt_load(dev, firmware, fw_name, - pas_id, mem_virt, mem_phys, res_size, NULL); + IRIS_PAS_ID, mem_virt, mem_phys, res_size, NULL); =20 memunmap(mem_virt); err_release_fw: @@ -79,7 +80,7 @@ int iris_fw_load(struct iris_core *core) return -ENOMEM; } =20 - ret =3D qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id); + ret =3D qcom_scm_pas_auth_and_reset(IRIS_PAS_ID); if (ret) { dev_err(core->dev, "auth and reset failed: %d\n", ret); return ret; @@ -93,7 +94,7 @@ int iris_fw_load(struct iris_core *core) cp_config->cp_nonpixel_size); if (ret) { dev_err(core->dev, "qcom_scm_mem_protect_video_var failed: %d\n", ret); - qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + qcom_scm_pas_shutdown(IRIS_PAS_ID); return ret; } } @@ -103,7 +104,7 @@ int iris_fw_load(struct iris_core *core) =20 int iris_fw_unload(struct iris_core *core) { - return qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + return qcom_scm_pas_shutdown(IRIS_PAS_ID); } =20 int iris_set_hw_state(struct iris_core *core, bool resume) diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/driv= ers/media/platform/qcom/iris/iris_platform_common.h index f42e1798747c..e4eefc646c7f 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -12,7 +12,6 @@ struct iris_core; struct iris_inst; =20 -#define IRIS_PAS_ID 9 #define HW_RESPONSE_TIMEOUT_VALUE (1000) /* milliseconds */ #define AUTOSUSPEND_DELAY_VALUE (HW_RESPONSE_TIMEOUT_VALUE + 500) /* mil= liseconds */ =20 @@ -226,7 +225,6 @@ struct iris_platform_data { unsigned int controller_rst_tbl_size; u64 dma_mask; const char *fwname; - u32 pas_id; struct iris_fmt *inst_iris_fmts; u32 inst_iris_fmts_size; struct platform_inst_caps *inst_caps; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/driver= s/media/platform/qcom/iris/iris_platform_gen1.c index aa71f7f53ee3..07ed572e895b 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c @@ -360,7 +360,6 @@ const struct iris_platform_data sm8250_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu-1.0/venus.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8250_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps =3D &platform_inst_cap_sm8250, @@ -413,7 +412,6 @@ const struct iris_platform_data sc7280_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu20_p1.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8250_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps =3D &platform_inst_cap_sm8250, diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/driver= s/media/platform/qcom/iris/iris_platform_gen2.c index a526b50a1cd3..1f23ddb972f0 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -934,7 +934,6 @@ const struct iris_platform_data sm8550_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu30_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1038,7 +1037,6 @@ const struct iris_platform_data sm8650_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu33_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1133,7 +1131,6 @@ const struct iris_platform_data sm8750_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu35_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1232,7 +1229,6 @@ const struct iris_platform_data qcs8300_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu30_p4_s6.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_qcs8300, --=20 2.47.3