From nobody Tue Apr 7 21:26:53 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96FDE38F92B for ; Wed, 11 Mar 2026 20:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773260262; cv=none; b=A9awhUh8Y6HtdcGQeHDRcLcDRyiNPkVdeZzYgFm+LxYJX12Ws8Rth8UkqlLONh1cR6oJi/w5bQGOsW6RsjT8Ke5bjEd4iLZtEgaGAyG4P1loUuFwQuHKHW3LEdbBUY8HzWgJkEKYFxBgGLHEW7BFlk1NuEnTmDJZJV9WQWFEWKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773260262; c=relaxed/simple; bh=cKeuUxvKam9PYjthYzvdvrZ0HPds02yhZieULog6qvg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U+Vd28V/qt5XsfY48+Sfa0BJI/SfDZBcFSamX8B5Tb7Sv3d4qgXhxVC86Dqmdm4gE1LN/W/e7Jp3P517cxtf7xkoYycEVOfk9s5gpT13ZS7Ij3z4fHFXLo0Qn825WWgXGcOqD2xRmInGf7RCogWQcHlK3/z2q73mnst0jdnnGw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KCWqWiOE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D3GKGq75; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KCWqWiOE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D3GKGq75" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BK27cx4032609 for ; Wed, 11 Mar 2026 20:17:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IctiJKzFga8uaoriJYS2d7YQbSXoOC3YlhoWAOwIcBE=; b=KCWqWiOEJeY3hadC wS62c8gJ0nsvyWJ6BVuAEso34vcsVKmHkW899r2bacf6o0gkZrlAfXG1sYvXbAyW ZlxDW4ewUlMDDQz/NJUuKrT1OCxxLXziQju1Am3z0o9Ib3/+kcnVtOhCRmhtmjjn luuuV8V8Iqi4sn+NwBHiU2sA6H9ZLYWwNdsB+XtpBWZJ6iv528dmXTGJdt745pgI eo12qkxEKQwRvlbuKzIpzox29y7GE2dQDjR/dTgqaoT8b7yipGVfqSlgfxIrnA1g HuG9J+pmwBhRI7nTY+NYwmoqRib0CisbN7LoEIc+d1Fjy/2ZWDvpOWaKrULBtyHr 0rtbSQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu90t9j56-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 20:17:40 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb706313beso44090085a.3 for ; Wed, 11 Mar 2026 13:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773260260; x=1773865060; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IctiJKzFga8uaoriJYS2d7YQbSXoOC3YlhoWAOwIcBE=; b=D3GKGq75eEz2mvL8yKxyhkQ3jELiVKT4pMTMZhuYy0+6vVv/zTaMsHIPNHz5poBul8 cAK5fgtzz2AvIKeI3PUkZk5ngkitFsVClc8Id0FyD4/ZRlMOs9i4YtflXJGeU6Fusoc2 v0VZTIQqfHRQXyCPAidJOrEPPpIq2n6YEdO757vc3sw2/CJwlJubGsuuQK2QBeEqlUfq re11zYsnEfxpQThxmkCnXagJrg73c536qCaFzjGphJEn3vk67T6thVO/ZVf/uZxM7TuP 9eCUk/E+RueiXBE9oLSF0dHXP5AacRA3SacyX0NO5+TcB6F5umPP15BCkRs15mLXK43N +7zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773260260; x=1773865060; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IctiJKzFga8uaoriJYS2d7YQbSXoOC3YlhoWAOwIcBE=; b=Ly4cwMsXBx/cXdgdbQQxaGp4toenvTi8KadzvzDlLprw35/XNzKVbz212ffgResIUt EZUo1MOeKKAu3A4uh1droD5dhBF7kGBLghs8VJBDfOS00zUiKnp8iNlXejOQ3bLoQrH+ R8nBettfyOskqJOqJs++iFgrdCU57H+k1LovbmW+K9Zp1u70wtttuZJXI8W/vjvI3XE9 C4B22a4eCC7KjyRzKEgugNste2fRhaWA+I5ko3gFSYvuVNqm76o9LxktotN3yrY/HEAD Lh/s0cd5L7quKB2sb94M3vD0cgyalK2jmwcbIOieErE1/P+DMU5mH1ary0wjMRINw3bp CymQ== X-Forwarded-Encrypted: i=1; AJvYcCVH2Tq9RwXYpd3g/fzUJZfe49nDXsyas2JKadFjNHGOBQYXFC0V/8oWkUQ9hwzUE0/uNOh1nUhiThEZ1ao=@vger.kernel.org X-Gm-Message-State: AOJu0YxPTUKEQyKTURkN/QIiVhNzO3RL35TaIpALD9s9dheFnONgSR2t d9HRIhBy/cYcofUA43+vwFxd69Bqx7k/WCgiyokXghRLlLHmZG64qI6PI2chWbHxx3+ey8vrmoe McVzDTBpLu4KgqpWzMkmMD+8ZdXHEIcjkCJGTX1RlAhZ07fHsHmc4IoL06sEM/so0s4w= X-Gm-Gg: ATEYQzyV4D7fdXIUgEznWZ/3O2+cIwoieEwSxgsbNnhhyNr5PcFwEwfnjB+lJlp7/L6 tvCOeRQDf+0aaAd7B4Vlng4NoxMdMXVJuktorujfjBrc883fphQAovi3O6Yg94Gkibe4F+b6njm Ug1AVU51VBy6nnoIjWPMpIkfO2p1VC/4XONwz4QtAuS1dmni1yTe5WQ7kYh1bFsFkyyIc+TxKei EDtjIMoFqbc6pDUo2k3LLxegMC1TW8M3p3pBXL3v19rSWiQL6wqtV7jC6DVJpbkyQ4+OX0kVxEK um9R42xK42EKe9czazIxoSwGTa0LEaoe70Re6sNXD0z65mC0JaolEqcoU7hn066Q+jCuqcM+beJ 77D4QPXz3jMAbh3sbZ3noJn4Sg/0SuCBOQlHvTudc+poY X-Received: by 2002:a05:620a:4608:b0:80e:3af7:7a0c with SMTP id af79cd13be357-8cda1a2d86dmr478179285a.43.1773260259846; Wed, 11 Mar 2026 13:17:39 -0700 (PDT) X-Received: by 2002:a05:620a:4608:b0:80e:3af7:7a0c with SMTP id af79cd13be357-8cda1a2d86dmr478176585a.43.1773260259393; Wed, 11 Mar 2026 13:17:39 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b65fd3dsm79257255e9.10.2026.03.11.13.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 13:17:38 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 11 Mar 2026 21:17:26 +0100 Subject: [PATCH 2/7] drm/msm/hdmi: Avoid double error print on msm_hdmi_get_phy() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-drm-msm-hdmi-cleanup-v1-2-c5535245f6de@oss.qualcomm.com> References: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> In-Reply-To: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=914; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=cKeuUxvKam9PYjthYzvdvrZ0HPds02yhZieULog6qvg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpsc3XvpzTqDQBfvwACXsB3YLTwN5yo9Pd14XvD ywA1VAQbtyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCabHN1wAKCRDBN2bmhouD 109ZD/4se3ojRQZtYZkaaQQDlKwDOo3S92l9zAVqZ0fXP2et9tbZltOtUyDphgaQ1tGglCwn0pA vkOn3KAMfUPGYoS0dx9YGttBI0GRE2PsAEawERzZp01fH/i4CKhICGVhCYdKs7jAMAq1uqTZ8cJ ZjF/JUf7yVQNIZFMLn660vp7GRDrlYG/1wik0SA2VmeBxw0dKWHZcBelbHRhbBwmKn62LYqj9XQ axg65JTZ14ab0y12qTGqOhWop5SlPFd//siYUhl6qFqE3wy2D3Ih0gUKH3JLUgVREfrYdURxqj3 6Gg56FETRpRnNX583bO7z9raBzHcqlCFqFJDZvOBvSnN00ROGo5/j3tGB5uHwRc6LOAf0prZ4nK Cx/Tq93mOcY538UehUbLughNs41PO+EtddMzmEkvi/j27IGTTCohT96fqoFkmNQd1YdGdPQuV6S RUYF2plnkzjtXFjnMoQtO8bMcimTFwDiVpBYjYVrTduiSDMJvB2Z5/f9YntDJ6kFKSMEZRW7Fw9 lj+FwYnsMSIuXEkzA/bmobBEQUtr1YtuTmHKQVYCG56KsGkgbZaNTvZNgOnoirNL1p4HUQrAnc6 zfd8tYD3sfpFRGB5hW1L9iG4E9oXMw/2CUDJ8hXHdYLMKesRsq2xj2QzszqqKauU+J6E98k2Hkh KoK0MUzqzV9vK+w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: rlRr9QRN-iv0c8y-B6uJLOsP4yCFgQhW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDE3MiBTYWx0ZWRfXzxxwHYbm6uBf YpbIJlLzu08KgHeQ0SXnvtRnGvRc4F/Or7XRoEdhE+U67OP1h1cvG2Rh+r2vU5w/R895/w98g8h 7nViUU5pafcBcv7UBOhgzXCu8AdEviRMaXCJmRQCf2Kjn0OmhZbHlQRlL7/wUQgjF4a5AeEaMIU UJOq3YUuXIKqAkfKCbCCdWw+Y9lohHxRsGBIGyXIKTNyOHL/rxpyzM7Gdq5wuYtJl9z1JDJGm7K Lr9CGj4aSqYfy4mwYAlkWqDwxUN7CEiOebGX2e8OHLuNlcCp9fkUI4ibCESdYcRFR5rwzPiivq0 FxJhw3YzjlCykoUH1pRYmB+DA5IRsWt+vbX/dzw6LNDN/8SwE/cG0Ec0pMUmo9pMxWcxxrC1hcL prhXWj3xgmv/g/mdwqjOhl7blzevray326ShzfEsb5qUymlr2vuMF5m0ATckJZ+FvGLx3Hp59rF QYwrMntzyaOW2bxF37Q== X-Authority-Analysis: v=2.4 cv=DfEaa/tW c=1 sm=1 tr=0 ts=69b1cde4 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=kDavz4lrka8aSrD8mlAA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: rlRr9QRN-iv0c8y-B6uJLOsP4yCFgQhW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110172 msm_hdmi_get_phy() already prints error messages on each error path using dev_err_probe(), so final DRM_DEV_ERROR() would duplicate it and possibly flood the dmesg on probe deferrals. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdm= i.c index b1db1b597901..02a87bccab77 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -358,10 +358,8 @@ static int msm_hdmi_dev_probe(struct platform_device *= pdev) gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD"); =20 ret =3D msm_hdmi_get_phy(hdmi); - if (ret) { - DRM_DEV_ERROR(&pdev->dev, "failed to get phy\n"); + if (ret) return ret; - } =20 ret =3D devm_pm_runtime_enable(&pdev->dev); if (ret) --=20 2.51.0