From nobody Fri Apr 3 01:24:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6575A3CEBA7 for ; Wed, 11 Mar 2026 10:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224831; cv=none; b=NJv9/46Nt0LL8JEkS5YgvwMXVrefea9p/BzcXLbQVg/8ReoEiRGo2NUoeJmXO+mdUdibIGtEIQvvp2X0dDmMKX/nY3zkpFlZgdsPnLsFkb9fhFwwOsssV61d7wPOPvRyBLYmxm/4huytjT93yj8UPO7oxf49yamvulS19D7XLpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224831; c=relaxed/simple; bh=pO8vVScrKCYroJtbrmCEg0jsQAkeOLwy64wLlBodYLo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KwIOQPSyJa5ZdaDgwOufwNXGVExy8cpQ16yEK7PQfBQnXhLDTDmmF0o4Lzu8bZU3+uS/+fOGCJdVGdUyCh390C0PysvSxUkHoB7GmZ75f5/18gJxdq21EnTRq+YuaGFPsmtmFcXutshgDdfGM3LVPTuQxTQVlpcW1iO9QoGWVSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=npOBf5Ea; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xp370KDI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="npOBf5Ea"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xp370KDI" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B9PfTa614004 for ; Wed, 11 Mar 2026 10:27:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RUOhnCtucPISnasSan3rTKScJjVUfYHl/P5qU80U71Y=; b=npOBf5EaqDgpNRp/ eJChLrp+bcqb7qUFw7PsXocRwTdCeZjkLZ11TegHFzDPY0sT7MtX9fYrUXyNcH0f daT4UdxHQtkBaPboSxi3IS804Thcb3CTRw5X352M3rLLLB91huy2yVN56JUKT6Zk yU4HeEJVvoF7QHSTHYYU9pbzXXZk1P62dhnIaK7am7FTQCpVAmdzyinqOkQNcYR4 MAj+eu4mzuWUI+LdIcV28b+NLXgSZN3xl1ayGn2kByH9eVMreO+ejYQ83pI8qXgc dsyM0NhRCb1b0jpZHMqfeFWW2yzvdw6GCSgBvkAJgQZtaWnIngXaOVm273F1uPjU xq5fsQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu0jf1fc4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 10:27:09 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2aeabe9b4bbso6161375ad.0 for ; Wed, 11 Mar 2026 03:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773224829; x=1773829629; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RUOhnCtucPISnasSan3rTKScJjVUfYHl/P5qU80U71Y=; b=Xp370KDIecRKXnk1kZ3S5gWy/iFF1jkuN+9CUWa5x4Z+tfE3wM/8ZI+S4qoTTVtRlT HGshr+mdpdmXzKiEdYqn2WK3j+MEsYpKQPsHeZUVk++ABMIL4FJfZ8YRXCTyR+vMv4xI 4PGdn9XZN50Fta8uV81WQZdFshrh+pi5pgWFK/yzAYVIVK7OaZbHcfnGhCoQ64q68ZGE 0aiWO8M/SVO5FDgJm2oEPA53aoy0i6w9NGWSqPzcqnUKpxgvvItxlAVM2YHY8p5i2yBc n4eiWy5KgCBjSHd+oOnPcAMx5dbTWgDIGrN5m7ggi23HYZ7UfDLCQlldkai2epYjMnlR qOWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773224829; x=1773829629; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RUOhnCtucPISnasSan3rTKScJjVUfYHl/P5qU80U71Y=; b=uAh927EX4sTR1Ebbwxv4WTPylLU55OqjUOfdu2ONpfENEn9rCLhyvPApGXiRiUrjOa SuvG+MTK7Lrn8l6R7t6M2fqAQUYaNjnL4WigozN+xiEErSAokZYteCghnzK7MpFpe+Rl utF1eSbvI8U3e9Wh//gn/tkUxrDYV76/8Qd5BoY9YeDw/0V2d36y+PDjpXd+NIiy6sF6 wDz/OEjnH6GvDG+BmVlOK6YKrUSEdD1IFTqNGgQoDJSsFaSD8SFHlD/AniJBOcnRoqHv 27/IteTHRfN2IrEOvIePugDoRanUp6+iRgPzK03QIulXTNEYPVxMRAou8cdTGcVTdQKY Fadw== X-Forwarded-Encrypted: i=1; AJvYcCXHLpFWyY2VtPhBPmJQ38dLjGMhKmEvuIJjhbCUG7cnKe+a/pGw28SLC6uaFzvYFEXEBTlmO+yeG/YQWdY=@vger.kernel.org X-Gm-Message-State: AOJu0YwEbAgVyHWsgenGHmD/nLhfq4isZ85kksgkDel29NRxSKx4yARf zxIlvW532E7xw7DGeTvFZj79Vu4+N+Y1qe/KN56rDXN6vB1rbbHNgZHbtyZu+6zH8YQMMXHkgu8 bjlSOB0OJPGp1eDunIm7qZrk8txKiyaqeqPLJ9uxGZh3l6sF8Ah0yFG29hWLwX97ARx4= X-Gm-Gg: ATEYQzwfv7VgX0l1cPr6lhEbV9qxu9f84OtBQCELV4cz6GrLGrCSNgkUogVeikhAlRR U7uDLyS+u/q97wnGVhKUIfCMv4lpJuyoCA5QZG5N/k4tfKnneVOXqac3nlGqv/aNkP/se7e+2+D t+WopDvBCIv/e+MLuwHGLGG2/3w0ymzB5kf50ivWr/3Arn8M+thnjxO5dx9He5D6D+pxUZ6TIsQ uddMROFmSfH7S3298FkeYsdLHDLjYLLtF//gdOb8q3pGtId8LMyiJQvC7XEe2nZw71W5IuWUohF rCHcc+ZR0YE2CyUG1TVlWezJmdYD9sLwhtkqRrCJDilnqZ1JMVNcptzq+HG7w5Ia69atJHvS4Bm IZoQO7KKh6W5A+/PUjFG3EHqbZSkH9iohEba12Yx5NTQ6aC9UOwMq8Y3L X-Received: by 2002:a17:902:e784:b0:2ae:a73c:f773 with SMTP id d9443c01a7336-2aeae8c5744mr23019145ad.41.1773224828672; Wed, 11 Mar 2026 03:27:08 -0700 (PDT) X-Received: by 2002:a17:902:e784:b0:2ae:a73c:f773 with SMTP id d9443c01a7336-2aeae8c5744mr23018885ad.41.1773224828202; Wed, 11 Mar 2026 03:27:08 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aeae222872sm19575245ad.18.2026.03.11.03.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 03:27:07 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Wed, 11 Mar 2026 15:56:48 +0530 Subject: [PATCH v3 3/5] PCI: qcom: Add .get_ltssm() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-d3cold-v3-3-4d85dc7c2695@oss.qualcomm.com> References: <20260311-d3cold-v3-0-4d85dc7c2695@oss.qualcomm.com> In-Reply-To: <20260311-d3cold-v3-0-4d85dc7c2695@oss.qualcomm.com> To: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Will Deacon Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com, bjorn.andersson@oss.qualcomm.com, Krishna Chaitanya Chundru X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773224811; l=1941; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=pO8vVScrKCYroJtbrmCEg0jsQAkeOLwy64wLlBodYLo=; b=mBoYVYbl4in2XbB3yxFCeM/XXBIXcAl9LHDpdikA7pS5QlbwM886Ekp6fjfgzZwEbo3PkVfPH g7ToHnyZqlfCURgd+My7B1OtZ+2Bc1yVqPNI1oQScXlvgARxdS/DGgf X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-GUID: 9Kl3oecb830jhpyDEevXZo1vNH9NPcAL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDA4NyBTYWx0ZWRfX3i3iAnv2vrBL mL6VqLDekittzpACOjAPjOIyUcqkpJspN/oQOin7rSxwZBBZ2fPIQMrJxw9kWpOKTsw70jYRSY7 jBm0fKxb9BIPXKfu7eHLPIQ5oz/3KW48as0u/qYjRIBCoVwL2ygiZdmOEZVJDVKgmhO7qX6Shoz hzhA0E2wLVo87p4yH2v7KUGk/17JWGzJGndeDINZSDzRtOTdk21x+lCGU3Pj1HfHG9wmCM4/3V2 xx6PRk4x5bL7vXk9IjdgeXnrXFMU13QQ8YCE8ei7hYllDa+jGlpuQNuF1V0aPGhHV2QE+U5Arcp uOkZ8r50FBwZNaD0mvDW6CcSkMDer4940s5pPGakockC6zf1+TanuPeUgct3WVtsv9jry1Xldwa r7viqxZAWbAfysW5Cn4LvBlIujC4b6EPI0LMb2VddK1zD0DwRmLA8TC+IYwovyvhN5re/Hms0Xr 2zM7Zk6Nu5yRov2bIMQ== X-Authority-Analysis: v=2.4 cv=FMMWBuos c=1 sm=1 tr=0 ts=69b1437d cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=Py5lcOcq67Lbq8UMOfUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 9Kl3oecb830jhpyDEevXZo1vNH9NPcAL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110087 For older targets like sc7280, we see reading DBI after sending PME turn off message is causing NOC error. To avoid unsafe DBI accesses, introduce qcom_pcie_get_ltssm(), which retrieves the LTSSM state from the PARF_LTSSM register instead. This helper is used in place of direct DBI-based link state checks in the D3cold path after sending PME turn-off message, ensuring the LTSSM state can be queried safely even after DBI access is no longer valid. Signed-off-by: Krishna Chaitanya Chundru --- drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index 67a16af69ddc75fca1b123e70715e692a91a9135..b00bf46637a5ff803a845719c5b= 0b5b82739244b 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -131,6 +131,7 @@ =20 /* PARF_LTSSM register fields */ #define LTSSM_EN BIT(8) +#define PARF_LTSSM_STATE_MASK GENMASK(5, 0) =20 /* PARF_NO_SNOOP_OVERRIDE register fields */ #define WR_NO_SNOOP_OVERRIDE_EN BIT(1) @@ -1255,6 +1256,16 @@ static bool qcom_pcie_link_up(struct dw_pcie *pci) return val & PCI_EXP_LNKSTA_DLLLA; } =20 +static enum dw_pcie_ltssm qcom_pcie_get_ltssm(struct dw_pcie *pci) +{ + struct qcom_pcie *pcie =3D to_qcom_pcie(pci); + u32 val; + + val =3D readl(pcie->parf + PARF_LTSSM); + + return (enum dw_pcie_ltssm)FIELD_GET(PARF_LTSSM_STATE_MASK, val); +} + static void qcom_pcie_phy_power_off(struct qcom_pcie *pcie) { struct qcom_pcie_port *port; @@ -1507,6 +1518,7 @@ static const struct qcom_pcie_cfg cfg_fw_managed =3D { static const struct dw_pcie_ops dw_pcie_ops =3D { .link_up =3D qcom_pcie_link_up, .start_link =3D qcom_pcie_start_link, + .get_ltssm =3D qcom_pcie_get_ltssm, }; =20 static int qcom_pcie_icc_init(struct qcom_pcie *pcie) --=20 2.34.1