From nobody Tue Apr 7 23:42:41 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6142A3E0C6B for ; Wed, 11 Mar 2026 11:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230202; cv=none; b=nZkL7HPZ944mF6xUBZonjVuXbAedbzCEDwh49jcm9Ixr/Lb5XpUkr/7R0t4B8RmO+VwMLeM5OwXoeP6mSDjpS9b8X8a0tpllBv6lIfDV/n1rkIBM4bXYpnu0/K+ZR/R3m8IA1Ayz7v5+Q/5VBWzCx+nwTYdxme6jZV8/gQIVTGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230202; c=relaxed/simple; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SHTWTuOJZ0Bt57u3d+EZ/UUjpT/lDM9ni/abWFpmQm/8n1205iv54H9T1qHXf/drXVg+Lc+As1CSD8cgxF/r2Rf/AiMhYZsGr+aY42267MQBelysTJLHqeC1v6qrrLRu88RSXkRz5QJc05AsDJG8c+N0rEKilRAUqmVg9NSsAns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=dyJjo875; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="dyJjo875" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-483487335c2so117857295e9.2 for ; Wed, 11 Mar 2026 04:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1773230200; x=1773835000; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=dyJjo875bTZ6pO3TqpaO01tsiMFah/dqy0Ao27bDjB2En92LEuFexwjG9ur38dB74p xxLHEb/3ekk0dVh5HGpMbRRtkBNeJQQd/6HmYnS2SOYqRshKoADq7nZC2cJzDN7dLKFK L79mpZlZd0VMXWHhf/4oxcRLAhSw9C7euJkC+uNYZdFC3Cwipdi9MdLMlevltSi6844p z3iN8irHx7FDlaiB0qM9DMTABv1N1DdLXPWVPL/A0Gv1cQC1pkkaytp1PTgntlM5HIkZ b6ZI0W2AkBRpwMW48YRGWystVbm7UaqAGQOuUP/zWFtcrwFOiSyo/mIzS6qMAXP6iDs+ gGBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773230200; x=1773835000; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=sKwoqtW0GFFFPAfZepm81vckWB/t/SZr8Dm619xG5t02xs2RuUj3LmhinuuDThaNjx sHHINg10PsgwgUn9WDGU/dsNVGLcxOctj0+T5zsndy/HjDL93ySE8OMaUPN4fxe96Ac7 /40kE0GBO8bC0ci44VdwYz2dHK0jOOVyGGU5JZRmPI+5JZ3UTzhLMwt5sd9BbX5/646/ vrwnmFb91QHpX9OQHceFjb958HDdc4XXwf5n/h4HRPvsW56ghvjQILwKfc+8uIAARoB6 zwNJsDNUzN0RcY7Wi3+RhoYbcQ22bLNH8pJ1xCICyrkrYxxzmCv4Nw2irEfEswQdu4cA Pivw== X-Forwarded-Encrypted: i=1; AJvYcCVAzMfdmzrpkvPpCVW8J7LCbPD/p+GhkPdGlYrIvCDL7X3QAN11/0tEkmr/wnHq/WWOEMjnfINZwViwOMQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwXu2t9LVvQ/EatClWr1vXJZDWtzHFOKeqDuSO5I5HrGrNsD5rk 81fvyqwCUPQRt2/GNxxg5IZgzYhg+5aGplbpEJRyynWlCqnvjVebUcyNGki7Uxs6RCM= X-Gm-Gg: ATEYQzwM0dHDywtETFjs3NcNJf3OypLYpDVPVrSNqwjLPZajyukVn4CIMOzDc6aaNSF BSggaeMLfnUJktJAHFhrxc3wiNgJgksHWAe5LzUFtKVAQIhLsso8e5ha2jAJnQE70KtMY9psVKK yPb9I/jmmoSFPXILYbLcrKNqZqPe0F4wCYWFEuURl4Fl5b8A3/Fm0277Q4tI1oIBX5/8+XjiULB GnaA+tmmDRzLeo2HWtQcqea7vhbq406eJoJ8pfHV5EtzQEKsV8au8/G4y664HbUlBK/BCEOvkZI 9tyJZKhou5pxsWv0a/5q/XKyVPcwi7FiR9x292Y0Oqg5jFjO4dqn+IIoU2+1rOEDCrzkYP5vdq5 hA7AG0TUm7F8NwMAO6P/gw/U/NDdXC2vJrCn2wNJGc6JOJo3q2cBi9Nu7wgDaW0pkSxXbZV3SW7 HpiiEaui5Jxv2UtnEOCAHZaNfNc84/KpIBVyQzx44I7sNdg9XY0gC6hXguhU9wBdIPIjC67sviO r6n7w== X-Received: by 2002:a05:600c:154d:b0:485:3a59:99ca with SMTP id 5b1f17b1804b1-4854b109cb4mr38226145e9.16.1773230199754; Wed, 11 Mar 2026 04:56:39 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854ad5416bsm39586485e9.1.2026.03.11.04.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 04:56:39 -0700 (PDT) From: Alexey Charkov Date: Wed, 11 Mar 2026 15:56:21 +0400 Subject: [PATCH v4 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-bq25792-v4-8-7213415d9eec@flipper.net> References: <20260311-bq25792-v4-0-7213415d9eec@flipper.net> In-Reply-To: <20260311-bq25792-v4-0-7213415d9eec@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3105; i=alchark@flipper.net; h=from:subject:message-id; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWRujEj2jLXpr3h9Y2aA1/I02b6LBz+p8BlkH6tdcEzGz PX5k+khHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEz1vSBGhlPs2w+Y1UpWHvoX/U3Lc5pXhMyUycksmp7/fA7KqL33aWNkaCy4WC9 Yc9E0jyH6+8aqSfFLN563dg40/H7M717ZxTXbOAA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 0765673728e4..9c082865e745 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -54,8 +54,10 @@ struct bq257xx_chip_info { * @bq: parent MFD device * @charger: power supply device * @online: charger input is present + * @charging: charger is actively charging the battery * @fast_charge: charger is in fast charge mode * @pre_charge: charger is in pre-charge mode + * @overvoltage: overvoltage fault detected * @ov_fault: charger reports over voltage fault * @batoc_fault: charger reports battery over current fault * @oc_fault: charger reports over current fault @@ -71,8 +73,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -106,8 +110,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -478,14 +484,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0