From nobody Tue Apr 7 23:42:42 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E16C3DE42D for ; Wed, 11 Mar 2026 11:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230201; cv=none; b=RgA9IPKPzg5svEu13W/6w/a7TAE7hjY8KAOlxmnXQ0WSmWoGGq9GSFmfqB2ZiGL/CXTQDsY0+IZh9FRkZa6y/8dN3J5QY1rmoYLKo+JqBc073HUtOCxMBiK0/38hCED7OYpgFzliOkmeT430ANXiagyC7eDvm8t1env9mO9NCO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230201; c=relaxed/simple; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fKOl0R6nSh+KS4jW0s5xbQQ+kd3bWbfi+G5ouKQE4LlUbXToRVP+Fj6VfT6+g2EkZLd/V5VMI7Cw+iKYFN6Ms914Z1DhRxLklLkkEhjhdhRtBrpzNypGOwm7FluYPiNzvHDvQcLbcyh6CiC8eAOmeRNW8GNsbNa/73B0/ERm3T8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=LzpP/O27; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="LzpP/O27" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48534237460so41170125e9.3 for ; Wed, 11 Mar 2026 04:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1773230198; x=1773834998; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=LzpP/O27YW7DukXMieulBCJYDHhyhYhnbNWoNrY6cbJdcWez9OeJQ92TMk+P9kRVRk I5dMws7OgQFZ9C3EjX158ubq0r2Vp0Rmz1xrYSxSBGbk1ThXbfmQESoLg5CeQQzrL6Sb vSf1DHso40dEjYpXzIKhC7nBaQlf0MzzDxBIER17V6aYDtARpS30eZbpPmNR67RR3F5q NJug1s3ZKNIdpZlFpUxXL0YtLiz6C4lurrNwwqmrpRtgbccnfxu+cTdY1Ap0CqWaovXc PUyj1RYyb1ccMG6g1WBA3zCOO5m+lS+SGNeDlBDcwQNcYHJTCBlqEaLkN63U5fjkY030 nujg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773230198; x=1773834998; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=srgGWHC/gjFDfng1lSCFJkyX3QostpPTL/ZNPriuh46tKmY7iUJifGLeYlLr7ybfR/ AiGymvCGDd4R1zwZo+y25HKuGVsJn0UhtQvsUPJMOl/aGXjkqIYO3kMOwCJ6KHiaX3or 2h8T10cWxiS7CCRIJbqlvlskGnQ2QpLZ9Naownog11N3Q8Hu1BsQ0Od4VaCQvZJV2dJN mfcmVVflrPrSaiT17jbI08hX020ZXuvZS0AkPsIaW4LsOm+1JtLkuB4f8Jm/6DNQbQ+b t6Is0bKR1cpB4NVdUykuR9vJc94YagIaXr1YyUqljd0/c9JiiWcZTn2iQ6UE/TMN9tuE mr9A== X-Forwarded-Encrypted: i=1; AJvYcCUtFDz+hCasbY4MKULOyQr1dhTChJdKHHSecdbYtm2FaxKClnh0tXGk+vTiTdWshwh8mXPhVXo5L2W9MYs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw61SJbkbktfZDiRv+95SkcvesU0+C9eyP4q6RStb2VB6W5yVPO UYU4owkadX65i4OZiB9AKYiFQruOynWXR31CzwcfzeCEgZ7l1NqQD5NI2LC2MiwXpJU= X-Gm-Gg: ATEYQzxiIuyLOVLEUB+lA7R8A8WerBx9zfqLf4TULYyssT74807juRQ7i5i/8TMi5Yl Bl/sbRTv4Pn4BU1Onl1Zrm1s8ts1NLbfTC/KJUFhdcRT8h7wrc5xvluHp8ZV4LVwqoZTuwHkm6Z TznGun2FS0xWlCvJp4JNVDUQfmAHA0Fo1qHlqhpkzxyExr+Ua+8hpdc030fqRYmbRqEBxcWwwI9 xw/K4VsoWIyHvSW9Tsy+acm+Qx4PLZPG0ntyrxZgRIuqu1cVdUS0vg7PbVGFZTsqpeKVPd0nGXP LLut5eBOPf79sK8nCnZdhLNq6S8rI77e0VKvHRVcwb//iP1YGtlwmS7VyTbgyhs+gOVkSBX62jL UwmHGvgmOxIshYWeaSNnwTGlPISdwQeLSV7VrYHnlrKNd91lGMIqm5LZkXuLSu8a/8VqpEsGFAv z02478a32zoLznUp9rRskhiuHlFxvpwbcfFFpaFkevb8kAmw9KgUc0TDP1eR4bXOfcecjikIYFT KsW/PwoVyhrC2TU X-Received: by 2002:a05:600c:a08:b0:485:2c61:9459 with SMTP id 5b1f17b1804b1-4854b0afb48mr38299945e9.8.1773230197237; Wed, 11 Mar 2026 04:56:37 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854ad5416bsm39586485e9.1.2026.03.11.04.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 04:56:37 -0700 (PDT) From: Alexey Charkov Date: Wed, 11 Mar 2026 15:56:20 +0400 Subject: [PATCH v4 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-bq25792-v4-7-7213415d9eec@flipper.net> References: <20260311-bq25792-v4-0-7213415d9eec@flipper.net> In-Reply-To: <20260311-bq25792-v4-0-7213415d9eec@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4242; i=alchark@flipper.net; h=from:subject:message-id; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWRujEg+9Kgp+p7OmthNUvZb1s1ysl8VH2wpuUKVnaHf7 sH+HrPUjoksDGJcDJZiiixzvy2xnWrEN2uXh8dXmDmsTCBDpEUaGICAhYEvNzGv1EjHSM9U21DP 0FDHWMeIgYtTAKbaOZiR4SCHVptEYfyd7hW+9QcfCh/isdK4/G2O0Oq1yZfS05j2XWBk2GpwTFS pVzKUnfVS0tQl/3/nPFglo+Bu0h7iWL3fP9KRBwA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 39718223c3f9..0765673728e4 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -22,18 +22,30 @@ struct bq257xx_chg; * @bq257xx_hw_init: init function for hw * @bq257xx_hw_shutdown: shutdown function for hw * @bq257xx_get_state: get and update state of hardware + * @bq257xx_get_ichg: get maximum charge current (in uA) * @bq257xx_set_ichg: set maximum charge current (in uA) + * @bq257xx_get_vbatreg: get maximum charge voltage (in uV) * @bq257xx_set_vbatreg: set maximum charge voltage (in uV) + * @bq257xx_get_iindpm: get maximum input current (in uA) * @bq257xx_set_iindpm: set maximum input current (in uA) + * @bq257xx_get_cur: get battery current from ADC (in uA) + * @bq257xx_get_vbat: get battery voltage from ADC (in uV) + * @bq257xx_get_min_vsys: get minimum system voltage (in uV) */ struct bq257xx_chip_info { int default_iindpm_uA; int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; =20 /** @@ -490,22 +502,22 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, break; =20 case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_USB_TYPE: val->intval =3D pdata->usb_type; @@ -633,9 +645,15 @@ static const struct bq257xx_chip_info bq25703_chip_inf= o =3D { .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, + .bq257xx_get_ichg =3D &bq25703_get_ichg_cur, .bq257xx_set_ichg =3D &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25703_get_chrg_volt, .bq257xx_set_vbatreg =3D &bq25703_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25703_get_iindpm, .bq257xx_set_iindpm =3D &bq25703_set_iindpm, + .bq257xx_get_cur =3D &bq25703_get_cur, + .bq257xx_get_vbat =3D &bq25703_get_vbat, + .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 /** --=20 2.52.0