From nobody Tue Apr 7 23:42:41 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 032333E022A for ; Wed, 11 Mar 2026 11:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230195; cv=none; b=DbhN8wHT1O/MPRETaWAChM5jmaMD5U/SgX2uS6Wy2QQyd9Du6MIqBl99PsTDZhF/KFvHi4bBYTEmBFTAyQFNS2LzI/nIqkToIoHkfbymz/ZtlJTGmvE12ETQ99BTXwhuIzDmv5w+4Mcm/cDWBhQs7DKekq9cELomHorfI0+YgPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773230195; c=relaxed/simple; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d8jI90obFhM8OFUqfWoU+wLOO5Le8sw/aHemh3nm/krsGI2t3ZGKpdtqjqA6FIuf3gCuMJmigr444AO7fFVPnjxAcdegKVByo8He95cd5eOviDlAC1ZrzLaPMv/hTCaogmT7Fq/rQf1KM5MOQPlxmOkf8AT8vXfUolzLx+ErFtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=j/snTdrG; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="j/snTdrG" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48534e9076fso27617965e9.0 for ; Wed, 11 Mar 2026 04:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1773230192; x=1773834992; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=j/snTdrG27oLf/uCezauuFlD49o9fNjd0IndTm/3x/L1kqWEAKsp019S6PsHtLmQpu T24b2Ixz7rtaE15Nn6T7dYUJrYIUi4SnzeUvhVb7R2OguQNx1JD19I9w0FnH+7MKDmRF wzC7CwscL+wrR26vifi9uEKV4Jgffn5cader64cmHZjpYS+aG01Gq+xPL4syDk8C9FCJ Zk7In3/1nfOYZOb0mDBM7o9W3JhBmqhugdVlcCppiHbu+wn2D/AmK2KG1r4+TR2pcKpZ TD60OoPVFsBgV2SGKIyN9/i+VZvV13GF0DnNAo+2zL3Bf+vafYiTb3vfErvJQEnb4Xry 5b9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773230192; x=1773834992; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=pJlqPKQW79hmyPolT4I05Qw9LYvY/FCk5C41fL5lvYa3Lmdmz4RecWAynD4+M3jRym 1UtIAbkPXpEW7JoU2tbCWp+kAU7F89lNwWefkCGVvqq31XKIXTUOF2I86+tD7EUr4Hfv HUo6tu2hTmCY1voYk8JX5fqrdyr8CjI+bYEAf5tFoBR/5frFsDV1Fgmh1XhE/KYE407S uESxKbETkPXUI380nvZmn/nZYY4VzVJEAQ1/1H1tZzxtjG+rH4m414dDMPS0sLdBkUug ZoOqeKRy8v6/1YB7TRYSOaTrSTFdEqAOpxfRnuOBFGVKa8WpU2sRkCmRTVaERJ3bxJ1h hQnw== X-Forwarded-Encrypted: i=1; AJvYcCVSVe4FP6fk4c7deQ2L7LaSCTJnN5peaTDqWqSwzseQ3qtuER+Z+/Hq9r3uOlDnit5+iLOrVUaicTtAddY=@vger.kernel.org X-Gm-Message-State: AOJu0YwzFCUvkltu1bEtYlefpIJLgV26IJGwWzYtvH0ILrOK86N3Rp1D cvo2gzu4doolV/cpyVT+4QoFnTb3dM6pdfMqkbqFUvmxEMT09Y4GOb3HbJ5RXZF2t4s= X-Gm-Gg: ATEYQzwOGYGweZYehoaZ7YoAFFRzLwkLMcDWOry5QnDitvU2ZHdq60Kg3g2oooFH770 DWcU6p4Nj9vfGT2agbvnVzlAb6rJeXpIq2DbPV2I8zL0vSI2bR5aIZcr5EZ6acvIQgiQYe/zCgI yF1mfocj0a5uDsQu2rL36sXNNSIfjYVjXVQtIWcNq8PnFvoZHMwC8Y4e9k4Glw9q6idPGWxJZ6Q sy4yVJjlzJlr+gIQcTv0Ae4Vdcqfce/Nnam/EYCreajfUJESBpFsXyxJE7s20uCBv6Q0Paj3T7I +gKg/rFVZiYwHVdShO6B+jEHW7mX2h+nPK7dHxSCy7RirGguGlyeU2n0ifnPqIrNLShocOTceQ1 AHQFC91UfE7ax+1cx1zgfr9S9pbCRniSoiEw317006NzWSByqFWNGHIM9GIFcznx4cQ3Ynp9IIA jPY/C+V4/nrzdJAZT7oofbCcnakw5Vv07uC/VQ1UHFgJBcaX953m9PHauOTwxc9oQlERDCNzU5L MjNKA== X-Received: by 2002:a05:600c:1f10:b0:485:419c:4eba with SMTP id 5b1f17b1804b1-4854b0a5471mr41617415e9.1.1773230192293; Wed, 11 Mar 2026 04:56:32 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854ad5416bsm39586485e9.1.2026.03.11.04.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 04:56:32 -0700 (PDT) From: Alexey Charkov Date: Wed, 11 Mar 2026 15:56:18 +0400 Subject: [PATCH v4 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260311-bq25792-v4-5-7213415d9eec@flipper.net> References: <20260311-bq25792-v4-0-7213415d9eec@flipper.net> In-Reply-To: <20260311-bq25792-v4-0-7213415d9eec@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2028; i=alchark@flipper.net; h=from:subject:message-id; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWRujEgWT/ucbxX14DGrGb/3Ad1dh87rCMvdO63tkLm+/ u6bw0FRHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEy1EDfDf2eTRTziSYc4pghLXi6PuOqjy7lq5U2Vr8Ip4p4ZP3+mHGdkOOWaoP1 7berHE98NUw8vnXvhqEMGU+Z3Q34l02MZbMte8AMA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0